1. 01 May, 2008 10 commits
    • unknown's avatar
      Merge pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.0-trigs · 5cda5240
      unknown authored
      into  pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/build_work/mysql-5.1-trigs
      
      
      client/mysqltest.c:
        Auto merged
      5cda5240
    • unknown's avatar
      Bug#36026 - Test funcs_1.<engine>_trig_03 failing on Windows · 38c28141
      unknown authored
      Bug#36028 - Test funcs_1.<engine>_trig_03e failing on Windows
      Bug#36029 - Test funcs_1.<engine>_trig_0407 failing on Windows
      Bug#36030 - Test funcs_1.<engine>_trig_08 failing on Windows
      
      Adding $MASTER_MYSOCK to init_win_path()
      When path names are short, master.sock ends up in MYSQL_TMP_DIR, but with longer path names,
      master.sock ends up in /tmp/<random_string>/ and these tests will fail due to path delimiter difference.
      
      New changeset to start with 5.0 -- Not all of these tests are present in 5.0, but want to keep mysqltest the same
      
      
      38c28141
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 803d77f8
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B35298-5.1-bugteam
      
      
      configure.in:
        Auto merged
      803d77f8
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-bugteam · 4f354963
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      configure.in:
        merge 5.0-bugteam to 5.1-bugteam
      4f354963
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B35298-5.0-bugteam · 0e287a9c
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B35298-5.1-bugteam
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      configure.in:
        merge 5.0-bugteam to 5.1-bugteam
      0e287a9c
    • unknown's avatar
      Fix for bug #35298: GROUP_CONCAT with DISTINCT can crash the server · 1a68ec28
      unknown authored
      The bug is a regression introduced by the patch for bug32798.
      
      The code in Item_func_group_concat::clear() relied on the 'distinct'
      variable to check if 'unique_filter' was initialized. That, however,
      is not always valid because Item_func_group_concat::setup() can do
      shortcuts in some cases w/o initializing 'unique_filter'.
      
      Fixed by checking the value of 'unique_filter' instead of 'distinct'
      before dereferencing.
      
      
      mysql-test/r/func_gconcat.result:
        Added test cases for bugs #35298 and #36024.
      mysql-test/t/func_gconcat.test:
        Added test cases for bugs #35298 and #36024.
      sql/item_sum.cc:
        Check if unique_filter != NULL before dereferencing it. Non-zero value
        of distinct does not always mean that unique_filter is initialized
        because Item_func_group_concat::setup() can do shortcuts is some cases
      1a68ec28
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · cf2b2cc5
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.0-bugteam
      
      
      cf2b2cc5
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · fefb7c6b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-bugteam
      
      
      mysql-test/t/disabled.def:
        Auto merged
      fefb7c6b
    • unknown's avatar
      Use ulonglong to store row count in libmysld Protocol_text::remove_last_row() · a701a849
      unknown authored
      (fix warnings).
      
      
      libmysqld/lib_sql.cc:
        Use ulonglong to store row count in Protocol_text::remove_last_row()
        (fix warnings).
      a701a849
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 87298f01
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      
      mysql-test/t/disabled.def:
        manual merge
      87298f01
  2. 30 Apr, 2008 11 commits
    • unknown's avatar
      Handle a few failing test cases · 157c8ccf
      unknown authored
      
      mysql-test/r/group_concat_max_len_func.result:
        Properly restore global group_concat_max_len value at end of test
      mysql-test/t/disabled.def:
        Re-disable user_limits test; it is still failing randomly (bug 33696)
      mysql-test/t/group_concat_max_len_func.test:
        Update test results
      157c8ccf
    • unknown's avatar
      Merge hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean · 03896b37
      unknown authored
      into  hh-nb.hungers:/work/merge/mysql-5.1-build
      
      
      mysql-test/t/disabled.def:
        Auto merged
      03896b37
    • unknown's avatar
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/35788-5.1 · 368542d4
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
      
      
      368542d4
    • unknown's avatar
      Bug#35788 A few tests fail due to concurrent inserts · 57ae28ab
      unknown authored
      The problem is that since MyISAM's concurrent_insert is on by
      default some concurrent SELECT statements might not see changes
      made by INSERT statements in other connections, even if the
      INSERT statement has returned.
      
      The solution is to disable concurrent_insert so that INSERT
      statements returns after the data is actually visible to other
      statements.
      
      
      mysql-test/r/client_xml.result:
        Update test case result.
      mysql-test/r/federated.result:
        Update test case result.
      mysql-test/r/federated_bug_25714.result:
        Update test case result.
      mysql-test/t/client_xml.test:
        Disable concurrent insert and restore old value at the
        end of the test so it doesn't affect other tests.
      mysql-test/t/federated.test:
        Disable concurrent insert and restore old value at the
        end of the test so it doesn't affect other tests.
      mysql-test/t/federated_bug_25714.test:
        Disable concurrent insert and restore old value at the
        end of the test so it doesn't affect other tests.
      57ae28ab
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-bugteam · 06ddedd7
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-bugteam
      
      
      06ddedd7
    • unknown's avatar
      Merge hh-nb.hungers:/work/trees/mysql-5.1-build-src-clean · 888b92f1
      unknown authored
      into  hh-nb.hungers:/work/merge/mysql-5.1-build
      
      
      BitKeeper/deleted/.del-myisam_use_mmap_basic.result:
        Delete: mysql-test/r/myisam_use_mmap_basic.result
      BitKeeper/deleted/.del-myisam_use_mmap_basic.test:
        Delete: mysql-test/t/myisam_use_mmap_basic.test
      888b92f1
    • unknown's avatar
      Fix for bug 35988. · f2c82e48
      unknown authored
      f2c82e48
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/bugteam/mrg/51 · 775a0682
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      
      mysql-test/suite/rpl/r/rpl_packet.result:
        Auto merged
      mysql-test/suite/rpl/t/disabled.def:
        Auto merged
      mysql-test/suite/rpl/t/rpl_packet.test:
        Auto merged
      775a0682
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/bugteam/51 · 1e7bc461
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/suite/funcs_1/datadict/processlist_val.inc:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      mysql-test/suite/rpl/t/disabled.def:
        SCCS merged
      1e7bc461
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/bugteam/51 · 86e6ea34
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/bugteam/mrg/51
      
      
      86e6ea34
  3. 29 Apr, 2008 2 commits
    • unknown's avatar
      Merge mysqldev@production:my/build-200803311521-5.1.24-rc/mysql-5.1-release · 26888186
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/bugteam/mrg/51
      
      
      mysql-test/suite/rpl/r/rpl_packet.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_packet.test:
        Auto merged
      mysql-test/suite/rpl/t/disabled.def:
        SCCS merged
      26888186
    • unknown's avatar
      Backport kostja's fix for Bug#32724 "innodb_mysql.test fails randomly". · f4bd5105
      unknown authored
      Enable back the disabled test case.
      
      
      mysql-test/include/mix1.inc:
        Fix a race condition in the test, causing a sporadic failure.
      mysql-test/r/innodb_mysql.result:
        Update test case result.
      mysql-test/t/disabled.def:
        Enable the test case innodb_mysql.
      sql/sql_parse.cc:
        Fix the random failure of innodb_mysql test. The failure is not
        random any more after a patch for Bug 12713 added asserts around
        handler commit.
      f4bd5105
  4. 28 Apr, 2008 10 commits
  5. 26 Apr, 2008 1 commit
    • unknown's avatar
      Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows · 92098d5d
      unknown authored
      Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
      Bug#36034 - Test parts.part_supported_sql_func_<eng> fails on Windows
      Bug#36036 - Test parts.partition_alter1_<eng> fails on Windows
      Bug#36037 - Test parts.partition_alter2_<eng> fails on Windows
      Bug#36038 - Test parts.partition_basic_<engine> failing on Windows
      Bug#36039 - Test parts.partition_engine_<eng> fails on Windows
      Bug#36040 - Test parts.partition_syntax_<eng> fails on Windows
      
      Changeset to fix multiple 5.1.24-rc build bugs on Windows platforms.
      
      Many of these bugs had the same root causes.
      
      
      mysql-test/mysql-test-run.pl:
        Bug#36034 - Test parts.partition_supported_sql_func_<eng> fails on Windows
        
        Kent suggested these changes to ensure all contents of mysql-test/std_data are copied to std_data_ln on Windows (no symlinks)
      mysql-test/suite/funcs_1/datadict/processlist_priv.inc:
        Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
        
        Altered .inc file to include HOST column in the --replace_column clauses.
        
        Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
      mysql-test/suite/funcs_1/datadict/processlist_val.inc:
        Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
        
        Altered .inc file to include HOST column in the --replace_column clauses.
        
        Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
      mysql-test/suite/funcs_1/r/processlist_priv_no_prot.result:
        Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
        
        Altered .inc file to include HOST column in the --replace_column clauses.
        
        Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
        
        -reran .result file to account for change in --replace_column calls
      mysql-test/suite/funcs_1/r/processlist_priv_ps.result:
        Bug#36032 - Test funcs_1.processlist_priv_ps fails on Windows
        
        Altered .inc file to include HOST column in the --replace_column clauses.
        
        Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
        
        -reran .result file to account for change in --replace_column calls
      mysql-test/suite/funcs_1/r/processlist_val_no_prot.result:
        Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
        
        Altered .inc file to include HOST column in the --replace_column clauses.
        
        Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
        
        Reran .result file to account for changes to --replace_column clauses
      mysql-test/suite/funcs_1/r/processlist_val_ps.result:
        Bug#36033 - Test funcs_1.processlist_val_ps fails on Windows
        
        Altered .inc file to include HOST column in the --replace_column clauses.
        
        Windows tests were failing due to use of localhost as localhost:<port> rather than just localhost.
        
        Reran .result file to account for changes to --replace_column clauses
      mysql-test/suite/parts/inc/partition_layout_check1.inc:
        Bug#36036 - Test parts.partition_alter1_<eng> fails on Windows
        Bug#36037 - Test parts.partition_alter2_<eng> fails on Windows
        Bug#36038 - Test parts.partition_basic_<engine> failing on Windows
        Bug#36039 - Test parts.partition_engine_<eng> fails on Windows
        Bug#36040 - Test parts.partition_syntax_<eng> fails on Windows
        
        Added replace_result clause to account for Windows' use of '\r' vs. '\n'
        
        This difference was causing failures on Windows.
        
        Also, mleich added some changes to remove some -ls clauses that weren't necessary
      mysql-test/suite/parts/inc/partition_layout_check2.inc:
        Bug#36036 - Test parts.partition_alter1_<eng> fails on Windows
        Bug#36037 - Test parts.partition_alter2_<eng> fails on Windows
        Bug#36038 - Test parts.partition_basic_<engine> failing on Windows
        Bug#36039 - Test parts.partition_engine_<eng> fails on Windows
        Bug#36040 - Test parts.partition_syntax_<eng> fails on Windows
        
        Added replace_result clause to account for Windows' use of '\r' vs. '\n'
        
        This difference was causing failures on Windows.
        
        Also, mleich added some changes to remove some -ls clauses that weren't necessary
      mysql-test/suite/parts/r/partition_basic_symlink_myisam.result:
        changes by mleich to remove unneeded use of -ls clause in .result file 
        
        These clauses were removed from partition_layout_check1.inc and partition_layout_check2.inc
      92098d5d
  6. 25 Apr, 2008 1 commit
    • unknown's avatar
      Fixed bug#36006: Optimizer does table scan for SELECT COUNT(*) · 5b8cdbf4
      unknown authored
                       for ENGINE=MRG_MYISAM (should be optimized out).
      
      Before WL#3281 MERGE engine had the HA_NOT_EXACT_COUNT flag
      unset, and it worked with COUNT optimization as desired.
      After the removal of the HA_NOT_EXACT_COUNT flag neither
      HA_STATS_RECORDS_IS_EXACT (opposite to former HA_NOT_EXACT_COUNT
      flag) nor modern HA_HAS_RECORDS flag were not added to MERGE
      table flag mask.
      
      1. The HA_HAS_RECORDS table flag has been set.
      2. The ha_myisammrg::records method has been overridden to
         calculate total number of records in underlying tables.
      
      
      
      storage/myisammrg/myrg_records.c:
        Fixed bug#36006: Optimizer does table scan for select count(*).
        The myrg_records function has been added to calculate total number
        of records in underlying tables.
      include/myisammrg.h:
        Fixed bug#36006: Optimizer does table scan for select count(*).
        The myrg_records function declaration has been added.
      mysql-test/r/merge.result:
        Added test case for bug#36006.
      mysql-test/t/merge.test:
        Added test case for bug#36006.
      storage/myisammrg/CMakeLists.txt:
        Fixed bug#36006: Optimizer does table scan for select count(*).
        New myrg_records.c file has been added.
      storage/myisammrg/Makefile.am:
        Fixed bug#36006: Optimizer does table scan for select count(*).
        New myrg_records.c file has been added.
      storage/myisammrg/ha_myisammrg.cc:
        Fixed bug#36006: Optimizer does table scan for select count(*).
        The ha_myisammrg::records method has been overridden.
      storage/myisammrg/ha_myisammrg.h:
        Fixed bug#36006: Optimizer does table scan for select count(*).
        1. The HA_HAS_RECORDS table flag has been set.
        2. The ha_myisammrg::records method has been overridden.
      5b8cdbf4
  7. 24 Apr, 2008 4 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.1-bugteam · 2a1ba656
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-bug35844
      
      
      sql/sql_select.cc:
        Auto merged
      2a1ba656
    • unknown's avatar
      Bug#36023: Incorrect handling of zero length caused an assertion to fail. · 89b866e7
      unknown authored
      When a zero length is provided to the my_decimal_length_to_precision
      function along with unsigned_flag set to false it returns a negative value.
      For queries that employs temporary tables may cause failed assertion or
      excessive memory consumption while temporary table creation.
      
      Now the my_decimal_length_to_precision and the my_decimal_precision_to_length
      functions take unsigned_flag into account only if the length/precision
      argument is non-zero.
      
      
      mysql-test/t/type_decimal.test:
        Added a test case for the bug#36023: Incorrect handling of zero length caused
         an assertion to fail.
      mysql-test/r/type_decimal.result:
        Added a test case for the bug#36023: Incorrect handling of zero length caused
         an assertion to fail.
      sql/my_decimal.h:
        Bug#36023: Incorrect handling of zero length caused an assertion to fail.
        Now the my_decimal_length_to_precision and the my_decimal_precision_to_length
        functions take unsigned_flag into account only if the length/precision
        argument is non-zero.
      89b866e7
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug35157/my51-bug35157 · 34efb0fd
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.1-build
      
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/mysqldump.result:
        Auto merged
      34efb0fd
    • unknown's avatar
      Enabled rpl: rpl_view, rpl_ndb_multi, rpl_log_pos · 9cb63bfb
      unknown authored
      and main: user_limits, concurrent_innodb, lowercase_table3, ctype_create 
      tests.
      
      
      mysql-test/suite/ndb/t/disabled.def:
        Removed test commented.
      mysql-test/suite/rpl/t/disabled.def:
        Enabled rpl_view, rpl_ndb_multi, rpl_log_pos tests.
      mysql-test/t/disabled.def:
        Enabled user_limits, concurrent_innodb, lowercase_table3, ctype_create tests.
      9cb63bfb
  8. 23 Apr, 2008 1 commit