1. 19 Jul, 2007 1 commit
  2. 17 Jul, 2007 1 commit
  3. 16 Jul, 2007 1 commit
    • unknown's avatar
      Bug #29692 Single row inserts can incorrectly report a huge number of row insertions · 499a8cfe
      unknown authored
      This bug was caused by unitialized value that was the result of a bad 5.0 merge.
      
      
      sql/sql_class.h:
        Readded comments lost in a bad merge.
      sql/sql_insert.cc:
        Fixed code to completely initialize (zero) the "COPY_INFO info" var in the same manner as the delayed write code.
        
        Readded a change that was lost in a bad merge.
      tests/mysql_client_test.c:
        Test case added for bug#29692.
      499a8cfe
  4. 14 Jul, 2007 1 commit
  5. 13 Jul, 2007 21 commits
    • unknown's avatar
      correct cluster support check · 36a23ffe
      unknown authored
      36a23ffe
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb · 15006b6f
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-maint
      
      
      mysql-test/suite/ndb/t/ndb_multi.test:
        Auto merged
      mysql-test/suite/ndb/t/ndb_multi_row.test:
        Auto merged
      15006b6f
    • unknown's avatar
      avoid multiple defines of server1/2 · d24f7c46
      unknown authored
      d24f7c46
    • unknown's avatar
      Fix for bug #29253: csv table reportedly marked as crashed · 6da70a61
      unknown authored
      Problem: the data file changes made during delete/update are not visible to 
      other threads as the file is reopened, so reading data 
      with old descriptors might miss the changes.
      
      Fix: reopen the data file before reading if it was reopened during 
      delete/update to ensure there's no data behind.
      
      Note: there's no simple test case.
      
      
      storage/csv/ha_tina.cc:
        Fix for bug #29253: csv table reportedly marked as crashed
          - use the data file version technic to ensure we always see changes
            made by other threads:
              a) increase share->data_file_version each time we reopen the data 
                 file, i.e. at the end of update/delete.
              b) compare the local data file version with the shared one each time 
                 we want to read data, reopen it if they differ.
      storage/csv/ha_tina.h:
        Fix for bug #29253: csv table reportedly marked as crashed
          - use the data file version technic to ensure we always see changes
            made by other threads:
              a) increase share->data_file_version each time we reopen the data 
                 file, i.e. at the end og update/delete.
              b) compare the local data file version with shared one each time 
                 we want to read data, reopen it if they differ.
      6da70a61
    • unknown's avatar
      update bug dependency on failing test · 363108a3
      unknown authored
      
      mysql-test/suite/ndb/t/ndb_binlog_format.test:
        Rename: mysql-test/t/ndb_binlog_format.test -> mysql-test/suite/ndb/t/ndb_binlog_format.test
      mysql-test/suite/ndb/r/ndb_binlog_format.result:
        Rename: mysql-test/r/ndb_binlog_format.result -> mysql-test/suite/ndb/r/ndb_binlog_format.result
      363108a3
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-maint · 908a8a86
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-maint
      
      
      sql/set_var.cc:
        Auto merged
      908a8a86
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb · e39cd698
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-maint
      
      
      sql/set_var.cc:
        Auto merged
      e39cd698
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb · 0e485cc9
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-maint
      
      
      sql/ha_ndbcluster.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      storage/ndb/tools/restore/restore_main.cpp:
        Auto merged
      mysql-test/include/have_ndb.inc:
        manual merge
      mysql-test/t/disabled.def:
        manual merge
      0e485cc9
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb · 355321a5
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      sql/ha_ndbcluster.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      355321a5
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1-new-ndb-bj · 289acdd1
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-new-ndb
      
      
      mysql-test/t/disabled.def:
        Auto merged
      289acdd1
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb-bj · ce62de00
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      ce62de00
    • unknown's avatar
    • unknown's avatar
      avoid some sporadic startup issues · 551bb6ee
      unknown authored
      551bb6ee
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/50 · e641addf
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      client/mysqltest.c:
        Auto merged
      e641addf
    • unknown's avatar
      When opening a new connecgtion, changed mysqltest to prefer a brand new... · cfbf0428
      unknown authored
      When opening a new connecgtion, changed mysqltest to prefer a brand new connection slot over an existing, closed slot. Fixes a problem with reused slots that can cause tests to fail. bug#29579
      
      
      client/mysqltest.c:
        When opening a new connecgtion, changed mysqltest to prefer a brand new connection slot over an existing, closed slot. Fixes a problem with reused slots that can cause tests to fail.
      cfbf0428
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/50 · 4ebb03b1
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      extra/yassl/include/yassl_int.hpp:
        Auto merged
      extra/yassl/src/yassl_int.cpp:
        Auto merged
      mysql-test/r/mysqltest.result:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      4ebb03b1
    • unknown's avatar
      Minor fixes for test failures and compiler warnings for Bug #29579. · 86fe6ad7
      unknown authored
      
      BitKeeper/deleted/.del-ssl_big.test:
        Delete: mysql-test/t/ssl_big.test
      extra/yassl/include/yassl_int.hpp:
        added comment
      extra/yassl/src/yassl_int.cpp:
        Changed init order to fix a compiler warning.
      mysql-test/r/mysqltest.result:
        There is no limit to connections anymore.
      mysql-test/t/mysqltest.test:
        There is no limit to connections anymore.
      86fe6ad7
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/mysql50 · cd3fbe22
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      client/mysqltest.c:
        Auto merged
      extra/yassl/include/openssl/ssl.h:
        Auto merged
      extra/yassl/include/yassl_int.hpp:
        Auto merged
      extra/yassl/src/ssl.cpp:
        Auto merged
      extra/yassl/src/yassl_int.cpp:
        Auto merged
      sql/slave.cc:
        Auto merged
      vio/viossl.c:
        SCCS merged
      cd3fbe22
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/mysql50 · efcb1f95
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/50
      
      efcb1f95
    • unknown's avatar
      Merge dkatz@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 739eabaa
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      739eabaa
    • unknown's avatar
      Bug #29579 Clients using SSL can hang the server · 6cdd7d6c
      unknown authored
      Added an option to yassl to allow "quiet shutdown" like openssl does. This option causes the SSL libs to NOT perform the close_notify handshake during shutdown. This fixes a hang we experience because we hold a lock during socket shutdown.
      
      
      mysql-test/t/ssl_big.test:
        BitKeeper file /Users/dkatz/50/mysql-test/t/ssl_big.test
      mysql-test/r/ssl-big.result:
        BitKeeper file /Users/dkatz/50/mysql-test/r/ssl-big.result
      client/mysqltest.c:
        Added new command to mysqltest to send a quit command to the server, but to not close the actual socket on our end.
        
        Also changed code to reuse connection slots, so that the tests can open and close sockets in a loop.
      extra/yassl/include/openssl/ssl.h:
        Added C accessors to the quietShutdown option.
      extra/yassl/include/yassl_int.hpp:
        Added quietShutdown_ member and accessor methods to the SSL class.
      extra/yassl/src/ssl.cpp:
        Added accessors to get/set the quietShutdown option and to not perform the shutdown handshake if quietShutdown is set.
      extra/yassl/src/yassl_int.cpp:
        Added quietShutdown_ member and accessor methods to the SSL class.
      vio/viossl.c:
        Added line to set the quiet_shutdown option before shutting down the socket.
      mysql-test/t/ssl-big.test:
        Added a test that causes an unpatched server to hang during SSL socket shutdown.
      6cdd7d6c
  6. 11 Jul, 2007 6 commits
  7. 10 Jul, 2007 9 commits
    • unknown's avatar
      Merge dkatz@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 844f7081
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      mysql-test/t/status.test:
        Auto merged
      844f7081
    • unknown's avatar
      Merge mysql.com:/home/tnurnberg/22540/50-22540 · 39f9d96a
      unknown authored
      into  mysql.com:/home/tnurnberg/22540/51-22540
      
      
      sql/log.cc:
        Auto merged
      39f9d96a
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · e66686c4
      unknown authored
      into  mysql.com:/home/tnurnberg/22540/51-22540
      
      
      sql/log.cc:
        Auto merged
      e66686c4
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 7326e9be
      unknown authored
      into  mysql.com:/home/tnurnberg/22540/50-22540
      
      
      sql/log.cc:
        Auto merged
      7326e9be
    • unknown's avatar
      5c047b00
    • unknown's avatar
      Merge mysql.com:/home/tnurnberg/22540/50-22540 · 7f712649
      unknown authored
      into  mysql.com:/home/tnurnberg/22540/51-22540
      
      
      mysql-test/extra/binlog_tests/binlog.test:
        manual merge
      mysql-test/suite/binlog/r/binlog_stm_binlog.result:
        manual merge
      sql/log.cc:
        manual merge
      7f712649
    • unknown's avatar
      Merge sita.local:/Users/tsmith/m/bk/inno/jul10/50 · 674be56a
      unknown authored
      into  sita.local:/Users/tsmith/m/bk/maint/51
      
      
      storage/innobase/btr/btr0btr.c:
        use local (null merge)
      storage/innobase/buf/buf0buf.c:
        use local (null merge)
      storage/innobase/buf/buf0lru.c:
        use local (null merge)
      storage/innobase/handler/ha_innodb.cc:
        use local (null merge)
      storage/innobase/ibuf/ibuf0ibuf.c:
        use local (null merge)
      storage/innobase/include/buf0buf.ic:
        use local (null merge)
      storage/innobase/include/buf0lru.h:
        use local (null merge)
      storage/innobase/include/dict0dict.h:
        use local (null merge)
      storage/innobase/include/dict0dict.ic:
        use local (null merge)
      storage/innobase/include/dict0mem.h:
        use local (null merge)
      storage/innobase/include/os0file.h:
        use local (null merge)
      storage/innobase/include/trx0trx.h:
        use local (null merge)
      storage/innobase/lock/lock0lock.c:
        SCCS merged
      storage/innobase/log/log0log.c:
        use local (null merge)
      storage/innobase/mtr/mtr0mtr.c:
        use local (null merge)
      storage/innobase/os/os0file.c:
        use local (null merge)
      storage/innobase/rem/rem0rec.c:
        use local (null merge)
      storage/innobase/row/row0sel.c:
        use local (null merge)
      storage/innobase/srv/srv0srv.c:
        use local (null merge)
      674be56a
    • unknown's avatar
      NULL MERGE UP to 5.1. · adc3d3cb
      unknown authored
      Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
      
      Fixes:
      Bug#9709:  InnoDB inconsistensy causes "Operating System Error 32/33"
      Bug#22819: SHOW INNODB STATUS crashes the server with an assertion failure under high load
      Bug#25645: Assertion failure in file srv0srv.c
      Bug#27294: insert into ... select ... causes crash with innodb_locks_unsafe_for_binlog=1
      Bug#28138: indexing column prefixes produces corruption in InnoDB
      
      
      innobase/btr/btr0btr.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1547:
        branches/5.0: Merge r1546 from trunk:
        
        When buffering an insert to a prefix index of a variable-length column,
        do not incorrectly mark the column as fixed-length.  (Bug #28138)
        
        ibuf_entry_build(): Instead of prefix_len, pass fixed_len to
        dtype_new_store_for_order_and_null_size().  Add debug assertions.
        
        btr_index_rec_validate(): Correct a comment about prefix indexes.
        
        rec_get_converted_size_new(), rec_convert_dtuple_to_rec_new(): Add
        debug assertions and comments.
        
        dict_col_type_assert_equal(): New debug function.
      innobase/buf/buf0buf.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1502:
        branches/5.0: Add debug code for Bug 26081. This change has some debug
        assertions that have been promoted to normal assertions. These will need
        to be undone once we've nailed this bug.
      innobase/buf/buf0lru.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1502:
        branches/5.0: Add debug code for Bug 26081. This change has some debug
        assertions that have been promoted to normal assertions. These will need
        to be undone once we've nailed this bug.
      innobase/ibuf/ibuf0ibuf.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1547:
        branches/5.0: Merge r1546 from trunk:
        
        When buffering an insert to a prefix index of a variable-length column,
        do not incorrectly mark the column as fixed-length.  (Bug #28138)
        
        ibuf_entry_build(): Instead of prefix_len, pass fixed_len to
        dtype_new_store_for_order_and_null_size().  Add debug assertions.
        
        btr_index_rec_validate(): Correct a comment about prefix indexes.
        
        rec_get_converted_size_new(), rec_convert_dtuple_to_rec_new(): Add
        debug assertions and comments.
        
        dict_col_type_assert_equal(): New debug function.
      innobase/include/buf0buf.ic:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1502:
        branches/5.0: Add debug code for Bug 26081. This change has some debug
        assertions that have been promoted to normal assertions. These will need
        to be undone once we've nailed this bug.
      innobase/include/buf0lru.h:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1502:
        branches/5.0: Add debug code for Bug 26081. This change has some debug
        assertions that have been promoted to normal assertions. These will need
        to be undone once we've nailed this bug.
      innobase/include/dict0dict.h:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1547:
        branches/5.0: Merge r1546 from trunk:
        
        When buffering an insert to a prefix index of a variable-length column,
        do not incorrectly mark the column as fixed-length.  (Bug #28138)
        
        ibuf_entry_build(): Instead of prefix_len, pass fixed_len to
        dtype_new_store_for_order_and_null_size().  Add debug assertions.
        
        btr_index_rec_validate(): Correct a comment about prefix indexes.
        
        rec_get_converted_size_new(), rec_convert_dtuple_to_rec_new(): Add
        debug assertions and comments.
        
        dict_col_type_assert_equal(): New debug function.
      innobase/include/dict0dict.ic:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1547:
        branches/5.0: Merge r1546 from trunk:
        
        When buffering an insert to a prefix index of a variable-length column,
        do not incorrectly mark the column as fixed-length.  (Bug #28138)
        
        ibuf_entry_build(): Instead of prefix_len, pass fixed_len to
        dtype_new_store_for_order_and_null_size().  Add debug assertions.
        
        btr_index_rec_validate(): Correct a comment about prefix indexes.
        
        rec_get_converted_size_new(), rec_convert_dtuple_to_rec_new(): Add
        debug assertions and comments.
        
        dict_col_type_assert_equal(): New debug function.
      innobase/include/dict0mem.h:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1537:
        branches/5.0: merge r1536 and partially r1535
        
        Change the comment to a more appropriate one. Discussed with Heikki on IM.
        
        Document that DICT_MAX_INDEX_COL_LEN should not be changed.
      innobase/include/os0file.h:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1417:
        branches/5.0: Fix Bug#9709 by retrying (forever) if ERROR_SHARING_VIOLATION or
        ERROR_LOCK_VIOLATION is encountered during file operation.
        This is caused by backup software, so InnoDB should retry while the backup
        software is done with the file.
        
        Approved by:	Heikki
      innobase/include/trx0trx.h:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1463:
        branches/5.0: merge r1462 from trunk:
        
        Fix typo in comment.
      innobase/lock/lock0lock.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1458:
        branches/5.0: Fix Bug#22819, remove assertion.  (http://bugs.mysql.com/bug.php?id=22819)
      innobase/log/log0log.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1520:
        Patch to allow monitor threads to stop before proceeding with normal shutdown. 
        Also have a separate time counter for tablespace monitor.
        
        reviewed by: Heikki
        
        
        Revision r1525:
        backport of r1524
        
        Log:
        Undo bad space formatting introduced in earlier commit r1521
        
        spotted by: Marko
      innobase/mtr/mtr0mtr.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1502:
        branches/5.0: Add debug code for Bug 26081. This change has some debug
        assertions that have been promoted to normal assertions. These will need
        to be undone once we've nailed this bug.
      innobase/os/os0file.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1417:
        branches/5.0: Fix Bug#9709 by retrying (forever) if ERROR_SHARING_VIOLATION or
        ERROR_LOCK_VIOLATION is encountered during file operation.
        This is caused by backup software, so InnoDB should retry while the backup
        software is done with the file.
        
        Approved by:	Heikki
      innobase/rem/rem0rec.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1547:
        branches/5.0: Merge r1546 from trunk:
        
        When buffering an insert to a prefix index of a variable-length column,
        do not incorrectly mark the column as fixed-length.  (Bug #28138)
        
        ibuf_entry_build(): Instead of prefix_len, pass fixed_len to
        dtype_new_store_for_order_and_null_size().  Add debug assertions.
        
        btr_index_rec_validate(): Correct a comment about prefix indexes.
        
        rec_get_converted_size_new(), rec_convert_dtuple_to_rec_new(): Add
        debug assertions and comments.
        
        dict_col_type_assert_equal(): New debug function.
      innobase/row/row0sel.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1456:
        branches/5.0: merge r1452 from trunk:
        
        Fix phantom reads (http://bugs.mysql.com/27197) following Heikki's
        patch in the bug followup.
      innobase/srv/srv0srv.c:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1460:
        branches/5.0: Merge r1459 from trunk:
        
        Fix typo in the comment.
        
        
        Revision r1520:
        Patch to allow monitor threads to stop before proceeding with normal shutdown. 
        Also have a separate time counter for tablespace monitor.
        
        reviewed by: Heikki
      sql/ha_innodb.cc:
        Apply innodb-5.0-* snapshots:  ss1489 and ss1547.
        
        Revision r1436:
        branches/5.0: Fix Bug#27294 by using trx returned by check_trx_exists()
        instead of prebuilt->trx. This has been fixed in 5.1 in r782.
        
        Approved by:	Heikki
        
        
        Revision r1443:
        branches/5.0: merge r1442 from trunk:
        
        Potential fix for Bug#25645:
        
        "Move innobase_release_stat_resources(trx) outside the 'if' in
        ha_innobase::external_lock(). That would add more safety that whatever
        MySQL does at a query end, there would be no risk of a hang on the btr
        search latch."
        
        Also call innobase_release_temporary_latches() in the beginning of
        ha_innobase::close().
        
        Approved by:	Heikki
        
        
        Revision r1454:
        branches/5.0: merge r1453 from trunk:
        
        Bugfix: only call innobase_release_temporary_latches() in case of current_thd
        is not NULL, otherwise we get NULL pointer dereferencing.
        
        
        
        Revision r1504:
        branches/5.0: Apply patch for Bug 27650 from MySQL.
        
        
        Revision r1539:
        Backport of r1538 from 5.1
        Do not return error in ha_innobase::info if srv_force_recovery >= 4. This is to allow for
        normal processing of the query by MySQL instead of generating an error.
        
        Reviewed by: Heikki
      adc3d3cb
    • unknown's avatar
      Merge sita.local:/Users/tsmith/m/bk/inno/jul5/51-snap · 1bd9e0fa
      unknown authored
      into  sita.local:/Users/tsmith/m/bk/maint/51
      
      1bd9e0fa