- 08 Sep, 2017 7 commits
-
-
Igor Babaev authored
Currently condition pushdown into materialized views / derived tables is not implemented yet (see mdev-12387) and grouping views are optimized early when subqueries are converted to semi-joins in convert_join_subqueries_to_semijoins(). If a subquery that is converted to a semi-join uses a grouping view this view is optimized in two phases. For such a view V only the first phase of optimization is done after the conversion of subqueries of the outer join into semi-joins. At the same time the reference of the view V appears in the join expression of the outer join. In fixed code there was an attempt to push conditions into this view and to optimize it after this. This triggered the second phase of the optimization of the view and it was done prematurely. The second phase of the optimization for the materialized view is supposed to be called after the splitting condition is pushed into the view in the call of JOIN::improve_chosen_plan for the outer join. The fix blocks the attempt to push conditions into splittable views if they have been already partly optimized and the following optimization for them. The test case of the patch shows that the code for mdev-13369 basically supported the splitting technique for materialized views / derived tables. The patch also replaces the name of the state JOIN::OPTIMIZATION_IN_STAGE_2 for JOIN::OPTIMIZATION_PHASE_1_DONE and fixes a bug in TABLE_LIST::fetch_number_of_rows()
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
trx_undo_assign_undo(): Restore the fault injection.
-
Marko Mäkelä authored
Import the test innodb.alter_crash
-
Marko Mäkelä authored
The redo log is divided into 512-byte blocks. Sometimes, some of the strings end up at a block boundary and will not be found. Look for only one match.
-
Vladislav Vaintroub authored
-
- 07 Sep, 2017 7 commits
-
-
Vladislav Vaintroub authored
full server recovery is performed . We start "mysqld" with --bootstrap and pass bootstrap script consisting of several FLUSH TABLES FOR export/ UNLOCK TABLES
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
recv_reset_logs(): Initialize the redo log buffer, so that no data from the old redo log can be written to the new redo log. This bug has very little impact before MariaDB 10.2. The innodb_log_encrypt option that was introduced in MariaDB 10.1 increases the impact. If the redo log used to be encrypted, and it is being resized and encryption disabled, then previously encrypted data could end up being written to the new redo log in clear text. This resulted in encryption.innodb_encrypt_log test failures in MariaDB 10.2.
-
Marko Mäkelä authored
The SEARCH_ABORT logic was not working as intended (tests were not being aborted).
-
Marko Mäkelä authored
In XtraDB, buf_block_get_frame() can return NULL, and this value can be passed to buf_page_print(). Do not declare the parameter as nonnull.
-
- 06 Sep, 2017 9 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
The files ibtmp1 and ib_buffer_pool are sometimes created, sometimes not. Remove them if they exist.
-
Marko Mäkelä authored
-
Oleksandr Byelkin authored
MDEV-13523: Group By in a View, called within a Stored Routine causes Error Code 1356 when a non-root user runs the routine for a second time it is actually test suite for second code chunk fix in MDEV-13439
-
Marko Mäkelä authored
The bug only affects ROW_FORMAT=DYNAMIC tables. It is reproducible already with 2 records in the table. Keep testing with ROW_FORMAT=REDUNDANT just in case.
-
Marko Mäkelä authored
The bug only affected innodb_page_size=64k. There is no point running the test with smaller page sizes.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
buf_page_print(): Remove the parameter 'flags', and when a server abort is intended, perform that in the caller. In this way, page corruption reports due to different reasons can be distinguished better. This is non-functional code refactoring that does not fix any page corruption issues. The change is only made to avoid falsely grouping together unrelated causes of page corruption.
-
- 05 Sep, 2017 2 commits
-
-
Varun Gupta authored
Rdb_io_watchdog can not be built on OS X. Disable it.
-
Sergei Petrunia authored
-
- 04 Sep, 2017 4 commits
-
-
andrelkin authored
Was reported as 'rpl.rpl_gtid_stop_start fails with Valgrind in buildbot and outside'. The 'Conditional jump or move depends on uninitialized value' valgrind complaint is valid and means THD::m_current_stage_key that is not initialized indeed by constructor. Fixed with its initialization added to the initializer list of THD::THD. Double checked with mysql to have found a similar fixes for the very same issue which was discovered after P_S merge to Maria (60589aee where the member is introduced) had been done.
-
Andrei Elkin authored
A new $MYSQLD_LAST_CMD evaluation was too late in case --manual-gdb. Now it is done before the server restart type branches which is safe and the args value has been fully computed by the new point of evaluation.
-
Oleksandr Byelkin authored
save thd->select_number between parsing and executions (in case it was not complete executed due to errors (for example epsent table))
-
Marko Mäkelä authored
This is a backport of the following: MDEV-13009 10.1.24 does not compile on architectures without 64-bit atomics Add a missing #include "sync0types.h" that was removed in MDEV-12674.
-
- 03 Sep, 2017 1 commit
-
-
Julien Del-Piccolo authored
* Fix bash expansion issue in wsrep_sst_rsync. https://github.com/docker-library/mariadb/issues/126 * Fix permissions
-
- 01 Sep, 2017 8 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Follow-up to MDEV-13570 Assertion failure !srv_read_only_mode in --innodb-read-only shutdown when buf_resize_thread is active logs_empty_and_mark_files_at_shutdown(): Actually skip the debug assertion when the buf_resize_thread is active. The previous fix skipped the debug assertion failure when buf_dump_thread is active. Both these threads are created also in innodb_read_only mode. Depending on how fast these threads react to the shutdown signal, the debug assertion could be triggered. There is no impact on non-debug servers, and very little impact on debug servers either, because in innodb_read_only shutdown, no InnoDB files will need to be written.
-
Marko Mäkelä authored
metadata_lock_info_duration[]: Remove the unused variable. Add some comments /* fall through */ to silence -Wimplicit-fallthrough
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 31 Aug, 2017 2 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-