1. 17 Apr, 2009 4 commits
  2. 16 Apr, 2009 4 commits
  3. 15 Apr, 2009 5 commits
    • Alfranio Correia's avatar
      8de80ef1
    • Satya B's avatar
      Applying InnoDB snashot 5.1-ss4699, part 3. Fixes BUG#43660 · 3e90469f
      Satya B authored
      1) BUG#43660 - SHOW INDEXES/ANALYZE does NOT update cardinality 
                     for indexes of InnoDB table
      
      Detailed revision comments:
      
      r4699 | vasil | 2009-04-09 14:01:52 +0300 (Thu, 09 Apr 2009) | 15 lines
      branches/5.1:
      
      Fix Bug#43660 SHOW INDEXES/ANALYZE does NOT update cardinality for indexes
      of InnoDB table
      
      by replacing the PRNG that is used to pick random pages with a better
      one.
      
      This is based on r4670 but also adds a new configuration option and
      enables the fix only if this option is changed. Please skip the present
      revision when merging.
      
      Approved by:	Heikki (via email)
      3e90469f
    • Satya B's avatar
      Applying InnoDB snashot 5.1-ss4699, part 2. Fixes BUG#43309 · d629c4ec
      Satya B authored
      1) BUG#43309 - Test main.innodb can't be run twice
      
      2) Follow up fix for BUG#43309, adds explanatory comments.
      
      Detailed revision comments:
      
      r4575 | vasil | 2009-03-30 15:55:31 +0300 (Mon, 30 Mar 2009) | 8 lines
      branches/5.1:
      
      Fix Bug#43309 Test main.innodb can't be run twice
      
      Make the innodb mysql-test more flexible by inspecting how much a
      variable of interest has changed since the start of the test. Do not
      assume the variables have zero values at the start of the test.
      
      r4659 | vasil | 2009-04-06 15:34:51 +0300 (Mon, 06 Apr 2009) | 6 lines
      branches/5.1:
      
      Followup to r4575 and the fix of Bug#43309 Test main.innodb can't be run twice:
      
      Add an explanatory comment, as suggested by Patrick Crews in the bug report.
      d629c4ec
    • Satya B's avatar
      Applying InnoDB snashot 5.1-ss4699, part 1. Fixes BUG#39320 and other · df7f5472
      Satya B authored
      problems
      
      1) BUG#39320 - innodb crash in file btr/btr0pcur.c line 217 with 
                     innodb_locks_unsafe_for_binlog
      
      2) Fixes bug in multi-table semi consistent reads.
      
      3) Fixes email address from dev@innodb.com to innodb_dev_ww@oracle.com
      
      4) Fixes warning message generated by main.innodb test
      
      
      Detailed revision comments:
      
      r4399 | marko | 2009-03-12 09:38:05 +0200 (Thu, 12 Mar 2009) | 5 lines
      branches/5.1: row_sel_get_clust_rec_for_mysql(): Store the cursor position
      also for unlock_row().  (Bug #39320)
      
      rb://96 approved by Heikki Tuuri.
      
      r4400 | marko | 2009-03-12 10:06:44 +0200 (Thu, 12 Mar 2009) | 8 lines
      branches/5.1: Fix a bug in multi-table semi-consistent reads.
      Remember the acquired record locks per table handle (row_prebuilt_t)
      rather than per transaction (trx_t), so that unlock_row should successfully
      unlock all non-matching rows in multi-table operations.
      This deficiency was found while investigating Bug #39320.
      
      rb://94 approved by Heikki Tuuri.
      
      r4481 | marko | 2009-03-19 15:01:48 +0200 (Thu, 19 Mar 2009) | 6 lines
      branches/5.1: row_unlock_for_mysql(): Do not unlock records that were
      modified by the current transaction.  This bug was introduced or unmasked
      in r4400.
      
      rb://97 approved by Heikki Tuuri
      
      r4573 | vasil | 2009-03-30 14:17:13 +0300 (Mon, 30 Mar 2009) | 4 lines
      branches/5.1:
      
      Fix email address from dev@innodb.com to innodb_dev_ww@oracle.com
      
      r4574 | vasil | 2009-03-30 14:27:08 +0300 (Mon, 30 Mar 2009) | 38 lines
      branches/5.1:
      
      Restore the state of INNODB_THREAD_CONCURRENCY to silence this warning:
      
        TEST                                      RESULT   TIME (ms)
        ------------------------------------------------------------
        
        worker[1] Using MTR_BUILD_THREAD 250, with reserved ports 12500..12509
        main.innodb                              [ pass ]   8803
        
        MTR's internal check of the test case 'main.innodb' failed.
        This means that the test case does not preserve the state that existed
        before the test case was executed.  Most likely the test case did not
        do a proper clean-up.
        This is the diff of the states of the servers before and after the
        test case was executed:
        mysqltest: Logging to '/tmp/autotest.sh-20090330_033000-5.1.5Hg8CY/mysql-5.1/mysql-test/var/tmp/check-mysqld_1.log'.
        mysqltest: Results saved in '/tmp/autotest.sh-20090330_033000-5.1.5Hg8CY/mysql-5.1/mysql-test/var/tmp/check-mysqld_1.result'.
        mysqltest: Connecting to server localhost:12500 (socket /tmp/autotest.sh-20090330_033000-5.1.5Hg8CY/mysql-5.1/mysql-test/var/tmp/mysqld.1.sock) as 'root', connection 'default', attempt 0 ...
        mysqltest: ... Connected.
        mysqltest: Start processing test commands from './include/check-testcase.test' ...
        mysqltest: ... Done processing test commands.
        --- /tmp/autotest.sh-20090330_033000-5.1.5Hg8CY/mysql-5.1/mysql-test/var/tmp/check-mysqld_1.result	2009-03-30 14:12:31.000000000 +0300
        +++ /tmp/autotest.sh-20090330_033000-5.1.5Hg8CY/mysql-5.1/mysql-test/var/tmp/check-mysqld_1.reject	2009-03-30 14:12:41.000000000 +0300
        @@ -99,7 +99,7 @@
         INNODB_SUPPORT_XA	ON
         INNODB_SYNC_SPIN_LOOPS	20
         INNODB_TABLE_LOCKS	ON
        -INNODB_THREAD_CONCURRENCY	8
        +INNODB_THREAD_CONCURRENCY	16
         INNODB_THREAD_SLEEP_DELAY	10000
         INSERT_ID	0
         INTERACTIVE_TIMEOUT	28800
        
        mysqltest: Result content mismatch
        
        not ok
      
      r4576 | vasil | 2009-03-30 16:25:10 +0300 (Mon, 30 Mar 2009) | 4 lines
      branches/5.1:
      
      Revert a change to Makefile.am that I committed accidentally in c4574.
      df7f5472
    • Alfranio Correia's avatar
      BUG#41793 rpl_binlog_corruption disabled in main (needs new mtr) · a8f7d47e
      Alfranio Correia authored
      The test case was missing "let $slave_sql_errno= 1594;".
      a8f7d47e
  4. 14 Apr, 2009 7 commits
  5. 13 Apr, 2009 4 commits
  6. 10 Apr, 2009 6 commits
    • Chad MILLER's avatar
      Merge fix for bug 39559 and bugteam trunk. · 538fdd3d
      Chad MILLER authored
      538fdd3d
    • Sergey Glukhov's avatar
      Bug#43385 Cannot ALTER DATABASE ... UPGRADE DATA DIRECTORY NAME when Views exist · 5c5691e8
      Sergey Glukhov authored
      allow 'rename view' for ALTER ...UPGRADE DATA DIRECTORY NAME command.
      it's safe because a view has valid internal db&table names in this case.
      5c5691e8
    • Narayanan V's avatar
      Bug#44025 Some schema names longer than 8 characters not supported by IBMDB2I · 4a12ecf7
      Narayanan V authored
      On IBM i 5.4, schemas with names that are longer 
      than 8 characters and contain digits or an underscore
      cannot contain IBMDB2I tables, even though this should
      theoritically be possible if all alpha characters
      are uppercase.
      
      THe current patch fixes the IBMDB2I engine to
      allow digits and the underscore(_) to be used in
      schema names longer than 8 characters on IBM i 5.4.
      4a12ecf7
    • Narayanan V's avatar
      Bug#44022 CREATE TABLE sometimes fails silently for IBMDB2I engine · 9887dd7a
      Narayanan V authored
      In some circumstances, when a table is created with
      the IBMDB2I engine, the CREATE TABLE statement will
      return successfully but the table will not exist.
      
      The current patch addresses the above issue and causes
      CREATE to fail and report and error to the user.
      9887dd7a
    • Narayanan V's avatar
      Bug#44020 Unicode Swedish collations not working with IBMDB2I · 39d9d106
      Narayanan V authored
      The utf8_swedish_ci and ucs2_swedish_ci
      collations do not work with indexes on 
      IBMDB2I tables.
      
      The current patch adds the mapping for
      ucs2_swedish collation and removes the 
      ucs2_spanish2 mapping which is not
      supported by any version of the operating
      system.
      39d9d106
    • Chad MILLER's avatar
      Bug#39559: dump of stored procedures / functions with C-style \ · aa449c10
      Chad MILLER authored
      	comment can't be read back
      
      A change to the lexer in 5.1 caused slash-asterisk-bang-version
      sections to be terminated early if there exists a slash-asterisk-
      style comment inside it.  Nesting comments is usually illegal,
      but we rely on versioned comment blocks in mysqldump, and the
      contents of those sections must be allowed to have comments.
      
      The problem was that when encountering open-comment tokens and
      consuming -or- passing through the contents, the "in_comment"
      state at the end was clobbered with the not-in-a-comment value,
      regardless of whether we were in a comment before this or not.  
      
      So, """/*!VER one /* two */ three */""" would lose its in-comment
      state between "two" and "three".  Save the echo and in-comment
      state, and restore it at the end of the comment if we consume a 
      comment.
      aa449c10
  7. 09 Apr, 2009 10 commits
    • Davi Arnaut's avatar
      Bug#43706: libmysqld segfaults when re-intialised · 064c1b2c
      Davi Arnaut authored
      Bug#44091: libmysqld gets stuck waiting on mutex on initialization
      
      The problem was that libmysqld wasn't enforcing a certain
      initialization and deinitialization order for the mysys
      library. Another problem was that the global object used
      for management of log event handlers (aka LOGGER) wasn't
      being prepared for a possible reutilization.
      
      What leads to the hang/crash reported is that a failure
      to load the language file triggers a double call of the
      cleanup functions, causing an already destroyed mutex to
      be used.
      
      The solution is enforce a order on the initialization and
      deinitialization of the mysys library within the libmysqld
      library and to ensure that the global LOGGER object reset
      it's internal state during cleanup.
      064c1b2c
    • Luis Soares's avatar
      manual merge: 5.0-bugteam --> 5.1-bugteam · 49ab0497
      Luis Soares authored
      Note: empty changeset.
      49ab0497
    • Luis Soares's avatar
      BUG#13684: SP: DROP PROCEDURE|FUNCTION IF EXISTS not binlogged if · dc3fad94
      Luis Soares authored
      routine does not exist 
            
      There is an inconsistency with DROP DATABASE IF EXISTS, DROP TABLE IF
      EXISTS and DROP VIEW IF EXISTS: those are binlogged even if the DB or
      TABLE does not exist, whereas DROP PROCEDURE IF EXISTS does not. It
      would be nice or at least consistent if DROP PROCEDURE/STATEMENT
      worked the same too.
            
      Fixed DROP PROCEDURE|FUNCTION IF EXISTS by adding a call to
      mysql_bin_log.write in mysql_execute_command. Checked also if all 
      documented "DROP (...) IF EXISTS" get binlogged.
            
      NOTE: This is a 5.0 backport patch as requested by support.
      dc3fad94
    • Narayanan V's avatar
      merging with mysql-5.1-bugteam · cec52793
      Narayanan V authored
      cec52793
    • Sergey Glukhov's avatar
      null merge · c9f06889
      Sergey Glukhov authored
      c9f06889
    • Sergey Glukhov's avatar
      null merge · c8696420
      Sergey Glukhov authored
      c8696420
    • Sergey Glukhov's avatar
      auotmerge · 7d8a970f
      Sergey Glukhov authored
      7d8a970f
    • Sergey Glukhov's avatar
      5.0-bugteam->5.1-bugteam merge · c641d962
      Sergey Glukhov authored
      c641d962
    • He Zhenxing's avatar
      Null merge the fix only for 5.0-bugteam · 10234f23
      He Zhenxing authored
      10234f23
    • Sergey Glukhov's avatar
      Bug#43833 Simple INSERT crashes the server · db992986
      Sergey Glukhov authored
      The crash happens due to wrong 'digits' variable value(0),
      'digits' can not be 0, so the fix is use 1 as min allowed value.
      db992986