1. 17 Sep, 2021 4 commits
  2. 16 Sep, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-26626 InnoDB fails to advance the log checkpoint · c430aa72
      Marko Mäkelä authored
      buf_flush_page_cleaner(): Always try to advance the log checkpoint,
      even when no pages were flushed during the latest batch.
      Maybe, since the previous batch, there was an LRU flush that
      removed the last dirty pages.
      
      Failure to advance the log checkpoint will cause unnecessary work
      in Mariabackup and on crash recovery.
      c430aa72
    • Monty's avatar
      Updated rocksdb test result · 65cce297
      Monty authored
      This was required as I added a new error code to my_base.h and rocksdb
      is adding it's own errors after the last official one
      
      Updated result file also for index_merge_rocksdb2. This is a big test
      and we have probably not before noticed that some optimizer changes
      caused a difference.
      65cce297
    • Eugene Kosov's avatar
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in... · 5b0a7607
      Eugene Kosov authored
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in /storage/innobase/btr/btr0btr.cc during IMPORT
      
      dict_index_t::clear_instant_alter(): when searhing for an AUTO_INCREMENT column
      don't skip the beginning of the list because the field can be at the beginning of the list
      5b0a7607
  3. 15 Sep, 2021 4 commits
    • Monty's avatar
      Fixed bug in aria_chk that overwrote sort_buffer_length · 0d47945b
      Monty authored
      This bug happens when one runs aria_chk on multiple tables. It does not
      affect REPAIR TABLE.
      aria_chk tries to optimize the sort buffer size to minimize memory usage
      when used with small tables. The bug was that the adjusted value was
      used as a base for the next table, which could cause problems.
      0d47945b
    • Monty's avatar
      Merge branch '10.4' into 10.5 · b4f24c74
      Monty authored
      Fixed also an error in suite/perfschema/t/transaction_nested_events-master.opt
      b4f24c74
    • Monty's avatar
      Improve error messages from Aria · f03fee06
      Monty authored
      - Error on commit now returns HA_ERR_COMMIT_ERROR instead of
        HA_ERR_INTERNAL_ERROR
      - If checkpoint fails, it will now print out where it failed.
      f03fee06
    • Monty's avatar
      Fixed compiler warnings in CONNECT · 6be0ddae
      Monty authored
      6be0ddae
  4. 14 Sep, 2021 4 commits
    • Monty's avatar
      MDEV-23519 Protocol packet - "Original Name" info is showing alias name, · 689b8d06
      Monty authored
      instead of original name of the column
      
      When doing refactoring of temporary table field creation a mistake was
      done when copying the column name when creating internal temporary tables.
      For internal temporary tables we should use the original field name, not
      the item name (= alias).
      689b8d06
    • Daniel Black's avatar
      MDEV-26601: mysys - O_TMPFILE ^ O_CREAT · adaf0dde
      Daniel Black authored
      Thanks to Fabian Vogt for noticing the mutual exclusions
      of these open flags on tmpfs caused by mariadb opening it
      incorrectly.
      
      As such we clear the O_CREAT flag while opening it as O_TMPFILE.
      adaf0dde
    • Daniele Sciascia's avatar
      MDEV-21613 Failed to open table mysql.wsrep_streaming_log for writing · 5527fc58
      Daniele Sciascia authored
      Fix sporadic failure for MTR test galera_sr.GCF-1018B. The test
      sometimes fails due to an error that is logged to the error log
      unnecessarily.
      A deterministic test case (included in this patch) shows that the
      error is loggen when a transaction is BF aborted right before  it
      opens the streaming log table to perform fragment removal. When that
      happens, the attempt to open the table fails and consequently an error
      is logged. There is no need to log this error, as an ER_LOCK_DEADLOCK
      error is returned to the client.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      5527fc58
    • Otto Kekäläinen's avatar
      Deb: Fix Gitlab-CI/Salsa-CI builds failures · 07abcb50
      Otto Kekäläinen authored
      The debian/salsa-ci.yml used to work also on upstream MariaDB.org branches,
      but has recently regressed and several jobs stopped working. These fixes
      are necessary to get it working again.
      
      * Partially revert 8642f592 that never worked, as MariaDB 10.2 does not
        have a mysql.global table nor a mariadb.sys user. Those features weren't
        introduced until MariaDB 10.4.
      
      * Partially revert 0268b871 as we don't want ColumnStore as part of the
        native Debian build. It should build only when the build is triggered
        via autobake-deb.sh (MariaDB.org builds).
      
      * Adjust salsa-ci.yml to cope with various Stretch to Sid upgrade issues
        and remove the legacy mariadb-connector-c job completely as that package
        hasn't been around for years anymore.
      
      * Extend Lintian overrides to be otherwise Lintian clean
      07abcb50
  5. 12 Sep, 2021 1 commit
    • Sergei Golubchik's avatar
      perfschema: use correct type for left shifts · 1a6c130c
      Sergei Golubchik authored
      set_item() uses 1UL << bit, so is_set_item() must do the same.
      
      This fixes sporadic perfschema.show_aggregate failures
      (sporadic, because `bit` is the thread id, so depending on how many
      tests were run before perfschema.show_aggregate it can be above or
      below 32).
      1a6c130c
  6. 11 Sep, 2021 19 commits
  7. 10 Sep, 2021 5 commits
    • Vladislav Vaintroub's avatar
    • Marko Mäkelä's avatar
      MDEV-26537 InnoDB corrupts files due to incorrect st_blksize calculation · d09426f9
      Marko Mäkelä authored
      The st_blksize returned by fstat(2) is not documented to be
      a power of 2, like we assumed in
      commit 58252fff (MDEV-26040).
      While on Linux, the st_blksize appears to report the file system
      block size (which hopefully is not smaller than the sector size
      of the underlying block device), on FreeBSD we observed
      st_blksize values that might have been something similar to st_size.
      
      Also IBM AIX was affected by this. A simple test case would
      lead to a crash when using the minimum innodb_buffer_pool_size=5m
      on both FreeBSD and AIX:
      
      seq -f 'create table t%g engine=innodb select * from seq_1_to_200000;' \
      1 100|mysql test&
      seq -f 'create table u%g engine=innodb select * from seq_1_to_200000;' \
      1 100|mysql test&
      
      We will fix this by not trusting st_blksize at all, and assuming that
      the smallest allowed write size (for O_DIRECT) is 4096 bytes. We hope
      that no storage systems with larger block size exist. Anything larger
      than 4096 bytes should be unlikely, given that it is the minimum
      virtual memory page size of many contemporary processors.
      
      MariaDB Server on Microsoft Windows was not affected by this.
      
      While the 512-byte sector size of the venerable Seagate ST-225 is still
      in widespread use, the minimum innodb_page_size is 4096 bytes, and
      innodb_log_file_size can be set in integer multiples of 65536 bytes.
      
      The only occasion where InnoDB uses smaller data file block sizes than
      4096 bytes is with ROW_FORMAT=COMPRESSED tables with KEY_BLOCK_SIZE=1
      or KEY_BLOCK_SIZE=2 (or innodb_page_size=4096). For such tables,
      we will from now on preallocate space in integer multiples of 4096 bytes
      and let regular writes extend the file by 1024, 2048, or 3072 bytes.
      
      The view INFORMATION_SCHEMA.INNODB_SYS_TABLESPACES.FS_BLOCK_SIZE
      should report the raw st_blksize.
      
      For page_compressed tables, the function fil_space_get_block_size()
      will map to 512 any st_blksize value that is larger than 4096.
      
      os_file_set_size(): Assume that the file system block size is 4096 bytes,
      and only support extending files to integer multiples of 4096 bytes.
      
      fil_space_extend_must_retry(): Round down the preallocation size to
      an integer multiple of 4096 bytes.
      d09426f9
    • Vicențiu Ciorbaru's avatar
      Expand performance_schema tables definitions with column comments · 8fe927e6
      Vicențiu Ciorbaru authored
      Cover all columns that did not have comments. Adjust docs based off of
      MariaDB implementation.
      8fe927e6
    • Haidong Ji's avatar
      MDEV-25325 built-in documentation for performance_schema tables · cc71dc0b
      Haidong Ji authored
      Improve documentation of performance_schema tables by appending COLUMN
      comments to tables. Additionally improve test coverage and update corresponding
      tests.
      
      This is part of the patch covering newer columns and tables in 10.5.
      cc71dc0b
    • Vicențiu Ciorbaru's avatar