1. 15 Aug, 2017 11 commits
  2. 14 Aug, 2017 3 commits
  3. 13 Aug, 2017 2 commits
  4. 11 Aug, 2017 6 commits
  5. 10 Aug, 2017 8 commits
    • Igor Babaev's avatar
      This is a modification of the first patch committed for mdev-13369 · bf75dcac
      Igor Babaev authored
      developed to cover the case of mdev-13389: "Optimization for equi-joins
      of derived tables with window functions".
      bf75dcac
    • Igor Babaev's avatar
      This first patch prepared for the task MDEV-13369: · b14e2b04
      Igor Babaev authored
      "Optimization for equi-joins of derived tables with GROUP BY"
      should be considered rather as a 'proof of concept'.
      
      The task itself is targeted at an optimization that employs re-writing
      equi-joins with grouping derived tables / views into lateral
      derived tables. Here's an example of such transformation:
        select t1.a,t.max,t.min
        from t1 [left] join
             (select a, max(t2.b) max, min(t2.b) min from t2
             group by t2.a) as t
             on t1.a=t.a;
      =>
        select t1.a,tl.max,tl.min
        from t1 [left] join
             lateral (select a, max(t2.b) max, min(t2.b) min from t2
                      where  t1.a=t2.a) as t
             on 1=1;
      The transformation pushes the equi-join condition t1.a=t.a into the
      derived table making it dependent on table t1. It means that for
      every row from t1 a new derived table must be filled out. However
      the size of any of these derived tables is just a fraction of the
      original derived table t. One could say that transformation 'splits'
      the rows used for the GROUP BY operation into separate groups
      performing aggregation for a group only in the case when there is
      a match for the current row of t1.
      Apparently the transformation may produce a query with a better
      performance only in the case when
       - the GROUP BY list refers only to fields returned by the derived table
       - there is an index I on one of the tables T used in FROM list of
         the specification of the derived table whose prefix covers the
         the fields from the proper beginning of the GROUP BY list or
         fields that are equal to those fields.
      Whether the result of the re-writing can be executed faster depends
      on many factors:
        - the size of the original derived table
        - the size of the table T
        - whether the index I is clustering for table T
        - whether the index I fully covers the GROUP BY list.
      
      This patch only tries to improve the chosen execution plan using
      this transformation. It tries to do it only when the chosen
      plan reaches the derived table by a key whose prefix covers
      all the fields of the derived table produced by the fields of
      the table T from the GROUP BY list.
      The code of the patch does not evaluates the cost of the improved
      plan. If certain conditions are met the transformation is applied.
      b14e2b04
    • Alexey Botchkov's avatar
      MDEV-12604 Comparison of JSON_EXTRACT result differs with Mysql. · 79d28533
      Alexey Botchkov authored
              JSON_EXTRACT behaves specifically in the comparison,
              so we have to implement specific method for that in
              Arg_comparator.
      79d28533
    • Marko Mäkelä's avatar
      Fix some GCC 7 warnings for InnoDB · bfffe571
      Marko Mäkelä authored
      buf_page_io_complete(): Do not test bpage for NULL, because
      it is declared (and always passed) as nonnull.
      
      buf_flush_batch(): Remove the constant local variable count=0.
      
      fil_ibd_load(): Use magic comment to suppress -Wimplicit-fallthrough.
      
      ut_stage_alter_t::inc(ulint): Disable references to an unused parameter.
      
      lock_queue_validate(), sync_array_find_thread(), rbt_check_ordering():
      Define only in debug builds.
      bfffe571
    • Marko Mäkelä's avatar
      MDEV-13476 TRX_UNDO_PAGE_TYPE mismatch when writing undo log after upgrade · 73297f53
      Marko Mäkelä authored
      When undo log pages pre-exist from an upgrade, the
      TRX_UNDO_PAGE_TYPE could be TRX_UNDO_INSERT==1 (for insert_undo)
      TRX_UNDO_UPDATE==2 (for update_undo), instead of the new unified
      page type 0 that was introduced in MDEV-12288.
      
      The undo log page type does not really matter much, because the
      undo log record type identifies the records independently
      of the page type. So, the debug assertions can simply allow any
      potential value of the TRX_UNDO_PAGE_TYPE (0, 1, or 2).
      73297f53
    • Marko Mäkelä's avatar
      MDEV-13475 InnoDB: Failing assertion: lsn == log_sys->lsn ||... · 237f23d7
      Marko Mäkelä authored
      MDEV-13475 InnoDB: Failing assertion: lsn == log_sys->lsn || srv_force_recovery == SRV_FORCE_NO_LOG_REDO
      
      At shutdown, we would have lsn == srv_start_lsn == 0 if the server
      was started up in --innodb-read-only mode with an old-format redo log.
      
      This regression was caused by MDEV-13430, which skips some redo log
      processing at startup when the redo log file format differs (and the
      redo log has been determined to be logically empty).
      
      Even though the MDEV-13430 change was introduced in MariaDB 10.2.8,
      the MariaDB Server 10.2 series is unaffected by this, because
      it will refuse to start up from a version-tagged redo log that is
      not tagged to be in the MySQL 5.7.9 or MariaDB 10.2.2 format.
      Starting with MariaDB 10.3.1, there are multiple version-tagged
      redo log formats.
      
      recv_recovery_from_checkpoint_start(): When skipping an empty
      different-format redo log, initialize srv_start_lsn and
      recv_sys->recovered_lsn from the redo log file.
      237f23d7
    • Oleksandr Byelkin's avatar
      MDEV-13439: Database permissions are not enough to run a subquery with GROUP BY within a view · cb2a57c2
      Oleksandr Byelkin authored
      The bug is result adding ability to have derived tables inside views.
      Fixed checks should be a switch between view/derived or select derived and information schema.
      cb2a57c2
    • Marko Mäkelä's avatar
      MDEV-13481 Merge new release of InnoDB MySQL 5.7.19 to 10.2 · bdab49d3
      Marko Mäkelä authored
      Only a relevant subset of the InnoDB changes was merged.
      In particular, two follow-up bug fixes for the bugs that
      were introduced in 5.7.18 but not MariaDB 10.2.7 were omitted.
      Because MariaDB 10.2.7 omitted the risky change
      
      Bug#23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX
      APPLIED BY UNCOMMITTED ROWS
      
      we do not need the follow-up fixes that were introduced in
      MySQL 5.6.37 and MySQL 5.7.19:
      
      Bug#25175249 ASSERTION: (TEMPL->IS_VIRTUAL && !FIELD) || ...
      Bug#25793677 INNODB: FAILING ASSERTION: CLUST_TEMPL_FOR_SEC || LEN
      bdab49d3
  6. 09 Aug, 2017 10 commits
    • Thirunarayanan Balathandayuthapani's avatar
      Bug #24961167 CONCURRENT INSERT FAILS IF TABLE DOES REBUILD · 38be0beb
      Thirunarayanan Balathandayuthapani authored
      Analysis:
      =========
         During alter table rebuild, InnoDB fails to apply concurrent insert log.
      If the insert log record is present across the blocks then apply phase
      trying to access the next block without fetching it.
      
      Fix:
      ====
      During virtual column parsing, check whether the record is present
      across the blocks before accessing the virtual column information.
      Reviewed-by: default avatarJimmy Yang <jimmy.yang@oracle.com>
      RB: 16243
      38be0beb
    • Thirunarayanan Balathandayuthapani's avatar
      Bug #24960450 CONCURRENT DELETE DOESN'T APPLY DURING TABLE REBUILD · 5721d5ba
      Thirunarayanan Balathandayuthapani authored
      Analysis:
      ========
      During alter table rebuild, InnoDB fails to apply concurrent delete log.
      Parsing and validation of merge record happens while applying the
      log operation on a table. Validation goes wrong for the virtual column.
      Validation assumes that virtual column information can't be the end
      of the merge record end.
      
      Fix:
      ====
      Virtual column information in the merge record can be end of the merge
      record. Virtual column information is written at the end for
      row_log_table_delete().
      
      Reviewed-by: Satya Bodapati<satya.bodapati@oracle.com>
      RB: 16155
      5721d5ba
    • Marko Mäkelä's avatar
      Import a test case from MySQL 5.7.19 · ab2c3185
      Marko Mäkelä authored
      The test is for a bug that was introduced in MySQL 5.7.18
      but not MariaDB 10.2, because MariaDB did not merge the change
      that was considered incomplete and too risky for a GA release:
      
      Bug#23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX
      APPLIED BY UNCOMMITTED ROWS
      
      So, we are only merging the test changes from the bug fix in MySQL 5.7.19,
      not any code changes:
      
      commit 4f86aca37d551cc756d9187ec901f8c4a68a0543
      Author: Thirunarayanan Balathandayuthapani <thirunarayanan.balathandayuth@oracle.com>
      Date:   Wed Apr 26 11:10:41 2017 +0530
      
          Bug #25793677   INNODB: FAILING ASSERTION: CLUST_TEMPL_FOR_SEC || LEN
      ab2c3185
    • Marko Mäkelä's avatar
      Remove dead references to clust_templ_for_sec · f2eaac5d
      Marko Mäkelä authored
      MariaDB 10.2 never contained the Oracle change
      
      Bug#23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE
      INDEX APPLIED BY UNCOMMITTED ROWS
      
      because it was considered risky for a GA release and incomplete.
      Remove the references that were added when merging MySQL 5.6.36
      to MariaDB 10.0.31, 10.1.24, and 10.2.7.
      f2eaac5d
    • Thirunarayanan Balathandayuthapani's avatar
      Bug #25357789 INNODB: LATCH ORDER VIOLATION DURING TRUNCATE TABLE IF INNODB_SYNC_DEBUG ENABLED · 9d57468d
      Thirunarayanan Balathandayuthapani authored
      Analysis:
      ========
      
      (1) During TRUNCATE of file_per_table tablespace, dict_operation_lock is
      released before eviction of dirty pages of a tablespace from the buffer
      pool. After eviction, we try to re-acquire
      dict_operation_lock (higher level latch) but we already hold lower
      level latch (index->lock). This causes latch order violation
      
      (2) Deadlock issue is present if child table is being truncated and it
      holds index lock. At the same time, cascade dml happens and it took
      dict_operation_lock and waiting for index lock.
      
      Fix:
      ====
      1) Release the indexes lock before releasing the dict operation lock.
      
      2) Ignore the cascading dml operation on the parent table, for the
      cascading foreign key, if the child table is truncated or if it is
      in the process of being truncated.
      Reviewed-by: default avatarJimmy Yang <jimmy.yang@oracle.com>
      Reviewed-by: default avatarKevin Lewis <kevin.lewis@oracle.com>
      RB: 16122
      9d57468d
    • Darshan M N's avatar
      BUG#25365223 ERRORLOG UPDATED WITH NOTES INFORMATION WHEN A REF FKEY ISN'T FOUND IN GRSETUP · bf8054b0
      Darshan M N authored
      Issue
      ====
      The issue is that the info message that InnoDB prints when a table
      is created with a reference which doesn't exist fills up the log as
      it's printed for every insert when foreign_key_checks is disabled.
      
      Fix
      ===
      The fix is to display the message only if foreign_key_checks is
      enabled.
      Reviewed-by: default avatarJimmy Yang <jimmy.yang@oracle.com>
      bf8054b0
    • Thirunarayanan Balathandayuthapani's avatar
      Bug #25573565 TABLE REBUILD USES EXCESSIVE MEMORY · 88c391ad
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =======
         Offsets allocates memory from row_heap even for deleted row
      traversal during table rebuild.
      
      Solution:
      =========
        Empty the row_heap even for deleted record. So that
      offsets don't allocate memory everytime.
      Reviewed-by: default avatarJimmy Yang <jimmy.yang@oracle.com>
      RB: 15694
      88c391ad
    • Marko Mäkelä's avatar
      MDEV-12868 MySQL bug #84038 also affects MariaDB 10.2 · a72f34c0
      Marko Mäkelä authored
      Cherry-pick the commit from MySQL 5.7.19, and adapt the test case:
      
      commit 45c933ac19c73a3e9c756a87ee1ba18ba1ac564c
      Author: Aakanksha Verma <aakanksha.verma@oracle.com>
      Date:   Tue Mar 21 10:31:43 2017 +0530
      
          Bug #25189192   ERRORS WHEN RESTARTING MYSQL AFTER RENAME TABLE.
      
          PROBLEM
      
          While renaming table innodb doesn't update the InnoDB Dictionary table
          INNODB_SYS_DATAFILES incase there is change in database while doing
          rename table. Hence on a restart the server log shows error that it
          couldnt find table with old path before rename which has actually been
          renamed. So the errors would only vanish if we update the system
          tablespace
      
          FIX
      
          Update the innodb dictionary table with new path in the case there is
          not a change in the table but the database holding the table as well.
      
          Reviewed-by: Jimmy Yang<Jimmy.Yang@oracle.com>
          RB: 15751
      a72f34c0
    • Oleksandr Byelkin's avatar
      MDEV-13300 Query cache doesn't take in account CLIENT_DEPRECATE_EOF capability · 067ee84d
      Oleksandr Byelkin authored
      take into account new capabilty flag which has influence on result format.
      067ee84d
    • Marko Mäkelä's avatar
      MDEV-13430 InnoDB upgrade from previous versions to 10.3 is not possible · 63ad4fe5
      Marko Mäkelä authored
      Most of this fix was merged from a backport to 10.2.
      
      recv_find_max_checkpoint(): Do not return DB_SUCCESS on an error.
      63ad4fe5