An error occurred fetching the project authors.
  1. 18 Nov, 2004 2 commits
  2. 15 Nov, 2004 1 commit
    • lars@mysql.com's avatar
      BUG#6353 V2: · b7cfe5ec
      lars@mysql.com authored
      Replication using replicate-rewrite-db did not work for LOAD DATA INFILE.
      Now is does.  There was one place in the code that used current database 
      instead of the rewrite database.
      b7cfe5ec
  3. 07 Nov, 2004 1 commit
    • monty@mysql.com's avatar
      Simpler arena swapping code · b903a129
      monty@mysql.com authored
      Now thd->mem_root is a pointer to thd->main_mem_root and THR_MALLOC is a pointer to thd->mem_root.
      This gives us the following benefits:
      - Allow us to easily detect if arena has already been swapped before (this fixes a bug in setup_conds() where arena was swaped twice in some cases)
      - Faster swaps of arenas (as we don't have to copy the whole MEM_ROOT)
      - We don't anymore have to call my_pthread_setspecific_ptr(THR_MALLOC,...) to change where memory is alloced. Now it's enough to set thd->mem_root
      b903a129
  4. 19 Oct, 2004 1 commit
  5. 23 Sep, 2004 1 commit
  6. 07 Sep, 2004 1 commit
  7. 29 Aug, 2004 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#4500 "set character set replicates incorrectly" · 93101561
      guilhem@mysql.com authored
      We must not reset the charset in slave after each statement, otherwise the SET CHARACTER SET is cancelled immediately.
      Instead, we write a SET CHARACTER SET DEFAULT to the master's binlog when needed (like we already do for SET FOREIGN_KEY_CHECKS);
      such writing is not necessary in 4.1 (in 4.1 the bug does not exist, as the SET ONE_SHOT syntax is used).
      I have written a test and it works, but I'm not pushing the test as it requires building with all charsets.
      I have noticed differences between what is inserted in the master's table in 4.0 and 4.1, and alerted Bar.
      93101561
  8. 21 Jul, 2004 1 commit
  9. 20 Jul, 2004 1 commit
    • guilhem@mysql.com's avatar
      Sanja will probably rework this tomorrow; we need to unify the normal · e649dbfc
      guilhem@mysql.com authored
      client code and replication slave code, as far as LOAD DATA INFILE and
      other queries' execution is concerned. Duplication of code leads to
      replication bugs, because the replication duplicate lags much behind.
      Fix for 2 Valgrind errors on slave replicating LOAD DATA INFILE
        - one serious (causing a random test failure in rpl_loaddata in 5.0)
        - one not serious (theoretically a bug but not dangerous): uninited thd->row_count
      e649dbfc
  10. 08 Jul, 2004 1 commit
  11. 30 Jun, 2004 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#4326 "Replicated LOAD DATA INFILE show nothing in · 74809f74
      guilhem@mysql.com authored
      processlist on slave":
      we now report in SHOW PROCESSLIST that we are writing to the temp
      files or loading the table. When we are writing to the tmp file:
      | 3  | system user |                 |    | Connect | 6    | Making temp file /tmp/SQL_LOAD-2-1-2.data | 
      and when we are actually loading the .data temp file into the table:
      | 3  | system user |                 | test | Connect | 2    | | LOAD DATA INFILE '/tmp/SQL_LOAD-2-1-2.data' INTO TABLE `t` <...> |
      74809f74
  12. 08 Jun, 2004 1 commit
    • guilhem@mysql.com's avatar
      Correction to replication of charsets in 4.1: · b514e6a8
      guilhem@mysql.com authored
      In mysqlbinlog, there was a problem with how we escaped the content of a string user variable.
      To be perfect, we should have escaped with character_set_client. But this charset is unknown
      to mysqlbinlog. So the simplest is to print the string in hex. This is unreadable but
      100% safe with any charset (checked with Bar), no more need to bother with character_set_client.
      b514e6a8
  13. 03 Jun, 2004 1 commit
    • guilhem@mysql.com's avatar
      Implementation of WL#1824 "Add replication of character set variables in 4.1", · 86e8ecc9
      guilhem@mysql.com authored
      by binlogging some SET ONE_SHOT CHARACTER_SETetc,
      which will be enough until we have it more compact and more complete in 5.0. With the present patch,
      replication will work ok between 4.1.3 master and slaves, as long as:
      - master and slave have the same GLOBAL.COLLATION_SERVER
      - COLLATION_DATABASE and CHARACTER_SET_DATABASE are not used
      - application does not use the fact that table is created with charset of the USEd db (BUG#2326).
      all of which are not too hard to fulfill. 
      ONE_SHOT is reserved for internal use of mysqlbinlog|mysql and works only for charsets,
      so we give error if used for non-charset vars.
      Fix for BUG#3875 "mysqlbinlog produces wrong ouput  if query uses
       variables containing quotes" and BUG#3943 "Queries with non-ASCII literals are not replicated
       properly after SET NAMES".
      Detecting that master and slave have different global charsets or server ids.
      86e8ecc9
  14. 26 May, 2004 1 commit
  15. 17 May, 2004 1 commit
  16. 14 May, 2004 1 commit
    • heikki@hundin.mysql.fi's avatar
      Many files: · 02f51ccf
      heikki@hundin.mysql.fi authored
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      02f51ccf
  17. 04 May, 2004 1 commit
  18. 07 Apr, 2004 2 commits
  19. 06 Apr, 2004 1 commit
    • guilhem@mysql.com's avatar
      This is a fix for a bug in 3.23 -> 4.0 replication: Exec_master_log_pos is always · b5ffdec2
      guilhem@mysql.com authored
      too big by 6 bytes. So I add code to substract 6 bytes if the master is 3.23.
      This is not perfect (because it won't work if the slave I/O thread has not
      noticed yet that the master is 3.23), but as long as the slave I/O thread
      starts Exec_master_log_pos will be ok.
      It must be merged to 4.1 but not to 5.0 (or it can be, because of #if MYSQL_VERSION_ID),
      because 5.0 already works if the master is 3.23 (and in a more natural way:
      in 5.0 we store the end_log_pos in the binlog and relay log).
      I had to move functions from slave.h to slave.cc to satisfy gcc.
      b5ffdec2
  20. 05 Apr, 2004 1 commit
    • monty@mysql.com's avatar
      Fixed many compiler warnings · 42cf92ce
      monty@mysql.com authored
      Fixed bugs in group_concat with ORDER BY and DISTINCT (Bugs #2695, #3381 and #3319)
      Fixed crash when doing rollback in slave and the io thread catched up with the sql thread
      Set locked_in_memory properly
      42cf92ce
  21. 04 Apr, 2004 1 commit
  22. 12 Mar, 2004 1 commit
  23. 11 Mar, 2004 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#2983 "If statement was killed on master, slave errors despite replicate-wild-ignore-t" · 69517b22
      guilhem@mysql.com authored
      We introduce a new function mysql_test_parse_for_slave().
      If the slave sees that the query got a really bad error on master
      (killed e.g.), then it calls this function to know if this query
      can be ignored because of replicate-*-table rules (do not worry
      about replicate-*-db rules: they are checked so early that they have
      no bug). If the answer is yes, it skips the query and continues. If
      it's no, then it stops and say "fix your slave data manually" (like it
      did before this change).
      69517b22
  24. 10 Mar, 2004 2 commits
  25. 08 Mar, 2004 1 commit
  26. 01 Mar, 2004 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#3015 · bce65d4b
      guilhem@mysql.com authored
      "(binlog, position) stored by InnoDB for a replication slave can be wrong".
      This code contains conditional #if to distinguish between versions;
      it should be merged into 4.1 and 5.0.
      bce65d4b
  27. 29 Feb, 2004 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#3017 · e022ba60
      guilhem@mysql.com authored
      "wrong Relay_Log_Pos if Rotate is in the middle of a transaction in relay log"
      increment 'pending' instead of 'relay_log_pos'.
      e022ba60
  28. 27 Feb, 2004 1 commit
  29. 17 Feb, 2004 1 commit
  30. 16 Feb, 2004 1 commit
    • monty@mysql.com's avatar
      After merge fixes · f43093ec
      monty@mysql.com authored
      Added more DBUG statements
      Ensure that we are comparing end space with BINARY strings
      Use 'any_db' instead of '' to mean any database. (For HANDLER command)
      Only strip ' ' when comparing CHAR, not other space-like characters (like \t)
      f43093ec
  31. 13 Feb, 2004 1 commit
  32. 06 Feb, 2004 1 commit
  33. 28 Jan, 2004 1 commit
  34. 21 Dec, 2003 1 commit
  35. 16 Dec, 2003 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#2083 · db2d812d
      guilhem@mysql.com authored
      "EE_ error codes (EE_DELETE, EE_WRITE) end up in the binlog, making slave stop".
      The problem was that during execution of the command on the master, an error
      can occur (for example, not space left on device, then mysqld waits and when
      there is space it completes successfully: so finally it worked but the error
      EE_WRITE remains in thd->net.last_errno and thd->net.last_error).
      To know if finally the command succeeded, we test the 'error' variable in
      every place, and if it shows no failure we reset thd->net.last_err* using
      the function THD::clear_error() which is backported from 4.1.
      A new test to see if now only real errors get to the binlog (note: the test
      uses "rm").
      
      Also a bit of memory free/alloc saving in log_event.cc (do not free the whole
      mem_root after every query in the slave SQL thread: we can keep the initial
      block of it; which will be freed when the thread terminates).
      db2d812d
  36. 08 Dec, 2003 1 commit
    • guilhem@mysql.com's avatar
      Fix for BUG#2045 "Sending SIGHUP to mysqld crashes it if running with --log-bin". · dba12258
      guilhem@mysql.com authored
      The constructor of Rotate_log_event used when we are rotating our binlog or
      relay log, should not assume that there is a nonzero THD available.
      For example, when we are reacting to SIGHUP, the THD is 0.
      In fact we don't need to use the THD in this constructor;
      we can do like for Stop_log_event, and use the minimal Log_event
      constructor.
      If we were allowed to put Unix-specific commands in the testsuite,
      I'd add a test for this (<sigh>).
      dba12258
  37. 04 Nov, 2003 1 commit