- 14 Jun, 2019 7 commits
-
-
Daniel Black authored
-
Daniel Black authored
By removing Galera functionality, we remove PermissionsStartOnly=true and hence make this service more flexible for running multiple instances each on a different user.
-
Daniel Black authored
When the multi-instance systemd service file was chosen it effectively relied on /etc/my.cnf.d/my{instancename}.cnf file to define its configuration file. This is problematic if running along side a single instance mariadb service which has /etc/my.cnf that reads all configuration file /etc/my.cnf.d/*.cnf. To prevent the service from auto starting up if a user has this previous configuration ConditionPathExists=!@sysconf2dir@/my%I.cnf to ensure that a user with the previous configuration isn't started in a non-intended mode. Documentation in the service file (should be release notes too), described a recommended migration. A new approach was to use --defaults-group-suffix=.%I as an arguement to mysqld and let the user define a [mysqld.{instancename}] group within the configuration file. This way existing global mysqld configuration options are read with the instance name having special overrides of datadir, port, socket etc. A systemd environment variable MYSQLD_MULTI_INSTANCE is used in the defination as it give the user flexability to use multiple segregation mechanisms between services. This is used multiple times within the service which all needed to be kept consistent. Another notable change is mysql_install_db being part of the ExecStartPre. This provides and auto-initialization for users that run multiple instances.
-
Marko Mäkelä authored
On 32-bit systems, sizeof(uint)==sizeof(long). The C++11 narrowing cast would issue a warning due to the sign mismatch.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
If the allocation of spider_table_sts_threads failed, we would DBUG_RETURN(error_num) without having initialized it earlier. Pre-initialize error_num to HA_ERR_OUT_OF_MEM and remove a lot of assignments that thus became redundant. This error was introduced in 207594af (Spider 3.3.13).
-
- 12 Jun, 2019 4 commits
-
-
Kentoku SHIBA authored
-
Marko Mäkelä authored
-
Jan Lindström authored
-
Jan Lindström authored
Remove unneeded select to provider name. Provider can have different names and can be located on different directory on different environments.
-
- 11 Jun, 2019 8 commits
-
-
Vladislav Vaintroub authored
GCC crashes during compilation, on a code fragment that was added to workaround code generation bug on GCC. To fix, I randomly moved pragmas around, which seems to make GCC happy.
-
Sergei Golubchik authored
MDEV-19706 RPM no longer installs init script on systemd systems, but preun script still tries to erase it
-
Sergei Golubchik authored
MDEV-16249 CHECKSUM TABLE for a spider table is not parallel and saves all data in memory in the spider head by default (#1328) followup for be5c432a ha_partition::calculate_checksum() has to invoke calculate_checksum() for partitions unconditionally, not under (HA_HAS_OLD_CHECKSUM | HA_HAS_NEW_CHECKSUM). Because the server uses ::info() to ask for a live checksum, while calculate_checksum() must, precisely, calculate it the slow way, also for tables that don't have the live checksum at all. Also, fix the compilation on Windows (ha_checksum/ulonglong type mix).
-
Marko Mäkelä authored
-
Varun authored
-
Varun authored
Introduced a print_key_value function to makes sure that the trace prints data in readable format for readable characters and the rest of the characters are printed as hexadecimal.
-
Marko Mäkelä authored
-
Vladislav Vaintroub authored
Older GCC generates SSE instruction on not-128-bit-aligned data in Bitmap<128>::buffer Workaround by forcing GCC not to use SSE on Bitmap<N> template.
-
- 10 Jun, 2019 3 commits
-
-
Kentoku SHIBA authored
MDEV-16249 CHECKSUM TABLE for a spider table is not parallel and saves all data in memory in the spider head by default (#1328) add checksum_null for setting null value of checksum
-
Marko Mäkelä authored
Some I/O functions and macros that are declared in os0file.h used to return a Boolean status code (nonzero on success). In MySQL 5.7, they were changed to return dberr_t instead. Alas, in MariaDB Server 10.2, some uses of functions were not adjusted to the changed return value. Until MDEV-19231, the valid values of dberr_t were always nonzero. This means that some code that was incorrectly checking for a zero return value from the functions would never detect a failure. After MDEV-19231, some tests for ALTER ONLINE TABLE would fail with cmake -DPLUGIN_PERFSCHEMA=NO. It turned out that the wrappers pfs_os_file_read_no_error_handling_int_fd_func() and pfs_os_file_write_int_fd_func() were wrongly returning bool instead of dberr_t. Also the callers of these functions were wrongly expecting bool (nonzero on success) instead of dberr_t. This mistake had been made when the addition of these functions was merged from MySQL 5.6.36 and 5.7.18 into MariaDB Server 10.2.7. This fix also reverts commit 40becbc3 which attempted to work around the problem.
-
Otto Kekäläinen authored
-
- 07 Jun, 2019 5 commits
-
-
Sergei Petrunia authored
Make it visible
-
Sergei Golubchik authored
MDEV-18788 Live upgrade from MySQL 5.6/5.7 to MariaDB 10.4 fails with "Event Scheduler: An error occurred when initializing system tables" if columns or indexes are modified/renamed/dropped in an ALTER TABLE, stat tables must be updated accordingly (e.g. all statistics for a column should be dropped). But if a stat table doesn't exist, it's not a reason to fail the whole ALTER TABLE operation - such an error should be ignored.
-
Sergei Golubchik authored
comments, rename a function to reflect its usage better
-
Daniele Sciascia authored
-
- 06 Jun, 2019 6 commits
-
-
Sergei Golubchik authored
option values now have to be edited in-place, instead of replacing an option with another one that has the same name but a new value.
-
Monty authored
-
Monty authored
- --disable-plugin-load or --skip-plugin-load will now reset plugin load list. Needed for future changes to mtr tests
-
Monty authored
- multiple usage of plugin-load-add and optimizer-switch are now included in generated config files
-
Sergey Vojtovich authored
-
Thirunarayanan Balathandayuthapani authored
Problem: ======= fil_iterate() writes imported tablespace page0 as it is to discarded tablespace. Space id wasn't even changed. While opening the tablespace, tablespace fails with space id mismatch error. Fix: ==== fil_iterate() copies the page0 with discarded space id to imported tablespace.
-
- 05 Jun, 2019 4 commits
-
-
Sergei Golubchik authored
-
Zicheng Huang authored
fix MDEV-18750: failed to flashback large-size binlog file fix mysqlbinlog flashback failure caused by reading io_cache without MY_FULL_IO flag fix MDEV-18750: mysqlbinlog flashback failure on large binlog
-
Thirunarayanan Balathandayuthapani authored
- Use corrupt page id instead of whole block after releasing it from LRU list.
-
Sergei Petrunia authored
MDEV-19600: The optimizer should be able to produce rows=1 estimate for unique index with NULLable columns Modify best_access_path() to produce rows=1 estimate for null-rejecting lookups on unique NULL keys.
-
- 04 Jun, 2019 2 commits
-
-
Varun Gupta authored
MDEV-18015: Assertion `global_status_var.global_memory_used == 0' failed when using UDF , window functions and views Adding destructor for Group_bound_tracker to free Cached_item_str. The Cached_item for window functions are allocated on THD:mem_root but the Cached_item_str has value of type string which is allocated on the heap, so we need to call free() for it
-
Vladislav Vaintroub authored
Using different recommended speedup options for WolfSSL. - Enable x64 assembly code on Intel. - in my_crypt.cc, align EVP_CIPHER_CTX buffer, since some members need alignment of 16 (for AESNI instructions), when assembler is enabled. - Adjust MY_AES_CTX_SIZE - Enable fastmath in wolfssl (large integer math).
-
- 03 Jun, 2019 1 commit
-
-
Sergei Golubchik authored
-