1. 14 Jun, 2019 7 commits
    • Daniel Black's avatar
    • Daniel Black's avatar
      systemd: multi-instance not for Galera, User/Group flexible · 91f16948
      Daniel Black authored
      By removing Galera functionality, we remove PermissionsStartOnly=true
      and hence make this service more flexible for running multiple
      instances each on a different user.
      91f16948
    • Daniel Black's avatar
      systemd: multi-instance changes to -defaults-group-suffix=.%I · 3a0a570e
      Daniel Black authored
      When the multi-instance systemd service file was chosen it effectively
      relied on /etc/my.cnf.d/my{instancename}.cnf file to define its
      configuration file. This is problematic if running along side a
      single instance mariadb service which has /etc/my.cnf that reads all
      configuration file /etc/my.cnf.d/*.cnf.
      
      To prevent the service from auto starting up if a user has this
      previous configuration ConditionPathExists=!@sysconf2dir@/my%I.cnf
      to ensure that a user with the previous configuration isn't
      started in a non-intended mode. Documentation in the service file
      (should be release notes too), described a recommended migration.
      
      A new approach was to use --defaults-group-suffix=.%I as an
      arguement to mysqld and let the user define a [mysqld.{instancename}]
      group within the configuration file. This way existing global
      mysqld configuration options are read with the instance name
      having special overrides of datadir, port, socket etc.
      
      A systemd environment variable MYSQLD_MULTI_INSTANCE is used in the
      defination as it give the user flexability to use multiple
      segregation mechanisms between services. This is used multiple
      times within the service which all needed to be kept consistent.
      
      Another notable change is mysql_install_db being part of the
      ExecStartPre. This provides and auto-initialization for users
      that run multiple instances.
      3a0a570e
    • Marko Mäkelä's avatar
      MDEV-6275: Use a non-narrowing conversion · e5fab61a
      Marko Mäkelä authored
      On 32-bit systems, sizeof(uint)==sizeof(long).
      The C++11 narrowing cast would issue a warning due to the sign mismatch.
      e5fab61a
    • Marko Mäkelä's avatar
      MDEV-6275: Fix signed/unsigned comparison · 2cd45add
      Marko Mäkelä authored
      2cd45add
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 991d5140
      Marko Mäkelä authored
      991d5140
    • Marko Mäkelä's avatar
      spider_db_init(): Do not return uninitialized error_num · d9fe615e
      Marko Mäkelä authored
      If the allocation of spider_table_sts_threads failed,
      we would DBUG_RETURN(error_num) without having initialized
      it earlier.
      
      Pre-initialize error_num to HA_ERR_OUT_OF_MEM and remove
      a lot of assignments that thus became redundant.
      
      This error was introduced in 207594af
      (Spider 3.3.13).
      d9fe615e
  2. 12 Jun, 2019 4 commits
  3. 11 Jun, 2019 8 commits
  4. 10 Jun, 2019 3 commits
    • Kentoku SHIBA's avatar
      MDEV-16249 CHECKSUM TABLE for a spider table is not parallel and saves all... · be5c432a
      Kentoku SHIBA authored
      MDEV-16249 CHECKSUM TABLE for a spider table is not parallel and saves all data in memory in the spider head by default (#1328)
      
      add checksum_null for setting null value of checksum
      be5c432a
    • Marko Mäkelä's avatar
      MDEV-19725 Incorrect error handling in ALTER TABLE · cbac8f93
      Marko Mäkelä authored
      Some I/O functions and macros that are declared in os0file.h used to
      return a Boolean status code (nonzero on success). In MySQL 5.7, they
      were changed to return dberr_t instead. Alas, in MariaDB Server 10.2,
      some uses of functions were not adjusted to the changed return value.
      
      Until MDEV-19231, the valid values of dberr_t were always nonzero.
      This means that some code that was incorrectly checking for a zero
      return value from the functions would never detect a failure.
      
      After MDEV-19231, some tests for ALTER ONLINE TABLE would fail with
      cmake -DPLUGIN_PERFSCHEMA=NO. It turned out that the wrappers
      pfs_os_file_read_no_error_handling_int_fd_func() and
      pfs_os_file_write_int_fd_func() were wrongly returning
      bool instead of dberr_t. Also the callers of these functions were
      wrongly expecting bool (nonzero on success) instead of dberr_t.
      
      This mistake had been made when the addition of these functions was
      merged from MySQL 5.6.36 and 5.7.18 into MariaDB Server 10.2.7.
      
      This fix also reverts commit 40becbc3
      which attempted to work around the problem.
      cbac8f93
    • Otto Kekäläinen's avatar
      Deb: Purge unused debconf translations · 5e9090ef
      Otto Kekäläinen authored
      5e9090ef
  5. 07 Jun, 2019 5 commits
  6. 06 Jun, 2019 6 commits
  7. 05 Jun, 2019 4 commits
  8. 04 Jun, 2019 2 commits
    • Varun Gupta's avatar
      MDEV-18015: Assertion `global_status_var.global_memory_used == 0' failed when... · 7906bee6
      Varun Gupta authored
      MDEV-18015: Assertion `global_status_var.global_memory_used == 0' failed when using UDF , window functions and views
      
      Adding destructor for Group_bound_tracker to free Cached_item_str.
      The Cached_item for window functions are allocated on THD:mem_root
      but the Cached_item_str has value of type string which is allocated on
      the heap, so we need to call free() for it
      7906bee6
    • Vladislav Vaintroub's avatar
      MDEV-19684 enable intel assembly (AESNI etc) and fastmath when compiling WolfSSL · c5beac68
      Vladislav Vaintroub authored
      Using different recommended speedup options for WolfSSL.
      
      - Enable  x64 assembly code on Intel.
      - in my_crypt.cc, align EVP_CIPHER_CTX buffer, since some members need
      alignment of 16 (for AESNI instructions), when assembler is enabled.
      - Adjust MY_AES_CTX_SIZE
      - Enable fastmath in wolfssl (large integer math).
      c5beac68
  9. 03 Jun, 2019 1 commit