1. 09 May, 2011 2 commits
    • Serge Kozlov's avatar
      automerge 5.1->5.5 · 724cc400
      Serge Kozlov authored
      724cc400
    • Alexander Nozdrin's avatar
      Patch for Bug#12362125 (SP INOUT HANDLING IS BROKEN FOR TEXT TYPE). · 8f795799
      Alexander Nozdrin authored
      Attempts to assign value to a table column from trigger by using
      NEW.column_name pseudo-variable might result in garbled data.
      That happened when:
        - the column had a BLOB-based type (e.g. TEXT)
          and
        - the value being assigned was retrieved from stored routine variable
          of the same type.
      
      The problem was that BLOB values were not copied correctly in this
      case. Instead of doing a copy of a real value, the value's representation
      in record buffer was copied. This representation is essentially a
      pointer to a buffer associated with the virtual table for routine
      variables where the real value is stored. Since this buffer got
      freed once trigger was left or could have changed its contents when
      new value was assigned to corresponding routine variable such a shallow
      copying resulted in garbled data in NEW.colum_name column.
      
      It worked in 5.1 due to a subtle bug in create_virtual_tmp_table():
        - in 5.1 create_virtual_tmp_table() returned a table which
          had db_low_byte_first == false.
        - in 5.5 and up create_virtual_tmp_table() returns a table which
          has db_low_byte_first == true.
      Actually, db_low_byte_first == false only for ISAM storage engine,
      which was deprecated and removed in 5.0.
      
      Having db_low_byte_first == false led to getting false in the
      complex condition for the 2nd "if" in field_conv(), which in turn
      led to copy-blob-behavior as a fall-back strategy:
        - to->table->s->db_low_byte_first was true (correct value)
        - from->table->s->db_low_byte_first was false (incorrect value)
      
      In 5.5 and up that condition is true, which means blob-values are
      not copied.
      8f795799
  2. 06 May, 2011 6 commits
    • Alexander Nozdrin's avatar
      Patch for Bug#12374486 - SEVERE MEMORY LEAK IN PREPARED STATEMENTS · 32a41e5a
      Alexander Nozdrin authored
      THAT CALL STORED PROCEDURES.
      
      The bug was introduced by WL#4435. The problem was that if a stored
      procedure generated a few result sets with different set of columns,
      a new memory would be allocated after every EXECUTE for every
      result set.
      
      The fix is to introduce a new memory root in scope of MYSQL_STMT,
      and to store result-set metadata in that memory root.
      32a41e5a
    • Alexander Nozdrin's avatar
      Patch for Bug#11848763 / 60025 · acbe8238
      Alexander Nozdrin authored
      (SUBSTRING inside a stored function works too slow).
      
      The user-visible problem was that the server started to consume memory if a
      stored-routine of some sort is executed subsequently. The memory was freed
      only after the corresponding connection was closed.
      
      Technically, the problem was that the memory needed for temporary string
      conversions was allocated on the connection ("persistent") memory root,
      instead of statement one.
      
      The root cause of this problem was the incorrect patch for Bug 55744.
      That patch wrongly fixed a crash in prepared-statement-mode introduced by
      another patch. The patch for Bug 55744 used wrong condition to check if
      prepared statement mode is active (or whether the connection-scoped or
      statement-scoped memory root should be used). The thing is that for
      prepared statements such conversions should be done in the connection
      memory root, so that that the transformations of item-tree were correctly
      remembered in the PREPARE-phase.
      
      The fix is to use proper condition to detect prepared-statement-mode and
      use proper memory root.
      acbe8238
    • Alexander Nozdrin's avatar
      Preliminary patch for Bug#11848763 / 60025 · 52efe3e0
      Alexander Nozdrin authored
      (SUBSTRING inside a stored function works too slow).
      
      Background:
        - THD classes derives from Query_arena, thus inherits the 'state'
          attribute and related operations (is_stmt_prepare() & co).
      
        - Although these operations are available in THD, they must not
          be used. THD has its own attribute to point to the active
          Query_arena -- stmt_arena.
      
        - So, instead of using thd->is_stmt_prepare(),
          thd->stmt_arena->is_stmt_prepare() must be used. This was the root
          cause of Bug 60025.
      
      This patch enforces the proper way of calling those operations.
      is_stmt_prepare() & co are declared as private operations
      in THD (thus, they are hidden from being called on THD instance).
      
      The patch tries to minimize changes in 5.5.
      52efe3e0
    • Magnus Blåudd's avatar
      Add --with-debug=full support to BUILD/* scripts, this option has been lost · 167d2896
      Magnus Blåudd authored
      between 5.1 and 5.5, it's purpose is to set the compiler flags in a way that
      does not optimize away the call stack(i.e don't use any -OX flags at all)
      167d2896
    • Magnus Blåudd's avatar
      Merge in patch for bug 12380149 · 5b141170
      Magnus Blåudd authored
      5b141170
    • unknown's avatar
      Merge from mysql-5.5.12-release · db4c6f56
      unknown authored
      db4c6f56
  3. 05 May, 2011 6 commits
    • Luis Soares's avatar
      BUG#12354268 · 6875f4df
      Luis Soares authored
      Automerge from mysql-5.1 into mysql-5.5.
      6875f4df
    • Luis Soares's avatar
      BUG#12354268 · 902e64da
      Luis Soares authored
      Automerged bzr bundle from bug report:
      luis.soares@oracle.com-20110505224815-6ob90n7suxsoizvs.bundle
      902e64da
    • Luis Soares's avatar
      BUG#11762616: BUG#55229: 'POSTION' · a85150c3
      Luis Soares authored
      Manual merge from mysql-5.1 into mysql-5.5.
      
      Conflicts
      =========
      Text conflict in mysql-test/suite/rpl/t/rpl_row_until.test
      Text conflict in sql/handler.h
      Text conflict in storage/archive/ha_archive.cc
      a85150c3
    • Luis Soares's avatar
      BUG#11762616: BUG#55229: 'POSTION' · 8a08fd43
      Luis Soares authored
                  
      Fix for all "postion" in Oracle files (s/postion/position). 
      Updated the copyright notices where needed.
      8a08fd43
    • Luis Soares's avatar
      BUG#12425924 · f2fa3015
      Luis Soares authored
      Automerging cset into latest mysql-5.5.
      f2fa3015
    • Luis Soares's avatar
      BUG#12354268: MYSQLBINLOG --BASE64-OUTPUT=DECODE-ROWS DOES NOT · 0efb452e
      Luis Soares authored
      WORK WITH --START-POSITION
            
      If setting --start-position to start after the FD event, mysqlbinlog
      will output an error stating that it has not found an FD event.
      However, its not that mysqlbinlog does not find it but rather that it
      does not processes it in the regular way (i.e., it does not print it).
      Given that one is using --base64-output=DECODE-ROWS then not printing
      it is actually fine.
            
      To fix this, we make mysqlbinlog not to complain when it has not
      printed the FD event, is outputing in base64, but is decoding the
      rows.
      0efb452e
  4. 04 May, 2011 5 commits
    • Luis Soares's avatar
      BUG#12425924: SEMI-SYNC RELATED VALGRIND WARNINGS IN 5.5 CODEBASE · df07595d
      Luis Soares authored
      There are a couple of valgrind warnings in 5.5 codebase, that
      do not exist in 5.6. The root cause was found and fixed in 5.6
      codebase before (BUG#11763880 and BUG#11763879), but the patches
      were only pushed to 5.6.
      
      To fix it in 5.5, we cherrypicked the csets from 5.6 and merged 
      them in 5.5.
      df07595d
    • Alexander Nozdrin's avatar
      Manual merge from mysql-5.1. · e7dc2b0a
      Alexander Nozdrin authored
      e7dc2b0a
    • Luis Soares's avatar
      Automerged (cherrypicked) cset from 5.6: · 7d719a9c
      Luis Soares authored
      zhenxing.he@sun.com-20101117085902-n9gfvlkmm44t38y0
        
      This takes care of valgrind warnings in 5.5 that exhibit
      the same trace as in BUG#11763879 (BUG#56649).
      7d719a9c
    • Luis Soares's avatar
      Automerged (cherrypicked) cset from 5.6: · 843f3816
      Luis Soares authored
      zhenxing.he@sun.com-20101202073812-iel8lvhmulyagtsv
      
      This takes care of valgrind warnings in 5.5 that exhibit
      the same trace as in BUG#11763880 (BUG#56650).
      843f3816
    • Alexander Nozdrin's avatar
      Patch for Bug#12394306: the sever may crash if mysql.event is corrupted. · 16f26d2a
      Alexander Nozdrin authored
      The problem was that wrong structure of mysql.event was not detected and
      the server continued to use wrongly-structured data.
      
      The fix is to check the structure of mysql.event after opening before
      any use. That makes operations with events more strict -- some operations
      that might work before throw errors now. That seems to be Ok.
      
      Another side-effect of the patch is that if mysql.event is corrupted,
      unrelated DROP DATABASE statements issue an SQL warning about inability
      to open mysql.event table. 
      16f26d2a
  5. 03 May, 2011 2 commits
  6. 02 May, 2011 5 commits
  7. 30 Apr, 2011 1 commit
  8. 29 Apr, 2011 13 commits