1. 22 Mar, 2011 1 commit
    • Marko Mäkelä's avatar
      Bug#11766305 - 59392: Remove thr0loc.c and ibuf_inside() [part 3] · 76ec2da6
      Marko Mäkelä authored
      Remove the slot_no member of struct thr_local_struct.
      
      enum srv_thread_type: Remove unused thread types.
      srv_get_thread_type(): Unused function, remove.
      
      thr_local_get_slot_no(), thr_local_set_slot_no(): Remove.
      
      srv_thread_type_validate(), srv_slot_get_type(): New functions, for debugging.
      
      srv_table_reserve_slot(): Return the srv_slot_t* directly. Do not create
      thread-local storage.
      
      srv_suspend_thread(): Get the srv_slot_t* as parameter. Return void;
      the caller knows slot->event already.
      
      srv_thread_has_reserved_slot(), srv_release_threads(): Assert
      srv_thread_type_validate(type).
      
      srv_init(): Use mem_zalloc() instead of mem_alloc(). Replace
      srv_table_get_nth_slot(), because it now asserts that the kernel_mutex
      is being held.
      
      srv_master_thread(), srv_purge_thread(): Remember the slot from
      srv_table_reserve_slot().
      
      rb:629 approved by Inaam Rana
      76ec2da6
  2. 21 Mar, 2011 2 commits
    • Marko Mäkelä's avatar
      Bug#11766305 - 59392: Remove thr0loc.c and ibuf_inside() [part 2] · 72ec03c2
      Marko Mäkelä authored
      Add some const qualifiers to accessor and validator functions.
      
      btr_pcur_get_up_match(), btr_pcur_get_low_match(): Add const qualifiers.
      
      btr_pcur_get_page(), btr_pcur_get_block(), btr_pcur_get_rec(),
      rec_get_start(), rec_get_end(): Define as constness-preserving macros.
      In debug builds, discard the const qualifier.
      
      page_rec_validate(), page_simple_validate_old(), page_simple_validate_new(),
      page_dir_slot_check(), page_validate(): Add const qualifiers.
      
      rb:626 approved by Sunny Bains
      72ec03c2
    • Marko Mäkelä's avatar
      Bug#11766305 - 59392: Remove thr0loc.c and ibuf_inside() [part 1] · 30a28cfb
      Marko Mäkelä authored
      Remove unused member mtr from btr_pcur_struct.
      
      rb:624 approved by Sunny Bains
      30a28cfb
  3. 15 Mar, 2011 3 commits
  4. 09 Mar, 2011 1 commit
  5. 08 Mar, 2011 1 commit
  6. 07 Mar, 2011 1 commit
    • kevin.lewis@oracle.com's avatar
      Bug#60196 / Bug#11831040 · d072bb0d
      kevin.lewis@oracle.com authored
      Setting lowercase_table_names to 2 on Windows causing Foreign Key problems
      
      This problem was exposed by the fix for Bug#55222.  There was a codepath in dict0load.c,
      dict_load_foreigns() that made sure the table name matched case sensitive in order to
      load a referenced table into the dictionary as needed.  If an engine is rebooted which
      accesses a table with foreign keys, and lower_case_table_names=2, then the table with
      foreign keys will get an error when it is changed (insert/updated/delete).
      Once the referenced tables are loaded into the dictionary cache by a select statement
      on those tables, the same change would succeed because the affected code path would
      not get followed.
      d072bb0d
  7. 02 Mar, 2011 3 commits
  8. 01 Mar, 2011 8 commits
    • Vinay Fisrekar's avatar
      merge from mysql-5.1 -> mysql-5.5 · 1ae395d8
      Vinay Fisrekar authored
      1ae395d8
    • Vinay Fisrekar's avatar
      Bug#11766165 - 59211: SELECT RETURNS DIFFERENT VALUE FOR MIN(YEAR) FUNCTION · c9e9dede
      Vinay Fisrekar authored
      Result File Correction For Bug Fix
      c9e9dede
    • Alexander Barkov's avatar
      Merging from mysql-5.1 · e7ff0df0
      Alexander Barkov authored
      e7ff0df0
    • Magne Mahre's avatar
      Post-push cleanup, for Bug#11763065 et al. · 5a1314a8
      Magne Mahre authored
      5a1314a8
    • Alexander Barkov's avatar
      Bug#11766725 (Bug#59901) EXTRACTVALUE STILL BROKEN AFTER FIX FOR BUG #44332 · bb7f40a1
      Alexander Barkov authored
      Problem: a byte behind the end of input string was read
      in case of a broken XML not having a quote or doublequote
      character closing a string value.
      
      Fix: changing condition not to read behind the end of input string
      
        @ mysql-test/r/xml.result
        @ mysql-test/t/xml.test
        Adding tests
      
        @ strings/xml.c
        When checking if the closing quote/doublequote was found,
        using p->cur[0] us unsafe, as p->cur can point to the byte after the value.
        Comparing p->cur to p->beg instead.
      bb7f40a1
    • Alexander Barkov's avatar
      Bug#11753363 (bug#44793) CHARACTER SETS: CASE CLAUSE, UCS2 OR UTF32, FAILURE · 8a83d304
      Alexander Barkov authored
      Problem: in case of string CASE/WHEN arguments with different
      character sets, Item_func_case::find_item() called comparator
      cmp_items[x] on mixed character set Items, so a 8-bit value could
      be errouneously referenced to as being utf16/utf32 value,
      which led to crash on DBUG_ASSERT() because of wrong value length.
      This was wrong, as string comparator expects arguments in the same
      character set.
      
      Fix: modify Item_func_case's argument list after calling
      agg_arg_charsets_for_comparison() - put the Items in "agg" array
      back to "args", because some of the Items in the "agg" array might
      have been changed to character set converters:
      - to Item_func_conv_charset for non-constant items
      - to Item_string for constant items
      
      In other words, perform the same substitution which is done in
      all other operations string comparison or string result operations:
      
      Replace
        CASE         latin1_item              WHEN utf16_item THEN ... END
      to
        CASE CONVERT(latin1_item USING utf16) WHEN utf16_item THEN ... END
      
      Replace
        CASE utf16_item WHEN         latin1_item              THEN ... END
      to
        CASE utf16_item WHEN CONVERT(latin1_item USING utf16) THEN ... END
      
      
        @ mysql-test/r/ctype_utf16.result
        @ mysql-test/r/ctype_utf32.result
        @ mysql-test/t/ctype_utf16.test
        @ mysql-test/t/ctype_utf32.test
        Adding tests
      
        @ sql/item_cmpfunc.cc
        Put "agg" back to "args".
      
        @ sql/sql_string.cc
        Backporting a fix for String::set_or_copy_aligned() from 5.6,
        for better test coverage:
        "SELECT _utf16 0x61" should expand the string to 0x0061 rather
        than to 0x000061.
        This fix was made in 5.6 under terms of "WL#4616 Implement UTF16-LE".
      8a83d304
    • Magne Mahre's avatar
      Bug#11765237 - 58179: CANNOT START MYSQLD WITH APP VERIFIER · 48126a57
      Magne Mahre authored
      Bug#11763065 - 55730: KILL_SERVER() CALLS SETEVENT ON A NULL 
                     HANDLE, SMEM_EVENT_CONNECT_REQUEST
            
      Application Verifier is a Microsoft tool used for
      detecting certain classes of programming errors.
      In particular, MS Windows OS resource usage is
      monitored for wrong usage (handles, thread local
      storage, critical sections, ...)
            
      In MySQL 5.5.x, an error was introduced where an
      object on thread local storage was used before the
      TLS and the object was created.
            
      The fix has been to move the mysys initialization
      to an earlier stage in the boot process when built for
      Windows.  For non-win builds, the init already happens
      early.
      
      Some un-tangling of calls to my_init(), my_basic_init()
      and my_thread_global_init() was done.  There is no
      longer a need to do init in steps, so the full my_init()
      is called instead of my_init_basic().
            
      In addition,  Bug#11763065 was fixed.  The event handle
      'smem_event_connect_request' is only created if
      'opt_enable_shared_memory' is set.  When killing the
      server, an event was flagged on the handle
      unconditionally.  Added a test, so it will only be
      flagged if created.
      48126a57
    • Dmitry Lenev's avatar
      Fix for bug #11765505 - "58480: LARGE_TESTS.LOCK_TABLES_BIG · 626b835f
      Dmitry Lenev authored
      IS FAILING".
      
      The problem was that large_tests.lock_tables_big test was
      failing due to exceeding open files limit on platforms where
      this limit was set too low (this test simultaneously opens
      approx. 6000 files).
      
      This patch solves this issue by ensuring that this test is
      skipped on such platforms.
      626b835f
  9. 28 Feb, 2011 5 commits
  10. 27 Feb, 2011 1 commit
  11. 25 Feb, 2011 4 commits
  12. 24 Feb, 2011 1 commit
  13. 23 Feb, 2011 6 commits
  14. 22 Feb, 2011 3 commits