1. 29 May, 2007 1 commit
  2. 23 May, 2007 1 commit
    • unknown's avatar
      Bug #28250: Run-Time Check Failure #3 - The variable 'value' is · 8998080a
      unknown authored
      being used without being def
      
      Inside method Item_func_unsigned::val_int, the variable value 
      can be returned without being initialized when the CAST argument
      is of type DECIMAL and has a NULL value. This gives a run-time 
      error when building debug binaries using Visual C++ 2005.
      
      Solution: Initialize value to 0
      
      
      mysql-test/t/cast.test:
        bug#28250: There is no need for an extra test case, but we
        recognize that this one catches the bug.
      sql/item_func.cc:
        bug#28250: initialization of value.
      8998080a
  3. 17 May, 2007 2 commits
  4. 16 May, 2007 4 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · d200346e
      unknown authored
      into  mysql.com:/home/hf/work/8663/my51-8663
      
      
      d200346e
    • unknown's avatar
      Merge mysql.com:/home/hf/work/8663/my50-8663 · f7efc636
      unknown authored
      into  mysql.com:/home/hf/work/8663/my51-8663
      
      
      strings/decimal.c:
        Auto merged
      mysql-test/r/bigint.result:
        SCCS merged
      mysql-test/t/bigint.test:
        merging
      f7efc636
    • unknown's avatar
      valgrind error fix · b6be8fd0
      unknown authored
      b6be8fd0
    • unknown's avatar
      bug #8663 cant use bigint unsigned as input to cast · 1e33cfb3
      unknown authored
      in the case of the overflow in the decimal->integer conversion
      we didn't return the proper boundary value, but just the result
      of the conversion we calculated on the moment of the error
      
      
      mysql-test/r/bigint.result:
        bug #8663 cant use bigint unsigned as input to cast
        test result fixed
      mysql-test/t/bigint.test:
        bug #8663 cant use bigint unsigned as input to cast
        test case
      strings/decimal.c:
        bug #8663 cant use bigint unsigned as input to cast
        decimal->int conversion fixed to return proper boundary value
        in the case of overflow
      1e33cfb3
  5. 15 May, 2007 1 commit
  6. 12 May, 2007 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · ac811bf0
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      sql/field.cc:
        Auto merged
      ac811bf0
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 6fa4fdd2
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      mysql-test/r/subselect3.result:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      6fa4fdd2
    • unknown's avatar
      Post-merge fix · c749664d
      unknown authored
      c749664d
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 42cc0e87
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      mysql-test/t/grant.test:
        Auto merged
      mysql-test/r/grant.result:
        Manual merge
      42cc0e87
    • unknown's avatar
      Fixed bug #28375: a query with an NOT IN subquery predicate may cause · d886ea8f
      unknown authored
      a crash when the left operand of the predicate is evaluated to NULL.
      It happens when the rows from the inner tables (tables from the subquery)
      are accessed by index methods with key values obtained by evaluation of
      the left operand of the subquery predicate. When this predicate is
      evaluated to NULL an alternative access with full table scan is used
      to check whether the result set returned by the subquery is empty or not.
      The crash was due to the fact the info about the access methods used for
      regular key values was not properly restored after a switch back from the
      full scan access method had occurred.
      The patch restores this info properly.
      The same problem existed for queries with IN subquery predicates if they
      were used not at the top level of the queries.
      
      
      mysql-test/r/subselect3.result:
        Added a test case for bug #28375.
      mysql-test/t/subselect3.test:
        Added a test case for bug #28375.
      sql/item_subselect.cc:
        Fixed bug #28375: a query with an NOT IN subquery predicate may cause
        a crash when the left operand of the predicate is evaluated to NULL.
        It happens when the rows from the inner tables (tables from the subquery)
        are accessed by index methods with key values obtained by evaluation of
        the left operand of the subquery predicate. When this predicate is
        evaluated to NULL an alternative access with full table scan is used
        to check whether the result set returned by the subquery is empty or not.
        The crash was due to the fact the info about the access methods used for
        regular key values was not properly restored after a switch back from the
        full scan access method had occurred.
        The patch restores this info properly.
      sql/sql_select.h:
        Fixed bug #28375: a query with an NOT IN subquery predicate may cause
        a crash when the left operand of the predicate is evaluated to NULL.
        In the JOIN_TAB structure two fields have been added to save info about
        index methods used to access the subquery rows. The saved info is used
        after a switch back from the alternative full scan access method has 
        occurred. The full scan is used when the left operand of the subquery
        predicate is evaluated to NULL.
      d886ea8f
  7. 11 May, 2007 20 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 50c5b549
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27878-bug-5.0-opt-mysql
      
      
      50c5b549
    • unknown's avatar
      grant.result, grant.test: · f0ddabc5
      unknown authored
        Corrected test case for the bug#27878.
      
      
      mysql-test/t/grant.test:
        Corrected test case for the bug#27878.
      mysql-test/r/grant.result:
        Corrected test case for the bug#27878.
      f0ddabc5
    • unknown's avatar
      merging fix · c9f09703
      unknown authored
      c9f09703
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · 2e3baa68
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/t/grant.test:
        Auto merged
      mysql-test/r/grant.result:
        merging
      sql/sql_update.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      2e3baa68
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · bd311c0c
      unknown authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      
      
      bd311c0c
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 86dccd92
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27878-bug-5.0-opt-mysql
      
      
      86dccd92
    • unknown's avatar
      Bug#27878: Unchecked privileges on a view referring to a table from another · 04efdb15
      unknown authored
      database.
      
      If a user has a right to update anything in the current database then the 
      access was granted and further checks of access rights for underlying tables
      wasn't done correctly. The check is done before a view is opened and thus no
      check of access rights for underlying tables can be carried out.
      This allows a user to update through a view a table from another database for
      which he hasn't enough rights.
      
      Now the mysql_update() and the mysql_test_update() functions are forces
      re-checking of access rights after a view is opened.
      
      
      mysql-test/t/grant.test:
        Added a test case for the bug#27878: Unchecked privileges on a view referring to a table from another database.
      mysql-test/r/grant.result:
        Added a test case for the bug#27878: Unchecked privileges on a view referring to a table from another database.
      sql/sql_update.cc:
        Bug#27878: Unchecked privileges on a view referring to a table from another 
        database.
        Now the mysql_update() function forces re-checking of access rights after 
        the view is opened.
      sql/sql_prepare.cc:
        Bug#27878: Unchecked privileges on a view referring to a table from another 
        database.
        Now the mysql_test_update() function forces re-checking of access rights after
        the view is opened.
      04efdb15
    • unknown's avatar
      merging fixes · ee7677d1
      unknown authored
      
      mysql-test/r/insert_update.result:
        result fixed
      mysql-test/r/type_newdecimal.result:
        result fixed
      ee7677d1
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · e7c2cbe9
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      sql/item_func.cc:
        Auto merged
      mysql-test/r/type_datetime.result:
        merging
      mysql-test/t/type_datetime.test:
        merging
      sql/my_decimal.h:
        merging
      e7c2cbe9
    • unknown's avatar
      merging fixes · 8bbe6f23
      unknown authored
      
      mysql-test/r/type_datetime.result:
        result fixed
      mysql-test/t/type_datetime.test:
        testcase fixed
      sql/item_func.cc:
        my_decimal_length_to_precision used
      sql/my_decimal.h:
        merging fix
      8bbe6f23
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my51-27921 · e5683f7b
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      sql/item_create.cc:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      e5683f7b
    • unknown's avatar
      merging fixes · d4b87344
      unknown authored
      
      mysql-test/t/view.test:
        merging fix
      sql/item_create.cc:
        merging fix
      sql/my_decimal.cc:
        merging fix
      sql/my_decimal.h:
        merging fix
      d4b87344
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · 5f41b262
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/r/cast.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/my_decimal.h:
        merging
      5f41b262
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my51-27921 · 3f28924e
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/r/cast.result:
        Auto merged
      sql/item_create.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      3f28924e
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my50-27921 · 78ed69c3
      unknown authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      
      
      mysql-test/r/cast.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/my_decimal.h:
        merging
      78ed69c3
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · 62db8d6d
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        merging
      mysql-test/r/innodb_mysql.result:
        SCCS merged
      sql/sql_select.cc:
        merging
      62db8d6d
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · f4ded1f2
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      sql/item_func.cc:
        Auto merged
      f4ded1f2
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 563b1297
      unknown authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      
      
      sql/item_func.cc:
        Auto merged
      563b1297
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27957/my50-27957 · 61b947c3
      unknown authored
      into  mysql.com:/home/hf/work/27957/my51-27957
      
      
      include/decimal.h:
        Auto merged
      mysql-test/r/type_newdecimal.result:
        Auto merged
      mysql-test/t/type_newdecimal.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      strings/decimal.c:
        Auto merged
      mysql-test/r/cast.result:
        merging
      sql/my_decimal.h:
        merging
      61b947c3
    • unknown's avatar
      Merge mysql.com:/home/hf/work/27921/my50-27921 · 812a6ee7
      unknown authored
      into  mysql.com:/home/hf/work/27921/my51-27921
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_create.h:
        merging
      sql/my_decimal.h:
        merging
      sql/sql_yacc.yy:
        merging
      812a6ee7
  8. 10 May, 2007 6 commits
    • unknown's avatar
      Fixed bug #28000. · 36190568
      unknown authored
      Bug occurs in INSERT IGNORE ... SELECT ... ON DUPLICATE KEY UPDATE
      statements, when SELECT returns duplicated values and UPDATE clause
      tries to assign NULL values to NOT NULL fields.
      NOTE: By current design MySQL server treats INSERT IGNORE ... ON
      DUPLICATE statements as INSERT ... ON DUPLICATE with update of
      duplicated records, but MySQL manual lacks this information.
      After this fix such behaviour becomes legalized.
      
      The write_record() function was returning error values even within
      INSERT IGNORE, because ignore_errors parameter of
      the fill_record_n_invoke_before_triggers() function call was
      always set to FALSE. FALSE is replaced by info->ignore.
      
      
      sql/sql_insert.cc:
        Fixed bug #28000:
        The write_record() function was returning error values even within
        INSERT IGNORE, because ignore_errors parameter of
        the fill_record_n_invoke_before_triggers() function call was
        always set to FALSE. FALSE is replaced by info->ignore.
      mysql-test/t/insert_update.test:
        Added test case for bug #28000.
      mysql-test/r/insert_update.result:
        Added test case for bug #28000.
      36190568
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb · 4d7824e3
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-single-user
      
      
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      4d7824e3
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-4.1-ndb · 28d9a827
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      28d9a827
    • unknown's avatar
      bigint.test made ps-protocol consistent · f1dbb95b
      unknown authored
      
      mysql-test/r/bigint.result:
        test result fixed
      mysql-test/t/bigint.test:
        testcase made ps-protocol consistent
      f1dbb95b
    • unknown's avatar
      Fixed bug #28189: in some rare cases optimizer preferred a more expensive · 184cc3b5
      unknown authored
      ref access to a less expensive range access. 
      This occurred only with InnoDB tables.
      
      
      mysql-test/r/innodb_mysql.result:
        Added a test case for bug #28189.
      mysql-test/t/innodb_mysql.test:
        Added a test case for bug #28189.
      184cc3b5
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 47430268
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-4.1-ndb
      
      
      47430268