- 15 Aug, 2013 1 commit
-
-
Igor Babaev authored
-
- 13 Aug, 2013 1 commit
-
-
Igor Babaev authored
This a an old legacy performance bug. When a very selective range scan existed for the second table in a join, and, at the same time, there was another range condition depending on the fields of the first table, the optimizer chose a plan with 'Range checked for each record'. This plan was extremely inefficient in comparison with the regular selective range scan. As a matter of fact the range scan chosen for each record was the same as that selective range scan. Changed the test case for bug 24776 to preserve the old output for explain.
-
- 01 Aug, 2013 1 commit
-
-
unknown authored
MDEV-4823: Server crashes in Item_func_not::fix_fields on creating a table with a virtual column using NOT fix_field() call protocol was brocken (zero pointer passed as link to item which is possible only if you are sure that there can not be Items which transforms).
-
- 21 Jul, 2013 1 commit
-
-
Alexey Botchkov authored
not_enough_points() introduced to check if the spatial object is incorrect.
-
- 09 Jul, 2013 2 commits
-
-
Vladislav Vaintroub authored
MDEV-4409 - Fix deadlock in MySQL key cache code, that can happen if there is a key cache resize running in parallel with an update. If there is a key cache resize,a thread writing to key cache, will pause waiting until resize finishes. However this thread is won't be woken, because resize does not signaling waiters anymore. This is a regression introduced in WL#86(segmented MyISAM key cache) The fix is to unconditionally release threads waiting on resize_queue when resize finishes, as in pre-WL#86 code.
-
Alexander Barkov authored
modified: mysql-test/suite/plugins/r/fulltext_plugin.result mysql-test/suite/plugins/t/fulltext_plugin.test plugin/fulltext/plugin_example.c sql/sql_show.cc pending merges: Sergei Golubchik 2013-07-06 Bug #69682 - mysqld crashes after uninstall ... Sergei Golubchik 2013-05-24 MDEV-4575 MySQL client doesn't strip off...
-
- 06 Jul, 2013 1 commit
-
-
Sergei Golubchik authored
-
- 24 May, 2013 1 commit
-
-
Sergei Golubchik authored
extend 5.1 client library to read 4 byte capabilities from the first handshake packet. two higher bytes are always zeros for 5.1 servers.
-
- 20 May, 2013 1 commit
-
-
Sergei Golubchik authored
-
- 19 May, 2013 2 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
- 11 May, 2013 3 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
MDEV-4280: Assertion `empty_size == empty_size_on_page' failure in ma_blockrec.c or ER_NOT_KEYFILE on query with DISTINCT and GROUP BY This could happen when using Aria for internal temporary files (default case) and using DISTINCT. _ma_scan_restore_block_record() didn't work correctly if there was rows inserted, updated or deleted on the handler between calls to _ma_scan_remember_block_record() and _ma_scan_restore_block_record(). The effect was that some DISTINCT queries that used remove_dup_with_compare() could fail. .bzrignore: Ignore sql_yacc.hh mysql-test/suite/maria/r/distinct.result: Test case for MDEV-4280 mysql-test/suite/maria/t/distinct.test: Test case for MDEV-4280 mysql-test/t/mysql.test: Fixed test suite (we could get error -1 in some cases) sql/sql_select.cc: Break loop if restart_rnd_next() gives an error storage/maria/ha_maria.cc: scan_restore_pos() can return disk fault error. storage/maria/ma_blockrec.c: _ma_scan_remember_block_record() did incorrectly update scan.dir instead of scan_save.dir . _ma_scan_restore_block_record() didn't work correctly if there was rows inserted,updated or deleted on the handler between calls to _ma_scan_remember_block_record() and _ma_scan_restore_block_record(). Fixed by adding counters for row changes and reading the current scan page if changes had been made. storage/maria/ma_blockrec.h: scan_restore_pos() can return disk fault error. storage/maria/ma_delete.c: Increment row_changes storage/maria/ma_scan.c: scan_restore_pos() can return disk fault error. storage/maria/ma_update.c: Increment row_changes storage/maria/ma_write.c: Increment row_changes storage/maria/maria_def.h: scan_restore_pos() can return disk fault error.
-
- 08 May, 2013 1 commit
-
-
Sergei Golubchik authored
avoid divison by zero
-
- 11 Apr, 2013 1 commit
-
-
Sergei Golubchik authored
-
- 09 Apr, 2013 1 commit
-
-
unknown authored
Removed "optimization" which caused preoblems on second execution of PS with string parameter in LIMIT clause. Fixed test_bug43560 to be able to skipp it if connection is UNIX socket.
-
- 06 Apr, 2013 1 commit
-
-
Sergei Golubchik authored
fixes for gcc 4.8 - compilation warnings and -fsanitize=address
-
- 04 Apr, 2013 1 commit
-
-
Sergei Golubchik authored
update 5.1 to replicate from 10.0 and to show the server version (as of 10.0) correctly sql-common/client.c: mdev:4088 sql/slave.cc: use the version number, not just the first character of the version string (we want 10 > 4 not "10" < "4").
-
- 26 Mar, 2013 1 commit
-
-
Sergei Golubchik authored
-
- 20 Mar, 2013 1 commit
-
-
Sergei Golubchik authored
./mtr --suite=main,plugins will work on all branches.
-
- 19 Mar, 2013 2 commits
-
-
Alexey Botchkov authored
Need to check if the number of points is 0 for the polygon.
-
Alexey Botchkov authored
Forgotten DBUG_ASSERT should be replaced with the 'return error'.
-
- 18 Mar, 2013 3 commits
-
-
unknown authored
Item_default_value inherited form Item_field so should create temporary table field similary.
-
Alexey Botchkov authored
Additional fixes for possible overflows in length-related calculations in 'spatial' implementations. Checks added to the ::get_data_size() methods. max_n_points decreased to occupy less 2G size. An object of that size is practically inoperable anyway.
-
Sergei Golubchik authored
Item_func_make_set wasn't taking into account the first argument when calculating maybe_null. sql/item_strfunc.cc: rewrite Item_func_make_set, removing separate storage of the first argument sql/item_strfunc.h: rewrite Item_func_make_set, removing separate storage of the first argument
-
- 10 Mar, 2013 1 commit
-
-
Alexey Botchkov authored
The bug was found by Alyssa Milburn. If the number of points of a geometry feature read from binary representation is greater than 0x10000000, then the (uint32) (num_points * 16) will cut the higher byte, which leads to various errors. Fixed by additional check if (num_points > max_n_points).
-
- 28 Feb, 2013 4 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MySQL Bug #12408412: GROUP_CONCAT + ORDER BY + INPUT/OUTPUT SAME USER VARIABLE = CRASH and MySQL Bug#14664077 SEVERE PERFORMANCE DEGRADATION IN SOME CASES WHEN USER VARIABLES ARE USED sql/item_func.cc: don't use anything from Item_func_set_user_var::fix_fields() in Item_func_set_user_var::save_item_result() sql/sql_class.cc: Call suv->save_item_result(item) *before* doing suv->fix_fields(), because the former evaluates the item (and caches its value), while the latter marks the user variable as non-const. The problem is that the item was fix_field'ed when the user variable was const, and it doesn't expect it to change to non-const in the middle of the execution.
-
Michael Widenius authored
-
Sergei Golubchik authored
mysys/errors.c: revert upstream's fix. use a much simpler one mysys/my_write.c: revert upstream's fix. use a simpler one sql/item_xmlfunc.cc: useless, but ok sql/mysqld.cc: simplify upstream's fix storage/heap/hp_delete.c: remove upstream's fix. we'll use a much less expensive approach.
-
- 26 Feb, 2013 1 commit
-
-
Vladislav Vaintroub authored
-
- 21 Feb, 2013 1 commit
-
-
Vladislav Vaintroub authored
-
- 14 Feb, 2013 1 commit
-
-
Elena Stepanova authored
-
- 31 Jan, 2013 1 commit
-
-
unknown authored
Analysis: Range analysis discoveres that the query can be executed via loose index scan for GROUP BY. Later, GROUP BY analysis fails to confirm that the GROUP operation can be computed via an index because there is no logic to handle duplicate field references in the GROUP clause. As a result the optimizer produces an inconsistent plan. It constructs a temporary table, but on the other hand the group fields are not set to point there. Solution: Make loose scan analysis work in sync with order by analysis. In the case of duplicate columns loose scan will not be applicable. This limitation will be lifted in 10.0 by removing duplicate columns.
-
- 28 Jan, 2013 1 commit
-
-
Sergei Golubchik authored
-
- 25 Jan, 2013 4 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-729 lp:998028 - Server crashes on normal shutdown in closefrm after executing a query from MyISAM table don't write a key value into the record buffer - a key length can be larger then the record length.
-
Sergei Golubchik authored
MDEV-759 lp:998340 - Valgrind complains on simple selects containing expression DAY(FROM_UNIXTIME(-1)) check item->null_value before using the result of item->val_int()
-
Sergei Golubchik authored
mysqldump.c: s/SET OPTION/SET/ (OPTION was, hm, optional since 3.21, so there's no need to use SET OPTION even in the old compatibility modes)
-