1. 20 Dec, 2017 2 commits
  2. 19 Dec, 2017 7 commits
    • sjaakola's avatar
      MW-416 DDL replication moved after acl checking · 64e1dda0
      sjaakola authored
      galera_events test shows a regression with the original fix for MW-416
      Reason was that Events::drop_event() can be called also from inside event
      execution, and there we have a speacial treatment for event, which executes
      "DROP EVENT" statement, and runs TOI replication inside the event processing body.
      This resulted in executing WSREP_TO_ISOLATION two times for such DROP EVENT statement.
      Fix is to call WSREP_TO_ISOLATION_BEGIN only in Events::drop_event()
      64e1dda0
    • sjaakola's avatar
      MW-416 · 1a8da003
      sjaakola authored
      Changed return code for replicatio error to TRUE.
      This is aligned with native mysql convention to return TRUE (defined to 1) or FALSE (defined to 0) from a bool function.
      This is wrong, but follows the mysql conventiosn, at least...
      1a8da003
    • Sergey Vojtovich's avatar
      MDEV-14265 - RPMLint warning: shared-lib-calls-exit · 2cd31691
      Sergey Vojtovich authored
      find_type_or_exit() client helper did exit(1) on error, exit(1) moved to
      clients.
      
      mysql_read_default_options() did exit(1) on error, error is passed through and
      handled now.
      
      my_str_malloc_default() did exit(1) on error, replaced my_str_ allocator
      functions with normal my_malloc()/my_realloc()/my_free().
      
      sql_connect.cc did many exit(1) on hash initialisation failure. Removed error
      check since my_hash_init() never fails.
      
      my_malloc() did exit(1) on error. Replaced with abort().
      
      my_load_defaults() did exit(1) on error, replaced with return 2.
      
      my_load_defaults() still does exit(0) when invoked with --print-defaults.
      2cd31691
    • Jan Lindström's avatar
      DEV-14701: install_db shows corruption for rest encryption with innodb_data_file_path=ibdata1:3M · ed7e4b68
      Jan Lindström authored
      Problem was that crypt_data->min_key_version is not a reliable way
      to detect is tablespace encrypted and could lead that in first page
      of the second (page 192 and similarly for other files if more configured)
      system tablespace file used key_version is replaced with zero leading
      a corruption as in next startup page is though to be corrupted.
      Note that crypt_data->min_key_version is updated only after all
      pages from tablespace have been processed (i.e. key rotation is done)
      and flushed.
      
      fil_write_flushed_lsn
              Use crypt_data->should_encrypt() instead.
      ed7e4b68
    • Jan Lindström's avatar
      Fix galera.view test case crash. · 252e690c
      Jan Lindström authored
      WSREP_TO_ISOLATION_BEGIN() call must be after view name is back
      on tables list.
      252e690c
    • Daniel Black's avatar
    • Daniel Black's avatar
      64f1fab0
  3. 18 Dec, 2017 10 commits
  4. 14 Dec, 2017 1 commit
  5. 13 Dec, 2017 10 commits
  6. 12 Dec, 2017 1 commit
  7. 09 Dec, 2017 3 commits
    • Jan Lindström's avatar
      de76cbdc
    • Jan Lindström's avatar
      MDEV-14401: Stored procedure that declares a handler that catches... · feb8296e
      Jan Lindström authored
      MDEV-14401: Stored procedure that declares a handler that catches ER_LOCK_DEADLOCK error causes thd->is_error() assertion
      
      This was missing bug fix from MySQL wsrep i.e. Galera.
      Problem was that if stored procedure declares a handler that
      catches deadlock error, then the error may have been
      cleared in method sp_rcontext::handle_sql_condition().
      Use wsrep_conflict_state correctly to determine is the
      error already sent to client.
      
      Add test case for both this bug and MDEV-12837: WSREP: BF
      lock wait long. Test requires both fixes to pass.
      feb8296e
    • Jan Lindström's avatar
      MDEV-12837: WSREP: BF lock wait long · e66bb572
      Jan Lindström authored
      This is 10.1 version where no merge error exists.
      
      wsrep_on_check
              New check function. Galera can't be enabled
              if innodb-lock-schedule-algorithm=VATS.
      
      innobase_kill_query
              In Galera async kill we could own lock mutex.
      
      innobase_init
              If Variance-Aware-Transaction-Sheduling Algorithm (VATS) is
              used on Galera we refuse to start InnoDB.
      
      Changed innodb-lock-schedule-algorithm as read-only parameter
      as it was designed to be.
      
      lock_rec_other_has_expl_req,
      lock_rec_other_has_conflicting,
      lock_rec_lock_slow
      lock_table_other_has_incompatible
      lock_rec_insert_check_and_lock
      
              Change pointer to conflicting lock to normal pointer as this
              pointer contents could be changed later.
      e66bb572
  8. 07 Dec, 2017 2 commits
  9. 05 Dec, 2017 1 commit
  10. 03 Dec, 2017 1 commit
    • Monty's avatar
      MDEV-10688 rpl.rpl_row_log_innodb failed in buildbot · d7b0b8dd
      Monty authored
      Problem was that Binlog_checkpoint can happen at random times.
      Fixed by not write binlog_checkpoint for the rpl_log test.
      
      Other things:
      - Removed not used variable "$keep_gtid_events"
      - Added option for show_binlog_events to skip binlog_checkpoint
      d7b0b8dd
  11. 29 Nov, 2017 1 commit
  12. 24 Nov, 2017 1 commit