1. 29 Apr, 2020 4 commits
    • Sergei Petrunia's avatar
      MDEV-22401: Optimizer trace: multi-component range is not printed correctly · 7bc67357
      Sergei Petrunia authored
      KEY_MULTI_RANGE::range_flag does not have correct flag bits for
      per-endpoint flags (NEAR_MIN, NEAR_MAX, NO_MIN_RANGE, NO_MAX_RANGE).
      It only has bits for flags that describe both endpoints.
      So
      - Document this.
      - Switch optimizer trace to using {start|end}_key.flag values, instead.
        This fixes the bug.
      - Switch records_in_column_ranges() to doing that too. (This used to
        work, because KEY_MULTI_RANGE::range_flag had correct flag value
        for the last key component, and EITS only uses one-component
        pseudo-indexes)
      7bc67357
    • Marko Mäkelä's avatar
      MDEV-7962: Remove one more wsrep_on() · 5ba2aa1d
      Marko Mäkelä authored
      trx_rollback_to_savepoint(): Invoke trx_t::is_wsrep().
      5ba2aa1d
    • Marko Mäkelä's avatar
      MDEV-7962: Follow-up fix for 10.4 · cfbbf542
      Marko Mäkelä authored
      Replace wsrep_on() with trx_t::is_wsrep() where possible.
      
      Also, rename some functions to member functions and
      remove unused DBUG_EXECUTE_IF instrumentation:
      
      trx_t::commit(): Renamed from trx_commit().
      
      trx_t::commit_low(): Renamed from trx_commit_low().
      
      trx_t::commit_in_memory(): Renamed from trx_commit_in_memory().
      cfbbf542
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 0632b803
      Marko Mäkelä authored
      0632b803
  2. 28 Apr, 2020 14 commits
  3. 27 Apr, 2020 20 commits
  4. 26 Apr, 2020 1 commit
    • Monty's avatar
      Fixed shutdown crash in Aria that affects debug binaries · 81511b47
      Monty authored
      MDEV-18286 Assertion `pagecache->cnt_for_resize_op == 0' failed in
      check_pagecache_is_cleaned_up on server shutdown
      
      The reason for the crash is that the counter-of-pinned-pages in the
      Aria pagecache goes wrong.
      This only affects debug builds, as in these we do an assert on shutdown
      if the counter-of-pinned-pages is not 0 (some page was left pinned).
      
      The bug was that in 2 places in the page cache, when not succeeding to
      pin a page and a retry was made, the counter-of-pinned-pages counter was
      not properly adjusted.
      
      In the given test case, BLOCK_COMMIT flushed all Aria files. If a block was flushed at the same time the insert tried to access it, the insert would retry to get the block and that would cause the counter to go wrong.
      81511b47
  5. 24 Apr, 2020 1 commit
    • Eugene Kosov's avatar
      cleanup THR_KEY_mysys · 2c5067b6
      Eugene Kosov authored
      read TLS with my_thread_var
      write TLS with set_mysys_var()
      
      my_thread_var is no longer __attribute__ ((const)): this attribute
      is simply incorrect here. Read gcc manual for more information.
      sql/threadpool_generic.cc fails with that attribute.
      2c5067b6