An error occurred fetching the project authors.
  1. 21 Nov, 2006 1 commit
    • unknown's avatar
      Polishing: · 7c35c3d5
      unknown authored
        - change some return types from int to bool;
        - add [ERROR] tag to log_error() output;
        - add [INFO] tag to log_info() output;
        - change log messages to be more consistent.
      
      
      server-tools/instance-manager/IMService.cpp:
        Log polishing.
      server-tools/instance-manager/commands.cc:
        Log polishing.
      server-tools/instance-manager/commands.h:
        Eliminate warnings.
      server-tools/instance-manager/instance.cc:
        Log polishing.
      server-tools/instance-manager/instance_map.cc:
        Log polishing.
      server-tools/instance-manager/instance_options.cc:
        1) Log polishing.
        2) Change int-return type to bool.
      server-tools/instance-manager/instance_options.h:
        Change int-return type to bool.
      server-tools/instance-manager/listener.cc:
        Log polishing.
      server-tools/instance-manager/log.cc:
        Log polishing.
      server-tools/instance-manager/log.h:
        Log polishing.
      server-tools/instance-manager/manager.cc:
        Log polishing.
      server-tools/instance-manager/mysql_connection.cc:
        Log polishing.
      server-tools/instance-manager/mysql_connection.h:
        Change int-return type to bool.
      server-tools/instance-manager/mysqlmanager.cc:
        Log polishing.
      server-tools/instance-manager/priv.cc:
        Log polishing.
      server-tools/instance-manager/thread_registry.cc:
        1. Print pthread_t as (unsigned long), not as (signed long)
        to avoid negative identifiers in output.
        2. Print thread id after it will be initialized, not before.
      server-tools/instance-manager/user_map.cc:
        Log polishing.
      7c35c3d5
  2. 17 Nov, 2006 2 commits
    • unknown's avatar
      Port cleanups, trivial refactoring and code rearrangements from · c95482d4
      unknown authored
      Alik's patch for BUG#22306: STOP INSTANCE can not be applied for 
      instances in Crashed, Failed and Abandoned" to ease review process.
      Evaluate global variable linuxthreads before starting threads to avoid
      a race.
      
      
      server-tools/instance-manager/buffer.cc:
        Fix spelling.
      server-tools/instance-manager/command.h:
        Fix spelling.
      server-tools/instance-manager/commands.cc:
        Fix spelling.
      server-tools/instance-manager/commands.h:
        Fix spelling, tidy up.
      server-tools/instance-manager/guardian.cc:
        Cleanup logging, options.get_shutdown_delay() is a method, tidy up.
      server-tools/instance-manager/instance.cc:
        Rearrange methods to be the same as in Alik's patch, fix spelling errors,
        clean up logging texts, port comments from Alik's patch, 
        implement some basic renames from his patch.
        No real changes.
      server-tools/instance-manager/instance.h:
        Tidy up, renames.
      server-tools/instance-manager/instance_map.cc:
        Fix spellings, port some refactoring from Alik's patch.
      server-tools/instance-manager/instance_map.h:
        Cleanup.
      server-tools/instance-manager/instance_options.cc:
        Cleanup. Implement Instance_options::get_shutdown_delay() and
        Instance_options::get_mysqld_port().
      server-tools/instance-manager/instance_options.h:
        Cleanup.
      server-tools/instance-manager/listener.cc:
        Cleanup.
      server-tools/instance-manager/log.cc:
        Fix spelling.
      server-tools/instance-manager/manager.cc:
        Cleanup.
      server-tools/instance-manager/manager.h:
        Add getters for Manager members.
      server-tools/instance-manager/mysqlmanager.cc:
        Evaluate linuxthreads before starting threads to avoid a race.
      server-tools/instance-manager/parse_output.cc:
        Fix spelling.
      server-tools/instance-manager/priv.cc:
        Cleanup.
      server-tools/instance-manager/priv.h:
        Cleanup.
      server-tools/instance-manager/user_management_commands.cc:
        Fix spelling.
      server-tools/instance-manager/user_management_commands.h:
        Fix spelling.
      server-tools/instance-manager/user_map.cc:
        Fix spelling.
      c95482d4
    • unknown's avatar
      Polishing: generate more warnings and make code warnings-free. · 3bb26768
      unknown authored
      server-tools/instance-manager/Makefile.am:
        Generate more warnings.
      server-tools/instance-manager/commands.cc:
        Eliminate warnings.
      server-tools/instance-manager/commands.h:
        Eliminate warnings.
      server-tools/instance-manager/instance.cc:
        Eliminate warnings.
      server-tools/instance-manager/mysql_connection.cc:
        Eliminate warnings.
      server-tools/instance-manager/parse.cc:
        Eliminate warnings.
      server-tools/instance-manager/user_map.cc:
        Eliminate warnings.
      server-tools/instance-manager/user_map.h:
        Eliminate warnings.
      3bb26768
  3. 16 Nov, 2006 1 commit
    • unknown's avatar
      Cleanup: manually port the polishing parts from Alik's changeset for · 211b2bc9
      unknown authored
      BUG#22306: STOP INSTANCE can not be applied for instances in Crashed,
      Failed and Abandoned
      
      
      mysql-test/t/im_options.imtest:
        Update test for new framework.
      server-tools/instance-manager/IMService.cpp:
        Use Manager class instead of manager().
        Reformat comments.
      server-tools/instance-manager/Makefile.am:
        Treat warnings as errors.
      server-tools/instance-manager/command.cc:
        Store references to Guardian_thread and Instance_map in Command attributes.
      server-tools/instance-manager/command.h:
        Store references to Guardian_thread and Instance_map in Command 
        attributes.
      server-tools/instance-manager/commands.cc:
        Remove Instance_map argument from command constructors.
      server-tools/instance-manager/commands.h:
        Remove Instance_map argument from command constructors.
      server-tools/instance-manager/guardian.cc:
        Rename: Guardian_thread -> Guardian
      server-tools/instance-manager/guardian.h:
        Rename: Guardian_thread -> Guardian
      server-tools/instance-manager/instance_map.cc:
        Rename: Guardian_thread -> Guardian.
      server-tools/instance-manager/instance_map.h:
        Rename: Guardian_thread -> Guardian.
      server-tools/instance-manager/manager.cc:
        Use Manager class instead of manager() function.
      server-tools/instance-manager/manager.h:
        Transfer manager() function into Manager class (singleton).
      server-tools/instance-manager/mysql_connection.cc:
        Polishing.
      server-tools/instance-manager/mysqlmanager.cc:
        Use Manager class instead of manager() function.
      server-tools/instance-manager/parse.cc:
        Rename: Guardian_thread -> Guardian
      server-tools/instance-manager/parse.h:
        Rename: Guardian_thread -> Guardian
      server-tools/instance-manager/priv.cc:
        Move create_pid_file() out of manager.cc.
      server-tools/instance-manager/priv.h:
        Move create_pid_file() out of manager.cc.
      server-tools/instance-manager/thread_registry.h:
        Prevent copying.
      server-tools/instance-manager/user_map.cc:
        Fix alignment.
      211b2bc9
  4. 01 Nov, 2006 1 commit
    • unknown's avatar
      Fixed a lot of compiler warnings (Mainly in mysqld and instance manager) · 07d8be45
      unknown authored
      Fixed some possible fatal wrong arguments to printf() style functions
      Initialized some not initialized variables
      Fixed bug in stored procedure and continue handlers
      (Fixes Bug#22150)
      
      
      include/mysql/plugin.h:
        Remove compiler warning
      mysql-test/mysql-test-run.pl:
        Ensure that --extern works on a clean tree (when 'var' directory doesn't exists)
      server-tools/instance-manager/commands.cc:
        Fixed possible use of unitialized variable
      server-tools/instance-manager/guardian.cc:
        Fixed wrong arguments to log_info() that could cause crashes
      server-tools/instance-manager/instance.cc:
        Fixed wrong arguments to log_info() and log_error() that could cause crashes
      server-tools/instance-manager/instance_options.cc:
        Fixed wrong arguments to log_error() that could cause crashes
      server-tools/instance-manager/mysql_connection.cc:
        Fixed wrong arguments to log_info()
      server-tools/instance-manager/parse.cc:
        Fixed possible use of unitialized variable
      server-tools/instance-manager/user_map.cc:
        Fixed wrong arguments to log_error() that could cause crashes
      sql/Makefile.am:
        Fix for bison 1.875
        (It write an __attribute__() tag that was causing compiler failures)
      sql/ha_ndbcluster.cc:
        Fixed wrong snprintf() arguments
        Remoed not used variables
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warning (unsigned/signed comparision)
      sql/handler.cc:
        Fixed wrong parameter to hton->binlog_func()
      sql/item_cmpfunc.cc:
        Removed compiler warnings
      sql/item_timefunc.cc:
        Removed compiler warnings
      sql/log.cc:
        fixed wrong argument to snprintf()
      sql/mysqld.cc:
        Removed compiler warnings
        Fixed wrong arguments to printf()
      sql/partition_info.cc:
        Removed compiler warnings
      sql/protocol.cc:
        reset is_fatal_error for stored procedures
        (Fix for Bug#22150)
      sql/sp_head.cc:
        More DBUG information
        Reset is_fatal_error in case of continue handler.
        (Fix for Bug#22150)
      sql/sql_base.cc:
        Removed compiler warnings
      sql/sql_class.h:
        More DBUG information
      sql/sql_insert.cc:
        Removed compiler warnings
        Initialize not initialized variable (fatal bug)
      sql/sql_parse.cc:
        Added DBUG_ASSERT to detect if stored procedure code returns with a wrong state
        Removed compiler warning
      sql/sql_plugin.cc:
        Fied wrong aruguments to printf() (Fatal bug)
      sql/sql_select.cc:
        Initailize not initialized variable.
        Remove compiler warnings
        Fixed wrong argument to printf() (Possible fatal error)
      sql/sql_view.cc:
        Removed compiler warnings
      sql/table.cc:
        Fixed wrong argument to printf() (Possible fatal)
      07d8be45
  5. 19 May, 2006 1 commit
    • unknown's avatar
      Fix compilation problems on Windows and SUN Solaris. · ac380604
      unknown authored
      include/m_string.h:
        Fix declaration of C-structure for Visual Studio and Sun C-compiler.
      server-tools/instance-manager/IMService.cpp:
        Fixed.
      server-tools/instance-manager/Makefile.am:
        Removed gcc-specific flags.
      server-tools/instance-manager/commands.cc:
        Moved m_string.h to the header.
      server-tools/instance-manager/commands.h:
        Replaced forward declaration of LEX_STRING because
        it is not understood by all compilers.
      server-tools/instance-manager/instance_map.cc:
        1. Moved m_string.h to the header.
        2. Use (const char *) to point to const C-string.
      server-tools/instance-manager/instance_map.h:
        Replaced forward declaration of LEX_STRING because
        it is not understood by all compilers.
      server-tools/instance-manager/instance_options.h:
        Fixed headers.
      server-tools/instance-manager/mysqlmanager.cc:
        Fixed headers.
      server-tools/instance-manager/user_management_commands.cc:
        Removed unused variables.
      server-tools/instance-manager/user_map.cc:
        Fixed headers.
      ac380604
  6. 18 May, 2006 1 commit
    • unknown's avatar
      This is an implementation of two WL items: · 8b4fcf6e
      unknown authored
        - WL#3158: IM: Instance configuration extensions;
        - WL#3159: IM: --bootstrap and --start-default-instance modes
      
      The following new statements have been added:
        - CREATE INSTANCE;
        - DROP INSTANCE;
      
      The behaviour of the following statements have been changed:
        - SET;
        - UNSET;
        - FLUSH INSTANCES;
        - SHOW INSTANCES;
        - SHOW INSTANCE OPTIONS;
      
      
      BitKeeper/deleted/.del-im_options_set.imtest~b53d9d60e5684833:
        Delete: mysql-test/t/im_options_set.imtest
      BitKeeper/deleted/.del-im_options_set.result~59278f56be61d921:
        Delete: mysql-test/r/im_options_set.result
      BitKeeper/deleted/.del-im_options_unset.imtest~768eb186b51d0048:
        Delete: mysql-test/t/im_options_unset.imtest
      BitKeeper/deleted/.del-im_options_unset.result~20a4790cd3c70a4f:
        Delete: mysql-test/r/im_options_unset.result
      client/get_password.c:
        Change prototype to avoid casting when using C-strings (char *).
      include/m_string.h:
        Moved LEX_STRING to global header from sql/ to be accessible
        from all components (IM for one).
      include/my_sys.h:
        Added constants for modify_defaults_file().
      include/mysql_com.h:
        Removed duplicated declarations. my_sys.h should be used instead.
      libmysql/get_password.c:
        Change prototype to avoid casting when using C-strings (char *).
      mysql-test/mysql-test-run.pl:
        Added environment variables to be used from tests.
      mysql-test/r/im_daemon_life_cycle.result:
        Column name has been changed in SHOW INSTANCES.
      mysql-test/r/im_life_cycle.result:
        1. Column name has been changed in SHOW INSTANCES.
        2. Removed redundant SHOW INSTANCE STATUS statements.
      mysql-test/r/im_utils.result:
        Updated the result file.
      mysql-test/t/im_daemon_life_cycle-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      mysql-test/t/im_daemon_life_cycle.imtest:
        Get Instance Manager and managed mysqld-instances enough time to start.
      mysql-test/t/im_life_cycle.imtest:
        1. Polishing;
        2. Fixed a test error in 1.1.2.
      mysql-test/t/im_utils.imtest:
        Get Instance Manager and managed mysqld-instances enough time to start.
      mysys/default.c:
        Pass the name of the section to the handler function as well.
      mysys/default_modify.c:
        Added REMOVE_SECTION functionality.
      server-tools/instance-manager/IMService.cpp:
        Polishing: be more verbose.
      server-tools/instance-manager/IMService.h:
        Polishing: added copyright.
      server-tools/instance-manager/Makefile.am:
        Added new files.
      server-tools/instance-manager/WindowsService.cpp:
        Polishing: according to The Coding Style, TRUE/FALSE must be
        used instead of true/false.
      server-tools/instance-manager/WindowsService.h:
        Polishing: added copyright.
      server-tools/instance-manager/command.h:
        Polishing: provide a comment for the main operation of "Command" class.
      server-tools/instance-manager/commands.cc:
        1. Added support for CREATE INSTANCE, DROP INSTANCE statements;
        2. Added "deprecated" column in output of SHOW INSTANCE OPTIONS;
        3. Modified the behaviour of SET/UNSET, FLUSH INSTANCES statements;
      server-tools/instance-manager/commands.h:
        1. Added support for CREATE INSTANCE, DROP INSTANCE statements;
        2. Added "deprecated" column in output of SHOW INSTANCE OPTIONS;
        3. Modified the behaviour of SET/UNSET, FLUSH INSTANCES statements;
      server-tools/instance-manager/guardian.cc:
        Added operations to retrieve state of managed instances.
      server-tools/instance-manager/guardian.h:
        Added operations to retrieve state of managed instances.
      server-tools/instance-manager/instance.cc:
        1. Provided an operation to check validity of instance name.
        2. Added an attribute to distiguish mysqld-instances,
           whose configuration should be kept backward-compatible.
      server-tools/instance-manager/instance.h:
        1. Provided an operation to check validity of instance name.
        2. Added an attribute to distiguish mysqld-instances,
           whose configuration should be kept backward-compatible.
      server-tools/instance-manager/instance_map.cc:
        1. Used the operation to check validity of instance name;
        2. Added operations to manage instances.
      server-tools/instance-manager/instance_map.h:
        Added operations to manage instances.
      server-tools/instance-manager/instance_options.cc:
        Changed Instance_options so that it will be possible to manage
        options on the fly.
      server-tools/instance-manager/instance_options.h:
        Changed Instance_options so that it will be possible to manage
        options on the fly.
      server-tools/instance-manager/listener.cc:
        1. Remove reference to the instance of Options;
        2. Use new Options naming scheme.
      server-tools/instance-manager/listener.h:
        Remove reference to the instance of Options;
      server-tools/instance-manager/log.cc:
        Polishing: use TRUE/FALSE instead of true/false.
      server-tools/instance-manager/manager.cc:
        Added a common for IM operation to work with configuration file.
      server-tools/instance-manager/manager.h:
        Added a common for IM operation to work with configuration file.
      server-tools/instance-manager/messages.cc:
        Added messages for new errors.
      server-tools/instance-manager/mysql_connection.cc:
        1. Move a constant to common place.
        2. Polishing.
      server-tools/instance-manager/mysql_manager_error.h:
        Added new errors.
      server-tools/instance-manager/mysqlmanager.cc:
        1. Use error code from Options::load();
        2. Eliminate type-casting warning on Windows.
      server-tools/instance-manager/options.cc:
        Added support for user-management command-line options.
      server-tools/instance-manager/options.h:
        Added support for user-management command-line options.
      server-tools/instance-manager/parse.cc:
        1. Added support of new statements:
           - CREATE INSTANCE;
           - DROP INSTANCE.
        2. Modified SET/UNSET.
      server-tools/instance-manager/parse.h:
        1. Added support of new statements:
           - CREATE INSTANCE;
           - DROP INSTANCE.
        2. Modified SET/UNSET.
      server-tools/instance-manager/parse_output.cc:
        Sorted out header files.
      server-tools/instance-manager/parse_output.h:
        Sorted out header files.
      server-tools/instance-manager/portability.h:
        1. Added constants for Windows.
        2. Moved system-dependent defines from instance_options.cc.
      server-tools/instance-manager/priv.cc:
        Updated version.
      server-tools/instance-manager/priv.h:
        Added some global constants.
      server-tools/instance-manager/protocol.cc:
        Replaced NAME_WITH_LENGTH by LEX_STRING.
      server-tools/instance-manager/protocol.h:
        Replaced NAME_WITH_LENGTH by LEX_STRING.
      server-tools/instance-manager/thread_registry.cc:
        Polishing: use TRUE/FALSE instead of true/false.
      server-tools/instance-manager/user_map.cc:
        Added support for managing password database.
      server-tools/instance-manager/user_map.h:
        Added support for managing password database.
      sql/sp.cc:
        Replaced LEX_STRING_WITH_INIT by LEX_STRING + struct initialization.
      sql/sp_head.cc:
        Replaced LEX_STRING_WITH_INIT by LEX_STRING + struct initialization.
      sql/spatial.cc:
        Removed LEX_STRING_WITH_INIT.
      sql/spatial.h:
        Removed LEX_STRING_WITH_INIT.
      sql/sql_string.h:
        Moved STRING_WITH_LEN() macro out from sql (to m_string.h).
      sql/sql_trigger.cc:
        Moved STRING_WITH_LEN() macro out from sql (to m_string.h).
      sql/structs.h:
        Removed LEX_STRING_WITH_INIT.
      support-files/mysql.server.sh:
        Instruct Instance Manager to work in mysqld-safe compatible mode
        for backward compatibility.
      mysql-test/r/im_cmd_line.result:
        Added result file.
      mysql-test/r/im_instance_conf.result:
        Added result file.
      mysql-test/r/im_options.result:
        Added result file.
      mysql-test/t/im_cmd_line.imtest:
        IM command-line options test.
      mysql-test/t/im_instance_conf-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      mysql-test/t/im_instance_conf.imtest:
        Added a new test case for checking instance-management.
      mysql-test/t/im_life_cycle-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      mysql-test/t/im_options.imtest:
        Join im_options_set and im_options_unset and add new tests.
      mysql-test/t/im_utils-im.opt:
        Set minimal monitoring interval for Instance Manager to speed up testing.
      server-tools/instance-manager/exit_codes.h:
        New file for defining exit codes for user-management mode.
      server-tools/instance-manager/user_management_commands.cc:
        User-management commands implementation.
      server-tools/instance-manager/user_management_commands.h:
        User-management command declarations.
      8b4fcf6e
  7. 07 Oct, 2005 1 commit
  8. 23 Sep, 2005 1 commit
    • unknown's avatar
      Some minor fixes revealed as warnings by · ab0d7e2a
      unknown authored
      Intel compiler.
      
      
      client/mysqltest.c:
        Fixed a warning from using reference to a memory area,
        which is outside an object. This is just a minor
        clean-up, not a bug fix.
      server-tools/instance-manager/buffer.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/buffer.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/command.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/command.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/guardian.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/guardian.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_map.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_map.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_options.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_options.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/listener.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/listener.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/mysql_connection.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/mysql_connection.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/options.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/options.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/parse_output.cc:
        Removed unused goto.
      server-tools/instance-manager/thread_registry.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/thread_registry.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/user_map.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/user_map.h:
        Fixed pragma warning for those compilers that do
        not support it.
      sql/field.cc:
        Fixed a warning about overflow.
      sql/item.h:
        Fixed implicit function declaration warning.
      sql/item_sum.cc:
        Fixed implicit function declaration warning.
      ab0d7e2a
  9. 19 Sep, 2005 1 commit
    • unknown's avatar
      fix warnings · c8c29f2d
      unknown authored
      server-tools/instance-manager/buffer.cc:
        perform initialization of static consts in .cc file to respect VC6
      server-tools/instance-manager/buffer.h:
        fix compiler warning
      server-tools/instance-manager/commands.cc:
        fix compiler warning
      server-tools/instance-manager/user_map.cc:
        fix compiler warning
      c8c29f2d
  10. 29 Aug, 2005 1 commit
    • unknown's avatar
      Cleanup the instance manager code. · 26b6b1b2
      unknown authored
      BitKeeper/deleted/.del-factory.h~c1679505d3a6dd53:
        Delete: server-tools/instance-manager/factory.h
      BitKeeper/deleted/.del-factory.cc~6836cccd4cd35b4d:
        Delete: server-tools/instance-manager/factory.cc
      server-tools/instance-manager/Makefile.am:
        - remove Commands_factory: it'll be needed when we add support
        for NNTP/HTTP connections, currently it only adds unnecessary
        complexity.
      server-tools/instance-manager/commands.cc:
        - fix coding style: no else after return; fix comments, make
        one place a bit faster.
      server-tools/instance-manager/guardian.cc:
        - fix coding style and comments.
        - we must register the current thread in the thread registry
          before entering pthread_cond_timedwait, because at shutdown
          the thread registry will try to kick out of wait all blocked 
          threads. Unregistered threads are not awakened by the registry. 
          This fixes the failinig assert in Thread_registry::~Thread_registry
          at shutdown, when shutdown is requested and there is an
          instance monitored by Guardian.
      server-tools/instance-manager/guardian.h:
        - fix coding style: enums must start with enum_
      server-tools/instance-manager/instance.h:
        - move comment to the variable it comments
      server-tools/instance-manager/instance_map.cc:
        - cleanup
      server-tools/instance-manager/instance_options.cc:
        - cleanup; no else after return (fix coding style).
      server-tools/instance-manager/manager.cc:
        - fix alignment; make some code easier to read.
      server-tools/instance-manager/mysql_connection.cc:
        - remove Commands_factory
      server-tools/instance-manager/options.cc:
        - fix a possible crash when the instance manager is started with
        --no-defaults --defaults-file=~/.my.cnf: if we return
        without cloning saved_argv by calling load_defaults, Options::cleanup
        will crash on attempt to free_defaults(saved_argv);
      server-tools/instance-manager/parse.cc:
        - get rid of Commands_factory
      server-tools/instance-manager/parse.h:
        - get rid of Commands_factory
      server-tools/instance-manager/parse_output.cc:
        - in parse_output_and_get_value return error also if the specified
          pattern was not found, or the command failed to execute.
      server-tools/instance-manager/portability.h:
        - fix coding style (// comments are allowed only at ends of lines)
      server-tools/instance-manager/thread_registry.cc:
        - implement Thread_registry::cond_timedwait
      server-tools/instance-manager/thread_registry.h:
        - implement Thread_registry::cond_timedwait; remove
          unused out parameter from Thread_registry::cond_wait.
      server-tools/instance-manager/user_map.cc:
        - safety: newline can take 2 bytes.
      26b6b1b2
  11. 09 Aug, 2005 2 commits
    • unknown's avatar
      removing trailing spaces · 81a24473
      unknown authored
      81a24473
    • unknown's avatar
      small corrections to the IM. · 530abb5c
      unknown authored
      server-tools/instance-manager/IMService.cpp:
        removed \n from log_info calls as these will be added automatically
      server-tools/instance-manager/user_map.cc:
        added back in support for password files using \r\n, this time
        without breaking the const contract.
      530abb5c
  12. 05 Aug, 2005 1 commit
    • unknown's avatar
      IM port cleanup · cd3fa684
      unknown authored
      server-tools/instance-manager/IMService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.h:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/instance.cc:
        cleanup & coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/listener.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/manager.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/options.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/user_map.cc:
        simplify password file processing
      cd3fa684
  13. 03 Aug, 2005 1 commit
    • unknown's avatar
      alot of formatting changes that came out of JimW's review · 55b4cb00
      unknown authored
      server-tools/instance-manager/IMService.cpp:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/WindowsService.cpp:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/WindowsService.h:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/commands.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/instance.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/instance_map.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/listener.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/manager.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/options.cc:
        fixed tabs and spacing per JimW's review
      server-tools/instance-manager/user_map.cc:
        fixed tabs and spacing per JimW's review
      55b4cb00
  14. 20 Jul, 2005 1 commit
    • unknown's avatar
      initial import of Windows port of IM. · 875b0e63
      unknown authored
      server-tools/instance-manager/commands.cc:
        type cleanups for compiling on Windows
        now using Options::config_file for the location of the single 
        my.cnf file we are using
      server-tools/instance-manager/guardian.cc:
        pthread_mutex_lock and unlock do not return a value on Windows
        so we return 0 in all cases
      server-tools/instance-manager/instance.cc:
        big changes here.
        Had to implement Windows versions of launch_and_wait and kill()
      server-tools/instance-manager/instance.h:
        added some function defs
      server-tools/instance-manager/instance_map.cc:
        pthread_mutex_lock and unlock do not return a value on Windows
        Also, now using only the file named as Options::config_file
      server-tools/instance-manager/instance_options.h:
        added reference to port.h
      server-tools/instance-manager/listener.cc:
        reworked and simplified the socket handling code.
        Added windows versions of the code that sets the sockets to be
        non-blocking and non-inheritable
      server-tools/instance-manager/listener.h:
        change Options to always be a struct.  Really surprised GCC was 
        letting this go.  Options was declared to be struct in some places
        and class in other places.
      server-tools/instance-manager/log.cc:
        added reference to port.h
      server-tools/instance-manager/manager.cc:
        moved all the signal code inside some #ifndef __WIN__ blocks
      server-tools/instance-manager/manager.h:
        change Options to always be a struct.  Really surprised GCC was 
        letting this go.  Options was declared to be struct in some places
        and class in other places.
      server-tools/instance-manager/mysqlmanager.cc:
        added in the Windows service code.
      server-tools/instance-manager/options.cc:
        Added in the windows options for running as a service and the code
        for loading settings only from a single file
      server-tools/instance-manager/options.h:
        added definitions for the new Windows service vars and routines
      server-tools/instance-manager/parse_output.cc:
        added reference to port.h
      server-tools/instance-manager/priv.cc:
        added reference to port.h
      server-tools/instance-manager/priv.h:
        linuxthreads should not be visible on Windows
      server-tools/instance-manager/thread_registry.cc:
        more __WIN__ blocking
      server-tools/instance-manager/user_map.cc:
        fixed passwd file code to handle files with \r\n line endings
      server-tools/instance-manager/IMService.cpp:
        New BitKeeper file ``server-tools/instance-manager/IMService.cpp''
      server-tools/instance-manager/IMService.h:
        New BitKeeper file ``server-tools/instance-manager/IMService.h''
      server-tools/instance-manager/WindowsService.cpp:
        New BitKeeper file ``server-tools/instance-manager/WindowsService.cpp''
      server-tools/instance-manager/WindowsService.h:
        New BitKeeper file ``server-tools/instance-manager/WindowsService.h''
      server-tools/instance-manager/mysqlmanager.vcproj:
        New BitKeeper file ``server-tools/instance-manager/mysqlmanager.vcproj''
      server-tools/instance-manager/port.h:
        New BitKeeper file ``server-tools/instance-manager/port.h''
      875b0e63
  15. 11 Feb, 2005 1 commit
    • unknown's avatar
      Post-review fixes + some bugs fixed + several minor features · dce2554f
      unknown authored
      BitKeeper/deleted/.del-client_func.c~3476a8a85cbd3c29:
        Delete: server-tools/instance-manager/client_func.c
      server-tools/instance-manager/Makefile.am:
        clien_func removed
      server-tools/instance-manager/buffer.cc:
        several methods added
      server-tools/instance-manager/buffer.h:
        Some error-handling fixes.
      server-tools/instance-manager/commands.cc:
        check for Buffer errors
      server-tools/instance-manager/guardian.cc:
        Guardian rewiriten. Not it works in a finite state machine-way.
      server-tools/instance-manager/guardian.h:
        Appropriate (to .cc) changes in the header + some comment added
      server-tools/instance-manager/instance.cc:
        added proxy thread to monitor instance. Two kinds of stop() now -- stop() and kill_instance which
        only sends a signal
      server-tools/instance-manager/instance.h:
        appropriate changes
      server-tools/instance-manager/instance_map.cc:
        cleanup
      server-tools/instance-manager/instance_map.h:
        cleanup
      server-tools/instance-manager/instance_options.cc:
        Caching of the pid-file-name is added. some comments added
      server-tools/instance-manager/instance_options.h:
        cleanup
      server-tools/instance-manager/listener.cc:
        listener my_thread_init added (though it doesn't use any mysys functions). Just in case
      server-tools/instance-manager/manager.cc:
        SIGCHLD handler removed. now instance monitoring is implemented through proxy threads. This is to work nicely
        with LinuxThreads
      server-tools/instance-manager/options.cc:
        added option to create a password file entry (this was implemented by Sergei Vojtovich)
      server-tools/instance-manager/parse.cc:
        inline function get_word moved to the header
      server-tools/instance-manager/parse.h:
        get_word moved here to use form parse_output
      server-tools/instance-manager/parse_output.cc:
        get_word() clone removed. now looking through the output linewise
      server-tools/instance-manager/protocol.cc:
        Buffer error chech added
      server-tools/instance-manager/user_map.cc:
        typo fixed
      dce2554f
  16. 05 Feb, 2005 1 commit
    • unknown's avatar
      Fixed setup scripts to use mysqlmanager instead of mysqld_safe · 87e104e4
      unknown authored
      server-tools/instance-manager/Makefile.am:
        obsolete defaults removed. Also changed default binary  placement. Now mysqlmanager should be installed in
        libexecdir (usually /usr/sbin)
      server-tools/instance-manager/instance_options.cc:
        bug, resulted in skipping non-sepcially recognized mysqld options fixed
      server-tools/instance-manager/user_map.cc:
        log message made a bit more verbose
      support-files/mysql.server.sh:
        use mysqlmanager tp start mysqld
      support-files/mysql.spec.sh:
        mysqlmanager should be placed in /usr/bin
      87e104e4
  17. 03 Feb, 2005 1 commit
    • unknown's avatar
      Various fixes (cleanups, valgrind, makefiles, ...) · ab432d6c
      unknown authored
      server-tools/instance-manager/Makefile.am:
        increased default_monitoring interval
      server-tools/instance-manager/guardian.cc:
        some fixes for proper shutdown
      server-tools/instance-manager/guardian.h:
        removed init() prototype, as it was never used
      server-tools/instance-manager/instance.cc:
        cleanup() function removed
      server-tools/instance-manager/instance.h:
        cleanup() prototype removed
      server-tools/instance-manager/instance_map.cc:
        Instance_map::cleanup() removed, as instances have nothing to clean up
      server-tools/instance-manager/instance_map.h:
        Instance_map::cleanup() prototype removed
      server-tools/instance-manager/instance_options.cc:
        added print_argv() function for debug purposes
      server-tools/instance-manager/instance_options.h:
        declared print_argv()
      server-tools/instance-manager/listener.cc:
        some fixed in listener for proper shutdown
      server-tools/instance-manager/log.cc:
        cleanup
      server-tools/instance-manager/log.h:
        cleanup
      server-tools/instance-manager/manager.cc:
        some comments added
      server-tools/instance-manager/mysqlmanager.cc:
        we need to free memory in the very end
      server-tools/instance-manager/options.cc:
        fixed default options handling (as they were not working properly), added new method to cleanup Options
      server-tools/instance-manager/options.h:
        cleanup() declared
      server-tools/instance-manager/thread_registry.cc:
        cleanup
      server-tools/instance-manager/user_map.cc:
        missing password file is not a critical error anymore, as IM should be able to work as mysqld_safe only
      ab432d6c
  18. 21 Dec, 2004 1 commit
    • unknown's avatar
      Bug #7468 Instance Manager fails to compile: thread_registry.cc · 8b80b584
      unknown authored
      This fix icludes workaround for Irix compiler bug & removs some unused
      variables (resulted in warnings)
      
      
      server-tools/instance-manager/mysql_connection.cc:
        removed unused variable
      server-tools/instance-manager/parse.cc:
        removed unused variable
      server-tools/instance-manager/thread_registry.cc:
        Workaround for the Irix compiler bug
      server-tools/instance-manager/user_map.cc:
        removed unused variable
      8b80b584
  19. 02 Nov, 2004 1 commit
    • unknown's avatar
      post-review fixes · 7a3a757f
      unknown authored
      server-tools/instance-manager/Makefile.am:
        Removed entry for deleted file
      server-tools/instance-manager/buffer.cc:
        cleanup
      server-tools/instance-manager/commands.cc:
        cleanup, added missing error handling
      server-tools/instance-manager/instance.cc:
        added waitpid in instance_start, added few checks
      server-tools/instance-manager/instance_map.cc:
        error handling for hash_init added
      server-tools/instance-manager/instance_map.h:
        Extended constructor
      server-tools/instance-manager/instance_options.cc:
        made add_option less bulky
      server-tools/instance-manager/instance_options.h:
        -
      server-tools/instance-manager/listener.cc:
        added missing close, fixed typo
      server-tools/instance-manager/manager.cc:
        moved some Instance_map initialization to costructor
      server-tools/instance-manager/protocol.cc:
        error handling added
      server-tools/instance-manager/protocol.h:
        store_to_string fixed to return a value
      server-tools/instance-manager/user_map.cc:
        error handling for hash_init added
      server-tools/instance-manager/user_map.h:
        added init() for User map (becouse of the hash_init check)
      7a3a757f
  20. 23 Oct, 2004 1 commit
    • unknown's avatar
      Intermediate commit - just to make new files visible to bk in the new · a5435ea7
      unknown authored
      tree
      
      
      server-tools/instance-manager/Makefile.am:
        Fixed IM linking to avoid using both mysys and libmysql as the define the
        same symbols and therefore conflict
      server-tools/instance-manager/listener.cc:
        Added ability to listen network ports
      server-tools/instance-manager/listener.h:
        Various additions to the Listener_thread_args
      server-tools/instance-manager/log.cc:
        merge
      server-tools/instance-manager/log.h:
        merge
      server-tools/instance-manager/manager.cc:
        Fixes and additions to enable guardian functionality
      server-tools/instance-manager/manager.h:
        Changed manager() signature
      server-tools/instance-manager/mysqlmanager.cc:
        Various fixes
      server-tools/instance-manager/options.cc:
        Added handling of default values for new options in the Options struct. (such
        as default_user, default_password, monitoring_interval e.t.c)
      server-tools/instance-manager/options.h:
        Added new options to the Options struct
      sql/net_serv.cc:
        Added MYSQL_INSTANCE_MANAGER defines to enable alarm handling in the IM
      server-tools/instance-manager/buffer.cc:
        Simple implementation of variable-length buffer
      server-tools/instance-manager/command.cc:
        Abstract command. All commands are derived from Command class
      server-tools/instance-manager/commands.h:
        Interfaces for all commands we have
      server-tools/instance-manager/factory.cc:
        Commands factory. This class hides command instantiation. The idea is to
        handle various protocols this way. (different commands for different
        protocols
      server-tools/instance-manager/guardian.cc:
        Guardian thread implementation (monitor and restart instances in case of a
        failure
      server-tools/instance-manager/guardian.h:
        Guardian_thread and Guardian_thread_args class interface. The
        Guardian_thread is responsible for monitoring and restarting instances
      server-tools/instance-manager/instance.cc:
        Instance class contains methods and data to manage a single instance
      server-tools/instance-manager/instance.h:
        This file contains class an instance class interface. The class is
        responsible for starting/stopping an instance
      server-tools/instance-manager/instance_map.cc:
        The instance repository. This class is also responsible for initialization
        of Instance class objects.
      server-tools/instance-manager/instance_options.cc:
        The Instance_options class contains all methods to get and  handle options
        of an instance
      server-tools/instance-manager/mysql_connection.cc:
        The class responsible for handling MySQL client/server protocol connections
      server-tools/instance-manager/mysql_manager_error.h:
        The list of Instance Manger-specific errors
      server-tools/instance-manager/parse.cc:
        Simple query parser
      server-tools/instance-manager/parse.h:
        Parser interface
      server-tools/instance-manager/protocol.cc:
        Here implemented functions used to handle mysql client/server protocol
      server-tools/instance-manager/protocol.h:
        Interface for MySQL client/server protocol
      server-tools/instance-manager/thread_registry.cc:
        Thread registry stores information about every thread. It's main function is
        to provide graceful shutdown for all threads.
      server-tools/instance-manager/user_map.h:
        User map contains hash with user names and passwords
      a5435ea7