1. 01 Dec, 2006 2 commits
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/mysql-5.0-4968 · 7c6fe6e7
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      tests/mysql_client_test.c:
        Manual merge.
      7c6fe6e7
    • unknown's avatar
      A fix and a test case for Bug#24179 "select b into $var" fails with · fe84b016
      unknown authored
      --cursor_protocol": fix a misleading error message in case of
      SELECT .. INTO.
      
      
      sql/sql_class.cc:
        Implement select_result::check_simple_select hierarchy to 
        support correct error messages in case of SELECT .. INTO and C API 
        cursors.
      sql/sql_class.h:
        Set the error message inside the function that checks for the error
        condition (simple_select, renamed to check_simple_select).
      sql/sql_prepare.cc:
        Use a new method that now sets the error.
      tests/mysql_client_test.c:
        Add a test case for Bug#24179 "select b into $var" fails with 
        --cursor_protocol" (check for the right error message and error code).
      fe84b016
  2. 30 Nov, 2006 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · c8100cba
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      c8100cba
    • unknown's avatar
      Bug #24487 Valgrind: uninited byte in table->record[1] in binlog code for rbr + inno db · f8d8b3db
      unknown authored
      The reason of this valgrind's compaint is not a bug but rather a feature of bitwise ops:
      for any value of the byte x
      x | 1 -> 1,  and x & 0 -> 0.
      x, being a null_byte part of record[1] can be left unassigned even after
      ha_innobase::index_read_idx because the above and still be correct.
      Addding a check memory upon the invocation of the function can detect this fact
      long before record[1], old record, is eventually passed to my_write.
      
      Fixed with initialization of record[1]'s null_bytes part in open_table_from_share.
      
      
      sql/table.cc:
        initialization of null-bytes for valgrind.
      f8d8b3db
    • unknown's avatar
      Fix for the following bugs: · 23776f53
      unknown authored
        - BUG#22306: STOP INSTANCE can not be applied for instances in Crashed,
          Failed and Abandoned;
        - BUG#23476: DROP INSTANCE does not work
        - BUG#23215: STOP INSTANCE takes too much time
      
      BUG#22306:
      The problem was that STOP INSTANCE checked that mysqld is up and running.
      If it was not so, STOP INSTANCE reported an error. Now, STOP INSTANCE
      reports an error if the instance has been started (mysqld can be down).
      
      BUG#23476:
      The problem was that DROP INSTANCE tried to stop inactive instance. The fix is
      trivial.
      
      BUG#23215:
      The problem was that locks were not acquired properly, so the
      instance-monitoring thread could not acquire the mutex, holded by the
      query-processing thread.
      
      The fix is to simplify locking scheme by moving instance-related information to
      Instance-class out of Guardian-class. This allows to get rid of storing a
      separate list of Instance-information in Guardian and keeping it synchronized
      with the original list in Instance_map.
      
      
      server-tools/instance-manager/commands.cc:
        1. Introduce Instance_cmd class -- base class for the commands
           that deal with the one instance;
        2. Remove Instance_map argument from command constructors;
        3. Ensure, that Instance Map and Instance are locked in the proper order;
        4. Polishing.
      server-tools/instance-manager/commands.h:
        1. Introduce Instance_cmd class -- base class for the commands
           that deal with the one instance;
        2. Remove Instance_map argument from command constructors;
        3. Polishing.
      server-tools/instance-manager/guardian.cc:
        1. Move "extended" instance information to the Instance-class.
           That allows to get rid of storing instance-related container and data in
           Guardian class, that significantly simplifies locking schema.
        2. Polishing.
      server-tools/instance-manager/guardian.h:
        1. Move "extended" instance information to the Instance-class.
           That allows to get rid of storing instance-related container and data in
           Guardian class, that significantly simplifies locking schema.
        2. Polishing.
      server-tools/instance-manager/instance.cc:
        1. Move "extended" instance information to the Instance-class.
        2. Introduce new state STOPPED to mark that guarded instance
           is stopped and should not be restarted by Guardian.
        3. Polishing.
      server-tools/instance-manager/instance.h:
        1. Move "extended" instance information to the Instance-class.
        2. Introduce new state STOPPED to mark that guarded instance
           is stopped and should not be restarted by Guardian.
        3. Polishing.
      server-tools/instance-manager/instance_map.cc:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/instance_map.h:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/instance_options.h:
        Polishing.
      server-tools/instance-manager/manager.cc:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/manager.h:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/user_map.cc:
        Polishing.
      23776f53
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 46fd7dec
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-arch
      
      
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      46fd7dec
    • unknown's avatar
      A post-merge fix: fix the failing trigger-grant.test. · 6949b042
      unknown authored
      
      sql/sql_trigger.cc:
        Another post-merge fix: make TRIGGER privilege work again, after
        IF EXISTS refactoring.
      6949b042
  3. 29 Nov, 2006 28 commits
    • unknown's avatar
      A post-merge fix. · 21fdaf5e
      unknown authored
      
      mysql-test/r/func_str.result:
        Update results (a post-merge fix).
      21fdaf5e
    • unknown's avatar
      A post-merge fix. · 0717e6c3
      unknown authored
      0717e6c3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 126375b1
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/lib/mtr_io.pl:
        Auto merged
      mysql-test/r/im_daemon_life_cycle.result:
        Auto merged
      mysql-test/r/im_life_cycle.result:
        Auto merged
      mysql-test/r/rpl_trigger.result:
        Auto merged
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/im_daemon_life_cycle.imtest:
        Auto merged
      mysql-test/t/im_life_cycle.imtest:
        Auto merged
      mysql-test/t/im_utils.imtest:
        Auto merged
      mysql-test/t/rpl_trigger.test:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/lib/mtr_process.pl:
        Use local.
      mysql-test/r/func_str.result:
        SCCS merged
      mysql-test/t/func_str.test:
        Manual merge.
      sql/sql_trigger.cc:
        Manual merge.
      sql/sql_yacc.yy:
        Manual merge.
      126375b1
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · 4ec84721
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      4ec84721
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · c670cad0
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      c670cad0
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · bfde6f3e
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      bfde6f3e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 73079a24
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-4.1-runtime
      
      
      73079a24
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 66b53b16
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      sql/sql_yacc.yy:
        Auto merged
      66b53b16
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · afc91556
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/r/udf.result:
        Auto merged
      mysql-test/t/udf.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      afc91556
    • unknown's avatar
      Many files: · 8f71610f
      unknown authored
        Changed paths to ndb include directory to include "storage"
      Makefile.am:
        Adjusted path to yaSSL libtool libraries
      ssl.m4:
        Use libtool way of specifying yaSSL libraries
      
      
      config/ac-macros/ssl.m4:
        Use libtool way of specifying yaSSL libraries
      libmysqld/Makefile.am:
        Adjusted path to yaSSL libtool libraries
      storage/ndb/config/type_kernel.mk.am:
        Changed paths to ndb include directory to include "storage"
      storage/ndb/config/type_ndbapi.mk.am:
        Changed paths to ndb include directory to include "storage"
      storage/ndb/config/type_ndbapitest.mk.am:
        Changed paths to ndb include directory to include "storage"
      storage/ndb/config/type_ndbapitools.mk.am:
        Changed paths to ndb include directory to include "storage"
      storage/ndb/config/type_util.mk.am:
        Changed paths to ndb include directory to include "storage"
      8f71610f
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 2477bd5a
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-arch
      
      
      configure.in:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      2477bd5a
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0 · bc3fe09a
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug20637
      
      
      sql/sql_yacc.yy:
        Auto merged
      bc3fe09a
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-bug20637 · b9567227
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug20637
      
      
      sql/sql_yacc.yy:
        Auto merged
      b9567227
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mysql-5.0-build · d6eb3627
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.1-build
      
      
      Docs/Makefile.am:
        Auto merged
      extra/yassl/taocrypt/benchmark/benchmark.dsp:
        Auto merged
      extra/yassl/taocrypt/taocrypt.dsp:
        Auto merged
      extra/yassl/taocrypt/taocrypt.vcproj:
        Auto merged
      extra/yassl/taocrypt/test.dsp:
        Auto merged
      extra/yassl/testsuite/testsuite.dsp:
        Auto merged
      extra/yassl/yassl.dsp:
        Auto merged
      extra/yassl/yassl.vcproj:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      mysql-test/t/type_newdecimal.test:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      strings/decimal.c:
        Auto merged
      d6eb3627
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.1 · e93a20a5
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.1-build
      
      
      sql-common/my_time.c:
        Auto merged
      e93a20a5
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 412d284e
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.1-build
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      412d284e
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mysql-4.1-build · ea7559ce
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0-build
      
      
      ea7559ce
    • unknown's avatar
      BUG#20637: "load data concurrent infile" locks the table · c707c7ea
      unknown authored
      Note that we ignore CONCURRENT if LOAD DATA CONCURRENT is used from
      inside a stored routine and MySQL is compiled with Query Cache support
      (this is not in the manual).
      
      The problem was that the condition test of "we are inside stored routine"
      was reversed, thus CONCURRENT _worked only_ from stored routine.  The
      solution is to use proper condition test.
      
      No test case is provided because the test case would require a large
      amount of input, and it's hard to tell is SELECT is really blocked or
      just slow (subject to race).
      
      
      sql/sql_yacc.yy:
        Fix the condition of TL_WRITE_CONCURRENT_INSERT on LOAD DATA CONCURRENT,
        which was reversed, and return valid value if we are in SP.
      c707c7ea
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-4.1-build · d765ed0c
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-4.1-build-work
      
      
      d765ed0c
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build · e0bf8da9
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build-work
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      e0bf8da9
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build-work · b58adf2f
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      b58adf2f
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-4.1-build-work · abb3dfc4
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build-work
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      abb3dfc4
    • unknown's avatar
      minor fix · 3344298d
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        remove dependency on Data::Dumper, it's not used anywhere
      3344298d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · b51cf266
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/sql_parse.cc:
        Auto merged
      b51cf266
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 0e978328
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime-merge
      
      
      libmysql/libmysql.c:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      server-tools/instance-manager/mysql_connection.cc:
        Rollback Monty's removals of explicit casts
      tests/mysql_client_test.c:
        SCCS merged
      0e978328
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/mysql-4.1-runtime · b4b2d3bc
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      tests/mysql_client_test.c:
        Manual merge: use local.
      b4b2d3bc
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1 · 84d5733b
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      84d5733b
    • unknown's avatar
      Varchar hack to clean strings removed. · 0ec590fa
      unknown authored
      
      storage/archive/ha_archive.cc:
        Removed Varchar cleanup hack. I'm going to commit new pack code.
      0ec590fa
  4. 28 Nov, 2006 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 15584161
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/t/wait_for_socket.sh:
        Manual merge.
      sql/sql_cache.cc:
        Manual merge.
      15584161
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 760bd9d1
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-4.1-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      760bd9d1
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 19daf5d9
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-arch
      
      
      sql/field.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      storage/federated/ha_federated.cc:
        Auto merged
      storage/myisammrg/ha_myisammrg.cc:
        Auto merged
      plugin/fulltext/plugin_example.c:
        e
        C
      sql/field.h:
        e
      19daf5d9
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 269d32b6
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.1-build
      
      
      client/mysql_upgrade.c:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      269d32b6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · fe99bda8
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-24486
      
      
      sql/sql_parse.cc:
        Auto merged
      fe99bda8