1. 11 May, 2022 2 commits
  2. 10 May, 2022 2 commits
  3. 09 May, 2022 4 commits
  4. 08 May, 2022 4 commits
  5. 07 May, 2022 2 commits
  6. 06 May, 2022 12 commits
    • Daniel Black's avatar
      MDEV-27816: Set sql_mode before DROP IF EXISTS already (postfix) · 0db27eff
      Daniel Black authored
      Test compat/oracle.sp-package-mysqldump needed re-record.
      0db27eff
    • Andrei's avatar
      MDEV-28310 Missing binlog data for INSERT .. ON DUPLICATE KEY UPDATE · a5dc12ee
      Andrei authored
      MDEV-21810 MBR: Unexpected "Unsafe statement" warning for unsafe IODKU
      
      MDEV-17614 fixes to replication unsafety for INSERT ON DUP KEY UPDATE
      on two or more unique key table left a flaw. The fixes checked the
      safety condition per each inserted record with the idea to catch a user-created
      value to an autoincrement column and when that succeeds the autoincrement column
      would become the source of unsafety too.
      It was not expected that after a duplicate error the next record's
      write_set may become different and the unsafe decision for that
      specific record will be computed to screw the Query's binlogging
      state and when @@binlog_format is MIXED nothing gets bin-logged.
      
      This case has been already fixed in 10.5.2 by 91ab42a8 that
      relocated/optimized THD::decide_logging_format_low() out of the record insert
      loop. The safety decision is computed once and at the right time.
      Pertinent parts of the commit are cherry-picked.
      
      Also a spurious warning about unsafety is removed when MIXED
      @@binlog_format; original MDEV-17614 test result corrected.
      The original test of MDEV-17614 is extended and made more readable.
      a5dc12ee
    • Marko Mäkelä's avatar
    • Daniel Black's avatar
      MDEV-4875 Can't restore a mysqldump if --add-drop-database meets general_log · 221ced92
      Daniel Black authored
      or slow query log when the log_output=TABLE.
      
      When this happens, we temporary disable by changing log_output until
      we've created the general_log and slow_log tables again.
      
      Move </database> in xml mode until after the transaction_registry.
      
      General_log and slow_log tables where moved to be first to be dumped so
      that the disabling of the general/slow queries is minimal.
      221ced92
    • Hartmut Holzgraefe's avatar
      MDEV-27816 Set sql_mode before DROP IF EXISTS already · 9fe3bc2a
      Hartmut Holzgraefe authored
      Previously the correct SQL mode for a stored routine or
      package was only set before doing the CREATE part, this
      worked out for PROCEDUREs and FUNCTIONs, but with ORACLE
      mode specific PACKAGEs the DROP also only works in ORACLE
      mode.
      
      Moving the setting of the sql_mode a few lines up to happen
      right before the DROP statement is writen fixes this.
      9fe3bc2a
    • Marko Mäkelä's avatar
      MDEV-28484 InnoDB encryption key rotation is not being marked completed · f67d65e3
      Marko Mäkelä authored
      fil_crypt_flush_space(): Correct a condition that was refactored
      incorrectly in commit aaef2e1d
      f67d65e3
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 57a9626f
      Marko Mäkelä authored
      57a9626f
    • Oleksandr Byelkin's avatar
      MDEV-28402 ASAN heap-use-after-free in create_tmp_table, Assertion `l_offset... · 141ab971
      Oleksandr Byelkin authored
      MDEV-28402 ASAN heap-use-after-free in create_tmp_table, Assertion `l_offset >= 0 && table->s->rec_buff_length - l_offset > 0'
      
      Make default() function follow Item_field and use get_tmp_table_item() for
      change_to_use_tmp_fields().
      141ab971
    • Marko Mäkelä's avatar
      fd9e733a
    • Sergei Petrunia's avatar
      624cb973
    • Marko Mäkelä's avatar
      MDEV-28478: INSERT into SPATIAL INDEX in TEMPORARY table writes log · 26d46234
      Marko Mäkelä authored
      This is based on commit 20ae4816
      with some adjustments for MDEV-12353.
      
      row_ins_sec_index_entry_low(): If a separate mini-transaction is
      needed to adjust the minimum bounding rectangle (MBR) in the parent
      page, we must disable redo logging if the table is a temporary table.
      For temporary tables, no log is supposed to be written, because
      the temporary tablespace will be reinitialized on server restart.
      
      rtr_update_mbr_field(), rtr_merge_and_update_mbr(): Changed the return
      type to void and removed unreachable code. In older versions, these
      used to return a different value for temporary tables.
      
      page_id_t: Add constexpr to most member functions.
      
      mtr_t::log_write(): Catch log writes to invalid tablespaces
      so that the test case would crash without the fix to
      row_ins_sec_index_entry_low().
      26d46234
    • Marko Mäkelä's avatar
      MDEV-28478: INSERT into SPATIAL INDEX in TEMPORARY table writes log · 20ae4816
      Marko Mäkelä authored
      row_ins_sec_index_entry_low(): If a separate mini-transaction is
      needed to adjust the minimum bounding rectangle (MBR) in the parent
      page, we must disable redo logging if the table is a temporary table.
      For temporary tables, no log is supposed to be written, because
      the temporary tablespace will be reinitialized on server restart.
      
      rtr_update_mbr_field(): Plug a memory leak.
      20ae4816
  7. 05 May, 2022 5 commits
  8. 04 May, 2022 5 commits
    • Sergei Golubchik's avatar
      test fixes for FreeBSD · 53193599
      Sergei Golubchik authored
      * FreeBSD returns errno 31 (EMLINK, Too many links),
        not 40 (ELOOP, Too many levels of symbolic links)
      * (`mysqlbinlog|mysql`) was just crazy, why did it ever work?
      * socket_ipv6.inc check (that checked whether ipv6 is supported)
        only worked correctly when ipv6 was supported
      * perfschema.socket_summary_by_instance was changing global variables
        and then skip-ing the test (because on missing ipv6)
      53193599
    • Anel Husakovic's avatar
      MDEV-28391: table_exists procedure fails when arguments contain escaped... · 06a4193c
      Anel Husakovic authored
      MDEV-28391: table_exists procedure fails when arguments contain escaped backticks as an quoted identifiers
      
      - When arguments to the procedure contain quote in the name, procedure fails with parsing error.
        The reason was because additional quoting is done when testing TEMPORARY table with the same name.
      - Reviewed by: <wlad@mariadb.com>
      06a4193c
    • Sergei Petrunia's avatar
      MDEV-19398: Assertion `item1->type() == Item::FIELD_ITEM ... · ba4927e5
      Sergei Petrunia authored
      Window Functions code tries to minimize the number of times it
      needs to sort the select's resultset by finding "compatible"
      OVER (PARTITION BY ... ORDER BY ...) clauses.
      
      This employs compare_order_elements(). That function assumed that
      the order expressions are Item_field-derived objects (that refer
      to a temp.table). But this is not always the case: one can
      construct queries order expressions are arbitrary item expressions.
      
      Add handling for such expressions: sort them according to the window
      specification they appeared in.
      This means we cannot detect that two compatible PARTITION BY clauses
      that use expressions can share the sorting step.
      But at least we won't crash.
      ba4927e5
    • Vlad Lesin's avatar
      MDEV-17843 Assertion `page_rec_is_leaf(rec)' failed in lock_rec_queue_validate... · 2c381d8c
      Vlad Lesin authored
      MDEV-17843 Assertion `page_rec_is_leaf(rec)' failed in lock_rec_queue_validate upon SHOW ENGINE INNODB STATUS
      
      lock_validate() accumulates page ids under locked lock_sys->mutex, then
      releases the latch, and invokes lock_rec_block_validate() for each page.
      Some other thread has ability to add/remove locks and change pages
      between releasing the latch in lock_validate() and acquiring it in
      lock_rec_validate_page().
      
      lock_rec_validate_page() can invoke lock_rec_queue_validate() for
      non-locked supremum, what can cause ut_ad(page_rec_is_leaf(rec)) failure
      in lock_rec_queue_validate().
      
      The fix is to invoke lock_rec_queue_validate() only for locked records
      in lock_rec_validate_page().
      
      The error message in lock_rec_block_validate() is not necessary as
      BUF_GET_POSSIBLY_FREED mode is used to get block from buffer pool, and
      this is not error if a block was evicted.
      
      The test case would require new debug sync point. I think it's not
      necessary as the fixed code is debug-only.
      2c381d8c
    • anel's avatar
      Use proper pid namespace · 794bebf9
      anel authored
          Problem:
          ==============
          By testing `pgrep` with `--ns` option,
          introduced with MDEV-21331, commit fb7c1b94,
          I noted that:
          a) `--ns`  cannot use more than single PID.
          b) `--ns` is returning the processes of the namespace to which supplied PID belongs to.
          So by that sense command `pgrep -x --ns $$ mysqld` will always return an error and skip
          checking of the existing PID of the server.
      
          Solution:
          ==============
          Suggested solution is to add `--nslist pid`, since `--ns` needs to know in which namespace type it should look for.
          See `pgrep --help` for different namespace types.
          Note also that this works *only* if script is run as a `root` (we have that case here).
      
          Current PR is a part of:
          1. MDEV-21331: sync preinst and postrm script
          2. MDEV-15718: check for exact mysqld process
      
          This commit:
          a) fixes fb7c1b94
          b) Closes PR #2068 (obsolete)
          c) Closes PR #2069 (obsolete)
      
          Thanks Faustin Lammler <faustin@mariadb.org> for testing and verifying
          Reviewed by <>
      794bebf9
  9. 03 May, 2022 4 commits
    • Marko Mäkelä's avatar
      MDEV-28465 Some calls to btr_pcur_close() are unnecessary · bc113b87
      Marko Mäkelä authored
      The function btr_pcur_close() is being invoked on local variables
      even when no cleanup needs to be done. In particular, for B-tree
      indexes (not SPATIAL INDEX), unless btr_pcur_store_position()
      was invoked in the past, there is no need to invoke btr_pcur_close().
      
      On purge and rollback, we will retain btr_pcur_close(&pcur)
      because otherwise some ./mtr --suite=innodb_gis tests would leak memory.
      bc113b87
    • Marko Mäkelä's avatar
      c844a588
    • Marko Mäkelä's avatar
      MDEV-28454 Latching order violation (and hang) in ibuf_insert_low · caa985e6
      Marko Mäkelä authored
      Since commit 2ca11234 (MDEV-26217)
      the function trx_t::commit(std::vector<pfs_os_file_t>&)
      holds exclusive lock_sys.latch while invoking fil_delete_tablespace(),
      which in turn may wait for change buffer tree latches in
      ibuf_delete_for_discarded_space().
      
      ibuf_insert_low(): If a shared lock_sys.latch cannot be acquired
      without waiting, refuse to buffer the insert. In this way, a
      deadlock with a DDL operation will be avoided.
      
      ibuf_insert_to_index_page(), ibuf_delete(): Remove redundant calls to
      record locking. In ibuf_insert_low() we already ensured that no record
      locks existed on the page. No locks can be added before the buffered
      changes have been merged.
      caa985e6
    • Oleksandr Byelkin's avatar
      Merge branch '10.2' into 10.3 · 9614fde1
      Oleksandr Byelkin authored
      9614fde1