1. 16 Jul, 2007 1 commit
  2. 13 Jul, 2007 1 commit
    • tnurnberg@sin.intern.azundris.com's avatar
      Bug#27198: Error returns from time() are ignored · 5cbe511f
      tnurnberg@sin.intern.azundris.com authored
      gettimeofday() can fail and presumably, so can time().
      Keep an eye on it.
      
      Since we have no data on this at all so far, we just
      retry on failure (and log the event), assuming that
      this is just an intermittant failure. This might of
      course hang the threat until we succeed. Once we know
      more about these failures, an appropriate more clever
      scheme may be picked (only try so many times per thread,
      etc., if that fails, return last "good" time() we got or
      some such).  Using sql_print_information() to log as this
      probably only occurs in high load scenarios where the debug-
      trace likely is disabled (or might interfere with testing
      the effect).  No test-case as this is a non-deterministic
      issue.
      5cbe511f
  3. 09 Jul, 2007 1 commit
  4. 07 Jul, 2007 1 commit
  5. 06 Jul, 2007 2 commits
  6. 05 Jul, 2007 1 commit
  7. 04 Jul, 2007 1 commit
  8. 03 Jul, 2007 4 commits
    • gshchepa/uchum@gleb.loc's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 0e8292c9
      gshchepa/uchum@gleb.loc authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      0e8292c9
    • gshchepa/uchum@gleb.loc's avatar
      loaddata.result, loaddata.test: · 1f85dac2
      gshchepa/uchum@gleb.loc authored
        Test case update for bug #29294.
      1f85dac2
    • gshchepa/uchum@gleb.loc's avatar
      sql_class.cc: · 5f592984
      gshchepa/uchum@gleb.loc authored
        Windows compilation error fix.
      5f592984
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #29294. · dbe4fb94
      gshchepa/uchum@gleb.loc authored
      The `SELECT 'r' INTO OUTFILE ... FIELDS ENCLOSED BY 'r' ' statement
      encoded the 'r' string to a 4 byte string of value x'725c7272'
      (sequence of 4 characters: r\rr).
      The LOAD DATA statement decoded this string to a 1 byte string of
      value x'0d' (ASCII Carriage Return character) instead of the original
      'r' character.
      The same error also happened with the FIELDS ENCLOSED BY clause
      followed by special characters: 'n', 't', 'r', 'b', '0', 'Z' and 'N'.
      
      NOTE 1: This is a result of the undocumented feature: the LOAD DATA INFILE
      recognises 2-byte input sequences like \n, \t, \r and \Z in addition
      to documented 2-byte sequences: \0 and \N. This feature should be
      documented (here backspace character is a default ESCAPED BY character,
      in the real-life example it may be any ESCAPED BY character).
      
      NOTE 2, changed behaviour:
      Now the `SELECT INTO OUTFILE' statement with the `FIELDS ENCLOSED BY'
      clause followed by one of: 'n', 't', 'r', 'b', '0', 'Z' or 'N' characters
      encodes this special character itself by doubling it ('r' --> 'rr'),
      not by prepending it with an escape character.
      dbe4fb94
  9. 26 Jun, 2007 2 commits
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #29251. · f8bf427b
      gshchepa/uchum@gleb.loc authored
      Sometimes special 0 ENUM values was ALTERed to normal
      empty string ENUM values.
      
      Special 0 ENUM value has the same string representation
      as normal ENUM value defined as '' (empty string).
      The do_field_string function was used to convert
      ENUM data at an ALTER TABLE request, but this
      function doesn't care about numerical "indices" of
      ENUM values, i.e. do_field_string doesn't distinguish
      a special 0 value from an empty string value.
      
      A new copy function called do_field_enum has been added to
      copy special 0 ENUM values without conversion to an empty
      string.
      f8bf427b
    • tsmith@maint1.mysql.com's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/41 · 2bfa624a
      tsmith@maint1.mysql.com authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      2bfa624a
  10. 25 Jun, 2007 1 commit
  11. 23 Jun, 2007 1 commit
  12. 22 Jun, 2007 1 commit
  13. 20 Jun, 2007 1 commit
  14. 19 Jun, 2007 4 commits
  15. 18 Jun, 2007 6 commits
  16. 15 Jun, 2007 1 commit
  17. 14 Jun, 2007 2 commits
  18. 13 Jun, 2007 8 commits
  19. 12 Jun, 2007 1 commit
    • cmiller@zippy.cornsilk.net's avatar
      Bug#28984: crasher on connect with out of range password length in \ · 4c9af559
      cmiller@zippy.cornsilk.net authored
      	protocol
      
      Fixed duplicated code, same as last commit.
      
      One could send a malformed packet that caused the server to SEGV.  In 
      recent versions of the password protocol, the client tells the server 
      what length the ciphertext is (almost always 20).  If that length was
      large enough to overflow a signed char, then the number would jump to 
      very large after being casted to unsigned int.
      
      Instead, cast the *passwd char to uchar.
      4c9af559