1. 21 Dec, 2019 5 commits
  2. 20 Dec, 2019 1 commit
  3. 19 Dec, 2019 1 commit
  4. 18 Dec, 2019 1 commit
  5. 17 Dec, 2019 2 commits
  6. 16 Dec, 2019 4 commits
    • Marko Mäkelä's avatar
      MDEV-21174: Fix the WITH_INNODB_EXTRA_DEBUG build · c24253d0
      Marko Mäkelä authored
      One reference to PageConverter::m_page_zip_ptr was not adjusted
      commit 745fd4b3 when the
      data member was removed.
      c24253d0
    • Marko Mäkelä's avatar
      MDEV-16678: Actually ignore #sql-ib tables · 89633995
      Marko Mäkelä authored
      Apparently, regular expression operations that remove entire lines
      of output do not work with list_files, and hence the adjustments in
      commit 1c282d4b were ineffective.
      
      For cat_file (preceded by list_files_write_file) the replace_regex
      does work.
      
      For some reason, for suite/parts/inc/partition_crash_exchange.inc
      some file names will be lost when using list_files_write_file
      instead of list_files.
      
      We use a precise pattern match. dict_mem_create_temporary_tablename()
      is generating #sql-ib names followed by decimal digits only.
      89633995
    • Teemu Ollakka's avatar
      Update wsrep-lib. (#1426) · 67e063eb
      Teemu Ollakka authored
      This commit updates the wsrep-lib. The changes are a cleanup in
      client_state TOI processing and stub methods for future extensions.
      67e063eb
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 28c89b71
      Marko Mäkelä authored
      28c89b71
  7. 13 Dec, 2019 8 commits
  8. 12 Dec, 2019 8 commits
    • Eugene Kosov's avatar
      MDEV-20950 Reduce size of record offsets · f0aa073f
      Eugene Kosov authored
      offset_t: this is a type which represents one record offset.
      It's unsigned short int.
      
      a lot of functions: replace ulint with offset_t
      
      btr_pcur_restore_position_func(),
      page_validate(),
      row_ins_scan_sec_index_for_duplicate(),
      row_upd_clust_rec_by_insert_inherit_func(),
      row_vers_impl_x_locked_low(),
      trx_undo_prev_version_build():
        allocate record offsets on the stack instead of waiting for rec_get_offsets()
        to allocate it from mem_heap_t. So, reducing  memory allocations.
      
      RECORD_OFFSET, INDEX_OFFSET:
        now it's less convenient to store pointers in offset_t*
        array. One pointer occupies now several offset_t. And those constant are start
        indexes into array to places where to store pointer values
      
      REC_OFFS_HEADER_SIZE: adjusted for the new reality
      
      REC_OFFS_NORMAL_SIZE:
        increase size from 100 to 300 which means less heap allocations.
        And sizeof(offset_t[REC_OFFS_NORMAL_SIZE]) now is 600 bytes which
        is smaller than previous 800 bytes.
      
      REC_OFFS_SEC_INDEX_SIZE: adjusted for the new reality
      
      rem0rec.h, rem0rec.ic, rem0rec.cc:
        various arguments, return values and local variables types were changed to
        fix numerous integer conversions issues.
      
      enum field_type_t:
        offset types concept was introduces which replaces old offset flags stuff.
        Like in earlier version, 2 upper bits are used to store offset type.
        And this enum represents those types.
      
      REC_OFFS_SQL_NULL, REC_OFFS_MASK: removed
      
      get_type(), set_type(), get_value(), combine():
        these are convenience functions to work with offsets and it's types
      
      rec_offs_base()[0]:
        still uses an old scheme with flags REC_OFFS_COMPACT and REC_OFFS_EXTERNAL
      
      rec_offs_base()[i]:
        these have type offset_t now. Two upper bits contains type.
      f0aa073f
    • Eugene Kosov's avatar
      optimize crash recovery · 014e1258
      Eugene Kosov authored
      recv_dblwr_t::list is used for appending to the beginning and iterating
      through its elements. std::deque fits better for that purpose because
      it does less allocations than std::forward_list and provides better memory
      locality.
      014e1258
    • Eugene Kosov's avatar
      fix a memory leak introduced by f4b42846 · ce41a907
      Eugene Kosov authored
      ce41a907
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 0a20e5ab
      Marko Mäkelä authored
      0a20e5ab
    • Alexander Barkov's avatar
      MDEV-20667 Server crash on pop_cursor · e0f9540b
      Alexander Barkov authored
      When backpatching a forward GOTO label, the old code erroneously
      used CURSOR/HANDLER difference between context frames "c" and "a" to tune
      a cpop/hpop command. So the cpop/hpop command later tried to pop
      all cursors/handlers declared between "a" and "c", but those between
      "b" and "c" were not cpushed/hpoped yet during the execution of "GOTO x".
      
      Fixing the code to use the difference between frames "b" and "a" only.
      
      BEGIN     -- a
       ...
      GOTO x;   -- b
       ...
      <<x>>     -- c
       ...
      END       -- d
      e0f9540b
    • Vladislav Vaintroub's avatar
      MDEV-21260 Innodb/Wjndows do not report error when trying open volumes on UNC paths · 3304004a
      Vladislav Vaintroub authored
      fil_node_t::find_metadata() tries to find out whether file
      is on an SSD, and the disk sector size.
      On Windows, it opens the corresponding volume for finding this data.
      
      This does not go well, if datadir is on network path/UNC. The volume name
      is invalid, CreateFile() function fails, and a cryptic (from the end user
      perspective) error is reported. Like this
      
      [ERROR] InnoDB: File \\.\\\workpc\work: 'CreateFile()' returned OS error 203.
      
      The fix is not to report error if open volume failed, and the path was not
      on fixed disk, i.e not on HDD or SSD. This is not a fatal error, there is
      a fallback anyway.
      3304004a
    • Vladislav Vaintroub's avatar
      git ignore generated stuff · 71e47f34
      Vladislav Vaintroub authored
      71e47f34
    • Vlad Lesin's avatar
      MDEV-21255: Deadlock of parallel slave and mariabackup (with failed log · beec9c0e
      Vlad Lesin authored
      copy thread)
      
      mariabackup hangs waiting until innodb redo log thread read log till certain
      LSN, and it waits under FTWRL. If there is redo log read error in the thread,
      it is finished, and main thread knows nothing about it, what leads to hanging.
      As it hangs under FTWRL, slave threads on server side can be blocked due
      to MDL lock conflict.
      
      The fix is to finish mariabackup with error message on innodb redo log read
      failure.
      beec9c0e
  9. 11 Dec, 2019 8 commits
  10. 10 Dec, 2019 2 commits
    • Marko Mäkelä's avatar
      Cleanup test sys_vars.innodb_buffer_pool_size_basic · f2d3b2ee
      Marko Mäkelä authored
      When using huge pages, the innodb_buffer_pool_size cannot necessarily
      be restored. Simplify things by restarting the server.
      f2d3b2ee
    • Marko Mäkelä's avatar
      MDEV-14482 - Cache line contention on ut_rnd_interval() · 41e6a154
      Marko Mäkelä authored
      InnoDB RNG maintains global state, causing otherwise unnecessary bus
      traffic. Even worse, this is cross-mutex traffic. That is, different
      mutexes suffer from contention.
      
      Fixed delay of 4 was verified to give best throughput by OLTP update
      index and read-write benchmarks on Intel Broadwell (2/20/40) and
      ARM (1/46/46).
      
      This is a backport of ce047900 from
      MariaDB Server 10.3.
      41e6a154