1. 23 Oct, 2007 3 commits
  2. 22 Oct, 2007 5 commits
  3. 19 Oct, 2007 7 commits
  4. 18 Oct, 2007 12 commits
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-base · bf5bcb84
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
      
      
      client/mysqlcheck.c:
        Auto merged
      client/mysqltest.c:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/udf.result:
        Auto merged
      mysql-test/t/udf.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      bf5bcb84
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-base · d9274610
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
      
      
      mysql-test/r/udf.result:
        Auto merged
      mysql-test/t/udf.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/udf_example.c:
        Auto merged
      sql/udf_example.def:
        Auto merged
      d9274610
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p1-bug31473.1 · 8d923eb5
      unknown authored
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p1-bug31473.1-merge-5.1-engines
      
      
      8d923eb5
    • unknown's avatar
      Bug#31473 · 57600b02
      unknown authored
        "CSV does not work with NULL value in datetime fields"
        Attempting to insert a row with a NULL value for a DATETIME field
        results in a CSV file which the storage engine cannot read.
        Don't blindly assume that "0" is acceptable for all field types,
        Since CSV does not support NULL, we find out from the field the
        default non-null value.
        Do not permit the creation of a table with a nullable columns.
      
      
      mysql-test/r/csv.result:
        test for bug 31473
      mysql-test/r/log_tables.result:
        change in results due to bugfix 31473
      mysql-test/r/system_mysql_db.result:
        change in results due to bugfix 31473
      mysql-test/t/csv.test:
        test for bug 31473
      mysql-test/t/log_tables.test:
        due to bug31473, all columns in CSV tables must be declared as NOT NULL
      scripts/mysql_system_tables.sql:
        due to bug31473, all columns in CSV tables must be declared as NOT NULL
      storage/csv/ha_tina.cc:
        bug31473
          Don't blindly assume that "0" is acceptable for all field types,
          Since CSV does not support NULL, we find out from the field the
          default non-null value.
          Do not permit the creation of a table with a nullable columns;
      57600b02
    • unknown's avatar
      Merge moksha.com.br:/Users/davi/mysql/bugs/21557-5.1 · 6f2d5b30
      unknown authored
      into  moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
      
      
      6f2d5b30
    • unknown's avatar
      Post merge fix for Bug 21557 · 7ae94a68
      unknown authored
      
      mysql-test/r/log_tables.result:
        Update test result, general_log disabled.
      mysql-test/t/log_tables.test:
        Disable the general_log before consulting it.
      7ae94a68
    • unknown's avatar
      Merge moksha.com.br:/Users/davi/mysql/bugs/21557-5.1 · 42d4be2c
      unknown authored
      into  moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
      
      
      sql/sp_head.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      42d4be2c
    • unknown's avatar
      Bug#21557 entries in the general query log truncated at 1000 characters. · b9b481ec
      unknown authored
      The general log write function (general_log_print) uses printf style
      arguments which need to be pre-processed, meaning that the all arguments
      are copied to a single buffer and the problem is that the buffer size is
      constant (1022 characters) but queries can be much larger then this.
      
      The solution is to introduce a new log write function that accepts a
      buffer and it's length as arguments. The function is to be used when
      a formatted output is not required, which is the case for almost all
      query write-to-log calls.
      
      This is a incompatible change with respect to the log format of prepared
      statements.
      
      
      mysql-test/r/log_tables.result:
        Add test case result for Bug#21557
      mysql-test/t/log_tables.test:
        Add test case for Bug#21557
      sql/log.cc:
        Introduce the logger function general_log_write which is similar to
        general_log_print but accepts a single buffer and the buffer length.
        The function doesn't perform any formatting and sends the buffer
        directly to the underlying log handlers.
      sql/log.h:
        Introduce the logger function general_log_write.
      sql/log_event.cc:
        Pass the query buffer directly to the logger function, formatting
        is not required on this case.
      sql/mysql_priv.h:
        Prototype for the logger function general_log_write.
      sql/sp_head.cc:
        Pass the query buffer directly to the logger function, formatting
        is not required on this case.
      sql/sql_parse.cc:
        Pass the buffer directly to the logger function when formatting
        is not required.
      sql/sql_prepare.cc:
        Don't log the statement id, it avoids making a extra copy of the query
        and the query is not truncated anymore if it exceeds the limit.
      b9b481ec
    • unknown's avatar
      Bug#31692 - binlog_killed.test crashes sometimes · bf82c2f9
      unknown authored
      The server crashed when a thread was killed while locking the
      general_log table at statement begin.
      
      The general_log table is handled like a performance schema table.
      The state of open tables is saved and cleared so that this table
      seems to be the only open one. Then this table is opened and locked.
      After writing, the table is closed and the open table state is
      restored. Before restoring, however, it is asserted that there is
      no current table open.
      
      After locking the table, mysql_lock_tables() checks if the thread
      was killed in between. If so, it unlocks the table and returns an
      error. open_ltable() just returns with the error and leaves closing
      of the table to close_thread_tables(), which is called at
      statement end.
      
      open_performance_schema_table() did not take this into account.
      It assumed that a failed open_ltable() would not leave an open
      table behind.
      
      Fixed by closing thread tables after open_ltable() and before
      restore_backup_open_tables_state() if the thread was killed.
      
      No test case. It requires correctly timed parallel execution.
      Since this bug was detected by the test suite, it seems
      dispensable to add another test.
      
      
      sql/sql_base.cc:
        Bug#31692 - binlog_killed.test crashes sometimes
        Closing thread tables after open_ltable() and before
        restore_backup_open_tables_state() if the thread was killed.
      bf82c2f9
    • unknown's avatar
      Post-merge changes for bug #31207: Test "join_nested" shows different strategy... · 89810417
      unknown authored
      Post-merge changes for bug #31207: Test "join_nested" shows different strategy on IA64 CPUs / Intel's ICC compiler.
      
      
      
      89810417
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/mysql-5.0-maint · ddaecb21
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.1-maint
      
      
      include/my_sys.h:
        Auto merged
      libmysql/Makefile.shared:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/records.cc:
        Auto merged
      sql/sql_array.h:
        Auto merged
      sql/sql_help.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      storage/myisam/ft_boolean_search.c:
        Auto merged
      storage/myisam/ft_nlq_search.c:
        Auto merged
      storage/myisam/myisampack.c:
        Auto merged
      mysys/mf_keycache.c:
        Manual merge.
      mysys/mf_sort.c:
        Manual merge.
      mysys/my_lib.c:
        Manual merge.
      mysys/queues.c:
        Manual merge.
      sql/sql_acl.cc:
        Manual merge.
      sql/sql_table.cc:
        Manual merge.
      storage/csv/ha_tina.cc:
        Manual merge.
      storage/myisam/sort.c:
        Manual merge.
      ddaecb21
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/bug31207/my50-bug31174 · 85f9df83
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      
      myisam/sort.c:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      85f9df83
  5. 17 Oct, 2007 13 commits
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/udf50 · f8c436d6
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql-5.1-runtime
      
      
      mysql-test/r/udf.result:
        Auto merged
      mysql-test/t/udf.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/udf_example.def:
        Auto merged
      sql/udf_example.c:
        null merge
      f8c436d6
    • unknown's avatar
      Bug #29804 UDF parameters don't contain correct string length · 367fc73e
      unknown authored
          
      Previously, UDF *_init functions were passed constant strings with erroneous lengths. The length came from the containing variable's size, not the length of the value itself.
          
      Now the *_init functions get the constant as a null terminated string with the correct length supplied too.
      
      
      mysql-test/r/udf.result:
        Test case to check constants passed UDFs.
      mysql-test/t/udf.test:
        Test case to check constants passed UDFs.
      sql/item_func.cc:
        UDF _init functions are now passed the length of the constants, rather than the max length of the var containing the constant.
      sql/udf_example.c:
        Added check_const_len functions. The check_const_len_init functions checks that lengths of constants are correctly passed.
      sql/udf_example.def:
        Add new example functions to windows dll export list.
      367fc73e
    • unknown's avatar
      Merge moksha.com.br:/Users/davi/mysql/bugs/31608-5.1 · c0d2ce4c
      unknown authored
      into  moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
      
      
      c0d2ce4c
    • unknown's avatar
      Bug#31608 missing mysqltest change_user command · e5125728
      unknown authored
      Post merge fixes: close any open statement before
      the change user command and fix test case output.
      
      
      client/mysqltest.c:
        Close an open statement since it won't work after a change_user command.
      mysql-test/r/change_user.result:
        Fixed test case output.
      mysql-test/t/change_user.test:
        Fix test case output to return 1 or 0.
      e5125728
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 9014e8e9
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      libmysql/libmysql.c:
        Auto merged
      9014e8e9
    • unknown's avatar
      Fix syntax error build problem on Windows (variable was defined · a634d1bf
      unknown authored
      in middle of block)
      
      
      libmysql/libmysql.c:
        Fix syntax error - don't define new variables in the middle of a block.
        
        Also, use size_t instead of uint to avoid unnecessary casting.
      a634d1bf
    • unknown's avatar
      Merge moksha.com.br:/Users/davi/mysql/bugs/31608-5.1 · eea87d9e
      unknown authored
      into  moksha.com.br:/Users/davi/mysql/mysql-5.1-runtime
      
      
      eea87d9e
    • unknown's avatar
      Fix for bug #31207: Test "join_nested" shows different strategy on IA64 · ce8bf087
      unknown authored
      CPUs / Intel's ICC compile
      
      The bug is a combination of two problems:
      
      1. IA64/ICC MySQL binaries use glibc's qsort(), not the one in mysys.
      
      2. The order relation implemented by join_tab_cmp() is not transitive,
      i.e. it is possible to choose such a, b and c that (a < b) && (b < c)
      but (c < a). This implies that result of a sort using the relation
      implemented by join_tab_cmp() depends on the order in which
      elements are compared, i.e. the result is implementation-specific. Since
      choose_plan() uses qsort() to pre-sort the
      join tables using join_tab_cmp() as a compare function, the results of
      the sorting may vary depending on qsort() implementation.
      
      It is neither possible nor important to implement a better ordering
      algorithm in join_tab_cmp(). Therefore the only way to fix it is to
      force our own qsort() to be used by renaming it to my_qsort(), so we don't depend
      on linker to decide that.
      
      This patch also "fixes" bug #20530: qsort redefinition violates the
      standard.
      
      
      include/my_sys.h:
        Renamed qsort() and qsort2() to my_qsort() and my_qsort2(). Since
        previously we relied on stdlib.h to provide a declaration for qsort(), a
        separate declaration for my_qsort() is now required.
      libmysql/Makefile.shared:
        Added mf_qsort.c to libmysql, since my_lib.c now uses my_qsort() instead of qsort().
      myisam/ft_boolean_search.c:
        Replaced qsort2() with my_qsort2().
      myisam/ft_nlq_search.c:
        Replaced qsort2() with my_qsort2().
      myisam/myisampack.c:
        Replaced qsort() with my_qsort().
      myisam/sort.c:
        Replaced qsort2() with my_qsort2().
      mysys/mf_keycache.c:
        Replaced qsort() with my_qsort().
      mysys/mf_qsort.c:
        Renamed qsort() to my_qsort() and qsort2() to my_qsort2().
      mysys/mf_sort.c:
        Replaced qsort2() with my_qsort2().
      mysys/my_lib.c:
        Replaced qsort() with my_qsort().
      mysys/queues.c:
        Replaced qsort2() with my_qsort2().
      sql/item_cmpfunc.cc:
        Replaced qsort2() with my_qsort2().
      sql/item_cmpfunc.h:
        Replaced qsort2() with my_qsort2().
      sql/opt_range.cc:
        Replaced qsort() with my_qsort().
      sql/records.cc:
        Replaced qsort() with my_qsort().
      sql/sql_acl.cc:
        Replaced qsort() with my_qsort().
      sql/sql_array.h:
        Replaced qsort() with my_qsort().
      sql/sql_help.cc:
        Replaced qsort() with my_qsort().
      sql/sql_select.cc:
        Replaced qsort() with my_qsort().
      sql/examples/ha_tina.cc:
        Replaced qsort() with my_qsort().
      sql/sql_table.cc:
        Replaced qsort() with my_qsort().
      ce8bf087
    • unknown's avatar
      Fix result files (BUG#24923). · 3fe4de96
      unknown authored
      3fe4de96
    • unknown's avatar
      Fix for BUG#24923: Functions with ENUM issues. · 9e1604a4
      unknown authored
      The problem was that the RETURNS column in the mysql.proc was of
      CHAR(64). That was not enough for storing long-named datatypes.
      
      The fix is to change CHAR(64) to LONGBLOB, and to throw warnings
      at the time a stored routine is created if some data is truncated
      during writing into mysql.proc.
      
      
      mysql-test/r/sp.result:
        Update test result.
      mysql-test/t/sp.test:
        Add a test case for BUG#24923.
      scripts/mysql_system_tables.sql:
        Change the data type of column 'returns' from char(64) to longblob.
      scripts/mysql_system_tables_fix.sql:
        Change the data type of column 'returns' from char(64) to longblob.
      sql/sp.cc:
        Produce warnings if any data was truncated during writing
        into mysql.proc.
      sql/sp.h:
        Add new error code.
      sql/share/errmsg.txt:
        Add new error message.
      sql/sql_parse.cc:
        Hande
      9e1604a4
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/mysql-5.0-maint · d5cf878e
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.1-maint
      
      
      mysql-test/r/repair.result:
        Auto merged
      mysql-test/t/repair.test:
        Auto merged
      d5cf878e
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/mysql-4.1-maint · d73ab388
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      
      mysql-test/r/repair.result:
        Auto merged
      mysql-test/t/repair.test:
        Auto merged
      d73ab388
    • unknown's avatar