1. 07 Apr, 2019 3 commits
  2. 06 Apr, 2019 9 commits
    • Marko Mäkelä's avatar
      MDEV-12699 preparation: Clean up recv_sys · 1d30b7b1
      Marko Mäkelä authored
      The recv_sys data structures are accessed not only from the thread
      that executes InnoDB plugin initialization, but also from the
      InnoDB I/O threads, which can invoke recv_recover_page().
      
      Assert that sufficient concurrency control is in place.
      Some code was accessing recv_sys data structures without
      holding recv_sys->mutex.
      
      recv_recover_page(bpage): Refactor the call from buf_page_io_complete()
      into a separate function that performs necessary steps. The
      main thread was unnecessarily releasing and reacquiring recv_sys->mutex.
      
      recv_recover_page(block,mtr,recv_addr): Pass more parameters from
      the caller. Avoid redundant lookups and computations. Eliminate some
      redundant variables.
      
      recv_get_fil_addr_struct(): Assert that recv_sys->mutex is being held.
      That was not always the case!
      
      recv_scan_log_recs(): Acquire recv_sys->mutex for the whole duration
      of the function. (While we are scanning and buffering redo log records,
      no pages can be read in.)
      
      recv_read_in_area(): Properly protect access with recv_sys->mutex.
      
      recv_apply_hashed_log_recs(): Check recv_addr->state only once,
      and continuously hold recv_sys->mutex. The mutex will be released
      and reacquired inside recv_recover_page() and recv_read_in_area(),
      allowing concurrent processing by buf_page_io_complete() in I/O threads.
      1d30b7b1
    • Marko Mäkelä's avatar
      MDEV-12699 preparation: Write MLOG_INDEX_LOAD for FTS_ tables · aa3f7a10
      Marko Mäkelä authored
      The record MLOG_INDEX_LOAD is supposed to be written to indicate that
      some page modifications bypassed redo logging, and that redo logging
      is now re-enabled. It was not written for fulltext indexes during
      ALTER TABLE.
      
      row_merge_write_redo(): Declare globally. Assert that the index
      is neither a spatial nor fulltext index.
      
      recv_mlog_index_load(): Observe a MLOG_INDEX_LOAD operation.
      
      recv_parse_log_recs(): Handle MLOG_INDEX_LOAD also in multi-record
      mini-transactions. Because of this omission, we should keep writing
      MLOG_INDEX_LOAD in single-record mini-transactions, because older
      versions of Mariabackup would fail.
      
      row_fts_merge_insert(): Write MLOG_INDEX_LOAD for the auxiliary
      tables of fulltext indexes.
      aa3f7a10
    • Marko Mäkelä's avatar
      MDEV-12699 preparation: Initialize the entire page on MLOG_ZIP_PAGE_COMPRESS · 45d338dc
      Marko Mäkelä authored
      The record MLOG_ZIP_PAGE_COMPRESS is similar to MLOG_INIT_FILE_PAGE2
      that it contains all the information needed to initialize the page.
      Like for the other record, do initialize the entire page on recovery.
      45d338dc
    • Marko Mäkelä's avatar
      buf_page_get_gen(): Allow BUF_GET_IF_IN_POOL with a dummy page_size · 1b95118c
      Marko Mäkelä authored
      The page_size argument to buf_page_get_gen() only matters when the
      page is going to be loaded into the buffer pool. Allow callers to
      pass a dummy parameter when using BUF_GET_IF_IN_POOL (which would
      return NULL if the block is not in the buffer pool).
      1b95118c
    • Marko Mäkelä's avatar
      Fix a crash in CHECK TABLE for corrupted encrypted root page · 80f29211
      Marko Mäkelä authored
      btr_root_get(): Ignore the root->page.encrypted flag.
      The purpose of this flag is questionable since
      commit 8c43f963.
      
      btr_validate_index(): Avoid crash if btr_root_get() returns NULL.
      80f29211
    • Marko Mäkelä's avatar
      MDEV-15528 preparation: Do not modify a freed page · 1d0380e0
      Marko Mäkelä authored
      btr_free_root(): Add the parameter bool invalidate.
      
      btr_free_root_invalidate(): Remove.
      1d0380e0
    • Marko Mäkelä's avatar
      Clean up the parsing of MLOG_INIT_FILE_PAGE2 · 56df18be
      Marko Mäkelä authored
      fsp_apply_init_file_page(): Renamed from fsp_init_file_page_low().
      
      fsp_parse_init_file_page(): Remove. The redo log record has no
      parameters.
      56df18be
    • Marko Mäkelä's avatar
      recv_recovery_is_on(): Add UNIV_UNLIKELY · 71f9552f
      Marko Mäkelä authored
      Normally, InnoDB is not in the process of executing crash recovery.
      Provide a hint to the compiler that the recovery-related code paths
      are rarely executed.
      71f9552f
    • Marko Mäkelä's avatar
      Re-record plugins.feedback_plugin_load · c56ae2df
      Marko Mäkelä authored
      c56ae2df
  3. 05 Apr, 2019 1 commit
  4. 04 Apr, 2019 3 commits
  5. 03 Apr, 2019 12 commits
  6. 02 Apr, 2019 9 commits
    • Sergei Golubchik's avatar
      MDEV-18298 Crashes server with segfault during role grants · 65d758aa
      Sergei Golubchik authored
      it was supposed to be `*(p-1)` not `*p-1`
      (the crash happens if `*p==0`)
      65d758aa
    • Sergei Golubchik's avatar
      cmake: only search for libraries that are needed · 409f69cd
      Sergei Golubchik authored
      in particular, don't search for libjemalloc.a, which is only
      needed for tokudb's ftcxx tests, when the tests aren't going
      to be built.
      409f69cd
    • Sergei Golubchik's avatar
      cmake: fix krb5 detection on SUSE · 7b527e63
      Sergei Golubchik authored
      `zypper install krb5-devel` installs executables outside of $PATH.
      It also installs /etc/profile.d/krb5.sh that is sourced by a new
      shell to add the new location to the $PATH. But this doesn't affect
      the current shell.
      
      Now decent Linux distros remind the user to run `. /etc/profile`
      to reload paths in such a case. SUSE doesn't and for a good reason -
      it doesn't work there. Because SUSE sets PROFILEREAD=true in the
      environment and /etc/profile does not do anything.
      
      By this point, one should not really expect `unset PROFILEREAD` to help,
      and it does not - PROFILEREAD is readonly, and cannot be unset.
      
      Apparently SUSE really *really* wants you to re-login between installing
      MariaDB build dependencies and actually running the rpmbuild.
      
      Which we cannot do it buildbot. And it would look very user-un-friendly
      in the Build Instructions section of the manual.
      
      So, we work around it - by adding SUSE krb5 path to the search list.
      
      THIS IS SUSEEEEEE!!!
      7b527e63
    • Sergei Golubchik's avatar
      speedup RPM builds · 0b2042fd
      Sergei Golubchik authored
      Filter out most common file types from automatic dependency collection.
      This makes `make package`  in centos73 VM three times faster
      0b2042fd
    • Marko Mäkelä's avatar
      MDEV-19085: Remove a bogus debug assertion · e3f44d8d
      Marko Mäkelä authored
      MariaDB does support InnoDB tables with no stored columns.
      (They are necessarily empty.)
      e3f44d8d
    • Marko Mäkelä's avatar
      Fix integer type mismatch · 5633f83c
      Marko Mäkelä authored
      5633f83c
    • Marko Mäkelä's avatar
      MDEV-19128 fil_name_parse() for MLOG_FILE_ is not portable · 8650848e
      Marko Mäkelä authored
      On Microsoft Windows, InnoDB writes the path separator \ to the
      redo log file, while on all other platforms, / is being used.
      
      fil_name_parse(): Normalize the parsed path separators to the
      native format. This allows backups or data sets to be portable
      between Windows and other systems.
      8650848e
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · bce380f2
      Marko Mäkelä authored
      bce380f2
    • Marko Mäkelä's avatar
      Omit the definition of unused function yyset_extra() · b88f3786
      Marko Mäkelä authored
      This is follow-up for commit 619d22dd
      to fix the cmake -DWITH_EMBEDDED_SERVER build.
      b88f3786
  7. 01 Apr, 2019 3 commits
    • Marko Mäkelä's avatar
      d59ad697
    • Marko Mäkelä's avatar
      MDEV-19085 Assertion failures due to virtual columns after upgrading from 10.1 · f055da9b
      Marko Mäkelä authored
      MariaDB before MDEV-5800 in version 10.2.2 did not support
      indexed virtual columns. Non-persistent virtual columns were
      hidden from storage engines. Only starting with MDEV-5800, InnoDB
      would create internal metadata on virtual columns.
      
      Similar to what was done in MDEV-18084, MDEV-18090, MDEV-18960, we adjust
      one more code path for the old tables.
      
      innobase_build_col_map(): Allocate space for virtual columns in col_map[]
      but leave the entries at ULINT_UNDEFINED, noting that the virtual columns
      were missing before the table was being rebuilt.
      f055da9b
    • Marko Mäkelä's avatar
      Rebuild the InnoDB lexical analyzers with flex 2.6.4 · 619d22dd
      Marko Mäkelä authored
      InnoDB includes 3 parsers, which use 3 lexical analyzers that
      are generated with flex. Flex versions before 2.6 emitted
      the keyword "register", which is deprecated in C++17.
      
      The lexical analyzers were regenerated as follows:
      
      for s in storage/innobase storage/xtradb
      do
      	(cd "$s"/pars; ./make_flex.sh)
      	touch "$s"/fts/*.l
      	make -C "$s"/fts -f Makefile.query
      done
      619d22dd