1. 27 Jun, 2006 3 commits
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 810d8e21
      unknown authored
      Third cut to simplify parsing phase. Now DROP EVENT works.
      
      Overloaded few functions to be able to use either sp_name or pass two LEX_STRINGs
      instead of a Event_timed pointer. This is transitional and eventually the old
      functions will be removed. For now DROP EVENT also works, does not need anymore
      a parsing object (Event_timed) and definer initialization because everyone who
      has EVENT_ACL can drop events, and this is checked on execution time in sql_parse.cc
      from the security context, as it should be.
      
      
      sql/event_data_objects.cc:
        overload few functions
      sql/event_scheduler.cc:
        Event_scheduler::drop_event() actually does not need Event_timed object
        but just an identifier, hence pass only sp_name.
        
        Overloaded Event_scheduler::find_event() to work with sp_name object. Eventually
        the old version will be removed. This is being done as transitional step to
        be able to test frequently code.
      sql/event_scheduler.h:
        Event_scheduler::drop_event() actually does not need Event_timed object
        but just an identifier, hence pass only sp_name.
        
        Overloaded Event_scheduler::find_event() to work with sp_name object. Eventually
        the old version will be removed. This is being done as transitional step to
        be able to test frequently code.
      sql/events.cc:
        Change db_drop_event() not to use Event_timed, either coming from parsing
        or from Event_timed::drop, but use LEX_STRINGs. sp_name is not convinient
        because in Event_timed::drop a temporary object has to be created. Hence, 
        dereference the sp_name in Events::drop_event() and pass the LEX_STRINGs.
      sql/events.h:
        Change db_drop_event() not to use Event_timed, either coming from parsing
        or from Event_timed::drop, but use LEX_STRINGs. sp_name is not convinient
        because in Event_timed::drop a temporary object has to be created. Hence, 
        dereference the sp_name in Events::drop_event() and pass the LEX_STRINGs.
      sql/events_priv.h:
        Change db_drop_event() not to use Event_timed, either coming from parsing
        or from Event_timed::drop, but use LEX_STRINGs. sp_name is not convinient
        because in Event_timed::drop a temporary object has to be created. Hence, 
        dereference the sp_name in Events::drop_event() and pass the LEX_STRINGs.
      sql/sql_parse.cc:
        SQLCOM_DROP_EVENT does not need lex->event_parse_data object and 
        is more like SQLCOM_SHOW_CREATE_EVENT. Therefore, move it to the block that
        handles the latter.
      sql/sql_yacc.yy:
        DROP EVENT does not need a parsing object, just a name.
        Store it as lex->spname. Pretty similar handling to the one of
        SHOW CREATE EVENT.
      810d8e21
    • unknown's avatar
      WL#3337 (Events new infrasctructure) · fd91a6f2
      unknown authored
      Second cut of separating parsing phase from execution phase
      Separate Event_timed from parsing phase and introducing Event_parse_data.
      
      
      sql/event_data_objects.cc:
        second cut,
        copy Event_timed::init_body() to Event_parse_data::init_body()
        Init the body during parsing, everything else keep as a pointer to
        Item or some other pointer to use for later initialization.
      sql/event_data_objects.h:
        get the identifier as sp_name*, later will initialize our structures
      sql/events.cc:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      sql/events.h:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      BitKeeper/etc/ignore:
        Added libmysql/viosocket.o.6WmSJk libmysqld/event_data_objects.cc libmysqld/event_db_repository.cc libmysqld/event_queue.cc server-tools/instance-manager/net_serv.cc to the ignore list
      sql/share/errmsg.txt:
        remove this message, not used and needed for now
      sql/sql_lex.h:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      sql/sql_parse.cc:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      sql/sql_yacc.yy:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      fd91a6f2
    • unknown's avatar
      first cut of WL#3337 (New event scheduler locking infrastructure). · 2ca34120
      unknown authored
      Infrastructure built. Added the  foreseen files and change Makefile.am/CMakeLists.txt
      accordingly.
      
      
      libmysqld/Makefile.am:
        add new files. this is first cut of WL3337u
      sql/CMakeLists.txt:
        add more files to build
      sql/Makefile.am:
        add new files. this is first cut of WL3337
      sql/event_scheduler.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/events.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/share/errmsg.txt:
        new error message
      sql/event_data_objects.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/event_data_objects.h:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/sql_parse.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/sql_show.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/sql_yacc.yy:
        event_timed.h -> event_data_objects.h (WL#3337)
      2ca34120
  2. 26 Jun, 2006 2 commits
  3. 23 Jun, 2006 5 commits
    • unknown's avatar
      Fix for bug #18897 "Events: unauthorized action possible with · 2b276ab2
      unknown authored
      alter event rename".
      
      ALTER EVENT ... RENAME statement hasn't checked privileges
      for the target database. It also caused server crashes when
      target database was not specified explicitly and there was
      no current database.
      
      This fix adds missing privilege check and check for the case
      when target database is not specified explicitly or implicitly.
      
      
      mysql-test/r/events_bugs.result:
        update result
      mysql-test/t/events_bugs.test:
        add test case for bug 18897 Events: unauthorized action possible with alter event
        rename:
        - test rename to db the user does not have access to
        - test rename when there is no selected db
      sql/sql_parse.cc:
        Additional check for the situation when no db is selected.
        CREATE EVENT abc and ALTER EVENT db.abc RENAME TO xyz,
        and DROP EVENT abc
        won't work if there is no selected DB.
      2b276ab2
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · f8da71fc
      unknown authored
      into  mysql.com:/home/cps/mysql/devel/5.1-curs-bug
      
      f8da71fc
    • unknown's avatar
      remove links from bk to get rid of warnings on windows · 3613b8bc
      unknown authored
      
      BitKeeper/deleted/.del-sql_state.c~3b39d30b649690f3:
        Delete: server-tools/instance-manager/sql_state.c
      BitKeeper/deleted/.del-password.c~9d4b6a4c57887ac7:
        Delete: server-tools/instance-manager/password.c
      BitKeeper/deleted/.del-pack.c~4754cd15e3058c75:
        Delete: server-tools/instance-manager/pack.c
      BitKeeper/deleted/.del-net_serv.cc~120fb81d7e670308:
        Delete: server-tools/instance-manager/net_serv.cc
      3613b8bc
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 230da33c
      unknown authored
      into lmy004.:/work/mysql-5.1-runtime-bug20624
      
      230da33c
    • unknown's avatar
      disable events tests in embedded · 75e89f42
      unknown authored
      (fix for bug#20290 Event mechanism incompatible with embedded server, but tests tried)
      
      
      mysql-test/t/events.test:
        disable test in embedded
      mysql-test/t/events_bugs.test:
        disable test in embedded
      mysql-test/t/events_grant.test:
        disable test in embedded
      mysql-test/t/events_logs_tests.test:
        disable test in embedded
      mysql-test/t/events_microsec.test:
        disable test in embedded
      mysql-test/t/events_scheduling.test:
        disable test in embedded
      mysql-test/t/events_stress.test:
        disable test in embedded
      75e89f42
  4. 22 Jun, 2006 8 commits
    • unknown's avatar
      Merge mysql.com:/mnt/raid/alik/MySQL/devel/5.1-tree · e589b3fe
      unknown authored
      into  mysql.com:/mnt/raid/alik/MySQL/devel/5.1-rt-bug20294
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      e589b3fe
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 712fa869
      unknown authored
      into  mysql.com:/mnt/raid/alik/MySQL/devel/5.1-rt-bug20294
      
      712fa869
    • unknown's avatar
      Additional fix for BUG#20294: Instance manager test · 94268ebb
      unknown authored
      im_instance_conf fails randomly.
      
      
      mysql-test/r/im_options.result:
        Updated result file.
      mysql-test/t/im_instance_conf.imtest:
        Added a note about specific of CREATE INSTANCE usage in IM-tests.
      mysql-test/t/im_options.imtest:
        1. Specify socket-file-name for new instance so that the test
           does not depend on another running test-suite on the same box.
        2. Added a note about specific of CREATE INSTANCE usage in IM-tests.
      94268ebb
    • unknown's avatar
      fix for bug#20624: events_logs_tests.test fails randomly · d34bc275
      unknown authored
      (this is a change to a faulty test file)
      
      
      mysql-test/r/events_logs_tests.result:
        update result
      mysql-test/t/events_logs_tests.test:
        fix the test file, so TRUNCATE should not land into the slow_log
        This happens on loaded machines, for example when running few suites
        in parallel.
        fix for bug #20624: events_logs_tests.test fails randomly
      d34bc275
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1 · 37ba963e
      unknown authored
      into  mysql.com:/home/bk/fix-mysql-5.1
      
      
      sql/sql_insert.cc:
        Auto merged
      37ba963e
    • unknown's avatar
      Patch to handle some bad situations resulting from the fix for BUG#19995. · dd85b4b6
      unknown authored
      
      sql/handler.cc:
        Generating table maps from all locks that can be available: THD::extra_lock,
        THD::lock, and THD::locked_tables.
      sql/sql_class.h:
        Adding member Open_tables:state::extra_lock to hold the extra lock used by select_create.
        Removing select_insert::lock.
      sql/sql_insert.cc:
        Adding member Open_tables:state::extra_lock to hold the extra lock used by select_create.
        Removing select_insert::lock.
      dd85b4b6
    • unknown's avatar
      fix for bug#16992 (Events: Information_schema troubles) · 8a355686
      unknown authored
      Introduced EVENTS.EVENT_DEFINITION, like ROUTINES.ROUTINE_DEFINITION
      Hence, the contents of the current EVENTS.EVENT_BODY become the contents
      of EVENT_DEFINITION. EVENT_BODY will contain always, for now, "SQL" (wo
      quotes).
      
      
      mysql-test/r/events.result:
        update result
        event_body -> event_definition
        event_body -> SQL
      mysql-test/r/events_grant.result:
        update result
        event_body -> event_definition
        event_body -> SQL
      mysql-test/r/information_schema.result:
        update result
        event_body -> event_definition
      mysql-test/t/events.test:
        update result
        event_body -> event_definition
        event_body -> SQL
      mysql-test/t/events_grant.test:
        update result
        event_body -> event_definition
        event_body -> SQL
      sql/sql_show.cc:
        Introduce enum_i_s_events_fields, because I hate recounting
        all the time a field is changed.
        Rename EVENT_BODY to EVENT_DEFINITION
        Introduce EVENT_BODY after that to be "SQL"
        (final fix for bug#16992 Events: Information schema troubles ) ?
      8a355686
    • unknown's avatar
      Merge mysql.com:/M50/bug19353-5.0 into mysql.com:/M51/bug19353-5.1 · fd579b48
      unknown authored
      
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      support-files/mysql.server.sh:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      fd579b48
  5. 21 Jun, 2006 22 commits