1. 15 Jan, 2007 1 commit
    • unknown's avatar
      Fix for bug#20390 "SELECT FOR UPDATE does not release locks · 810fc001
      unknown authored
      of untouched rows in full table scans".
      
      SELECT ... FOR UPDATE/LOCK IN SHARE MODE statements as well as
      UPDATE/DELETE statements which were executed using full table
      scan were not releasing locks on rows which didn't satisfy
      WHERE condition.
      This bug surfaced in 5.0 and affected NDB tables. (InnoDB tables
      intentionally don't support such unlocking in default mode).
      
      This problem occured because code implementing join didn't call
      handler::unlock_row() for rows which didn't satisfy part of condition
      attached to this particular table/level of nested loop. So we solve
      the problem adding this call.
      Note that we already had this call in place in 4.1 but it was lost
      (actually not quite correctly placed) when we have introduced nested 
      joins.
      
      Also note that additional QA should be requested once this patch is
      pushed as interaction between handler::unlock_row() and many recent
      MySQL features such as subqueries, unions, views is not tested enough.
      
      
      mysql-test/r/ndb_lock.result:
        Enabled back part of the test that covers bug #20390 "SELECT FOR
        UPDATE does not release locks of untouched rows in full table scans".
        Adjusted test in such way that it now covers both execution paths
        in which we unlock non-matching rows inspected during table scan.
      mysql-test/t/ndb_lock.test:
        Enabled back part of the test that covers bug #20390 "SELECT FOR
        UPDATE does not release locks of untouched rows in full table scans".
        Adjusted test in such way that it now covers both execution paths
        in which we unlock non-matching rows inspected during table scan.
      sql/sql_select.cc:
        evaluate_join_record() should call handler::unlock_row() for records
        which don't satisfy condition which was pushed-down to this table/level
        of nested loop.
        We just put back the thing that we already have in 4.1 and which was lost
        when we have introduced nested joins.
      810fc001
  2. 12 Dec, 2006 2 commits
    • unknown's avatar
      minor cleanup · d501b2dd
      unknown authored
      
      mysql-test/t/sp_stress_case.test:
        Minor cleanup ... the test is now faster, even in debug builds
      d501b2dd
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · 1ec10680
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.0-19194
      
      
      sql/sp_head.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      1ec10680
  3. 11 Dec, 2006 1 commit
    • unknown's avatar
      Bug#19194 (Right recursion in parser for CASE causes excessive stack usage, · c01c4cc3
      unknown authored
        limitation)
      Bug#24854 (Mixing Searched Case with Simple Case inside Stored Procedure
        crashes Mysqld)
      
      Implemented code review (19194) comments
      
      
      mysql-test/r/sp_stress_case.result:
        Implemented code review comments : use SQL instead of a shell script to
        generate the code
      mysql-test/t/sp_stress_case.test:
        Adjusted
      sql/sql_yacc.yy:
        Added more explicit comments
      BitKeeper/deleted/.del-sp_stress_case.sh:
        Delete: mysql-test/t/sp_stress_case.sh
      c01c4cc3
  4. 04 Dec, 2006 3 commits
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · 3d5c638b
      unknown authored
      into  outpost.site:/home/cps/mysql/trees/5.0-runtime-19044
      
      
      3d5c638b
    • unknown's avatar
      Fix Bug #19044 IM aborts on exit · 1adc1368
      unknown authored
      On windows IM aborted on assert once one
      stoppped it. The reason is that we didn't
      close the sockets on windows and therefore,
      the listener thread wasn't able to finish.
      This happened because we used close() call
      for it. While on windows one should use
      closesocket().
      On other platfroms we have appropriate defines
      for closesocket(), so this is the function which
      should be used.
      
      
      server-tools/instance-manager/listener.cc:
        close -> closesocket
      1adc1368
    • unknown's avatar
      Use standard shell instead of BASH. · 85e15fb3
      unknown authored
      85e15fb3
  5. 01 Dec, 2006 1 commit
    • unknown's avatar
      A fix and a test case for Bug#24179 "select b into $var" fails with · fe84b016
      unknown authored
      --cursor_protocol": fix a misleading error message in case of
      SELECT .. INTO.
      
      
      sql/sql_class.cc:
        Implement select_result::check_simple_select hierarchy to 
        support correct error messages in case of SELECT .. INTO and C API 
        cursors.
      sql/sql_class.h:
        Set the error message inside the function that checks for the error
        condition (simple_select, renamed to check_simple_select).
      sql/sql_prepare.cc:
        Use a new method that now sets the error.
      tests/mysql_client_test.c:
        Add a test case for Bug#24179 "select b into $var" fails with 
        --cursor_protocol" (check for the right error message and error code).
      fe84b016
  6. 29 Nov, 2006 12 commits
  7. 28 Nov, 2006 10 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 15584161
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/t/wait_for_socket.sh:
        Manual merge.
      sql/sql_cache.cc:
        Manual merge.
      15584161
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 760bd9d1
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-4.1-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      760bd9d1
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 00fec63a
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      00fec63a
    • unknown's avatar
      Merge trift2.:/M50/mysql-5.0 · fa26de19
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      fa26de19
    • unknown's avatar
      netware/BUILD/nwbootstrap : Editing "mwenv" is now obsolete and even plain wrong - drop it. · 5be953f8
      unknown authored
      
      netware/BUILD/nwbootstrap:
        Editing "mwenv" is now obsolete,
        as this file gets its variable settings from the environment already;
        and it is even plain wrong,
        because the assignments to those variables are written in such a way that
        replacing the variables by values (as tried here) yields invalid shell lines.
      5be953f8
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0-build · d41b660b
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0-build
      
      
      d41b660b
    • unknown's avatar
      Makefile.am: · 89a71063
      unknown authored
        Handle the case "sql_yacc.cc" is pregenerated or not, and that the
        case where the source and build tree is the same or not.
      
      
      sql/Makefile.am:
        Handle the case "sql_yacc.cc" is pregenerated or not, and that the
        case where the source and build tree is the same or not.
      89a71063
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mysql-4.1-build · 4d08b747
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0-build
      
      
      Docs/Makefile.am:
        Auto merged
      4d08b747
    • unknown's avatar
      Makefile.am: · 0fb76499
      unknown authored
        If using \$(srcdir)/mysql.info in action, use same in rule.
      
      
      Docs/Makefile.am:
        If using \$(srcdir)/mysql.info in action, use same in rule.
      0fb76499
    • unknown's avatar
      Merge trift2.:/M50/mysql-5.0 · c8b23c37
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      extra/yassl/taocrypt/taocrypt.dsp:
        Auto merged
      extra/yassl/yassl.dsp:
        Auto merged
      extra/yassl/yassl.vcproj:
        Auto merged
      extra/yassl/taocrypt/taocrypt.vcproj:
        Auto merged
      extra/yassl/taocrypt/benchmark/benchmark.dsp:
        Auto merged
      extra/yassl/taocrypt/test.dsp:
        Auto merged
      extra/yassl/testsuite/testsuite.dsp:
        Auto merged
      c8b23c37
  8. 27 Nov, 2006 10 commits
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mysql-4.1-build · 344db8ab
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0-build
      
      
      344db8ab
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · 048dfce0
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0-merge
      
      
      sql-common/my_time.c:
        Auto merged
      048dfce0
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · eb63927c
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-4.1-merge
      
      
      eb63927c
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0-build · e9c502b3
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0
      
      
      e9c502b3
    • unknown's avatar
      ha_innodb.m4, Makefile.am, ha_ndbcluster.m4, Makefile.shared, ha_berkeley.m4: · 16918343
      unknown authored
        Reenabled build outside source tree
      
      
      config/ac-macros/ha_berkeley.m4:
        Reenabled build outside source tree
      config/ac-macros/ha_innodb.m4:
        Reenabled build outside source tree
      config/ac-macros/ha_ndbcluster.m4:
        Reenabled build outside source tree
      extra/yassl/src/Makefile.am:
        Reenabled build outside source tree
      extra/yassl/taocrypt/benchmark/Makefile.am:
        Reenabled build outside source tree
      extra/yassl/taocrypt/src/Makefile.am:
        Reenabled build outside source tree
      extra/yassl/taocrypt/test/Makefile.am:
        Reenabled build outside source tree
      extra/yassl/testsuite/Makefile.am:
        Reenabled build outside source tree
      libmysql/Makefile.shared:
        Reenabled build outside source tree
      ndb/src/mgmsrv/Makefile.am:
        Reenabled build outside source tree
      16918343
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0-release · 4ab2a016
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/build/mysql-5.0-build
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      4ab2a016
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mysql-4.1 · cae25b0c
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0
      
      
      cae25b0c
    • unknown's avatar
      Makefile.am: · f53733db
      unknown authored
        BSD compatibility
      
      
      Docs/Makefile.am:
        BSD compatibility
      f53733db
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mysql-4.1 · 14ba2178
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-5.0
      
      
      BitKeeper/deleted/.del-acinclude.m4~f4ab416bac5003:
        Auto merged
      bdb/dist/gen_rec.awk:
        Auto merged
      libmysql_r/Makefile.am:
        Auto merged
      ndb/config/type_ndbapitools.mk.am:
        Auto merged
      ndb/src/kernel/Makefile.am:
        Auto merged
      14ba2178
    • unknown's avatar
      gen_rec.awk: · 8d6f67f3
      unknown authored
        Fix undefined behaviour.
      Many files:
        Reenabled build outside ource tree
      
      
      bdb/dist/gen_rec.awk:
        Fix undefined behaviour.
      acinclude.m4:
        Reenabled build outside ource tree
      configure.in:
        Reenabled build outside ource tree
      libmysql_r/Makefile.am:
        Reenabled build outside ource tree
      libmysqld/Makefile.am:
        Reenabled build outside ource tree
      ndb/config/common.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_kernel.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_ndbapi.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_ndbapitest.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_ndbapitools.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_util.mk.am:
        Reenabled build outside ource tree
      ndb/src/kernel/Makefile.am:
        Reenabled build outside ource tree
      8d6f67f3