1. 14 Dec, 2012 1 commit
    • Igor Babaev's avatar
      Addressed all remaining issues from the review of the patch · 8654e373
      Igor Babaev authored
      that introduced engine independent persistent statistics.
      In particular:
      - added an enumeration type for possible values of the system
        variable use_stat_tables
      - renamed KEY::real_rec_per_key to KEY::actual_rec_per_key
      - optimized the collection of statistical data for any primary
        key defined only on one column.
        
      8654e373
  2. 13 Dec, 2012 1 commit
    • Igor Babaev's avatar
      Fixed bug mdev-3891. · c503f8b0
      Igor Babaev authored
      If a query referenced some system statistical tables, but not all of them,
      then executing an ANALYZE command simultaneously with this query could
      lead to a deadlock.
      The fix prohibited reading statistics from system statistical tables
      for such queries.
      
      Removed the function unlock_tables_n_open_system_tables_for_write()
      as not used anymore.
      Performed some minor refactoring of the code in sql_statistics.cc. 
      c503f8b0
  3. 10 Dec, 2012 1 commit
  4. 08 Dec, 2012 1 commit
    • Igor Babaev's avatar
      Addressed the following issue from the review of the patch for · 4b27ac9e
      Igor Babaev authored
      engine-independent statistics.
      When the primary key was dropped or changed statistics on secondary
      indexes for the prefixes that included components of the primary 
      key was not removed from the table mysql.index_stats.
      
      Also fixed: in the some cases when a column was changed statistics
      on the indexes that included this column was not removed from the
      table mysql.index_stats.
      
      Also disabled the test mdev-504 for --ps-protocol.
      4b27ac9e
  5. 06 Dec, 2012 1 commit
    • Igor Babaev's avatar
      Addressed the following issues from the review of the patch: · d7232ffd
      Igor Babaev authored
      1. The PERSISTENT FOR clause of the ANALYZE command overrides
      the setting of the system variable use_stat_tables: 
      with this clause ANALYZE unconditionally collects persistent
      statistics.
      2. ANALYZE collects persistent statistics only for tables of
      the USER category. So it never collects persistent statistics
      for system tables.  
      d7232ffd
  6. 05 Dec, 2012 4 commits
    • Igor Babaev's avatar
      Adjusted results for a test. · fa98c158
      Igor Babaev authored
      The adjustment was supposed to be done in the previous commit.
      fa98c158
    • Igor Babaev's avatar
      Changed the names of the system tables for statistical data: · b7c93cd7
      Igor Babaev authored
        table_stat  -> table_stats
        column_stat -> column_stats
        index_stat  -> index_stats
      to be in line with the names of innodb statistical tables 
      from mysql-5.6: innodb_table_stats and innodb_index_stats.
      b7c93cd7
    • Igor Babaev's avatar
      Merge 5.5->mwl248 · e0821c1d
      Igor Babaev authored
      e0821c1d
    • Igor Babaev's avatar
      Fixed bug mdev-3888. · c9d73dce
      Igor Babaev authored
      When inserting a record with update on duplicate keys the server calls
      the ha_index_read_idx_map handler function to look for the record
      that violates unique key constraints. The third parameter of this call
      should mark only the base components of the index where the server is
      searched for the record. Possible hidden components of the primary key
      are to be unmarked.
      c9d73dce
  7. 01 Dec, 2012 2 commits
  8. 27 Nov, 2012 3 commits
  9. 26 Nov, 2012 2 commits
  10. 22 Nov, 2012 2 commits
  11. 21 Nov, 2012 2 commits
  12. 19 Nov, 2012 1 commit
    • Igor Babaev's avatar
      Fixed bug mdev-3866. · 0217812f
      Igor Babaev authored
      The invalid implementation of the method Field_bit::cmp_max could
      trigger a valgrind complain or could lead to incorrect statistical
      data when collecting engine-independent statistics on BIT fields.
      0217812f
  13. 17 Nov, 2012 1 commit
    • Sergei Golubchik's avatar
      MDEV-736 LP:1004615 - Unexpected warnings "Encountered illegal value '' when... · 0405a6d7
      Sergei Golubchik authored
      MDEV-736 LP:1004615 - Unexpected warnings "Encountered illegal value '' when converting to DECIMAL" on a query with aggregate functions and GROUP BY
      
      fix: don't call field->val_decimal() if the field->is_null()
      because the buffer at field->ptr might not hold a valid decimal value
      
      sql/item_sum.cc:
        do not call field->val_decimal() if the field->is_null()
      storage/maria/ma_blockrec.c:
        cleanup
      storage/maria/ma_rrnd.c:
        cleanup
      strings/decimal.c:
        typo
      0405a6d7
  14. 20 Nov, 2012 3 commits
  15. 19 Nov, 2012 3 commits
  16. 17 Nov, 2012 1 commit
  17. 15 Nov, 2012 1 commit
    • Sergei Golubchik's avatar
      MDEV-3826 compilation of client programs fail: m_string.h tries to include <mysql/plugin.h> · c2cacb25
      Sergei Golubchik authored
      mysql_config:
      - add not only $pkgincludedir, but also $pkgincludedir/.. to the header search path,
        for #include <mysql/plugin.h> to work
      
      
      scripts/mysql_config.sh:
        - don't support headers in */include anymore. only in */include/mysql
        - remove the incorrect "bug fix" (fixed correctly long time ago)
        - add not only $pkgincludedir, but also $pkgincludedir/.. to the header search path,
          for #include <mysql/plugin.h> to work
        - but don't do it, if $pkgincludedir/.. is /usr/include
      c2cacb25
  18. 12 Nov, 2012 1 commit
  19. 10 Nov, 2012 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-3849 - 1 bytes stack overwrite in normalize_dirname(). · 6b8e7456
      Vladislav Vaintroub authored
      Take into account that length of strings passed down to this function can be up to FN_REFLEN+1 bytes. including terminating zero.
      The overwrite was caused by incomplete fix to MySQL Bug # 44834
      6b8e7456
    • Igor Babaev's avatar
      Fixed bug mdev-3845. · af794708
      Igor Babaev authored
      If triggers are used for an insert/update/delete statement than the values of
      all virtual columns must be computed as any of them may be used by the triggers.
      af794708
  20. 09 Nov, 2012 7 commits