1. 14 Jan, 2009 2 commits
    • marko's avatar
      branches/innodb+: Merge revisions 3602:3931 from branches/zip: · 86b85252
      marko authored
        ------------------------------------------------------------------------
        r3607 | marko | 2008-12-30 22:33:31 +0200 (Tue, 30 Dec 2008) | 20 lines
      
        branches/zip: Remove the dependency on the MySQL HASH table implementation.
        Use the InnoDB hash table for keeping track of INNOBASE_SHARE objects.
      
        struct st_innobase_share: Make table_name const uchar*.  Add the member
        table_name_hash.
      
        innobase_open_tables: Change the type from HASH to hash_table_t*.
      
        innobase_get_key(): Remove.
      
        innobase_fold_name(): New function, for computing the fold value for the
        InnoDB hash table.
      
        get_share(), free_share(): Use the InnoDB hash functions.
      
        innobase_end(): Free innobase_open_tables before shutting down InnoDB.
        Shutting down InnoDB will invalidate all memory allocated via InnoDB.
      
        rb://65 approved by Heikki Tuuri.  This addresses Issue #104.
        ------------------------------------------------------------------------
        r3608 | marko | 2008-12-30 22:45:04 +0200 (Tue, 30 Dec 2008) | 22 lines
      
        branches/zip: When setting the PAGE_LEVEL of a compressed B-tree page
        from or to 0, compress the page at the same time.  This is necessary,
        because the column information stored on the compressed page will
        differ between leaf and non-leaf pages.  Leaf pages are identified by
        PAGE_LEVEL=0.  This bug was reported as Issue #150.
      
        Document the similarity between btr_page_create() and
        btr_page_empty().  Make the function signature of btr_page_empty()
        identical with btr_page_create().  (This will add the parameter "level".)
      
        btr_root_raise_and_insert(): Replace some code with a call to
        btr_page_empty().
      
        btr_attach_half_pages(): Assert that the page level has already been
        set on both block and new_block.  Do not set it again.
      
        btr_discard_only_page_on_level(): Document that this function is
        probably never called.  Make it work on any height tree.  (Tested on
        2-high tree by disabling btr_lift_page_up().)
      
        rb://68
        ------------------------------------------------------------------------
        r3612 | marko | 2009-01-02 11:02:44 +0200 (Fri, 02 Jan 2009) | 14 lines
      
        branches/zip: Merge c2998 from branches/6.0, so that the same InnoDB Plugin
        source tree will work both under 5.1 and 6.0.  Do not add the test case
        innodb_ctype_ldml.test, because it would not work under MySQL 5.1.
      
        Refuse to create tables whose columns contain collation IDs above 255.
        This removes an assertion failure that was introduced in WL#4164
        (Two-byte collation IDs).
      
        create_table_def(): Do not fail an assertion if a column contains a
        charset-collation ID greater than 256. Instead, issue an error and
        refuse to create the table.
      
        The original change (branches/6.0 r2998) was rb://51 approved by Calvin Sun.
        ------------------------------------------------------------------------
        r3613 | inaam | 2009-01-02 15:10:50 +0200 (Fri, 02 Jan 2009) | 6 lines
      
        branches/zip: Implement the parameter innodb_use_sys_malloc
        (false by default), for disabling InnoDB's internal memory allocator
        and using system malloc/free instead.
      
        rb://62 approved by Marko
        ------------------------------------------------------------------------
        r3614 | marko | 2009-01-02 15:55:12 +0200 (Fri, 02 Jan 2009) | 1 line
      
        branches/zip: ChangeLog: Document r3608 and r3613.
        ------------------------------------------------------------------------
        r3615 | marko | 2009-01-02 15:57:51 +0200 (Fri, 02 Jan 2009) | 1 line
      
        branches/zip: ChangeLog: Clarify the impact of r3608.
        ------------------------------------------------------------------------
        r3616 | marko | 2009-01-03 00:23:30 +0200 (Sat, 03 Jan 2009) | 1 line
      
        branches/zip: srv_suspend_mysql_thread(): Add some clarifying comments.
        ------------------------------------------------------------------------
        r3618 | marko | 2009-01-05 12:54:53 +0200 (Mon, 05 Jan 2009) | 15 lines
      
        branches/zip: Merge revisions 3598:3601 from branches/5.1:
      
          ------------------------------------------------------------------------
          r3601 | marko | 2008-12-22 16:05:19 +0200 (Mon, 22 Dec 2008) | 9 lines
      
          branches/5.1: Make
          SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED
          a true replacement of SET GLOBAL INNODB_LOCKS_UNSAFE_FOR_BINLOG=1.
          This fixes an error that was introduced in r370, causing
          semi-consistent read not to not unlock rows in READ COMMITTED mode.
          (Bug #41671, Issue #146)
      
          rb://67 approved by Heikki Tuuri
          ------------------------------------------------------------------------
        ------------------------------------------------------------------------
        r3623 | vasil | 2009-01-06 09:56:32 +0200 (Tue, 06 Jan 2009) | 7 lines
      
        branches/zip:
      
        Add patch to fix the failing main.variables mysql-test. It started failing
        after the variable innodb_use_sys_malloc was added because it matches
        '%alloc%' and the test is badly written and expects that no new variables
        like that will ever be added.
        ------------------------------------------------------------------------
        r3795 | marko | 2009-01-07 16:17:47 +0200 (Wed, 07 Jan 2009) | 7 lines
      
        branches/zip: row_merge_tuple_cmp(): Do not report a duplicate key value
        if any of the fields are NULL.  While the tuples are equal in the
        sorting order, SQL NULL is defined to be logically inequal to
        anything else. (Bug #41904)
      
        rb://70 approved by Heikki Tuuri
        ------------------------------------------------------------------------
        r3796 | marko | 2009-01-07 16:19:32 +0200 (Wed, 07 Jan 2009) | 1 line
      
        branches/zip: Add the tests that were forgotten from r3795.
        ------------------------------------------------------------------------
        r3797 | marko | 2009-01-07 16:22:18 +0200 (Wed, 07 Jan 2009) | 22 lines
      
        branches/zip: Do not call trx_allocate_for_mysql() directly, but use
        helper functions that initialize some members of the transaction struct.
        (Bug #41680)
      
        innobase_trx_init(): New function: initialize some fields of a
        transaction struct from a MySQL THD object.
      
        innobase_trx_allocate(): New function: allocate and initialize a
        transaction struct.
      
        check_trx_exists(): Use the above two functions.
      
        ha_innobase::delete_table(), ha_innobase::rename_table(),
        ha_innobase::add_index(), ha_innobase::final_drop_index():
        Use innobase_trx_allocate().
      
        innobase_drop_database(): In the Windows plugin, initialize the trx_t
        specially, because the THD is not available.  Otherwise, use
        innobase_trx_allocate().
      
        rb://69 accepted by Heikki Tuuri
        ------------------------------------------------------------------------
        r3798 | marko | 2009-01-07 16:42:42 +0200 (Wed, 07 Jan 2009) | 8 lines
      
        branches/zip: row_merge_drop_temp_indexes(): Do not lock the rows of
        SYS_INDEXES when looking for partially created indexes.  Use the
        transaction isolation level READ UNCOMMITTED to avoid interfering with
        locks held by incomplete transactions that will be rolled back in a
        subsequent step in the recovery.  (Issue #152)
      
        Approved by Heikki Tuuri
        ------------------------------------------------------------------------
        r3852 | vasil | 2009-01-08 22:10:10 +0200 (Thu, 08 Jan 2009) | 4 lines
      
        branches/zip:
      
        Add ChangeLog entries for r3795 r3796 r3797 r3798.
      
        ------------------------------------------------------------------------
        r3866 | marko | 2009-01-09 15:09:51 +0200 (Fri, 09 Jan 2009) | 2 lines
      
        branches/zip: buf_flush_try_page(): Move some common code from each
        switch case before the switch block.
        ------------------------------------------------------------------------
        r3867 | marko | 2009-01-09 15:13:14 +0200 (Fri, 09 Jan 2009) | 2 lines
      
        branches/zip: buf_flush_try_page(): Introduce the variable is_compressed
        for caching the result of buf_page_get_state(bpage) == BUF_BLOCK_FILE_PAGE.
        ------------------------------------------------------------------------
        r3868 | marko | 2009-01-09 15:40:11 +0200 (Fri, 09 Jan 2009) | 4 lines
      
        branches/zip: buf_flush_insert_into_flush_list(),
        buf_flush_insert_sorted_into_flush_list(): Remove unused code.
        Change the parameter to buf_block_t* block and assert that
        block->state == BUF_BLOCK_FILE_PAGE.  This is part of Issue #155.
        ------------------------------------------------------------------------
        r3873 | marko | 2009-01-09 22:27:40 +0200 (Fri, 09 Jan 2009) | 17 lines
      
        branches/zip: Some non-functional changes related to Issue #155.
      
        buf_page_struct: Note that space and offset are also protected by
        buf_pool_mutex.  They are only assigned to by
        buf_block_set_file_page().  Thus, it suffices for buf_flush_batch() to
        hold just buf_pool_mutex when checking these fields.
      
        buf_flush_try_page(): Rename "locked" to "is_s_latched", per Heikki's request.
      
        buf_flush_batch(): Move the common statement mutex_exit(block_mutex)
        from all if-else if-else branches before the if block.  Remove the
        redundant test (buf_pool->init_flush[flush_type] == FALSE) that was
        apparently copied from buf_flush_write_complete().
      
        buf_flush_write_block_low(): Note why it is safe not to hold buf_pool_mutex
        or block_mutex.  Enumerate the assumptions in debug assertions.
        ------------------------------------------------------------------------
        r3874 | marko | 2009-01-09 23:09:06 +0200 (Fri, 09 Jan 2009) | 4 lines
      
        branches/zip: Add comments related to Issue #155.
      
        buf_flush_try_page(): Note why it is safe to access bpage without
        holding buf_pool_mutex or block_mutex.
        ------------------------------------------------------------------------
        r3875 | marko | 2009-01-09 23:15:12 +0200 (Fri, 09 Jan 2009) | 11 lines
      
        branches/zip: Non-functional change: Tighten debug assertions and
        remove dead code.
      
        buf_flush_ready_for_flush(), buf_flush_try_page(): Assert that
        flush_type is one of BUF_FLUSH_LRU or BUF_FLUSH_LIST.  The flush_type
        comes from buf_flush_batch(), which already asserts this.  The
        assertion holds for all calls in the source code.
      
        buf_flush_try_page(): Remove the dead case BUF_FLUSH_SINGLE_PAGE
        of switch (flush_type).
        ------------------------------------------------------------------------
        r3879 | marko | 2009-01-12 12:46:44 +0200 (Mon, 12 Jan 2009) | 14 lines
      
        branches/zip: Simplify the flushing of dirty pages from the buffer pool.
      
        buf_flush_try_page(): Rename to buf_flush_page(), and change the
        return type to void.  Replace the parameters space, offset with bpage,
        and remove the second page hash lookup.  Note and assert that both
        buf_pool_mutex and block_mutex must now be held upon entering the
        function.  They will still be released by this function.
      
        buf_flush_try_neighbors(): Replace buf_flush_try_page() with
        buf_flush_page().  Make the logic easier to follow by not negating the
        precondition of buf_flush_page().
      
        rb://73 approved by Sunny Bains.  This is related to Issue #157.
        ------------------------------------------------------------------------
        r3880 | marko | 2009-01-12 13:24:37 +0200 (Mon, 12 Jan 2009) | 2 lines
      
        branches/zip: buf_flush_page(): Fix a comment that should have been fixed
        in r3879.  Spotted by Sunny.
        ------------------------------------------------------------------------
        r3881 | marko | 2009-01-12 14:25:22 +0200 (Mon, 12 Jan 2009) | 2 lines
      
        branches/zip: buf_page_get_newest_modification(): Use the block mutex
        instead of the buffer pool mutex.  This is related to Issue #157.
        ------------------------------------------------------------------------
        r3882 | marko | 2009-01-12 14:40:08 +0200 (Mon, 12 Jan 2009) | 3 lines
      
        branches/zip: struct mtr_struct: Remove the unused field magic_n
        unless UNIV_DEBUG is defined.  mtr->magic_n is only assigned to
        and checked in UNIV_DEBUG builds.
        ------------------------------------------------------------------------
        r3883 | marko | 2009-01-12 14:48:59 +0200 (Mon, 12 Jan 2009) | 1 line
      
        branches/zip: Non-functional change: Use ut_d when assigning to mtr->state.
        ------------------------------------------------------------------------
        r3884 | marko | 2009-01-12 18:56:11 +0200 (Mon, 12 Jan 2009) | 16 lines
      
        branches/zip: Non-functional change: Add some debug assertions and comments.
      
        buf_page_t: Note that the LRU fields are protected by buf_pool_mutex
        only, not block->mutex or buf_pool_zip_mutex.
      
        buf_page_get_freed_page_clock(): Note that this is sometimes invoked
        without mutex protection.
      
        buf_pool_get_oldest_modification(): Note that the result may be out of
        date.
      
        buf_page_get_LRU_position(), buf_page_is_old(): Assert that the buffer
        pool mutex is being held.
      
        buf_page_release(): Assert that dirty blocks are in the flush list.
        ------------------------------------------------------------------------
        r3896 | marko | 2009-01-13 09:30:26 +0200 (Tue, 13 Jan 2009) | 2 lines
      
        branches/zip: buf_flush_try_neighbors(): Fix a bug
        that was introduced in r3879 (rb://73).
        ------------------------------------------------------------------------
        r3900 | marko | 2009-01-13 10:32:24 +0200 (Tue, 13 Jan 2009) | 1 line
      
        branches/zip: Fix some comments to say buf_pool_mutex.
        ------------------------------------------------------------------------
        r3907 | marko | 2009-01-13 11:54:01 +0200 (Tue, 13 Jan 2009) | 3 lines
      
        branches/zip: row_merge_create_temporary_table(): On error,
        row_create_table_for_mysql() already frees new_table.
        Do not attempt to free it again.
        ------------------------------------------------------------------------
        r3908 | marko | 2009-01-13 12:34:32 +0200 (Tue, 13 Jan 2009) | 1 line
      
        branches/zip: Enable HASH_ASSERT_OWNED independently of UNIV_SYNC_DEBUG.
        ------------------------------------------------------------------------
        r3914 | marko | 2009-01-13 21:46:22 +0200 (Tue, 13 Jan 2009) | 37 lines
      
        branches/zip: In hash table lookups, assert that the traversed items
        satisfy some conditions when UNIV_DEBUG is defined.
      
        HASH_SEARCH(): New parameter: ASSERTION. All users will pass an appropriate
        ut_ad() or nothing.
      
        dict_table_add_to_columns(): Assert that the table being added to the data
        dictionary cache is not already being pointed to by the name_hash and
        id_hash tables.
      
        HASH_SEARCH_ALL(): New macro, for use in dict_table_add_to_columns().
      
        dict_mem_table_free(): Set ut_d(table->cached = FALSE), so that we can
        check ut_ad(table->cached) when traversing the hash tables, as in
        HASH_SEARCH(name_hash, dict_sys->table_hash, ...) and
        HASH_SEARCH(id_hash, dict_sys->table_id_hash, ...).
      
        dict_table_get_low(), dict_table_get_on_id_low(): Assert
        ut_ad(!table || table->cached).
      
        fil_space_get_by_id(): Check ut_ad(space->magic_n == FIL_SPACE_MAGIC_N)
        in HASH_SEARCH(hash, fil_system->spaces, ...).
      
        fil_space_get_by_name(): Check ut_ad(space->magic_n == FIL_SPACE_MAGIC_N)
        in HASH_SEARCH(name_hash, fil_system->name_hash, ...).
      
        buf_buddy_block_free(): Check that the blocks are in valid state in
        HASH_SEARCH(hash, buf_pool->zip_hash, ...).
      
        buf_page_hash_get(): Check that the blocks are in valid state in
        HASH_SEARCH(hash, buf_pool->page_hash, ...).
      
        get_share(), free_share(): Check ut_ad(share->use_count > 0) in
        HASH_SEARCH(table_name_hash, innobase_open_tables, ...).
      
        This was posted as rb://75 for tracking down errors similar to Issue #153.
        ------------------------------------------------------------------------
        r3931 | marko | 2009-01-14 16:06:22 +0200 (Wed, 14 Jan 2009) | 26 lines
      
        branches/zip: Merge revisions 3601:3930 from branches/5.1:
      
          ------------------------------------------------------------------------
          r3911 | sunny | 2009-01-13 14:15:24 +0200 (Tue, 13 Jan 2009) | 13 lines
      
          branches/5.1: Fix Bug#38187 Error 153 when creating savepoints
          InnoDB previously treated savepoints as a stack e.g.,
            SAVEPOINT a;
            SAVEPOINT b;
            SAVEPOINT c;
            SAVEPOINT b; <- This would delete b and c.
      
          This fix changes the behavior to:
            SAVEPOINT a;
            SAVEPOINT b;
            SAVEPOINT c;
            SAVEPOINT b; <- Does not delete savepoint c
          ------------------------------------------------------------------------
          r3930 | marko | 2009-01-14 15:51:30 +0200 (Wed, 14 Jan 2009) | 4 lines
      
          branches/5.1: dict_load_table(): If dict_load_indexes() fails,
          invoke dict_table_remove_from_cache() instead of dict_mem_table_free(),
          so that the data dictionary will not point to freed data.
          (Bug #42075, Issue #153, rb://76 approved by Heikki Tuuri)
          ------------------------------------------------------------------------
        ------------------------------------------------------------------------
      86b85252
    • inaam's avatar
      branches/innodb+ · c922320f
      inaam authored
      Enable group commit functionality.
      
      rb://47 approved by: Heikki
      c922320f
  2. 13 Jan, 2009 1 commit
  3. 30 Dec, 2008 1 commit
    • marko's avatar
      branches/innodb+: Merge revisions 3602:3608 from branches/zip: · 44e408b9
      marko authored
        ------------------------------------------------------------------------
        r3607 | marko | 2008-12-30 22:33:31 +0200 (Tue, 30 Dec 2008) | 20 lines
      
        branches/zip: Remove the dependency on the MySQL HASH table implementation.
        Use the InnoDB hash table for keeping track of INNOBASE_SHARE objects.
      
        struct st_innobase_share: Make table_name const uchar*.  Add the member
        table_name_hash.
      
        innobase_open_tables: Change the type from HASH to hash_table_t*.
      
        innobase_get_key(): Remove.
      
        innobase_fold_name(): New function, for computing the fold value for the
        InnoDB hash table.
      
        get_share(), free_share(): Use the InnoDB hash functions.
      
        innobase_end(): Free innobase_open_tables before shutting down InnoDB.
        Shutting down InnoDB will invalidate all memory allocated via InnoDB.
      
        rb://65 approved by Heikki Tuuri.  This addresses Issue #104.
        ------------------------------------------------------------------------
        r3608 | marko | 2008-12-30 22:45:04 +0200 (Tue, 30 Dec 2008) | 22 lines
      
        branches/zip: When setting the PAGE_LEVEL of a compressed B-tree page
        from or to 0, compress the page at the same time.  This is necessary,
        because the column information stored on the compressed page will
        differ between leaf and non-leaf pages.  Leaf pages are identified by
        PAGE_LEVEL=0.  This bug was reported as Issue #150.
      
        Document the similarity between btr_page_create() and
        btr_page_empty().  Make the function signature of btr_page_empty()
        identical with btr_page_create().  (This will add the parameter "level".)
      
        btr_root_raise_and_insert(): Replace some code with a call to
        btr_page_empty().
      
        btr_attach_half_pages(): Assert that the page level has already been
        set on both block and new_block.  Do not set it again.
      
        btr_discard_only_page_on_level(): Document that this function is
        probably never called.  Make it work on any height tree.  (Tested on
        2-high tree by disabling btr_lift_page_up().)
      
        rb://68
        ------------------------------------------------------------------------
      44e408b9
  4. 22 Dec, 2008 2 commits
    • marko's avatar
      branches/innodb+: Merge revisions 3599:3602 from branches/zip: · 91b39ec6
      marko authored
        ------------------------------------------------------------------------
        r3602 | marko | 2008-12-22 16:40:17 +0200 (Mon, 22 Dec 2008) | 6 lines
      
        branches/zip: page_cur_insert_rec_zip(): When allocating insert_buf from
        the free list, zero out the node pointer field of the deleted record if
        the new record would not overwrite it.  This fixes a harmless content
        mismatch reported by page_zip_validate() that was reported as Issue #147.
      
        rb://66 approved by Heikki Tuuri
        ------------------------------------------------------------------------
      91b39ec6
    • marko's avatar
      branches/innodb+: Merge revisions 3579:3599 from branches/zip: · a4f279a2
      marko authored
        ------------------------------------------------------------------------
        r3589 | marko | 2008-12-18 15:24:44 +0200 (Thu, 18 Dec 2008) | 2 lines
      
        branches/zip: ha_innodb.cc: Do not include some unnecessary MySQL
        header files.
        ------------------------------------------------------------------------
        r3594 | marko | 2008-12-19 13:58:13 +0200 (Fri, 19 Dec 2008) | 4 lines
      
        branches/zip: HASH_INSERT, HASH_DELETE: Add explicit type conversions,
        so that the macros will expand to valid C++.  Unlike C++, C allows
        implicit type conversions from void* to other pointer types.
        ------------------------------------------------------------------------
        r3597 | marko | 2008-12-22 12:27:16 +0200 (Mon, 22 Dec 2008) | 3 lines
      
        branches/zip: Pass the caller's file name and line number to
        row_mysql_lock_data_dictionary(), row_mysql_freeze_data_dictionary(),
        to better track down locking issues that involve dict_operation_lock.
        ------------------------------------------------------------------------
        r3599 | marko | 2008-12-22 15:41:47 +0200 (Mon, 22 Dec 2008) | 36 lines
      
        branches/zip: Merge revisions 3479:3598 from branches/5.1:
      
          ------------------------------------------------------------------------
          r3588 | inaam | 2008-12-18 14:26:54 +0200 (Thu, 18 Dec 2008) | 8 lines
      
          branches/5.1
      
          It is a bug in unused code. If we don't calculate the hash value when
          calculating the mutex number then two pages which map to same hash
          value can get two different mutex numbers.
      
          Approved by: Marko
          ------------------------------------------------------------------------
          r3590 | marko | 2008-12-18 15:33:36 +0200 (Thu, 18 Dec 2008) | 11 lines
      
          branches/5.1: When converting a record to MySQL format, copy the default
          column values for columns that are SQL NULL.  This addresses failures in
          row-based replication (Bug #39648).
      
          row_prebuilt_t: Add default_rec, for the default values of the columns in
          MySQL format.
      
          row_sel_store_mysql_rec(): Use prebuilt->default_rec instead of
          padding columns.
      
          rb://64 approved by Heikki Tuuri
          ------------------------------------------------------------------------
          r3598 | marko | 2008-12-22 15:28:03 +0200 (Mon, 22 Dec 2008) | 6 lines
      
          branches/5.1: ibuf_delete_rec(): When the record cannot be found and
          the tablespace has been dropped, commit the mini-transaction, so that
          InnoDB will not hold the insert buffer tree latch in exclusive mode,
          causing a potential deadlock.  This bug was introduced in the fix of
          Bug #27276 in r2924.
          ------------------------------------------------------------------------
        ------------------------------------------------------------------------
      a4f279a2
  5. 17 Dec, 2008 2 commits
    • marko's avatar
      branches/innodb+: Merge revisions 3575:3579 from branches/zip: · 5da5707b
      marko authored
        ------------------------------------------------------------------------
        r3577 | vasil | 2008-12-17 14:58:26 +0200 (Wed, 17 Dec 2008) | 6 lines
      
        branches/zip:
      
        Remove 2 entries from the ChangeLog about changes not big enough.
      
        Discussed with: Marko
        ------------------------------------------------------------------------
        r3579 | marko | 2008-12-17 22:40:38 +0200 (Wed, 17 Dec 2008) | 3 lines
      
        branches/zip: row_sel_try_search_shortcut(), row_sel(): Adjust two
        debug assertions that should have been adjusted in r3575.
        ------------------------------------------------------------------------
      5da5707b
    • marko's avatar
      branches/innodb+: Merge revisions 3544:3575 from branches/zip: · 82cfb40d
      marko authored
        ------------------------------------------------------------------------
        r3572 | marko | 2008-12-17 11:19:56 +0200 (Wed, 17 Dec 2008) | 3 lines
        Changed paths:
           M /branches/zip/ChangeLog
           M /branches/zip/btr/btr0sea.c
           M /branches/zip/buf/buf0buf.c
           M /branches/zip/buf/buf0lru.c
           M /branches/zip/ha/ha0ha.c
           M /branches/zip/ha/hash0hash.c
           M /branches/zip/include/buf0buf.h
           M /branches/zip/include/ha0ha.h
           M /branches/zip/include/ha0ha.ic
           M /branches/zip/include/hash0hash.h
           M /branches/zip/include/univ.i
      
        branches/zip: Introduce UNIV_AHI_DEBUG for debugging the adaptive hash
        index without enabling UNIV_DEBUG.
        ------------------------------------------------------------------------
        r3574 | marko | 2008-12-17 12:44:31 +0200 (Wed, 17 Dec 2008) | 2 lines
        Changed paths:
           M /branches/zip/ChangeLog
      
        branches/zip: ChangeLog: Document recent changes that were not included in
        InnoDB Plugin 1.0.2, except changes to source code comments.
        ------------------------------------------------------------------------
        r3575 | marko | 2008-12-17 14:40:58 +0200 (Wed, 17 Dec 2008) | 12 lines
        Changed paths:
           M /branches/zip/ChangeLog
           M /branches/zip/include/row0sel.h
           M /branches/zip/include/row0upd.h
           M /branches/zip/pars/pars0pars.c
           M /branches/zip/row/row0mysql.c
           M /branches/zip/row/row0sel.c
           M /branches/zip/row/row0upd.c
      
        branches/zip: Remove update-in-place-in-select from the internal SQL
        interpreter.  It was only used for updating the InnoDB internal data
        dictionary when renaming or dropping tables.  It could have caused
        deadlocks after acquiring latches on insert buffer bitmap pages.
        This and r3544 should fix Issue #135.
      
        Furthermore, the update-in-place-in-select does not account for
        compression failure.  That was not a problem yet, since the InnoDB SQL
        interpreter has so far assumed ROW_FORMAT=REDUNDANT.
      
        rb://63 approved by Heikki Tuuri
        ------------------------------------------------------------------------
      82cfb40d
  6. 16 Dec, 2008 4 commits
    • marko's avatar
      branches/innodb+: row_ins_index_entry_low(): Do not attempt to buffer · 2d403a4d
      marko authored
      inserts into the clustered index, so that the ut_ad() introduced in
      r3475 will not fail.
      2d403a4d
    • marko's avatar
      branches/innodb+: Merge revisions 3541:3544 from branches/zip: · 880a55f7
      marko authored
        ------------------------------------------------------------------------
        r3541 | marko | 2008-12-16 12:14:58 +0200 (Tue, 16 Dec 2008) | 3 lines
      
        branches/zip: btr_cur_optimistic_delete(): Note that no further pages
        must be latched before calling mtr_commit(mtr) if the function returns TRUE.
        ------------------------------------------------------------------------
        r3544 | marko | 2008-12-16 15:52:36 +0200 (Tue, 16 Dec 2008) | 20 lines
      
        branches/zip: Do not update the free bits in the insert buffer bitmap
        when inserting or deleting from the insert buffer B-tree.  Assert that
        records in the insert buffer B-tree are never updated.  This could cure
        Issue #135.
      
        btr_cur_optimistic_insert(): Do not update the insert buffer bitmap
        when inserting to the insert buffer tree.
      
        btr_cur_optimistic_delete(): Do not update the insert buffer bitmap
        when deleting from the insert buffer tree.  This could be the cause
        of the assertion failure that was reported in Issue #135.
      
        btr_cur_update_alloc_zip(): Assert that the index is not the insert
        buffer.  The insert buffer will never be stored in compressed format.
      
        btr_cur_update_in_place(), btr_cur_optimistic_update(),
        btr_cur_pessimistic_update(): Assert that these functions are never
        invoked on the insert buffer tree.  The insert buffer only supports
        the insertion and deletion of records.
        ------------------------------------------------------------------------
      880a55f7
    • marko's avatar
      branches/innodb+: Merge revisions 3519:3541 from branches/zip: · 0a8380ab
      marko authored
        ------------------------------------------------------------------------
        r3537 | marko | 2008-12-16 10:24:03 +0200 (Tue, 16 Dec 2008) | 3 lines
      
        branches/zip: sync_thread_add_level(): Add a comment explaining the
        assertion about SYNC_BUF_POOL and SYNC_BUF_BLOCK.
        ------------------------------------------------------------------------
        r3540 | marko | 2008-12-16 12:13:31 +0200 (Tue, 16 Dec 2008) | 2 lines
      
        branches/zip: buf_page_init_for_read(): Use common code for error exit.
        ------------------------------------------------------------------------
        r3541 | marko | 2008-12-16 12:14:58 +0200 (Tue, 16 Dec 2008) | 3 lines
      
        branches/zip: btr_cur_optimistic_delete(): Note that no further pages
        must be latched before calling mtr_commit(mtr) if the function returns TRUE.
        ------------------------------------------------------------------------
      0a8380ab
    • marko's avatar
      branches/innodb+: ibuf_insert_low(): Use common error handling · 79e5dc96
      marko authored
      when holding a latch on the insert buffer bitmap page.
      79e5dc96
  7. 12 Dec, 2008 6 commits
    • marko's avatar
      branches/innodb+: Merge revisions 3498:3519 from branches/zip: · 364910b1
      marko authored
        ------------------------------------------------------------------------
        r3514 | marko | 2008-12-12 13:39:40 +0200 (Fri, 12 Dec 2008) | 3 lines
      
        branches/zip: btr_cur_search_to_nth_level(): Remove a duplicate check
        for (rw_latch != RW_NO_LATCH) around debug code.
        ------------------------------------------------------------------------
      
      Other branches/zip revisions in that range were backported from
      branches/innodb+ and were thus not merged back to branches/innodb+.
      364910b1
    • marko's avatar
      branches/innodb+: ibuf_merge_or_delete_for_page(): Replace a double if · f13f514c
      marko authored
      with a single functionally equivalent if.
      f13f514c
    • marko's avatar
      branches/innodb+: Clean up the buffering of purges. Instead of · 60bbfd6d
      marko authored
      traversing the index B-tree twice (first in BTR_WATCH_LEAF mode and
      then in BTR_DELETE mode), let BTR_DELETE take care of checking that
      the record can be purged, and either buffering or performing the
      purge.
      
      row_purge_poss_sec(): New function, to check if it is possible to
      purge a secondary index record.  Refactored from
      row_purge_remove_sec_if_poss_low().
      
      row_purge_remove_sec_if_poss_nonbuffered(): Rename to
      row_purge_remove_sec_if_poss_tree().  Remove the parameter mode
      (always use BTR_MODIFY_TREE).  Use row_purge_poss_sec().
      
      row_purge_remove_sec_if_poss_low(): Rename to
      row_purge_remove_sec_if_poss_leaf().  Remove the parameter mode
      (always use BTR_MODIFY_LEAF). Let row_search_index_entry() do all the
      hard work.
      
      btr_cur_t: Add purge_node, which will be needed by
      btr_cur_search_to_nth_level() for BTR_DELETE.  Replace the flag value
      BTR_CUR_ABORTED with BTR_CUR_DELETE_REF and BTR_CUR_DELETE_FAILED.
      
      enum row_search_result, row_search_index_entry(): Replace
      ROW_NOT_IN_POOL with ROW_NOT_DELETED_REF and ROW_NOT_DELETED.
      
      btr_cur_search_to_nth_level(): Remove BTR_WATCH_LEAF.  As a side
      effect, the adaptive hash index can be used in purge as well.  If
      BTR_DELETE cannot be buffered, attempt btr_cur_optimistic_delete().
      Either way, check row_purge_poss_sec().  Move the code to set
      cursor->ibuf_count to get rid of another if (height == 0)
      check. Eliminate the label loop_end.  Do not call ibuf_should_try()
      twice.
      
      ibuf_should_try(): Now that the successful calls to this function will
      be halved, halve the magic constant that ibuf_flush_count will be
      compared to, accordingly.
      
      The changes regarding ibuf_should_try() were merged from branches/zip
      r3515.
      
      rb://60 approved by Heikki over IM
      60bbfd6d
    • marko's avatar
      branches/innodb+: btr_cur_search_to_nth_level(): Move some code before · bc452636
      marko authored
      the only goto loop_end after the loop_end: label to improve
      readability.
      bc452636
    • marko's avatar
      branches/innodb+: ibuf_insert_low(): Combine two nested if statements · a78bf6dd
      marko authored
      to one.  Note that buf_pool_watch_occurred(space, page_no) could start
      to hold again and explain why it is not a problem.
      a78bf6dd
    • marko's avatar
      branches/innodb+: btr_cur_search_to_nth_level(): Check for · 7d552257
      marko authored
      BTR_INSERT, BTR_DELETE, and BTR_DELETE_MARK in a single switch,
      and assert that at most one is specified at a time.
      7d552257
  8. 11 Dec, 2008 1 commit
    • marko's avatar
      branches/innodb+: Merge revisions 3459:3498 from branches/zip: · 127664eb
      marko authored
        ------------------------------------------------------------------------
        r3459 | vasil | 2008-12-09 11:49:03 +0200 (Tue, 09 Dec 2008) | 152 lines
      
        branches/zip:
      
        Merge 2929:3458 from branches/5.1 (resolving conflict in c3257,
        note also that r3363 reverted r2933 so there are not changes in
        mysql-test/innodb-autoinc.result with the current merge):
      
          ------------------------------------------------------------------------
          r2933 | calvin | 2008-10-30 02:57:31 +0200 (Thu, 30 Oct 2008) | 10 lines
          Changed paths:
             M /branches/5.1/mysql-test/innodb-autoinc.result
      
          branches/5.1: correct the result file innodb-autoinc.result
      
          Change the followings:
            auto_increment_increment
            auto_increment_offset
      
          to
            auto-increment-increment
            auto-increment-offset
          ------------------------------------------------------------------------
          r2981 | marko | 2008-11-07 14:54:10 +0200 (Fri, 07 Nov 2008) | 5 lines
          Changed paths:
             M /branches/5.1/row/row0mysql.c
      
          branches/5.0: row_mysql_store_col_in_innobase_format(): Correct a misleading
          comment. In the UTF-8 encoding, ASCII takes 1 byte per character, while
          the "latin1" character set (normally ISO-8859-1, but in MySQL it actually
          refers to the Windows Code Page 1252 a.k.a. CP1252, WinLatin1)
          takes 1 to 3 bytes (1 to 2 bytes for the ISO-8859-1 subset).
          ------------------------------------------------------------------------
          r3114 | calvin | 2008-11-14 20:31:48 +0200 (Fri, 14 Nov 2008) | 8 lines
          Changed paths:
             M /branches/5.1/handler/ha_innodb.cc
      
          branches/5.1: fix bug#40386: Not flushing query cache after truncate
      
          ha_statistics.records can not be 0 unless the table is empty, set to
          1 instead. The original problem of bug#29507 is fixed in the server.
      
          Additional test was done with the fix of bug#29507 in the server.
      
          Approved by: Heikki (on IM)
          ------------------------------------------------------------------------
          r3257 | inaam | 2008-11-24 22:06:50 +0200 (Mon, 24 Nov 2008) | 13 lines
          Changed paths:
             M /branches/5.1/handler/ha_innodb.cc
             M /branches/5.1/srv/srv0srv.c
             M /branches/5.1/trx/trx0trx.c
      
          branches/5.1 bug#40760
      
          The config param innodb_thread_concurrency is dynamically set and is
          read when a thread enters/exits innodb. If the value is changed between
          the enter and exit time the behaviour becomes erratic.
          The fix is not to use srv_thread_concurrency when exiting, instead use
          the flag trx->declared_to_be_inside_innodb.
      
          rb://57
      
          Approved by: Marko
          ------------------------------------------------------------------------
          r3363 | calvin | 2008-12-04 19:00:20 +0200 (Thu, 04 Dec 2008) | 13 lines
          Changed paths:
             M /branches/5.1/mysql-test/innodb-autoinc.result
      
          branches/5.1: revert the changes in r2933
      
          The changes in r2933 causes test failure on Linux.
          More investigation is needed for Windows.
      
          Change the followings in innodb-autoinc.result:
            auto-increment-increment
            auto-increment-offset
      
          back to:
            auto_increment_increment
            auto_increment_offset
          ------------------------------------------------------------------------
          r3412 | vasil | 2008-12-05 10:46:18 +0200 (Fri, 05 Dec 2008) | 7 lines
          Changed paths:
             M /branches/5.1/trx/trx0undo.c
      
          branches/5.1:
      
          Add the traditional 2 spaces after the timestamp so the message does
          not look like:
      
          070223 13:26:01InnoDB: Warning: canno....
          ------------------------------------------------------------------------
          r3458 | vasil | 2008-12-09 11:21:08 +0200 (Tue, 09 Dec 2008) | 51 lines
          Changed paths:
             M /branches/5.1/mysql-test/innodb_bug34300.test
      
          branches/5.1:
      
          Merge a change from MySQL to fix the failing innodb_bug34300 mysql-test:
      
            main.innodb_bug34300           [ fail ]
      
            mysqltest: At line 11: query 'SET @@max_allowed_packet=16777216' failed: 1621: SESSION variable 'max_allowed_packet' is read-only. Use SET GLOBAL to assign the value
      
            Aborting: main.innodb_bug34300 failed in default mode.
      
          The changeset is this:
            ------------------------------------------------------------
            revno: 2709.1.10
            committer: Staale Smedseng <staale.smedseng@sun.com>
            branch nick: b22891-51-bugteam
            timestamp: Thu 2008-11-20 08:51:48 +0100
            message:
              A fix for Bug#22891 "session level max_allowed_packet can be
              set but is ignored".
      
              This patch makes @@session.max_allowed_packed and
              @@session.net_buffer_length read-only as suggested in the bug
              report. The user will have to use SET GLOBAL (and reconnect)
              to alter the session values of these variables.
      
              The error string ER_VARIABLE_IS_READONLY is introduced.
      
              Tests are modified accordingly.
            modified:
              mysql-test/r/func_compress.result
              mysql-test/r/max_allowed_packet_basic.result
              mysql-test/r/max_allowed_packet_func.result
              mysql-test/r/net_buffer_length_basic.result
              mysql-test/r/packet.result
              mysql-test/r/union.result
              mysql-test/r/variables.result
              mysql-test/t/func_compress.test
              mysql-test/t/innodb_bug34300.test
              mysql-test/t/max_allowed_packet_basic.test
              mysql-test/t/max_allowed_packet_func.test
              mysql-test/t/net_buffer_length_basic.test
              mysql-test/t/packet.test
              mysql-test/t/union.test
              mysql-test/t/variables.test
              sql/set_var.cc
              sql/set_var.h
              sql/share/errmsg.txt
            ------------------------------------------------------------
          ------------------------------------------------------------------------
        ------------------------------------------------------------------------
        r3480 | calvin | 2008-12-10 23:56:00 +0200 (Wed, 10 Dec 2008) | 11 lines
      
        branches/zip: Merge r3458:3479 from branches/5.1:
      
          ------------------------------------------------------------------------
          r3479 | calvin | 2008-12-10 15:30:05 -0600 (Wed, 10 Dec 2008) | 4 lines
      
          branches/5.1: change .result file eol-style to LF
      
          mysql-test-run only takes LF style even on Windows.
          ------------------------------------------------------------------------
        ------------------------------------------------------------------------
        r3481 | calvin | 2008-12-11 00:01:20 +0200 (Thu, 11 Dec 2008) | 4 lines
      
        branches/zip: change diff and result files eol-style to LF
      
        The patch utility takes LF style diff, and mysql-test-run
        also only takes LF style, even on Windows.
        ------------------------------------------------------------------------
        r3482 | calvin | 2008-12-11 00:19:07 +0200 (Thu, 11 Dec 2008) | 9 lines
      
        branches/zip: fix Mantis issue #138 InnoDB fails if
        innodb_buffer_pool_size >= 4096M on x64 Windows
      
        All three srv_buf_pool related variables are defined as ulong, which is
        32-bit on 64-bit Windows. They are changed to 64-bit ulint. Also
        system_info.dwPageSize appears to be 32-bit only. Casting to 64-bit
        is required.
      
        Approved by:    Marko (on IM)
        ------------------------------------------------------------------------
        r3498 | marko | 2008-12-11 17:08:14 +0200 (Thu, 11 Dec 2008) | 6 lines
      
        branches/zip: ibuf_merge_or_delete_for_page(): Restore the seemingly
        redundant checks for ibuf_fixed_addr_page() || fsp_descr_page() that
        were removed in r3432, and add a comment explaining why.
      
        Thanks to Michael for reporting this bug.
        ------------------------------------------------------------------------
      127664eb
  9. 10 Dec, 2008 4 commits
    • marko's avatar
      branches/innodb+: When buffering an insert, notify the buffer pool · 2bd90b44
      marko authored
      watch.  This should fix the race condition that seems to have caused
      Issue #126: When another thread is buffering an insert for the record
      that is being purged, it should invoke buf_pool_watch_notify(), so
      that the purge will not be buffered. Otherwise, the purge would be
      buffered for the wrong record (one that was inserted after the purge
      determined that the record can be removed).
      
      When deletes are not buffered, the latch on the secondary index page
      would prevent the insert from occurring.  In delete buffering, the
      buf_pool_watch replaces the page latch when the page is not in the
      buffer pool.
      
      buf_pool_watch_notify(): Make public.
      
      ibuf_insert(): Invoke buf_pool_watch_notify() when buffering an
      insert or a delete-mark operation.
      2bd90b44
    • marko's avatar
      branches/innodb+: ibuf_delete(), · 838b6909
      marko authored
      row_purge_remove_sec_if_poss_low_nonbuffered(): Add debug assertions
      that records to be purged must have been marked for deletion.
      838b6909
    • marko's avatar
      fbb56135
    • marko's avatar
      branches/innodb+: btr_cur_search_to_nth_level(): Add debug assertions · efbc02a9
      marko authored
      that operations on clustered indexes or on the insert buffer B-tree
      must not be buffered.
      efbc02a9
  10. 09 Dec, 2008 1 commit
    • marko's avatar
      branches/innodb+: Merge revisions 3312:3459 from branches/zip: · 4c7f7c42
      marko authored
        ------------------------------------------------------------------------
        r3328 | marko | 2008-12-02 10:16:05 +0200 (Tue, 02 Dec 2008) | 7 lines
      
        branches/zip: page_cur_insert_rec_zip(): When allocating insert_buf
        from the free list, zero out the DB_TRX_ID and DB_ROLL_PTR of the
        deleted record if the new record would not overwrite these
        fields. This fixes a harmless content mismatch reported by
        page_zip_validate() that was reported as Issue #111.
        rb://55 approved by Sunny Bains.
        ------------------------------------------------------------------------
        r3329 | vasil | 2008-12-02 12:03:17 +0200 (Tue, 02 Dec 2008) | 4 lines
      
        branches/zip:
      
        Add entry in the ChangeLog for the release of 1.0.2.
        ------------------------------------------------------------------------
        r3331 | vasil | 2008-12-02 12:09:20 +0200 (Tue, 02 Dec 2008) | 5 lines
      
        branches/zip:
      
        Remove an entry from the ChnageLog for a change that was made before
        the release of 1.0.2 but was not included in that release.
        ------------------------------------------------------------------------
        r3333 | vasil | 2008-12-02 12:11:54 +0200 (Tue, 02 Dec 2008) | 4 lines
      
        branches/zip:
      
        Now that 1.0.2 is out, the current tree is version 1.0.3.
        ------------------------------------------------------------------------
        r3336 | vasil | 2008-12-02 13:34:36 +0200 (Tue, 02 Dec 2008) | 5 lines
      
        branches/zip:
      
        Resurrect a ChangeLog entry that I removed in c3331 with a fake date
        so it does not appear that it has been included in 1.0.2.
        ------------------------------------------------------------------------
        r3361 | vasil | 2008-12-04 18:10:08 +0200 (Thu, 04 Dec 2008) | 9 lines
      
        branches/zip:
      
        Fix Mantis issue#103 mysql_addons.c depends on THD internals - please remove it
      
        Use MySQL's thd_get_thread_id() instead of our own ib_thd_get_thread_id()
        since MySQL implemented the former, see http://bugs.mysql.com/30930.
      
        Approved by:    Marko (https://svn.innodb.com/rb/r/40, rb://40)
        ------------------------------------------------------------------------
        r3362 | vasil | 2008-12-04 18:49:24 +0200 (Thu, 04 Dec 2008) | 15 lines
      
        branches/zip:
      
        Revert our temporary fix for Bug#40360 Binlog related errors with binlog off
      
        This bug was fixed in MySQL code.
      
        Our fix went into r2944 and r2947, but this patch does not entirely revert
        those revisions because we want to leave the test case that was introduced
        and also r2944 itself reverted r2935 and r2936. So if we completely revert
        r2944 and r2947 then we would loose the test and will restore r2935 and
        r2936.
      
        This resolves Issue#108 We should remove ib_bin_log_is_engaged() once mysql
        add an equivallent, see Bug#40360
        ------------------------------------------------------------------------
        r3404 | marko | 2008-12-05 10:02:54 +0200 (Fri, 05 Dec 2008) | 5 lines
      
        branches/zip: row_undo_mod_del_mark_or_remove_sec_low(): Do not
        complain if the record is not found.  Explain that this is possible
        when a deadlock occurs during an update.  Heikki investigated this
        in Issue #134.
        ------------------------------------------------------------------------
        r3432 | marko | 2008-12-08 14:14:01 +0200 (Mon, 08 Dec 2008) | 4 lines
      
        branches/zip: ibuf_merge_or_delete_for_page(): Remove the redundant
        checks for ibuf_fixed_addr_page() || fsp_descr_page().  The one at
        the beginning of the function is enough.
        ------------------------------------------------------------------------
        r3456 | marko | 2008-12-09 10:31:26 +0200 (Tue, 09 Dec 2008) | 3 lines
      
        branches/zip: row_purge_remove_sec_if_poss_low(): Allocate mtr_vers
        from the stack, not with mem_alloc().
        ------------------------------------------------------------------------
        r3459 | vasil | 2008-12-09 11:49:03 +0200 (Tue, 09 Dec 2008) | 152 lines
      
        branches/zip:
      
        Merge 2929:3458 from branches/5.1 (resolving conflict in c3257,
        note also that r3363 reverted r2933 so there are not changes in
        mysql-test/innodb-autoinc.result with the current merge):
      
          ------------------------------------------------------------------------
          r2933 | calvin | 2008-10-30 02:57:31 +0200 (Thu, 30 Oct 2008) | 10 lines
          Changed paths:
             M /branches/5.1/mysql-test/innodb-autoinc.result
      
          branches/5.1: correct the result file innodb-autoinc.result
      
          Change the followings:
            auto_increment_increment
            auto_increment_offset
      
          to
            auto-increment-increment
            auto-increment-offset
      
          ------------------------------------------------------------------------
          r2981 | marko | 2008-11-07 14:54:10 +0200 (Fri, 07 Nov 2008) | 5 lines
          Changed paths:
             M /branches/5.1/row/row0mysql.c
      
          branches/5.0: row_mysql_store_col_in_innobase_format(): Correct a misleading
          comment. In the UTF-8 encoding, ASCII takes 1 byte per character, while
          the "latin1" character set (normally ISO-8859-1, but in MySQL it actually
          refers to the Windows Code Page 1252 a.k.a. CP1252, WinLatin1)
          takes 1 to 3 bytes (1 to 2 bytes for the ISO-8859-1 subset).
          ------------------------------------------------------------------------
          r3114 | calvin | 2008-11-14 20:31:48 +0200 (Fri, 14 Nov 2008) | 8 lines
          Changed paths:
             M /branches/5.1/handler/ha_innodb.cc
      
          branches/5.1: fix bug#40386: Not flushing query cache after truncate
      
          ha_statistics.records can not be 0 unless the table is empty, set to
          1 instead. The original problem of bug#29507 is fixed in the server.
      
          Additional test was done with the fix of bug#29507 in the server.
      
          Approved by: Heikki (on IM)
          ------------------------------------------------------------------------
          r3257 | inaam | 2008-11-24 22:06:50 +0200 (Mon, 24 Nov 2008) | 13 lines
          Changed paths:
             M /branches/5.1/handler/ha_innodb.cc
             M /branches/5.1/srv/srv0srv.c
             M /branches/5.1/trx/trx0trx.c
      
          branches/5.1 bug#40760
      
          The config param innodb_thread_concurrency is dynamically set and is
          read when a thread enters/exits innodb. If the value is changed between
          the enter and exit time the behaviour becomes erratic.
          The fix is not to use srv_thread_concurrency when exiting, instead use
          the flag trx->declared_to_be_inside_innodb.
      
          rb://57
      
          Approved by: Marko
      
      
          ------------------------------------------------------------------------
          r3363 | calvin | 2008-12-04 19:00:20 +0200 (Thu, 04 Dec 2008) | 13 lines
          Changed paths:
             M /branches/5.1/mysql-test/innodb-autoinc.result
      
          branches/5.1: revert the changes in r2933
      
          The changes in r2933 causes test failure on Linux.
          More investigation is needed for Windows.
      
          Change the followings in innodb-autoinc.result:
            auto-increment-increment
            auto-increment-offset
      
          back to:
            auto_increment_increment
            auto_increment_offset
      
          ------------------------------------------------------------------------
          r3412 | vasil | 2008-12-05 10:46:18 +0200 (Fri, 05 Dec 2008) | 7 lines
          Changed paths:
             M /branches/5.1/trx/trx0undo.c
      
          branches/5.1:
      
          Add the traditional 2 spaces after the timestamp so the message does
          not look like:
      
          070223 13:26:01InnoDB: Warning: canno....
      
          ------------------------------------------------------------------------
          r3458 | vasil | 2008-12-09 11:21:08 +0200 (Tue, 09 Dec 2008) | 51 lines
          Changed paths:
             M /branches/5.1/mysql-test/innodb_bug34300.test
      
          branches/5.1:
      
          Merge a change from MySQL to fix the failing innodb_bug34300 mysql-test:
      
            main.innodb_bug34300           [ fail ]
      
            mysqltest: At line 11: query 'SET @@max_allowed_packet=16777216' failed: 1621: SESSION variable 'max_allowed_packet' is read-only. Use SET GLOBAL to assign the value
      
            Aborting: main.innodb_bug34300 failed in default mode.
      
          The changeset is this:
      
            ------------------------------------------------------------
            revno: 2709.1.10
            committer: Staale Smedseng <staale.smedseng@sun.com>
            branch nick: b22891-51-bugteam
            timestamp: Thu 2008-11-20 08:51:48 +0100
            message:
              A fix for Bug#22891 "session level max_allowed_packet can be
              set but is ignored".
      
              This patch makes @@session.max_allowed_packed and
              @@session.net_buffer_length read-only as suggested in the bug
              report. The user will have to use SET GLOBAL (and reconnect)
              to alter the session values of these variables.
      
              The error string ER_VARIABLE_IS_READONLY is introduced.
      
              Tests are modified accordingly.
            modified:
              mysql-test/r/func_compress.result
              mysql-test/r/max_allowed_packet_basic.result
              mysql-test/r/max_allowed_packet_func.result
              mysql-test/r/net_buffer_length_basic.result
              mysql-test/r/packet.result
              mysql-test/r/union.result
              mysql-test/r/variables.result
              mysql-test/t/func_compress.test
              mysql-test/t/innodb_bug34300.test
              mysql-test/t/max_allowed_packet_basic.test
              mysql-test/t/max_allowed_packet_func.test
              mysql-test/t/net_buffer_length_basic.test
              mysql-test/t/packet.test
              mysql-test/t/union.test
              mysql-test/t/variables.test
              sql/set_var.cc
              sql/set_var.h
              sql/share/errmsg.txt
            ------------------------------------------------------------
          ------------------------------------------------------------------------
        ------------------------------------------------------------------------
      4c7f7c42
  11. 04 Dec, 2008 4 commits
    • marko's avatar
      branches/innodb+: btr_cur_t: Remove leaf_in_buf_pool. The flag can be · 6c3a99a7
      marko authored
      determined from flag == BTR_CUR_ABORTED.  This flag value was previously
      never tested for.  It was only assigned to, in the only place where
      leaf_in_buf_pool would be set FALSE.
      
      btr_cur_search_to_nth_level(): Do not initialize cursor->leaf_in_buf_pool.
      
      btr_pcur_was_buffered(): Remove.  The only caller, row_search_index_entry(),
      will switch (cursor->flag) and handle BTR_CUR_ABORTED as well.
      
      row_purge_remove_sec_if_poss_low(): Remove the assertions on leaf_in_buf_pool.
      6c3a99a7
    • inaam's avatar
      branches/innodb+ · dedade9f
      inaam authored
      I have added some too strict assertions on Marko's suggestion in r3355.
      This patch removes those assertions.
      
      
      dedade9f
    • inaam's avatar
      branches/innodb+ issue#115 · d81f8228
      inaam authored
      This is to fix issues introduced by recovery enhancements committed
      through r2993. The fix is to update flush_rbt whenever flush_list is
      manipulated because of buf_page/buf_block relocation.
      
      rb://54
      
      Reviewed by: Marko
      d81f8228
    • marko's avatar
      branches/innodb+: ibuf_insert_low(): Remove a race condition related to · 8b4a0686
      marko authored
      buf_pool_watch_occurred() and add explaining comments.
      8b4a0686
  12. 03 Dec, 2008 2 commits
  13. 01 Dec, 2008 2 commits
  14. 28 Nov, 2008 1 commit
    • marko's avatar
      branches/innodb+: Merge revisions 3180:3312 from branches/zip: · b6679b1d
      marko authored
        ------------------------------------------------------------------------
        r3254 | marko | 2008-11-24 18:01:42 +0200 (Mon, 24 Nov 2008) | 4 lines
      
        branches/zip: Note that it is legitimate for a secondary index record not
        to be found during purge.  This tries to address Issue #129.  The comments
        were supplied by Heikki.
        ------------------------------------------------------------------------
        r3286 | marko | 2008-11-26 10:00:28 +0200 (Wed, 26 Nov 2008) | 18 lines
      
        branches/zip: row_merge_drop_temp_indexes(): Replace the WHILE 1 with
        WHILE 1=1 in the SQL procedure, so that the loop will actually be
        entered and temporary indexes be dropped during crash recovery.
        Thanks to Sunny Bains for pointing this out.
      
        Tested as follows:
      
        Set a breakpoint in row_merge_rename_indexes.
      
        CREATE TABLE t(a INT)ENGINE=InnoDB;
        CREATE INDEX a ON t(a);
      
        -- The breakpoint will be reached.  Kill and restart mysqld.
        SHOW CREATE TABLE t;
        -- This shows the MySQL .frm file, without and index.
        CREATE TABLE innodb_table_monitor(a INT)ENGINE=InnoDB;
        -- This will dump the InnoDB dictionary to the error log, without the index.
        ------------------------------------------------------------------------
        r3302 | vasil | 2008-11-27 23:26:39 +0200 (Thu, 27 Nov 2008) | 12 lines
      
        branches/zip:
      
        Fix Mantis issue#130 wdl: does not handle 64-bit address
      
        - Change the call from strtoul() to strtoull()
        - Change "%16X" to "%16llx" when scanning preferred load address
      
        rb://58
      
        Submitted by:   Calvin
        Approved by:    Marko
        ------------------------------------------------------------------------
        r3303 | vasil | 2008-11-27 23:31:18 +0200 (Thu, 27 Nov 2008) | 10 lines
      
        branches/zip:
      
        * Remove a change from win-plugin/win-plugin.diff about time_t because
          MySQL has used VS2005 for building 5.1.30.
      
        * Adjust the line numbers so the patch applies cleanly without fuzz and
          offset messages.
      
        Submitted by:   Calvin
        ------------------------------------------------------------------------
        r3304 | vasil | 2008-11-27 23:33:48 +0200 (Thu, 27 Nov 2008) | 6 lines
      
        branches/zip:
      
        Non-functional change in win-plugin/win-plugin.diff: fix the file name
        before the diff, this is irrelevant but it is nice to be the same as
        the file name on the following line.
        ------------------------------------------------------------------------
        r3312 | marko | 2008-11-28 16:18:43 +0200 (Fri, 28 Nov 2008) | 5 lines
      
        branches/zip: row_undo_mod_del_mark_or_remove_sec_low(): Complain if
        the secondary index entry cannot be found, and this is not an incomplete
        transaction that is being rolled back in crash recovery.  The source code
        comments were suggested by Heikki.
        ------------------------------------------------------------------------
      b6679b1d
  15. 21 Nov, 2008 2 commits
    • marko's avatar
      branches/innodb+: Merge revisions 3177:3180 from branches/zip: · 87c9f0fc
      marko authored
        ------------------------------------------------------------------------
        r3180 | marko | 2008-11-21 16:36:18 +0200 (Fri, 21 Nov 2008) | 3 lines
      
        branches/zip: buf_LRU_free_block(): Do not assert on ibuf_count until after
        it has been determined that the block is not being I/O-fixed.
        This corrects the mistake that was made in r3177.
        ------------------------------------------------------------------------
      87c9f0fc
    • marko's avatar
      branches/innodb+: Merge revisions 3152:3177 from branches/zip: · 7172c215
      marko authored
        ------------------------------------------------------------------------
        r3170 | marko | 2008-11-21 10:11:18 +0200 (Fri, 21 Nov 2008) | 4 lines
      
        branches/zip: dtuple_print(): Dump each field in a separate line,
        so that the dumps can be read and compared more easily.
        This is related to the change to rec_print_old() and rec_print_comp()
        in r3148.
        ------------------------------------------------------------------------
        r3177 | marko | 2008-11-21 16:24:31 +0200 (Fri, 21 Nov 2008) | 3 lines
      
        branches/zip: buf_LRU_free_block(), buf_page_try_get_func(): Assert that
        there is nothing in the insert buffer for the page.  This is for
        tracking down Issue #128.
        ------------------------------------------------------------------------
      7172c215
  16. 20 Nov, 2008 3 commits
    • marko's avatar
      branches/innodb+: ibuf_get_volume_buffered_count(): Compute also the · f5cd22f3
      marko authored
      space taken by merging the buffered record to the index page.
      Assert that the record is in the "multiple tablespaces" format.
      
      ibuf_get_volume_buffered(): Remove the calls to ibuf_rec_get_volume()
      and use the return value of ibuf_get_volume_buffered_count() instead.
      f5cd22f3
    • marko's avatar
      branches/innodb+: Merge revisions 2986:3152 from branches/zip: · ace10f32
      marko authored
        ------------------------------------------------------------------------
        r3036 | marko | 2008-11-12 12:34:30 +0200 (Wed, 12 Nov 2008) | 4 lines
      
        branches/zip: dtuple_validate(): When UNIV_DEBUG_VALGRIND is defined,
        rely solely on the UNIV_MEM_ASSERT_RW() check and disable the for loop
        that would only cause additional noise.
        ------------------------------------------------------------------------
        r3037 | marko | 2008-11-12 13:52:57 +0200 (Wed, 12 Nov 2008) | 6 lines
      
        branches/zip: row_vers_impl_x_locked_off_kernel(): Remove compilation
        warnings about prev_trx_id and vers_del being possibly uninitialized,
        by handling the case prev_version == NULL in a single if block.
      
        rb://45 approved by Inaam Rana.
        ------------------------------------------------------------------------
        r3131 | michael | 2008-11-17 14:56:56 +0200 (Mon, 17 Nov 2008) | 9 lines
      
        branches/zip:
      
        rb://53
      
        Improve innodb_supports_xa system variable handling and
        reduces the number of retrievals of the value from MySQL.
      
        Approved by: Marko, over IM
        ------------------------------------------------------------------------
        r3132 | michael | 2008-11-17 16:02:01 +0200 (Mon, 17 Nov 2008) | 5 lines
      
        branches/zip: rb://53
      
        Final version of rb://53, fixes the styling of a comment, makes
        the definition and the declaration of thd_supports_xa() identical commentwise.
        ------------------------------------------------------------------------
        r3141 | marko | 2008-11-19 16:39:55 +0200 (Wed, 19 Nov 2008) | 1 line
      
        branches/zip: buf_LRU_free_block(): Clarify the function comment.
        ------------------------------------------------------------------------
        r3144 | marko | 2008-11-20 11:39:49 +0200 (Thu, 20 Nov 2008) | 2 lines
      
        branches/zip: rec_get_nth_field_offs_old(): Add UNIV_UNLIKELY hints
        to assertion-like tests.
        ------------------------------------------------------------------------
        r3145 | marko | 2008-11-20 12:22:40 +0200 (Thu, 20 Nov 2008) | 20 lines
      
        branches/zip: Always check for "row too large" when executing SQL to create
        an index or table.  We have to skip this check when loading table definitions
        from the data dictionary, because we could otherwise refuse to load old
        tables (even uncompressed ones).  This addresses Issue #119.
      
        The first "row too large" check was implemented in MySQL 5.0.3
        to address MySQL Bug #5682.  In the InnoDB Plugin 1.0.2, a more
        accurate check was implemented in innodb_strict_mode.  We now
        make the check unconditional.
      
        dict_create_index_step(): Pass strict=TRUE to dict_index_add_to_cache().
      
        trx_is_strict(), thd_is_strict(): Remove.
      
        innodb-zip.test: Test in innodb_strict_mode=OFF.
      
        innodb_bug36169.test: Ensure that none of the tables can be created.
      
        rb://56 approved by Sunny Bains.
        ------------------------------------------------------------------------
        r3148 | marko | 2008-11-20 13:27:27 +0200 (Thu, 20 Nov 2008) | 3 lines
      
        branches/zip: rec_print_old(), rec_print_comp(): Dump each field in a
        separate line, so that the dumps can be read and compared more easily.
        ------------------------------------------------------------------------
      ace10f32
    • marko's avatar
      branches/innodb+: ibuf_get_volume_buffered(): Do not clear the · fca2e168
      marko authored
      hash_bitmap a second time.  Only clear it if n_recs has been set.
      fca2e168
  17. 19 Nov, 2008 1 commit
  18. 12 Nov, 2008 1 commit