1. 26 Oct, 2009 2 commits
    • Dmitry Lenev's avatar
      Fix for bug #45143 "All connections hang on concurrent ALTER TABLE". · 86c23fa7
      Dmitry Lenev authored
      Concurrent execution of statements which require non-table-level
      write locks on several instances of the same table (such as
      SELECT ... FOR UPDATE which uses same InnoDB table twice or a DML
      statement which invokes trigger which tries to update same InnoDB
      table directly and through stored function) and statements which
      required table-level locks on this table (e.g. LOCK TABLE ... WRITE,
      ALTER TABLE, ...) might have resulted in a deadlock.
      
      The problem occured when a thread tried to acquire write lock
      (TL_WRITE_ALLOW_WRITE) on the table but had to wait since there was
      a pending write lock (TL_WRITE, TL_WRITE_ALLOW_READ) on this table
      and we failed to detect that this thread already had another instance
      of write lock on it (so in fact we were trying to acquire recursive
      lock) because there was also another thread holding write lock on the
      table (also TL_WRITE_ALLOW_WRITE). When the latter thread released
      its lock neither the first thread nor the thread trying to acquire
      TL_WRITE/TL_WRITE_ALLOW_READ were woken up (as table was still write
      locked by the first thread) so we ended up with a deadlock.
      
      This patch solves this problem by ensuring that thread which
      already has write lock on the table won't wait when it tries
      to acquire second write lock on the same table.
      
      mysql-test/r/lock_sync.result:
        Added test case for bug #45143 "All connections hang on concurrent
        ALTER TABLE".
      mysql-test/t/lock_sync.test:
        Added test case for bug #45143 "All connections hang on concurrent
        ALTER TABLE".
      mysys/thr_lock.c:
        Ensured that thread can acquire write lock on the table without
        waiting if it already has write lock on it even if there are other
        threads holding write locks on this table (this is normal situation
        for, e.g., TL_WRITE_ALLOW_WRITE type of lock).
        
        Adjusted comments to better explain why it is OK to do so and added
        asserts to prevent introduction of scenarios in which this can cause
        problems.
      86c23fa7
    • Sergey Glukhov's avatar
      Bug#35427 INFORMATION_SCHEMA.TABLES.TABLE_CATALOG is NULL, should be "def" · 90e2ad95
      Sergey Glukhov authored
      additional fix(Betony)
      
      90e2ad95
  2. 23 Oct, 2009 8 commits
  3. 22 Oct, 2009 17 commits
  4. 21 Oct, 2009 5 commits
    • Alexander Nozdrin's avatar
      Backport WL#4098 from 6.0. · 2c5ee88a
      Alexander Nozdrin authored
      The value was changed from 1024 to 2048,
      because 1024 is already used.
      
      Original revision:
      ------------------------------------------------------------
      revno: 2476.657.259
      committer: tsmith@bk-internal.mysql.com
      timestamp: Tue 2008-01-29 19:32:44 +0100
      message:
        WL#4098: Add a status flag for slow queries
        
        Add new result set status flag SERVER_QUERY_WAS_SLOW in mysql_com.h.
        
        There is no server-side implementation to actually set this flag at this
        time.  This patch simply defines the interface so that applications can
        make use of it.  See the worklog for background.
      ------------------------------------------------------------
      2c5ee88a
    • Alexander Nozdrin's avatar
      Backporting WL#3953 from 6.0. Original revision: · 6756b0fc
      Alexander Nozdrin authored
      ```---------------------------------------------------------
      revno: 2476.714.9
      committer: markleith@medusa.mysql.com
      timestamp: Mon 2007-09-03 23:18:50 +0100
      message:
        Bug#25822 / WL#3953 - Log Access Denied errors for bad passwords in the error log
        
        Added logging of Access Denied messages on failed new connections to the 
        error log when log-warnings = 2.
        
        This allows a user to log these messages without having to incur the overhead
        of using the general query log on production systems.
      ```
      
      ---------------------------------------------------------
      6756b0fc
    • Alexander Nozdrin's avatar
      ff98b6a2
    • Alexander Barkov's avatar
      dcb8bb23
    • Bjorn Munch's avatar
      merge from next-mr · 0632e9a4
      Bjorn Munch authored
      0632e9a4
  5. 20 Oct, 2009 8 commits