1. 17 Apr, 2007 1 commit
  2. 15 Apr, 2007 6 commits
    • unknown's avatar
      subselect.result: · a30802b4
      unknown authored
        After merge fix.
      
      
      mysql-test/r/subselect.result:
        After merge fix.
      a30802b4
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/27321-bug-5.0-opt-mysql · b138a4d3
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.1-opt
      
      
      mysql-test/r/subselect3.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      b138a4d3
    • unknown's avatar
      item.cc: · ac7b8e31
      unknown authored
        Fix warning after fix for bug#27321.
      
      
      sql/item.cc:
        Fix warning after fix for bug#27321.
      ac7b8e31
    • unknown's avatar
      subselect.test, subselect.result: · 5ac8dab5
      unknown authored
        After merge fix.
      
      
      mysql-test/r/subselect.result:
        After merge fix.
      mysql-test/t/subselect.test:
        After merge fix.
      5ac8dab5
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d06ea19d
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27321-bug-5.0-opt-mysql
      
      
      mysql-test/r/subselect3.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manually merged
      mysql-test/t/subselect.test:
        Manually merged
      mysql-test/t/subselect3.test:
        Manually merged
      d06ea19d
    • unknown's avatar
      Bug#27321: Wrong subquery result in a grouping select. · 321726e8
      unknown authored
      The Item_outer_ref class based on the Item_direct_ref class was always used
      to represent an outer field. But if the outer select is a grouping one and the 
      outer field isn't under an aggregate function which is aggregated in that
      outer select an Item_ref object should be used to represent such a field.
      If the outer select in which the outer field is resolved isn't grouping then
      the Item_field class should be used to represent such a field.
      This logic also should be used for an outer field resolved through its alias
      name.
      
      Now the Item_field::fix_outer_field() uses Item_outer_field objects to
      represent aliased and non-aliased outer fields for grouping outer selects
      only.
      Now the fix_inner_refs() function chooses which class to use to access outer
      field - the Item_ref or the Item_direct_ref. An object of the chosen class
      substitutes the original field in the Item_outer_ref object.
      The direct_ref and the found_in_select_list fields were added to the
      Item_outer_ref class.
      
      
      mysql-test/t/subselect3.test:
        Some test cases were corrected after the fix for the bug#27321.
      mysql-test/r/subselect3.result:
        Some test cases were corrected after the fix for the bug#27321.
      mysql-test/t/subselect.test:
        Added a test case for the bug#27321: Wrong subquery result in a grouping select.
      mysql-test/r/subselect.result:
        Added a test case for the bug#27321: Wrong subquery result in a grouping select.
        Some test cases were corrected after this fix.
      sql/sql_union.cc:
        Bug#27321: Wrong subquery result in a grouping select.
        Cleanup of the inner_refs_list.
      sql/sql_select.cc:
        Bug#27321: Wrong subquery result in a grouping select.
        Now the fix_inner_refs() function chooses which class to use to access outer
        field - the Item_ref or the Item_direct_ref. An object of the chosen class
        substitutes the original field in the Item_outer_ref object.
        A comment is corrected.
      sql/item.cc:
        Bug#27321: Wrong subquery result in a grouping select.
        Now the Item_field::fix_outer_field() uses Item_outer_field objects to
        represent aliased and non-aliased outer fields for grouping outer selects
        only.
      sql/item.h:
        Bug#27321: Wrong subquery result in a grouping select.
        The direct_ref and the found_in_select_list fields were added to the
        Item_outer_ref class.
      321726e8
  3. 14 Apr, 2007 11 commits
    • unknown's avatar
      A post-merge fix. · cb960430
      unknown authored
      
      mysql-test/r/sp.result:
        Manual merge.
      cb960430
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-5.0-runtime · 27cb5c7a
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/t/sp.test:
        Auto merged
      mysql-test/r/sp.result:
        Use local
      27cb5c7a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 91c01d99
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      client/mysqldump.c:
        Auto merged
      sql/events.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      91c01d99
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 4cf88937
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.0-runtime
      
      4cf88937
    • unknown's avatar
      Fix rpl_trigger.test failure in the runtime tree. · a53e3b38
      unknown authored
      
      sql/sql_trigger.cc:
        Fix a failure of rpl_trigger.test: triggers are not SUID on 
        replication slaves.
      a53e3b38
    • unknown's avatar
      Merge mysql.com:/d2/hf/mrg/mysql-5.0-opt · 1932481c
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-5.1-opt
      
      1932481c
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1 · eea0ac3e
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-5.1-opt
      
      eea0ac3e
    • unknown's avatar
      Merge mysql.com:/d2/hf/mrg/mysql-4.1-opt · 797c7650
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-5.0-opt
      
      797c7650
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 02a02fb6
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-5.0-opt
      
      02a02fb6
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · ddd19c66
      unknown authored
      into  mysql.com:/d2/hf/mrg/mysql-4.1-opt
      
      ddd19c66
    • unknown's avatar
      Fix rpl_events test failure in the runtime tree. · 627202b4
      unknown authored
      
      mysql-test/r/rpl_events.result:
        Now ON COMPLETION NOT PRESERVE events are also dropped on the
        slave, since DROP EVENT command that is invoked for all such commands
        gets invoked on the slave.
      sql/event_data_objects.cc:
        Fix the failing rpl_events test after the patch for Bug#27733.
        At the time Events::drop_event got invoked inside
        Event_job_data::execute() thd->query pointed to CREATE PROCEDURE
        statement. This statement was written to the binary log
        from inside Events::drop_event (under assumption that this is a
        DROP EVENT statement that needs to be replicated), and caused
        creation of this procedure on the slave (and a subsequent failure
        when a procedure with the same name already exist).
        
        The patch ensures that thd->query points at the right query text
        for DROP EVENT executed when dropping ON COMPLETION NOT PRESERVE 
        events.
      sql/event_data_objects.h:
        Update a  declaration.
      sql/events.cc:
        Change if () to an assert: thd->query now always points at a valid
        query.
      627202b4
  4. 13 Apr, 2007 6 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0-opt · e8e06a89
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      e8e06a89
    • unknown's avatar
      An attempt to fix a sporadic valgrind memory leak in Event Scheduler: · ea2d0a98
      unknown authored
      streamline the event worker thread work flow and try to eliminate
      possibilities for memory corruptions that might have been
      lurking in previous (complicated) code.
      This patch: 
       * removes Event_job_data::compile that was never used
       * cleans up Event_job_data::execute to minimize juggling with
         thread context and eliminate unneded code paths
       * Implements Security_context::change/restore_security_context
         to be able to re-use these methods in all stored programs
      This is to maybe fix Bug#27733 "Valgrind failures in 
      remove_table_from_cache".
      Review comments applied.
      
      
      sql/event_data_objects.cc:
        Remove Event_job_data::compile, which was never used without
        Event_job_data::execute().
        Merge the implementation of compile() with Event_job_data::execute().
        Reuse existing functions to prepare the event worker thread
        for execution instead of some previously copy-pasted code.
        Do not change and restore the current database inside 
        Event_job_data::execute(), just set the current database in the 
        thread, that is enough to parse and execute an event.
      sql/event_data_objects.h:
        Update declarations.
      sql/event_scheduler.cc:
        Allocate Event_job_data on stack.
      sql/item_func.cc:
        Update to match the new declaration of restore_security_context()
      sql/sp_head.cc:
        Update to match the new declaration of 
        change/restore_security_context()
      sql/sql_class.cc:
        Move change/restore_security_context to class Security_context.
        Add more comments.
      sql/sql_class.h:
        Make change/restore_security_context methods of Security_context.
        That allows us to reuse them in Event Scheduler (instead of a
        copy-paste presently used there).
      sql/sql_trigger.cc:
        Update to match the new declaration of 
        change/restore_security_context()
      ea2d0a98
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 12cdc5d5
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-opt
      
      12cdc5d5
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-opt · f0663982
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-opt
      
      f0663982
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb · d5d36a4a
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-opt
      
      d5d36a4a
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-single-user · 186ad47d
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1-opt
      
      186ad47d
  5. 12 Apr, 2007 16 commits