- 22 Apr, 2020 7 commits
-
-
Marko Mäkelä authored
-
Kentoku SHIBA authored
Fix a test result.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Jan Lindström authored
Test do we have galera debug library with debug_sync functionality needs to be earlier.
-
Otto Kekäläinen authored
Also add a check for tmp file being empty and bail out with a clear error message in such a case, as mysqld_safe prevents normal stderr from being displayed anywhere and would fail silently on this.
-
Jan Lindström authored
MDEV-22181 : galera.galera_sst_mysqldump_with_key MTR failed: INSERT failed: 1146: Table 'test.t1' doesn't exist Add wait condition to make sure table test.t1 is replicated to node_2 before we insert to it.
-
- 21 Apr, 2020 1 commit
-
-
Vlad Lesin authored
config. The solution is to read the system variable value on startup and to fill databases_exclude_hash. xb_load_list_string() became non-static and was reformatted. The system variable value is read and processed in get_mysql_vars(), which was also reformatted.
-
- 20 Apr, 2020 1 commit
-
-
Anel Husakovic authored
Patches of interest:374dae3e, 374dae3e
-
- 18 Apr, 2020 7 commits
-
-
Monty authored
Backported fix from 10.5
-
Monty authored
Part of: MDEV-21056 Assertion `global_status_var.global_memory_used == 0' failed upon shutdown after query with DEFAULT on a geometry field Fixed by changing the ASSERT for memory leaks to a printf() on stderr. This has needed as all mutex in mysys has been deleted and we can't call functions like my_open() anymore. Also added printing of leaks if safemalloc is used (like we do in 10.5)
-
Monty authored
- Remove memory leaks reported by safemalloc - Changed that all 0x strings are converted. This is needed to easily be able to resolve safemalloc backtraces
-
Monty authored
MDEV-21056 Assertion `global_status_var.global_memory_used == 0' failed upon shutdown after query with DEFAULT on a geometry field
-
Monty authored
MDEV-22275 Assertion `global_status_var.global_memory_used == 0' failed, bytes lost, or LeakSanitizer: detected memory leaks after using temporary table with fulltext key This affected MyISAM and Aria temporary tables
-
Monty authored
-
Teemu Ollakka authored
If a transaction had no effect due to INSERT IGNORE and a new transaction was started with START TRANSACTION without committing the previous one, the server crashed on assertion when starting a new wsrep transaction. As a fix, refined the condition to do wsrep_commit_empty() at the end of the ha_commit_trans().
-
- 17 Apr, 2020 6 commits
-
-
Marko Mäkelä authored
maria_page_crc_check_index(): Do not attempt to convert HA_ERR_WRONG_CRC (176) to my_bool (char). On platforms where char is signed, the 176 will be converted to -80. It turns out that the callers only care whether the result is zero. Let us return 1 in this case, like we do in all other error cases.
-
Marko Mäkelä authored
Several tests that involve stored procedures fail on 10.4 kvm-asan (clang 10) due to stack overrun. The main contributor to this stack overrun is mysql_execute_command(), which is invoked recursively during stored procedure execution. Rebuilding with cmake -DWITH_WSREP=OFF shrunk the stack frame size of mysql_execute_command() by more than 10 kilobytes in a WITH_ASAN=ON, CMAKE_BUILD_TYPE=Debug build. The culprit turned out to be the macro WSREP_LOG, which is allocating a separate 1KiB buffer for every occurrence. We replace the macro with a function, so that the stack will be allocated only when the function is actually invoked. In this way, no stack space will be wasted by default (when WSREP and Galera are disabled). This backports commit b6c5657e from MariaDB 10.3.1. Without ASAN, compilers can be smarter and optimize the stack usage. The original commit message mentions that 1KiB was saved on GCC 5.4, and 4KiB on Mac OS X Lion, which presumably uses a clang-based compiler.
-
Kentoku SHIBA authored
MDEV-20502 Queries against spider tables return wrong values for columns following constant declarations. When executing a query like "select id, 0 as const, val from ...", there are 3 columns(items) in Query->select at handlerton->create_group_by(). After that, MariaDB makes a temporary table with 2 columns. The skipped items are const item, so fixing Spider to skip const items for items at Query->select.
-
Kentoku SHIBA authored
-
Teemu Ollakka authored
- Made WSREP_LOG a function and moved the body out of header. - Reduced the stack allocated buffer size and implemented reprint into dynamically allocated buffer if stack buffer is not large enough to hold the message.
-
Kentoku SHIBA authored
-
- 16 Apr, 2020 4 commits
-
-
Kentoku SHIBA authored
-
Varun Gupta authored
-
Marko Mäkelä authored
In main.index_merge_myisam we remove the test that was added in commit a2d24def because it duplicates the test case that was added in commit 5af12e46.
-
Varun Gupta authored
-
- 15 Apr, 2020 9 commits
-
-
Sergey Vojtovich authored
-
Eugene Kosov authored
tests are: engines/funcs.jp_comment_column engines/funcs.jp_comment_index engines/funcs.jp_comment_table
-
Sergey Vojtovich authored
-
Sergey Vojtovich authored
-
Sergey Vojtovich authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
After MDEV-12353, the consistency check that I originally added for commit 1b9fe0bb (InnoDB Plugin for MySQL 5.1) started randomly failing. It turns out that the IMPORT TABLESPACE code was always incorrect: it did not update the (redundantly stored) tablespace ID in index tree root pages. It only does that for page headers and BLOB pointers. PageConverter::update_index_page(): Update the tablespace ID in the BTR_SEG_TOP and BTR_SEG_LEAF of index root pages. This is a backport of commit b8b3edff.
-
Marko Mäkelä authored
For some reason, when mbstream is compiled with GCC 10, ld will fail to link it due to a multiple definition of datasink_buffer. The code appears to have been like that since the very beginning. Let us remove the duplicate dummy definition.
-
Marko Mäkelä authored
-
- 14 Apr, 2020 3 commits
-
-
Daniel Black authored
Windows GNU patch 2.7.6 is ok without it. So account for the old buildbot version for now. Linux works without it. --binary fails on FreeBSD-12.0: $ patch --version patch 2.0-12u11 FreeBSD $ patch --binary patch: unrecognized option `--binary'
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 13 Apr, 2020 2 commits
-
-
Vicențiu Ciorbaru authored
This reverts commit 1749a689. The reason why we need --binary for patch is because of a bug in patch.exe 2.5.9. We need to supply binary otherwise the patch program crashes.
-
Otto Kekäläinen authored
This fixes bugs where upgrading MariaDB failed to start after an upgrade from MySQL 5.7 in Ubuntu, where auth_socket has been the default for MySQL as well for some time now. This was adopted from Debian where this change has been since Apr 18, 2019: https://salsa.debian.org/mariadb-team/mariadb-10.4/-/commit/3919860b6a4ef98c098fef35fb34601adbb132b2
-