1. 21 Feb, 2005 20 commits
    • unknown's avatar
      Generate warning in ha_delete_table() if files is missing in handler · 8cb6031d
      unknown authored
      
      
      mysql-test/r/myisam.result:
        Test of DROP TABLE when .MYI or .MYD is missing
      mysql-test/r/ndb_autodiscover.result:
        Update test results
      mysql-test/r/rpl_EE_error.result:
        Change test to conform with new handling of drop table when handler file is missing
      mysql-test/t/myisam.test:
        Test of DROP TABLE when .MYI or .MYD is missing
      mysql-test/t/rpl_EE_error.test:
        Change test to conform with new handling of drop table when handler file is missing
      sql/handler.cc:
        Generate a warning in ha_delete_table() if we get an error from 'delete_table()'
      sql/handler.h:
        More parameters to ha_delete_table() so that we can generate better error messages
      sql/sql_table.cc:
        Generate warning in ha_delete_table()
      8cb6031d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · ac1852b4
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      ac1852b4
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 80ddfccf
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      80ddfccf
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9a148273
      unknown authored
      into deer.(none):/home/hf/work/mysql-5.0.clean
      
      
      9a148273
    • unknown's avatar
      Tests modified to coved decimal-related code · cd32f960
      unknown authored
      
      mysql-test/r/analyse.result:
        test result extended
      mysql-test/r/cast.result:
        test result extended
      mysql-test/r/func_group.result:
        test result extended
      mysql-test/r/subselect.result:
        test result extended
      mysql-test/t/analyse.test:
        test extended
      mysql-test/t/cast.test:
        test extended
      mysql-test/t/func_group.test:
        test extended
      mysql-test/t/subselect.test:
        test extended
      cd32f960
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · f3d2090e
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      f3d2090e
    • unknown's avatar
      Cleanup. · 2be96196
      unknown authored
      
      mysql-test/t/type_bit.test:
        Cleanup (we don't need to have include/have_innodb.inc here).
      2be96196
    • unknown's avatar
      A minor adjustment of the previous bug fix in sp_head.cc. · 3c2e7f1e
      unknown authored
      (Which btw also fixed BUG#7295: Server crash when executing stored procedure,
       I just forgot to include that before.)
      
      
      sql/sp_head.cc:
        A minor adjustment of the previous bug fix; moved the rollback of item changes
        to a better place which will not miss some cases.
      3c2e7f1e
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 926826f5
      unknown authored
      into mysql.com:/usr/home/ram/work/5.0
      
      
      926826f5
    • unknown's avatar
      workaround for sun compiler on sol9x86 · f36c4a93
      unknown authored
      f36c4a93
    • unknown's avatar
      Fix compiler warning/crash(ds20) · 453809f3
      unknown authored
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Moved ndbrequire and break down one line, to avoid warnings and compiler crash
      453809f3
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · ecc4d850
      unknown authored
      into mysql.com:/usr/home/ram/work/5.0
      
      
      ecc4d850
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 32895fe3
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/handler.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      32895fe3
    • unknown's avatar
      Review of new pushed code (XA & other) · d50af8ae
      unknown authored
      Portability fixes and cleanups
      Fixed setting of 'res' in mysql_execute_command()
      
      
      sql/handler.cc:
        delete_table() will not return error for not found files if one handler file was found and deleted
      sql/handler.h:
        Incremented MAX_HA so that ndb works again
        Don't convert char pointer to (my_xid*) as we don't know if the address is aligned on 8
      sql/log.cc:
        Indentation fixes
        Simplified loop to find next log
        Fixed race condition in reset_logs that caused mix_innodb_myisam_binlog to fail
      sql/log_event.cc:
        Don't convert char pointer to (my_xid*) as we don't know if the address is aligned on 8
      sql/sql_acl.cc:
        Convert db name directly to avoid extra strmov
      sql/sql_base.cc:
        Added comment
        Removed not needed code
      sql/sql_db.cc:
        Added comment
        Remove not needed code
      sql/sql_parse.cc:
        Always call mysql_rm_db() with lower case db name
        Ensure that 'res' is set correctly in mysql_execute_command()
        (One don't have to set res if one calls my_error() and res should be = 0 for correct commands)
      sql/sql_repl.cc:
        Indentation fixes
        use packet->ptr() instead of packet->c_ptr()
      sql/sql_table.cc:
        Join similar code when table didn't exist in engine
      d50af8ae
    • unknown's avatar
      A fix (bug #7661: 'classic' shows different test effects which must be cared for) · 07f2634e
      unknown authored
      "create table ta(a bit...) engine=innodb" moved to innodb.test
      
      
      mysql-test/r/innodb.result:
        A fix (bug #7661: 'classic' shows different test effects which must be cared for)
      mysql-test/r/type_bit.result:
        A fix (bug #7661: 'classic' shows different test effects which must be cared for)
      mysql-test/t/innodb.test:
        A fix (bug #7661: 'classic' shows different test effects which must be cared for)
      mysql-test/t/type_bit.test:
        A fix (bug #7661: 'classic' shows different test effects which must be cared for)
      07f2634e
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 0fc34660
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      sql/handler.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      0fc34660
    • unknown's avatar
      xa assert fixes · 2d044701
      unknown authored
      
      sql/handler.cc:
        more DBUG
      sql/handler.h:
        increase MAX_HA (ha_archive has its handlerton too)
      sql/log.cc:
        fix assert
      2d044701
    • unknown's avatar
      ndb - ndb_multi - reset query cache at end of test · b526f434
      unknown authored
      
      mysql-test/r/ndb_cache_multi2.result:
        reset query cache settings on end of test
      mysql-test/t/ndb_cache_multi2.test:
        reset query cache settings on end of test
      b526f434
    • unknown's avatar
      ndb - fix problems introduced/discovered by XA · 493911bd
      unknown authored
      
      sql/ha_ndbcluster.cc:
        Respect "all" flag so that correct transaction is released
      sql/handler.cc:
        Make sure innodb temporary latches are only released if innodb is used
      493911bd
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · a89dcc58
      unknown authored
      into mysql.com:/home/jonas/src/mysql-5.0
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      BitKeeper/triggers/post-commit:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      a89dcc58
  2. 20 Feb, 2005 6 commits
  3. 19 Feb, 2005 11 commits
    • unknown's avatar
      use dbug_print_decimal instead of DBUG_EXECUTE · 3805001f
      unknown authored
      Portability fix
      Note: rpl_trunc_binlog fails, but Sergei has promised to fix it, so I will ignore it for now
      
      
      sql/field.cc:
        use dbug_print_decimal instead of DBUG_EXECUTE
      sql/item.h:
        Portability fix
      sql/my_decimal.cc:
        Fix error in last changeset (not pushed)
      3805001f
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 915660e0
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      915660e0
    • unknown's avatar
      fix rpl_trunc_binlog to test the new behaviour · 7b3df69b
      unknown authored
      7b3df69b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · a39f87f3
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      a39f87f3
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-5.0 · 01ed9a32
      unknown authored
      into beethoven.site:/home/georg/work/mysql/mysql-5.0
      
      
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      01ed9a32
    • unknown's avatar
      ndb - fix to Time comparison · 3f0def33
      unknown authored
      
      ndb/src/common/util/NdbSqlUtil.cpp:
        remove stupid check
      3f0def33
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 6c8ae9d6
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      BUILD/SETUP.sh:
        Auto merged
      mysql-test/r/ps_6bdb.result:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/my_decimal.cc:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      6c8ae9d6
    • unknown's avatar
      Fixed BUILD script to use --with-berkeley-db instead of --with-bdb · 64cc538b
      unknown authored
      Lots of small fixes to multi-precision-math path
      Give Note for '123.4e'
      Added helper functions type 'val_string_from_real()
      Don't give warnings for end space for string2decimal()
      Changed storage of values for SP so that we can detect length of argument without strlen()
      Changed interface for str2dec() so that we must supple the pointer to the last character in the buffer
      
      
      
      BUILD/SETUP.sh:
        with-bdb ->with-berkeley-db
      include/decimal.h:
        Make string2decimal and string2decimal_fixed inline
      mysql-test/r/func_group.result:
        More tests (to find bugs in precision math fixes)
      mysql-test/r/func_set.result:
        Test to cover more Item_func_field::val_xxx() code
      mysql-test/r/ps_6bdb.result:
        update results
      mysql-test/r/type_decimal.result:
        New tests
        Give note for '123.4e'
      mysql-test/r/type_newdecimal.result:
        Number of decimal changes (probably right, but hard to verify)
      mysql-test/t/func_group.test:
        More tests (to find bugs in precision math fixes)
      mysql-test/t/func_set.test:
        Test to cover more Item_func_field::val_xxx() code
      mysql-test/t/type_decimal.test:
        New tests to cover more cases in decimal.c
      sql/item.cc:
        Added helper functions type 'val_string_from_real()'
        Use new interfase to str2my_decimal()
        Moved nr_of_decimals() here (and made it static)
      sql/item.h:
        Added helper functions type 'val_string_from_real()'
      sql/item_func.cc:
        Style fixes
        Trivial optimizations
        Ensure null_value is set if my_decimal_add/sub/mul/div returns error
        Remove not needed Item_func_int_div::val_str()
        Join Item_func_signproc and Item_func_neg
        Fix that FIELD() works when first argument is NULL or one if it's arguments are NULL
        new str2my_decimal interface
      sql/item_func.h:
        Make Item_func_int_div inherit from Item_int_func (allows us to remove some virtual functions)
        Join Item_func_signproc & Item_func_neg
      sql/item_strfunc.cc:
        Move nr_of_decmails() to Item.cc (as it was only used here)
      sql/item_sum.cc:
        Style fixes
        Change a lot of code to use new helper converter functions in item.cc
        Moved Item_sum::val_decimal() to Item_sum_int::val_decimal()
        Fixed calls to wrong functions (Item_sum_num::val_int())
        Ensure that all hybrid functions checks hybrid_type in val_xxx() (As there is no gurantee that they are called in the right context)
        Simplify key_length allocation in Item_sum_sum_distinct()
        Simplified create_tmp_field() and reset_field()
        Fixed potential error in Item_sum_hybrid::reset_field()
        Optimize Item_sum_avg::update_field()
        Item_std_field() functions musted be fully coded becasue Item_variance_field::val_xxx functions called helper functions
        Coded missing Item_sum_ufd_xxx::val_decimal() functions
      sql/item_sum.h:
        Moved Item_sum::val_decimal() to Item_sum_int::val_decimal()
        Added missing Item_sum_ufd_xxx::val_decimal() functions
        Removed not used scale() function.
        Fixed that Item_std_field() works with decimal arguments
        Fixed that CREATE ... STD() will create a REAL field
      sql/log_event.cc:
        Ensure that we use same format for all types
      sql/my_decimal.cc:
        Don't give warnings for end space for string2decimal()
        Added dbug_print_decimal()
      sql/my_decimal.h:
        Style fixes
        Prototypes for new functions
        New interface for str2my_decimal()
      sql/mysql_priv.h:
        Made nr_of_decimals() static
      sql/protocol.cc:
        Simplify code (by assume that decimal can't be bigger than DECIMAL_MAX_STR_LENGTH]
      sql/protocol_cursor.cc:
        Changed storage of values for SP so that we can detect length of argument without strlen()
      sql/sp_head.cc:
        Simplify code for decimal handling by letting item handling conversion to decimal
      sql/sp_rcontext.cc:
        Use new method to get length of arguments
      sql/sql_analyse.cc:
        if -> switch
        Increase 'empty' if decimal value=0
        Remove usage of strcat()
      sql/sql_base.cc:
        Remove unnecessary checks
      sql/sql_class.cc:
        Remove not needed 'else'
        Removed not used variables
      sql/sql_select.cc:
        remove test for impossible condtion
      strings/decimal.c:
        Made two trivial functions macros
        Changed interface for str2dec() so that we must supple the pointer to the last character in the buffer
        This safer than before as we don't require an end \0 anymore (old code gave wrong answers in MySQL for some internals strings that where not \0 terminated)
        Detect error numbers of type '12.55e'
        str2dec() will now set 'to' to zero in case of errors
      64cc538b
    • unknown's avatar
      windows compilation fixes · 0bc02450
      unknown authored
      0bc02450
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 47fd010f
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      47fd010f
    • unknown's avatar
      fix compilation errors · a98179dc
      unknown authored
      
      sql/examples/ha_tina.cc:
        make tina to compile (wasn't catched with -max build)
      sql/sql_yacc.yy:
        fix compilation errors --without-geometry
      a98179dc
  4. 18 Feb, 2005 3 commits
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · a8604397
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      sql/sp_head.cc:
        Auto merged
      a8604397
    • unknown's avatar
      Fixed... · dba08753
      unknown authored
        BUG#6642: Stored procedure crash if expression with set function
        BUG#7013: Stored procedure crash if group by ... with rollup
        BUG#7743: 'Lost connection to MySQL server during query' on Stored Procedure
        BUG#7992: SELECT .. INTO variable .. within Stored Procedure crashes
                  the server
        BUG#8116: calling simple stored procedure twice in a row results
                  in server crash
      
      Rolling back the item change list after each substatement in a procedure
      fixed the failing assert().
      
      
      mysql-test/r/sp.result:
        New test cases for BUG#6642, 7013, 7743, 7992 and 8116.
      mysql-test/t/sp.test:
        New test cases for BUG#6642, 7013, 7743, 7992 and 8116.
      sql/sp_head.cc:
        Roll back the item change list after each sub statement.
      dba08753
    • unknown's avatar
      Changes and fixes for windows compilation · af4b5c89
      unknown authored
      
      VC++Files/libmysqld/libmysqld.dsp:
        added sql/my_decimal.cc
      VC++Files/sql/mysqld.dsp:
        added my_decimal.cpp
      VC++Files/strings/strings.dsp:
        added decimal.c
      sql/field.cc:
        conversion fixes for windows compilation
      sql/item.h:
        fix for windows compilation
      sql/item_func.cc:
        fixed conversion for windows (cast from ulonglong to double 
        is not supported)
      sql/item_sum.cc:
        typecast fix for windows compilation
      sql/sp_head.cc:
        typecast fix fo windows compilation
      sql/sql_cache.cc:
        typecast fix for windows compilation
      af4b5c89