1. 04 Oct, 2006 1 commit
  2. 03 Oct, 2006 1 commit
  3. 02 Oct, 2006 1 commit
    • marko's avatar
      branches/zip: Fix all bugs detected by mysql-test-run. The exactly same set · 66ae0ded
      marko authored
      of tests are failing with trunk -r869, with this revision using uncompressed
      storage, and with this revision hard-wired to use 1-kilobyte compressed pages
      and innodb_file_per_table.
      
      btr_push_update_extern_fields(): Do not call ut_ulint_sort() if n_pushed == 0.
      
      btr_copy_externally_stored_field_prefix_low(): Replace ut_max() with ut_min().
      66ae0ded
  4. 29 Sep, 2006 4 commits
    • marko's avatar
      branches/zip: Merge revisions 861:869 from trunk. · a7540940
      marko authored
      a7540940
    • marko's avatar
      branches/zip: Remove os_file_check_page_trailers(). It was used in · b8503c0e
      marko authored
      os_aio_simulated_handle() before and after initiating a write.  We
      cannot easily pass the compressed page sizes to this function.  The
      check could only be performed on uncompressed pages.
      b8503c0e
    • marko's avatar
      a003cc70
    • marko's avatar
      branches/zip: dtuple_convert_big_rec(): Do not store anything locally · 174bd7b7
      marko authored
      of externally stored columns, and fix bugs introduced in r873.  (Bug #22496)
      
      btr_page_get_sure_split_rec(), btr_page_insert_fits(),
      rec_get_converted_size(), rec_convert_dtuple_to_rec(),
      rec_convert_dtuple_to_rec_old(), rec_convert_dtuple_to_rec_new():
      Add parameters ext and n_ext.  Flag external fields during the
      conversion.
      
      rec_set_field_extern_bits(), rec_set_field_extern_bits_new(),
      rec_offs_set_nth_extern(), rec_set_nth_field_extern_bit_old():
      Remove.  The bits are set by rec_convert_dtuple_to_rec().
      
      page_cur_insert_rec_low(): Remove the parameters ext and n_ext.
      
      btr_cur_add_ext(): New utility function for updating and sorting ext[].
      Low-level functions now expect the array to be in ascending order
      for performance reasons.  Used in btr_cur_optimistic_insert(),
      btr_cur_pessimistic_insert(), and btr_cur_pessimistic_update().
      
      btr_cur_optimistic_insert(): Remove some defensive code, because we cannot
      compute the added parameters of rec_get_converted_size().
      
      btr_push_update_extern_fields(): Sort the array.  Require the array to
      be twice the maximum usage, so that ut_ulint_sort() can be used.
      
      dtuple_convert_big_rec(): Allocate new space for the BLOB pointer,
      to avoid overwriting prefix indexes to the same column.  Adapt
      dtuple_convert_back_big_rec().
      
      row_build_index_entry(): Fetch the columns also for prefix indexes of
      the clustered index.
      
      page_zip_apply_log(), page_zip_decompress_clust(): Allow externally
      stored fields to lack a locally stored part.
      174bd7b7
  5. 28 Sep, 2006 2 commits
  6. 27 Sep, 2006 1 commit
    • marko's avatar
      branches/zip: Replace FIL_PAGE_ZBLOB_SPACE_ID and FIL_PAGE_ZBLOB_DATA · 71e8ea62
      marko authored
      with FIL_PAGE_ARCH_LOG_NO_OR_SPACE_ID and FIL_PAGE_DATA.  The doublewrite
      buffer needs to read the space_id in order to determine the type of the page.
      Because FIL_PAGE_TYPE could contain garbage in MySQL/InnoDB 5.0 and earlier
      versions, we cannot trust fil_page_get_type().  Instead, we have to always
      store the space_id at the same location.  This modification wastes 12 bytes
      per compressed BLOB page (1.2% on 1-kilobyte pages).
      71e8ea62
  7. 26 Sep, 2006 7 commits
  8. 25 Sep, 2006 1 commit
    • marko's avatar
      branches/zip: Minor cleanup in update related code. · 8e59e994
      marko authored
      btr_push_update_extern_fields(): Instead of iterating all upd_get_n_fields(),
      stop at the first match.
      
      row_search_index_entry(): Simplify the return statements.
      
      row_upd_sec_step(): Eliminate the local variable "err".
      
      row_upd_clust_step(): Add a UNIV_UNLIKELY hint.
      8e59e994
  9. 22 Sep, 2006 3 commits
  10. 21 Sep, 2006 3 commits
  11. 20 Sep, 2006 5 commits
    • marko's avatar
      branches/zip: page_zip_empty_size(): New function to compute the · 5a21753b
      marko authored
      guaranteed free space available for inserting one record.
      
      btr_page_get_sure_split_rec(), btr_cur_pessimistic_insert():
      Use page_zip_empty_size().
      
      btr_page_split_and_insert(): Relax a debug assertion that there should
      be at least two user records on the page.  On compressed pages, we may
      be able to write only one record.
      5a21753b
    • marko's avatar
      branches/zip: Instrument the buffer pool allocator and deallocator · ff0acd76
      marko authored
      for more accurate Valgrind debugging.
      
      univ.i: Introduce UNIV_DEBUG_VALGRIND, UNIV_MEM_VALID, and UNIV_MEM_INVALID.
      
      buf_LRU_block_free_non_file_page(): Invalidate the buffer frame
      with UNIV_MEM_INVALID().
      
      buf_LRU_get_free_block(): Declare the buffer frame valid
      with UNIV_MEM_VALID().
      
      Other memory is allocated and deallocated via malloc() and free(),
      which are already overridden by Valgrind.  Without the added
      instrumentation, accesses to free pages in the buffer pool cannot
      be caught.
      
      The diagnostics could probably be improved further by declaring all
      non-latched buffer frames invalid.
      ff0acd76
    • marko's avatar
      branches/zip: Fix bugs #ifdef UNIV_DEBUG. · 3b03315f
      marko authored
      rec_convert_dtuple_to_rec_old(): Initialize the record in order to avoid
      bogus Valgrind warnings about the ut_ad() in mach_write_to_1() and
      mach_write_to_2().
      
      page_zip_compress(), page_zip_write_rec(), page_zip_write_blob_ptr():
      Replace ut_ad(page_validate(...)) with ut_ad(page_simple_validate_new(...)),
      because otherwise crash recovery would fail.
      3b03315f
    • marko's avatar
      branches/zip: fil_create_new_single_table_tablespace(): · a169d0ec
      marko authored
      Make page_zip->data point to an address different from page,
      to avoid calling memcpy() with overlapping source and destination.
      a169d0ec
    • marko's avatar
      branches/zip: mlog_parse_index(): After merge fix (r841): · 2af802d8
      marko authored
      Identify DB_TRX_ID and DB_ROLL_PTR in the index.
      2af802d8
  12. 19 Sep, 2006 2 commits
  13. 12 Sep, 2006 1 commit
  14. 06 Sep, 2006 2 commits
  15. 05 Sep, 2006 3 commits
  16. 04 Sep, 2006 2 commits
  17. 31 Aug, 2006 1 commit
    • marko's avatar
      branches/zip: dtuple_convert_big_rec(): Shorten the locally stored part · c3e2a8d4
      marko authored
      of externally stored columns to 108 bytes when possible.
      
      This will unmask a bug in the handling of BLOBs on compressed tablespaces,
      especially of small page sizes.  Apparently, the locally stored part must
      be less than 235 bytes in size for the bug to occur.
      
      dict_col_struct: Add field min_prefix.
      
      dict_index_build_internal_non_clust(): Adjust min_prefix.
      c3e2a8d4