1. 02 Dec, 2019 8 commits
    • Aleksey Midenkov's avatar
      Merge 10.4 into 10.5 · 8ed646f0
      Aleksey Midenkov authored
      8ed646f0
    • Aleksey Midenkov's avatar
      Merge 10.3 into 10.4 · 0b8b11b0
      Aleksey Midenkov authored
      0b8b11b0
    • Aleksey Midenkov's avatar
      MDEV-18929 2nd execution of SP does not detect ER_VERS_NOT_VERSIONED (10.4) · 1d46923a
      Aleksey Midenkov authored
      Don't do skip_setup_conds() unless all errors are checked.
      
      Fixes following errors:
            ER_PERIOD_NOT_FOUND
            ER_VERS_QUERY_IN_PARTITION
            ER_VERS_ENGINE_UNSUPPORTED
            ER_VERS_NOT_VERSIONED
      1d46923a
    • Aleksey Midenkov's avatar
      MDEV-18929 2nd execution of SP does not detect ER_VERS_NOT_VERSIONED · db32d945
      Aleksey Midenkov authored
      Don't do skip_setup_conds() unless all errors are checked.
      
      Fixes following errors:
            ER_PERIOD_NOT_FOUND
            ER_VERS_QUERY_IN_PARTITION
            ER_VERS_ENGINE_UNSUPPORTED
            ER_VERS_NOT_VERSIONED
      db32d945
    • Aleksey Midenkov's avatar
      MDEV-21011 Table corruption reported for versioned partitioned table after... · a7cf0db3
      Aleksey Midenkov authored
      MDEV-21011 Table corruption reported for versioned partitioned table after DELETE: "Found a misplaced row"
      
      LIMIT history partitions cannot be checked by existing algorithm of
      check_misplaced_rows() because working history partition is
      incremented each time another one is filled. The existing algorithm
      gets record and tries to decide partition id for it by
      get_partition_id(). For LIMIT history it will just get first
      non-filled partition.
      
      To fix such partitions it is required to do REBUILD instead of REPAIR.
      a7cf0db3
    • Aleksey Midenkov's avatar
      MDEV-21155 Assertion with versioned table upon DELETE from view of view after replacing first view · 6dd41e00
      Aleksey Midenkov authored
      When view is merged by DT_MERGE_FOR_INSERT it is then skipped from
      processing and doesn't update WHERE clause with
      vers_setup_conds(). Note that view itself cannot work in
      vers_setup_conds() because it doesn't have row_start, row_end
      fields. Thus it is required to descend down to material TABLE_LIST
      through calls of mysql_derived_prepare() and run vers_setup_conds()
      from there. Luckily, all views (views of views, views of views of
      views, etc.) are linked in one list through next_global pointer, so we
      can skip all views of views and get straight to non-view TABLE_LIST by
      checking its merge_underlying_list property for zero value (it is
      assigned by DT_MERGE_FOR_INSERT for merged derived tables).
      
      We have to do that only for UPDATE and DELETE. Other DML commands
      don't use WHERE clause.
      
      MDEV-21146 Assertion `m_lock_type == 2' in handler::ha_drop_table upon LOAD DATA
      
      LOAD DATA does not use WHERE and the above call of vers_setup_conds()
      is not needed. unit->prepare() led to wrongly locked temporary table.
      6dd41e00
    • Aleksey Midenkov's avatar
      MDEV-21147 Assertion `marked_for_read()' upon UPDATE on versioned table via view · 97aa07ab
      Aleksey Midenkov authored
      "write set" for replication finally got its correct place
      (mark_columns_per_binlog_row_image()). When done generally in
      mark_columns_needed_for_update() it affects optimization
      algorithm. used_key_is_modified, query_plan.using_io_buffer are
      wrongly set and that leads to wrong prepare_for_keyread() which limits
      read_set.
      97aa07ab
    • Aleksey Midenkov's avatar
      MDEV-20441 ER_CRASHED_ON_USAGE upon update on versioned Aria table · 498a96a4
      Aleksey Midenkov authored
      Turn read cache off for update and multi-update for versioned
      table. no_cache is reinited on each TABLE open because it is
      applicable for specific algorithms.
      
      As a side fix vers_insert_history_row() honors vers_write setting.
      
      Aria with row_format=fixed uses IO_CACHE of type READ_CACHE for
      sequential read in update loop. When history row is inserted inside
      this loop the cache misses it and fails with error.
      
      TODO:
      
      Currently maria_extra() does not support SEQ_READ_APPEND. Probably it
      might be possible to use this type of cache.
      498a96a4
  2. 30 Nov, 2019 1 commit
  3. 29 Nov, 2019 10 commits
  4. 28 Nov, 2019 13 commits
  5. 27 Nov, 2019 5 commits
    • Vladislav Vaintroub's avatar
      MDEV-19669 - fix matching CIDR address for proxy protocol. · 584ffa02
      Vladislav Vaintroub authored
      Prior to this fix, when matching addresses using mask,
      extra bits could be used for  comparison, e.g to
      match with "a.b.c.d/24" , 27 bits were compared rather than 24.
      
      The patch fixes the calculation.
      584ffa02
    • Vladislav Vaintroub's avatar
      Merge branch '10.4' into 10.5 · 29710b28
      Vladislav Vaintroub authored
      # Conflicts:
      #	win/packaging/extra.wxs.in
      29710b28
    • Vladislav Vaintroub's avatar
      MDEV-19781 fixups · 96c6b2b6
      Vladislav Vaintroub authored
      - It is not enough to have  and DeleteSymlinks actions
      because within the same installation some exes executables can be both
      added and removed, which needs both adding and removing some symlinks.
      
      Instead of CreateSymlinks, there is now FixSymlinks function, which
      goes through the list, and adds or removes the symlinks as needed.
      
      - Implemented rollback for symlink custom action.
      
      - Generate list of symlinks in C++ file, using CMake, rather than storing
      lists as MSI properties.
      96c6b2b6
    • Marko Mäkelä's avatar
      MDEV-21158 trx_undo_seg_free() is never redo-logged · 3fc1f626
      Marko Mäkelä authored
      As part of commit 3c09f148
      trx_undo_commit_cleanup() was always invoked with noredo=true.
      
      The impact of this should be that some undo log pages may not be
      correctly freed if the server is killed and crash recovery will be
      performed. Similarly, if mariabackup --backup is being executed
      concurrently with user transaction commits, it could happen that some
      undo log pages in the backup will never be marked as free for reuse.
      
      It seems that this bug should not have any user-visible
      impact other than some undo pages being wasted.
      3fc1f626
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · ddbbf976
      Marko Mäkelä authored
      ddbbf976
  6. 26 Nov, 2019 3 commits
    • Igor Babaev's avatar
      MDEV-20407 mysqld got signal 11; rowid filter · ed355f59
      Igor Babaev authored
      If a joined table is accessed by a full text index then now no range rowid
      filter can be used when accessing the records of this table.
      
      This bug was fixed by the patch for mdev-20056.
      This commit adds only a test case with a query using a full text index
      and a range condition for another index.
      ed355f59
    • Marko Mäkelä's avatar
      MDEV-21148: Assertion index->n_core_fields + n_add >= index->n_fields · 3eda03d0
      Marko Mäkelä authored
      Revert part of commit 6cedb671
      because it turns out to be theoretically impossible to parse a
      ROW_FORMAT=COMPACT or ROW_FORMAT=DYNAMIC metadata record where
      the variable-length fields in the PRIMARY KEY have been written
      as nonempty strings.
      3eda03d0
    • Monty's avatar
      Code cleanups · d1851b30
      Monty authored
      - Replace "class Repeat_count" with function call.
        There is no reason for this class to exists. More complex and more
        code than doing a function!  In addition the code didn't match what
        the val() function was doing.
      
      Other things:
      - Fixed compiler failure in print_cached_tables_callback()
      d1851b30