1. 08 Nov, 2007 1 commit
  2. 07 Nov, 2007 1 commit
    • kaa@polly.(none)'s avatar
      Fix for bug #32103: optimizer crash when join on int and mediumint with · f1a3c364
      kaa@polly.(none) authored
      variable in where clause.
      
      Problem: the new_item() method of Item_uint used an incorrect
      constructor. "new Item_uint(name, max_length)" calls
      Item_uint::Item_uint(const char *str_arg, uint length) which assumes the
      first argument to be the string representation of the value, not the
      item's name. This could result in either a server crash or incorrect
      results depending on usage scenarios.
      
      Fixed by using the correct constructor in new_item():
      Item_uint::Item_uint(const char *str_arg, longlong i, uint length).
      f1a3c364
  3. 05 Nov, 2007 1 commit
  4. 02 Nov, 2007 1 commit
    • kaa@polly.(none)'s avatar
      Fix for: · 9cd5f49c
      kaa@polly.(none) authored
        bug #26215: mysql command line client should not strip comments
                    from SQL statements
      and
        bug #11230: Keeping comments when storing stored procedures
      
      With the introduction of multiline comments support in the command line
      client (mysql) in MySQL 4.1, it became impossible to preserve
      client-side comments within single SQL statements or stored routines.
      This feature was useful for monitoring tools and maintenance.
      
      The patch adds a new option to the command line client
      ('--enable-comments', '-c') which allows to preserve SQL comments and
      send them to the server for single SQL statements, and to keep comments
      in the code for stored procedures / functions / triggers.
      
      The patch is a modification of the contributed patch from bug #11230
      with the following changes:
      - code style changes to conform to the coding guidelines
      - changed is_prefix() to my_strnncoll() to detect the DELIMITER
      command, since the first one is case-sensitive and not charset-aware
      - renamed t/comments-51.* to t/mysql_comments.*
      - removed tests for comments in triggers since 5.0 does not have SHOW
      CREATE TRIGGER (those tests will be added back in 5.1).
      
      The test cases are only for bug #11230. No automated test case for bug
      #26215 is possible due to the test suite deficiencies (though the cases
      from the bug report were tested manually).
      9cd5f49c
  5. 21 Oct, 2007 1 commit
    • kaa@polly.(none)'s avatar
      Bug #28550 "Potential bugs related to the return type of the CHAR function". · 34984111
      kaa@polly.(none) authored
        
      Since, as of MySQL 5.0.15, CHAR() arguments larger than 255 are converted into multiple result bytes, a single CHAR() argument can now take up to 4 bytes. This patch fixes Item_func_char::fix_length_and_dec() to take this into account.
        
      This patch also fixes a regression introduced by the patch for bug21513. As now we do not always have the 'name' member of Item set for Item_hex_string and Item_bin_string, an own print() method has been added to Item_hex_string so that it could correctly be printed by Item_func::print_args().
      34984111
  6. 17 Oct, 2007 1 commit
  7. 16 Oct, 2007 1 commit
  8. 15 Oct, 2007 2 commits
  9. 14 Oct, 2007 1 commit
  10. 13 Oct, 2007 2 commits
  11. 12 Oct, 2007 3 commits
  12. 11 Oct, 2007 3 commits
  13. 10 Oct, 2007 4 commits
  14. 09 Oct, 2007 5 commits
  15. 08 Oct, 2007 1 commit
    • gkodinov/kgeorge@magare.gmz's avatar
      Bug #31156: mysqld: item_sum.cc:918: virtual bool · 67302b12
      gkodinov/kgeorge@magare.gmz authored
        Item_sum_distinct::setup(THD*): Assertion
      
      There was an assertion to detect a bug in ROLLUP
      implementation. However the assertion is not true
      when used in a subquery context with non-cacheable
      statements.
      Fixed by turning the assertion to accepted case
      (just like it's done for the other aggregate functions). 
      67302b12
  16. 07 Oct, 2007 1 commit
  17. 05 Oct, 2007 10 commits
  18. 04 Oct, 2007 1 commit