1. 01 Dec, 2006 10 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 8ffed8be
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      server-tools/instance-manager/guardian.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      8ffed8be
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · ec00e02c
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      ec00e02c
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/mysql-5.0-4968 · 7c6fe6e7
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      tests/mysql_client_test.c:
        Manual merge.
      7c6fe6e7
    • unknown's avatar
      A fix and a test case for Bug#24179 "select b into $var" fails with · fe84b016
      unknown authored
      --cursor_protocol": fix a misleading error message in case of
      SELECT .. INTO.
      
      
      sql/sql_class.cc:
        Implement select_result::check_simple_select hierarchy to 
        support correct error messages in case of SELECT .. INTO and C API 
        cursors.
      sql/sql_class.h:
        Set the error message inside the function that checks for the error
        condition (simple_select, renamed to check_simple_select).
      sql/sql_prepare.cc:
        Use a new method that now sets the error.
      tests/mysql_client_test.c:
        Add a test case for Bug#24179 "select b into $var" fails with 
        --cursor_protocol" (check for the right error message and error code).
      fe84b016
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1 · cf245c8f
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      cf245c8f
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · 5176be8d
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/table.cc:
        Auto merged
      5176be8d
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1-marvel · b6004e62
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      Makefile.am:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      b6004e62
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1 · 922ea687
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      mysql-test/lib/mtr_process.pl:
        Auto merged
      922ea687
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 8c056ce5
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.1-11733_topdown
      
      
      sql/handler.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      8c056ce5
    • unknown's avatar
      WL#3602 · d469888a
      unknown authored
      Post review changes
      the --read-only option is not enforced for the slave thread in replication, or for the SUPER user.
      
      
      sql/handler.cc:
        Post review changes
        Allowing writes for the slave thread or for SUPER, in read-only mode
      sql/lock.cc:
        Post review changes
        Allowing writes for the slave thread or for SUPER, in read-only mode
      mysql-test/r/rpl_read_only.result:
        New test
      mysql-test/t/rpl_read_only-slave.opt:
        New test
      mysql-test/t/rpl_read_only.test:
        New test
      d469888a
  2. 30 Nov, 2006 30 commits
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build-work · 1c8facbc
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      1c8facbc
    • unknown's avatar
      late after-merge fix · 0bc42ce6
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        late after-merge fix: re-add MTR_BUILD_THREAD=auto
      0bc42ce6
    • unknown's avatar
      Merge monty@192.168.0.9:/home/my/mysql-5.1 · a49e1f4e
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      a49e1f4e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 9b1336fe
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      configure.in:
        Auto merged
      include/my_pthread.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      server-tools/instance-manager/guardian.cc:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/archive/ha_archive.cc:
        Auto merged
      storage/csv/ha_tina.cc:
        Auto merged
      storage/federated/ha_federated.cc:
        Auto merged
      sql/item_create.cc:
        manual merge
      9b1336fe
    • unknown's avatar
      After merge fixes · e0aeba21
      unknown authored
      Marked some functions as noreturn
      
      
      sql/mysql_priv.h:
        Marked some functions as noreturn
      storage/federated/ha_federated.cc:
        After merge fix
      storage/myisam/ft_boolean_search.c:
        Removed duplicate code
      storage/myisam/myisamchk.c:
        Added LINT_INIT()
      storage/myisam/myisampack.c:
        After merge fix
      storage/myisam/sort.c:
        Indentation fixup
      e0aeba21
    • unknown's avatar
      Merge mysql.com:/home/my/mysql-5.0 · 600336ef
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      client/mysql.cc:
        Auto merged
      cmd-line-utils/readline/bind.c:
        Auto merged
      cmd-line-utils/readline/histfile.c:
        Auto merged
      extra/yassl/taocrypt/include/algebra.hpp:
        Auto merged
      include/my_global.h:
        Auto merged
      include/my_tree.h:
        Auto merged
      mysys/my_thr_init.c:
        Auto merged
      server-tools/instance-manager/guardian.cc:
        Auto merged
      server-tools/instance-manager/portability.h:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/gen_lex_hash.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sp_cache.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_handler.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/heap/hp_clear.c:
        Auto merged
      storage/heap/hp_write.c:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      storage/innobase/os/os0file.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      client/mysqldump.c:
        Manual merge
      client/mysqltest.c:
        Manual merge
      extra/replace.c:
        Manual merge
      libmysql/libmysql.c:
        Manual merge
      mysys/base64.c:
        Manual merge
      sql/ha_ndbcluster.cc:
        Manual merge
      sql/handler.cc:
        Manual merge
      sql/item_strfunc.cc:
        Manual merge
      sql/item_timefunc.cc:
        Manual merge
      sql/log.cc:
        Manual merge
      sql/opt_range.cc:
        Manual merge
      sql/password.c:
        Manual merge
      sql/sp.cc:
        Manual merge
      sql/sql_base.cc:
        Manual merge
      sql/sql_cache.cc:
        Manual merge
      sql/sql_db.cc:
        Manual merge
      sql/sql_rename.cc:
        Manual merge
      sql/sql_select.cc:
        Manual merge
      sql/sql_show.cc:
        Manual merge
      sql/sql_trigger.cc:
        Manual merge
      sql/sql_update.cc:
        Manual merge
      sql/tztime.cc:
        Manual merge
      storage/archive/ha_archive.cc:
        Manual merge
      storage/federated/ha_federated.cc:
        Manual merge
      storage/myisam/mi_create.c:
        Manual merge
      storage/myisam/myisampack.c:
        Manual merge
      storage/myisammrg/myrg_rkey.c:
        Manual merge
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Manual merge
      storage/ndb/src/ndbapi/Ndb.cpp:
        Manual merge
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Manual merge
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Manual merge
      storage/ndb/src/ndbapi/Ndblist.cpp:
        Manual merge
      600336ef
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · c8100cba
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      c8100cba
    • unknown's avatar
      Don't abort if we call my_thread_end() multiple times · 9e5ec353
      unknown authored
      Fixed new introduced bug in my_time.c
      
      
      BitKeeper/deleted/.del-valgrind.supp.orig:
        Delete: mysql-test/valgrind.supp.orig
      mysys/my_thr_init.c:
        More comments
        Don't abort if we call my_thread_end() multiple times
      sql-common/my_time.c:
        Fixed wrong patch in last commit
      sql/sql_cache.cc:
        Fixed old bad merge (not critical)
      sql/tztime.cc:
        Portability fix
      9e5ec353
    • unknown's avatar
      Fixed compiler warnings · 25226de9
      unknown authored
      Don't assert if my_thread_end() is called twice (common case)
      
      
      client/mysql.cc:
        Removed not used variables
      client/mysqldump.c:
        Fixed compiler warnings
      client/mysqltest.c:
        Fixed compiler warnings
      cmd-line-utils/readline/bind.c:
        Fixed compiler warnings
      cmd-line-utils/readline/histfile.c:
        Fixed compiler warnings
      extra/replace.c:
        Fixed compiler warning on windows
      extra/yassl/taocrypt/include/algebra.hpp:
        Fixed compiler warnings
      heap/hp_write.c:
        Fixed compiler warnings
      innobase/os/os0file.c:
        Fixed compiler warnings
      libmysql/libmysql.c:
        Call my_end()/my_thread_end last.
        my_end() calls free_charsets(), which allowed me to move the call
      myisam/myisampack.c:
        Fixed compiler warnings
      myisammrg/myrg_rkey.c:
        Fixed compiler warnings
      mysys/my_thr_init.c:
        More comments
        Don't assert if my_thread_end() is called twice (common case)
      ndb/src/mgmapi/mgmapi.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/Ndb.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/NdbScanOperation.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/NdbTransaction.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/Ndblist.cpp:
        Fixed compiler warnings
      server-tools/instance-manager/guardian.cc:
        Removed not used variable
      server-tools/instance-manager/portability.h:
        Removed duplicated symbol
      sql/gen_lex_hash.cc:
        Fixed compiler warning
      sql/ha_archive.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/mysqld.cc:
        Fixed compiler warnings
      sql/sql_cache.cc:
        Fixed compiler warnings
        Fixed DBUG_PRINT strings to be consistent with 5.1
      sql/tztime.cc:
        Fixed compiler warnings
      sql/uniques.cc:
        Fixed compiler warnings
      25226de9
    • unknown's avatar
      Bug #24487 Valgrind: uninited byte in table->record[1] in binlog code for rbr + inno db · f8d8b3db
      unknown authored
      The reason of this valgrind's compaint is not a bug but rather a feature of bitwise ops:
      for any value of the byte x
      x | 1 -> 1,  and x & 0 -> 0.
      x, being a null_byte part of record[1] can be left unassigned even after
      ha_innobase::index_read_idx because the above and still be correct.
      Addding a check memory upon the invocation of the function can detect this fact
      long before record[1], old record, is eventually passed to my_write.
      
      Fixed with initialization of record[1]'s null_bytes part in open_table_from_share.
      
      
      sql/table.cc:
        initialization of null-bytes for valgrind.
      f8d8b3db
    • unknown's avatar
      Merge dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.0-opt · cdc86ac1
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      cdc86ac1
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · a4342155
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B11927-5.0-opt
      
      
      a4342155
    • unknown's avatar
      func_group.test, func_group.result, func_gconcat.result, func_gconcat.test: · 140c3ee9
      unknown authored
        merge fix : removed undeterministic warnings
      
      
      mysql-test/r/func_gconcat.result:
        merge fix : removed undeterministic warnings
      mysql-test/r/func_group.result:
        merge fix : removed undeterministic warnings
      mysql-test/t/func_gconcat.test:
        merge fix : removed undeterministic warnings
      mysql-test/t/func_group.test:
        merge fix : removed undeterministic warnings
      140c3ee9
    • unknown's avatar
      Fixed portability issue in my_thr_init.c (was added in my last push) · 7191e775
      unknown authored
      Fixed compiler warnings (detected by VC++):
      - Removed not used variables
      - Added casts
      - Fixed wrong assignments to bool
      - Fixed wrong calls with bool arguments
      - Added missing argument to store(longlong), which caused wrong store method to be called.
      
      
      
      client/mysqldump.c:
        Removed compiler warning
      heap/hp_clear.c:
        Removed compiler warning
      include/my_global.h:
        Removed compiler warning
      include/my_tree.h:
        Changed memory limits from int to ulong
        (Allowed me to get rid of some compiler warnings)
      myisam/mi_create.c:
        Removed compiler warning
      myisam/myisampack.c:
        Removed compiler warning
      mysys/base64.c:
        Removed compiler warning
      mysys/my_thr_init.c:
        Fixed portability issue (detected on windows)
        Added DBUG_ASSERT to detect if we call my_thread_end() too many times
        Don't wait if THR_thread_count == -1 (error condition)
      mysys/tree.c:
        Removed compiler warning
      sql/field.cc:
        Removed compiler warning
        Fixed wrong parameter to check_date()
        Added missing argument to store(longlong)
      sql/ha_archive.cc:
        Removed compiler warning
      sql/ha_federated.cc:
        Removed compiler warning
      sql/ha_innodb.cc:
        Removed not used variable
      sql/handler.cc:
        Removed not used variable
        Fixed wrong if (we didn't detect if rollback or commit failed). Not critical as value is not yet used
      sql/item.cc:
        Removed compiler warning
      sql/item_func.cc:
        Removed compiler warning
      sql/item_strfunc.cc:
        Removed compiler warning
      sql/item_timefunc.cc:
        Removed compiler warning
      sql/log.cc:
        Removed compiler warning
      sql/mysql_priv.h:
        Removed compiler warning
      sql/opt_range.cc:
        Removed compiler warning
      sql/password.c:
        Removed compiler warning
      sql/set_var.cc:
        Removed compiler warning
      sql/slave.cc:
        Removed compiler warning
      sql/sp.cc:
        Removed compiler warning
      sql/sp_cache.cc:
        Removed compiler warning
      sql/sp_head.cc:
        Removed compiler warning
        Adjusted argument to reserve() to not use up too much memory that we are probably not going to need
      sql/sql_acl.cc:
        Added missing argument to store(longlong)
      sql/sql_base.cc:
        Removed compiler warning
      sql/sql_db.cc:
        Removed compiler warning
      sql/sql_delete.cc:
        Removed compiler warning
      sql/sql_handler.cc:
        Removed not used variable
      sql/sql_lex.h:
        Removed not used variable
      sql/sql_prepare.cc:
        Removed not used variable
      sql/sql_rename.cc:
        Removed not used variable
      sql/sql_select.cc:
        Fixed that select_options are not 'cut'
        Removed some not used variables
        Removed compiler warnings by adding cast
      sql/sql_show.cc:
        Removed not used variables
        Added missing argument to store(longlong)
        Removed compiler warnings
      sql/sql_trigger.cc:
        Removed not used variables
        Added cast to remove compiler warnings
      sql/sql_update.cc:
        Fixed wrong set of bool variable
      sql/sql_view.cc:
        Removed not used variables
        Added cast to get rid of compiler warnings
      sql-common/client.c:
        Fixed compiler warning
      sql-common/my_time.c:
        Fixed wrong argument to check_date()
        Added casts to get rid of compiler warnings
      sql/sql_yacc.yy:
        Removed not used variable
      sql/uniques.cc:
        Changes memory size from uint to ulong
        Added casts to get rid of compiler warnings
      strings/ctype-simple.c:
        Fixed cast to get rid of compiler warnings
      7191e775
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build-work · 899ee459
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.1-build
      
      
      mysql-test/lib/mtr_process.pl:
        Auto merged
      899ee459
    • unknown's avatar
      Merge kahlann.erinye.com:/home/df/mysql/build/mysql-4.1-build-work · 32f06501
      unknown authored
      into  kahlann.erinye.com:/home/df/mysql/build/mysql-5.0-build-work
      
      
      mysql-test/lib/mtr_process.pl:
        Auto merged
      32f06501
    • unknown's avatar
      minor fix to mtr_process.pl · 5af42c1b
      unknown authored
      
      mysql-test/lib/mtr_process.pl:
        print extra message _once_ every 60 seconds
      5af42c1b
    • unknown's avatar
      Merge dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.0-opt · 4c0f67f8
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      4c0f67f8
    • unknown's avatar
      Merge dl145s.mysql.com:/data0/bk/team_tree_merge/mysql-5.1 · 6ea42e67
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/func_in.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      6ea42e67
    • unknown's avatar
      Merge dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-4.1-opt · 45fc00ee
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      45fc00ee
    • unknown's avatar
      Merge dl145s.mysql.com:/data0/bk/team_tree_merge/mysql-5.0 · 6e791795
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      6e791795
    • unknown's avatar
      Merge dl145s.mysql.com:/data0/bk/team_tree_merge/mysql-4.1 · 7c9c5409
      unknown authored
      into  dl145s.mysql.com:/data0/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      7c9c5409
    • unknown's avatar
      func_gconcat.result, func_gconcat.test: · ef42631b
      unknown authored
        disabled warnings because their order is undeterministic
      
      
      mysql-test/t/func_gconcat.test:
        disabled warnings because their order is undeterministic
      mysql-test/r/func_gconcat.result:
        disabled warnings because their order is undeterministic
      ef42631b
    • unknown's avatar
      Merge trift2.:/MySQL/M51/push-5.1 · 2467dc14
      unknown authored
      into  trift2.:/MySQL/M51/bug24182-5.1
      
      
      2467dc14
    • unknown's avatar
      support-files/mysql.spec.sh : Call "make install" using "benchdir_root=%{_datadir}" (bug#24182). · ba4c767e
      unknown authored
      
      support-files/mysql.spec.sh:
        Call "make install" using "benchdir_root=%{_datadir}", because that is affecting 
        the regression test suite as well.    Fixes bug#24182.
      ba4c767e
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 3099fd27
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      3099fd27
    • unknown's avatar
      Fix for the following bugs: · 23776f53
      unknown authored
        - BUG#22306: STOP INSTANCE can not be applied for instances in Crashed,
          Failed and Abandoned;
        - BUG#23476: DROP INSTANCE does not work
        - BUG#23215: STOP INSTANCE takes too much time
      
      BUG#22306:
      The problem was that STOP INSTANCE checked that mysqld is up and running.
      If it was not so, STOP INSTANCE reported an error. Now, STOP INSTANCE
      reports an error if the instance has been started (mysqld can be down).
      
      BUG#23476:
      The problem was that DROP INSTANCE tried to stop inactive instance. The fix is
      trivial.
      
      BUG#23215:
      The problem was that locks were not acquired properly, so the
      instance-monitoring thread could not acquire the mutex, holded by the
      query-processing thread.
      
      The fix is to simplify locking scheme by moving instance-related information to
      Instance-class out of Guardian-class. This allows to get rid of storing a
      separate list of Instance-information in Guardian and keeping it synchronized
      with the original list in Instance_map.
      
      
      server-tools/instance-manager/commands.cc:
        1. Introduce Instance_cmd class -- base class for the commands
           that deal with the one instance;
        2. Remove Instance_map argument from command constructors;
        3. Ensure, that Instance Map and Instance are locked in the proper order;
        4. Polishing.
      server-tools/instance-manager/commands.h:
        1. Introduce Instance_cmd class -- base class for the commands
           that deal with the one instance;
        2. Remove Instance_map argument from command constructors;
        3. Polishing.
      server-tools/instance-manager/guardian.cc:
        1. Move "extended" instance information to the Instance-class.
           That allows to get rid of storing instance-related container and data in
           Guardian class, that significantly simplifies locking schema.
        2. Polishing.
      server-tools/instance-manager/guardian.h:
        1. Move "extended" instance information to the Instance-class.
           That allows to get rid of storing instance-related container and data in
           Guardian class, that significantly simplifies locking schema.
        2. Polishing.
      server-tools/instance-manager/instance.cc:
        1. Move "extended" instance information to the Instance-class.
        2. Introduce new state STOPPED to mark that guarded instance
           is stopped and should not be restarted by Guardian.
        3. Polishing.
      server-tools/instance-manager/instance.h:
        1. Move "extended" instance information to the Instance-class.
        2. Introduce new state STOPPED to mark that guarded instance
           is stopped and should not be restarted by Guardian.
        3. Polishing.
      server-tools/instance-manager/instance_map.cc:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/instance_map.h:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/instance_options.h:
        Polishing.
      server-tools/instance-manager/manager.cc:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/manager.h:
        1. Move flush_instances() from Instance_map to Manager.
        2. Polishing.
      server-tools/instance-manager/user_map.cc:
        Polishing.
      23776f53
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-marvel · 1e2d3cdb
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      
      1e2d3cdb
    • unknown's avatar
      Fixed compiler warnings (Mostly VC++): · 1e87cfee
      unknown authored
      - Removed not used variables
      - Changed some ulong parameters/variables to ulonglong (possible serious bug)
      - Added casts to get rid of safe assignment from longlong to long (and similar)
      - Added casts to function parameters
      - Fixed signed/unsigned compares
      - Added some constructores to structures
      - Removed some not portable constructs
      
      Better fix for bug Bug #21428 "skipped 9 bytes from file: socket (3)" on "mysqladmin shutdown"
      (Added new parameter to net_clear() to define when we want the communication buffer to be emptied)
      
      
      client/mysql.cc:
        Removed not used variable
      client/mysqldump.c:
        Fixed compiler warning
      client/mysqlslap.c:
        Fixed compiler warning
      client/mysqltest.c:
        Fixed compiler warning
      extra/replace.c:
        Fixed compiler warning
      include/my_global.h:
        Fixed compiler warning
      include/mysql_com.h:
        Changed prototype for net_clear()
      libmysql/libmysql.c:
        Changed prototype for net_clear()
      mysys/base64.c:
        Fixed compiler warning (function definition and prototype didn't match)
      mysys/my_thr_init.c:
        AFter merge fixes
      mysys/my_vle.c:
        Fixed compiler warning
      sql/event_data_objects.cc:
        Fixed compiler warning
      sql/event_scheduler.cc:
        Removed not used variable
      sql/field.cc:
        Removed not used variables
        Fixed compiler warning
      sql/gen_lex_hash.cc:
        Fixed compiler warning
      sql/ha_partition.h:
        Fixed compiler warning
      sql/handler.cc:
        Fixed compiler warning
      sql/item.cc:
        Fixed compiler warning
      sql/item_create.cc:
        Fixed compiler warning
      sql/item_func.cc:
        Fixed compiler warning
      sql/item_strfunc.cc:
        Fixed compiler warning
      sql/item_timefunc.cc:
        Fixed compiler warning
      sql/item_xmlfunc.cc:
        Fixed compiler warning
      sql/log.cc:
        Fixed compiler warning
      sql/log_event.cc:
        Fixed compiler warning
      sql/log_event.h:
        Fixed compiler warning
      sql/mysql_priv.h:
        Fixed too short 'select_type'
      sql/net_serv.cc:
        Added argument to net_clear() if we should empty the communication buffer.
      sql/opt_range.cc:
        Fixed compiler warning
      sql/partition_info.cc:
        Fixed compiler warning
      sql/rpl_injector.h:
        Fixed compiler warning
      sql/set_var.cc:
        Fixed compiler warning
      sql/slave.cc:
        Fixed compiler warning
      sql/sp_head.cc:
        Fixed compiler warning
      sql/sql_base.cc:
        Fixed compiler warning
      sql/sql_db.cc:
        Fixed compiler warning
      sql/sql_delete.cc:
        Fixed compiler warning
      sql/sql_insert.cc:
        Fixed compiler warning
      sql/sql_lex.h:
        Fixed compiler warning
      sql/sql_parse.cc:
        Fixed compiler warning
      sql/sql_partition.cc:
        Fixed compiler warning
      sql/sql_plugin.cc:
        Fixed compiler warning
      sql/sql_prepare.cc:
        Fixed compiler warning
      sql/sql_rename.cc:
        Fixed compiler warning
      sql/sql_select.cc:
        Fixed compiler warning
      sql/sql_show.cc:
        Fixed compiler warning
      sql/sql_table.cc:
        Fixed compiler warning
      sql/sql_trigger.cc:
        Fixed compiler warning
      sql-common/client.c:
        Better fix for bug Bug #21428 "skipped 9 bytes from file: socket (3)" on "mysqladmin shutdown"
      sql-common/my_time.c:
        Fixed compiler warning
      sql/sql_union.cc:
        Fixed compiler warning
      sql/sql_update.cc:
        Fixed compiler warning
      sql/sql_view.cc:
        Fixed compiler warning
      sql/sql_yacc.yy:
        Fixed compiler warning
      sql/table.cc:
        Fixed compiler warning
      storage/archive/azio.c:
        Fixed compiler warning
      storage/csv/ha_tina.cc:
        Removed not used code
      storage/myisam/mi_unique.c:
        Fixed compiler warning
      storage/ndb/include/util/OutputStream.hpp:
        Fixed compiler warning
      storage/ndb/include/util/SocketAuthenticator.hpp:
        Fixed compiler warning
      storage/ndb/src/kernel/vm/Pool.hpp:
        Fixed compiler warning
      strings/ctype-simple.c:
        Fixed compiler warning
      strings/my_strchr.c:
        Fixed compiler warning
      1e87cfee
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 46fd7dec
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-arch
      
      
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      46fd7dec