1. 30 Jan, 2006 1 commit
  2. 25 Jan, 2006 1 commit
    • unknown's avatar
      Fixed BUG#15737: Stored procedure optimizer bug with LEAVE · 7ee65fcf
      unknown authored
        Second version.
        The problem was that the optimizer didn't work correctly with forwards jumps
        to "no-op" hpop and cpop instructions.
        Don't generate "no-op" instructions (hpop 0 and cpop 0), it isn't actually
        necessary.
      
      
      mysql-test/r/sp-code.result:
        Updated results for new test case (BUG#15737)
      mysql-test/t/sp-code.test:
        New test case (BUG#15737)
      sql/sp_head.cc:
        Removed backpatch methods from sp_instr_hpop/cpop, since they're not needed any more.
        Added more documentation to sp_head::optimize()
      sql/sp_head.h:
        Removed backpatch and opt_mark methods from sp_instr_hpop/cpop, since they're not needed
        any more.
        Added comments to optimizer methods in sp_instr.
      sql/sql_yacc.yy:
        Don't generate "no-op" hpop and cpop instructions for LEAVE, it's not necessary.
        Just generate them when needed.
      7ee65fcf
  3. 24 Jan, 2006 7 commits
    • unknown's avatar
      Fix for the following bugs: · 8f395ebb
      unknown authored
        - BUG#15166: Wrong update permissions required to execute triggers
        - BUG#15196: Wrong select permission required to execute triggers
      
      The idea of the fix is to check necessary privileges
      in Item_trigger_field::fix_fields(), instead of having "special variables"
      technique. To achieve this, we should pass to an Item_trigger_field instance
      a flag, which will indicate the usage/access type of this trigger variable.
      
      
      mysql-test/r/trigger-grant.result:
        Update the result file.
      mysql-test/t/trigger-grant.test:
        Add test cases for BUG#15166 and BUG#15196
      sql/item.cc:
        Item_trigger_field: check appropriate (SELECT/UPDATE) privilege in fix_fields().
      sql/item.h:
        Add a flag to specify access type for trigger field.
      sql/sql_trigger.cc:
        "Special variable" technique of checking privileges for NEW/OLD variables
        was replaced by checking table- and column-level privileges in
        Item_trigger_field::fix_fields().
      sql/sql_trigger.h:
        "Special variable" technique of checking privileges for NEW/OLD variables
        was replaced by checking table- and column-level privileges in
        Item_trigger_field::fix_fields().
      sql/sql_yacc.yy:
        Specify access type for trigger fields.
      8f395ebb
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9e0240d3
      unknown authored
      into  mysql.com:/usr_rh9/home/elkin.rh9/MySQL/mysql-5.0
      
      
      9e0240d3
    • unknown's avatar
      Fix for bug#15307 GROUP_CONCAT() with ORDER BY returns empty set on information_schema(2nd ver) · 333b1f85
      unknown authored
        Fill schema tables with data before filesort if it's necessary
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#15307 GROUP_CONCAT() with ORDER BY returns empty set on information_schema(2nd ver)
          test result
      mysql-test/t/information_schema.test:
        Fix for bug#15307 GROUP_CONCAT() with ORDER BY returns empty set on information_schema(2nd ver)
          test case
      333b1f85
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 74f670f2
      unknown authored
      into mysql.com:/home/gluh/MySQL/Merge/5.0
      
      
      74f670f2
    • unknown's avatar
      Fix for bug#15851 Unlistable directories yield no info from information_schema · fbc24f33
      unknown authored
        to skip directories which are not allowed for read
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#15851 Unlistable directories yield no info from information_schema
          test result
      mysql-test/t/information_schema.test:
        Fix for bug#15851 Unlistable directories yield no info from information_schema
          test case
      fbc24f33
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 794e94e4
      unknown authored
      into  mysql.com:/usr_rh9/home/elkin.rh9/MySQL/mysql-5.0
      
      
      794e94e4
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 30382bee
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug15020/my50-bug15020
      
      
      30382bee
  4. 23 Jan, 2006 7 commits
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 3f216c7d
      unknown authored
      into  mysql.com:/usr_rh9/home/elkin.rh9/MySQL/mysql-5.0
      
      
      3f216c7d
    • unknown's avatar
      Changes after initial patch to #15787 · 03ad365b
      unknown authored
      
      zlib/Makefile.am:
        Added a reference to ../include for my_config.h
      zlib/README.MySQL:
        Updated a readme file to emphasize which files we what to keep an eye on
        in case of zlib upgrade.
      zlib/zconf.h:
        restored a code for standard platform dependant definitions
      03ad365b
    • unknown's avatar
      Merge svlasenko@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4032f5ac
      unknown authored
      into  selena.:H:/MYSQL/src/#15787-mysql-5.0
      
      
      4032f5ac
    • unknown's avatar
      Merge april.(none):/home/svoj/devel/mysql/BUG16489/mysql-4.1 · dde3f727
      unknown authored
      into  april.(none):/home/svoj/devel/mysql/BUG16489/mysql-5.0
      
      
      myisam/ft_update.c:
        Auto merged
      mysql-test/r/fulltext2.result:
        Auto merged
      dde3f727
    • unknown's avatar
      BUG#15699, failure to apply ignore rule for unexisting table. · 1dcfe028
      unknown authored
        
      Since replication rules execute after `mysql_multi_update_prepare' returns we
      delay to `break' in case this functions returns non-zero (some tables are not found) 
      for to examine if there is an ignore rule for a not-found table. By doing that
      it is guaranteed do/ignore replication rules logically preceed opening table routine.
      
      
      sql/sql_parse.cc:
        BUG#15699. We delay to `break' in case of unexisted tables for multi-update.
        First it is checked whether an ignore rule for such a table exists.
        
        More to the fix:
        if (opt_readonly && ...' in two places got be idented because it were
        enclosed explicitly into corresponding `else' groups. For that 
        the preceding lines with `else' were changed in to be 
        `else 
         {'.
        This grouping is necessary to avoid any inattentive
        insertion in between of `else' and belonging to the else 
        `if (opt_readonly && ...' statement.
      mysql-test/r/rpl_multi_update4.result:
        New BitKeeper file ``mysql-test/r/rpl_multi_update4.result''
      mysql-test/t/rpl_multi_update4-slave.opt:
        New BitKeeper file ``mysql-test/t/rpl_multi_update4-slave.opt''
      mysql-test/t/rpl_multi_update4.test:
        New BitKeeper file ``mysql-test/t/rpl_multi_update4.test''
      1dcfe028
    • unknown's avatar
      BUG#16489 - utf8 + fulltext leads to corrupt index file. · 0ee28e1a
      unknown authored
      Fixed that UPDATE statement crashes multi-byte charset fulltext index.
      
      
      myisam/ft_update.c:
        Fixed that UPDATE statement crashes multi-byte charset fulltext index.
        While updating, always rewrite multi-byte charset fulltext index.
      mysql-test/r/fulltext2.result:
        Added a testcase for BUG#16489.
      mysql-test/t/fulltext2.test:
        Added a testcase for BUG#16489.
      0ee28e1a
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 2bdcc171
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug14634/my50-bug14634
      
      
      sql/sql_select.cc:
        Auto merged
      2bdcc171
  5. 22 Jan, 2006 1 commit
  6. 21 Jan, 2006 6 commits
    • unknown's avatar
      Merging · 49a09cc3
      unknown authored
      
      mysql-test/r/func_gconcat.result:
        merging
      mysql-test/r/type_float.result:
        merging
      49a09cc3
    • unknown's avatar
      Merging · 494bccf0
      unknown authored
      
      mysql-test/ndb/ndbcluster.sh:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/func_math.test:
        Auto merged
      mysql-test/t/type_float.test:
        Auto merged
      sql/spatial.h:
        Auto merged
      mysql-test/r/type_float.result:
        merging
      sql/item_func.cc:
        merging
      494bccf0
    • unknown's avatar
      Merge hf@192.168.21.12:work/mysql-4.1.15429 · ffe11393
      unknown authored
      into eagle.intranet.mysql.r18.ru:/home/hf/work/mysql-4.1.mrg
      
      
      ffe11393
    • unknown's avatar
      Merge hf@192.168.21.12:work/mysql-4.1.14320 · a8e1b468
      unknown authored
      into eagle.intranet.mysql.r18.ru:/home/hf/work/mysql-4.1.mrg
      
      
      a8e1b468
    • unknown's avatar
      Merge hf@192.168.21.12:work/mysql-4.1.9855 · 32fc6800
      unknown authored
      into eagle.intranet.mysql.r18.ru:/home/hf/work/mysql-4.1.mrg
      
      
      sql/item_func.cc:
        Auto merged
      32fc6800
    • unknown's avatar
      Turns out that the bulk interface was not well documented. I fixed the issue... · a207c820
      unknown authored
      Turns out that the bulk interface was not well documented. I fixed the issue in archive and I will go and update the comments in handler next. I should probably also look through the other engines and see if this an issue elsewhere as well. 
      
      
      sql/ha_archive.cc:
        Fixed for bulk_insert
      a207c820
  7. 20 Jan, 2006 3 commits
    • unknown's avatar
      Test case for BUG#16621: INSERTs in Stored Procedures causes data corruption · ff3079c8
      unknown authored
      in the Binary Log.
      
      
      mysql-test/r/rpl_sp.result:
        Update result file.
      mysql-test/t/rpl_sp.test:
        Add test case for BUG#16621: INSERTs in Stored Procedures causes data corruption
        in the Binary Log.
      ff3079c8
    • unknown's avatar
      Fix for BUG#15588: String overrun during sp-vars.test · b688b196
      unknown authored
      The bug appears after implementation of WL#2984
      (Make stored routine variables work according to the standard).
      
      
      mysql-test/r/type_varchar.result:
        Update result file.
      mysql-test/t/type_varchar.test:
        Add a test for BUG#15588.
      sql/field.cc:
        - use memmove() instead of memcpy() -- after implementation of WL#2984
          (Make stored routine variables work according to the standard) it is
          possible to store in the field the value from this field. For instance,
          this can happen for the following statement:
            SET sp_var = SUBSTR(sp_var, 1, 3);
      sql/sp_head.cc:
        - Work correctly with String:
          - String length has to be be reset before use;
          - qs_append() does not allocate memory, so the memory should
            be reserved beforehand.
      sql/sql_select.cc:
        Polishing: should have been done in WL#2984.
      b688b196
    • unknown's avatar
      Fix of fix for BUG#15866. (Actually change the fib() call in sp.test) · 1fe12884
      unknown authored
      
      mysql-test/r/sp.result:
        Updated results.
      mysql-test/t/sp.test:
        Actually change the fib(20) into fib(10).  (Doh!)
      1fe12884
  8. 19 Jan, 2006 14 commits