An error occurred fetching the project authors.
  1. 28 Apr, 2005 1 commit
    • unknown's avatar
      BUG#9911 After review fixes · 2c8e2617
      unknown authored
       - Remove ha_archive::rename_table and move the fix to handler::rename_table
      
      
      sql/examples/ha_archive.cc:
        Remove ha_archive::rename_table
      sql/examples/ha_archive.h:
        Remove ha_archive::rename_table
      sql/handler.cc:
        Fix handler::rename_table so it does not care about if the file to rename is missing
      2c8e2617
  2. 27 Apr, 2005 2 commits
    • unknown's avatar
      BUG#9911 RENAME TABLE of type ARCHIVE fails with .ARN file error · a1b0139f
      unknown authored
       - Different behaviuor in 5.0 pushes a warning when renaming a non existent file. Avoid that by checking that the file exists before renaming.
      
      
      mysql-test/r/archive.result:
        Warning is not produced anymore
      sql/examples/ha_archive.cc:
        Change ha_archive::rename_table to avoid warning when trying to rename non existent file.
      a1b0139f
    • unknown's avatar
      BUG#9714 libsupc++ problem · 072fa90d
      unknown authored
       - Remove linking of libsupc++
       - Move all local static variables to filescope
      
      
      configure.in:
        Remove linking with libsupc++
      sql/examples/ha_archive.cc:
        Move local static variables to file scope
      sql/examples/ha_example.cc:
        Move local static variables to file scope
      sql/examples/ha_tina.cc:
        Move local static variables to file scope
      sql/ha_berkeley.cc:
        Move local static variables to file scope
      sql/ha_blackhole.cc:
        Move local static variables to file scope
      sql/ha_federated.cc:
        Move local static variables to file scope
      sql/ha_heap.cc:
        Move local static variables to file scope
      sql/ha_innodb.cc:
        Move local static variables to file scope
      sql/ha_myisam.cc:
        Move local static variables to file scope
      sql/ha_myisammrg.cc:
        Move local static variables to file scope
      sql/ha_ndbcluster.cc:
        Move local static variables to file scope
      sql/item.cc:
        Move local static instance variables to file scope
      sql/item_sum.cc:
        Move local static variables to file scope
      072fa90d
  3. 26 Apr, 2005 1 commit
    • unknown's avatar
      BUG#9911 RENAME TABLE of type ARCHIVE fails with .ARN file error · 5444ad94
      unknown authored
       - Implemented ha_archive::rename_table
       - Added testcases for rename
      
      
      mysql-test/r/archive.result:
        Addd testcase for rename of archive table
      mysql-test/t/archive.test:
        Addd testcase for rename of archive table
      sql/examples/ha_archive.cc:
        Implement special version of rename table that does not care it the .arn file is missing
      sql/examples/ha_archive.h:
        Implement special version of rename table that does not care it the .arn file is missing
      5444ad94
  4. 13 Mar, 2005 1 commit
    • unknown's avatar
      print xa recovery progress · ec372b09
      unknown authored
      add names to handlertons
      trans_need_2pc() macro
      
      
      sql/examples/ha_archive.cc:
        add names to handlertons
      sql/ha_berkeley.cc:
        add names to handlertons
      sql/ha_innodb.cc:
        add names to handlertons
      sql/ha_ndbcluster.cc:
        add names to handlertons
      sql/handler.cc:
        print xa recovery progress
      sql/handler.h:
        add names to handlertons
        trans_need_2pc() macro
      sql/log.cc:
        add names to handlertons
      ec372b09
  5. 25 Feb, 2005 1 commit
    • unknown's avatar
      Remove compiler warnings and remove not used variables · 248e4494
      unknown authored
      (Found during build process)
      
      
      extra/comp_err.c:
        Remove compiler warnings
      extra/perror.c:
        Remove compiler warnings
      innobase/dict/dict0dict.c:
        Remove compiler warnings
      innobase/dict/dict0load.c:
        Remove compiler warnings
      innobase/pars/pars0sym.c:
        Remove compiler warnings
      innobase/row/row0row.c:
        Remove compiler warnings
      innobase/row/row0sel.c:
        Remove compiler warnings
      libmysqld/lib_sql.cc:
        Remove not used variables
      myisam/mi_key.c:
        Remove compiler warnings
      regex/engine.c:
        Added comment
      sql/derror.cc:
        Remove not used variables
      sql/examples/ha_archive.cc:
        Fixed bug in blob handling
        Removed not used variable
      sql/field.cc:
        Remove compiler warnings
        Remove not used variables
      sql/filesort.cc:
        Remove compiler warnings
      sql/ha_heap.cc:
        Remove not used variable
      sql/ha_innodb.cc:
        Remove not used variables
        Remove compiler warnings
      sql/handler.cc:
        Remove compiler warnings and remove not used variables
      sql/item.cc:
        Remove compiler warnings and remove not used variables
      sql/item_subselect.cc:
        Remove compiler warnings
      sql/item_sum.cc:
        Remove compiler warnings
      sql/item_sum.h:
        Remove compiler warnings and remove not used variables
      sql/log.cc:
        Remove compiler warnings and remove not used variables
      sql/log_event.cc:
        Remove compiler warnings
      sql/mysqld.cc:
        Remove compiler warnings and remove not used variables
      sql/opt_range.cc:
        Remove compiler warnings and remove not used variables
      sql/slave.cc:
        Remove compiler warnings and remove not used variables
      sql/sp_pcontext.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_acl.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_analyse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_base.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_db.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_help.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_insert.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_load.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_parse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_prepare.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_select.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_show.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_table.cc:
        Remove compiler warnings
      sql/sql_union.cc:
        Remove compiler warnings
      sql/sql_update.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_yacc.yy:
        Remove compiler warnings and remove not used variables
      sql/strfunc.cc:
        Remove compiler warnings and remove not used variables
      strings/ctype-ucs2.c:
        Remove compiler warnings
      tests/mysql_client_test.c:
        Remove compiler warnings and remove not used variables
      tools/mysqlmanager.c:
        Remove compiler warnings and remove not used variables
      248e4494
  6. 24 Feb, 2005 1 commit
    • unknown's avatar
      Solved bug 8691. · 48f0b277
      unknown authored
      Funny sometimes how things work when in reality you would think it would crash pretty hard :)
      
      
      sql/examples/ha_archive.cc:
        Solves bug #8691. This was reported in an internal build. Renamed ptr to bptr.
      48f0b277
  7. 17 Feb, 2005 1 commit
  8. 16 Feb, 2005 1 commit
  9. 12 Feb, 2005 1 commit
    • unknown's avatar
      new static archive_inited variable, so that archive_db_end() will do something... · a8b9f30e
      unknown authored
      new static archive_inited variable, so that archive_db_end() will do something only if archive_db_init() was run before
      (protection against destroying uninited mutex in the case where mysqld fails early at startup (before archive_db_init() was called)
      and then calls archive_db_end() to clean up).
      
      
      sql/examples/ha_archive.cc:
        new static archive_inited variable, so that archive_db_end() will do something only if archive_db_init() was run before.
      a8b9f30e
  10. 31 Jan, 2005 1 commit
  11. 29 Jan, 2005 1 commit
  12. 26 Jan, 2005 2 commits
    • unknown's avatar
      Test bug: Memory leak in archive handler. · f50a65b0
      unknown authored
      Added a call to close the meta file after a repair.
      
      
      f50a65b0
    • unknown's avatar
      Test Bug: Memory leaks in the archive handler. · b6e00331
      unknown authored
      Moved initialization code into a new init function.
      Added a new cleanup function.
      Added a call to close the meta file.
      
      
      
      mysql-test/t/archive.test:
        Test Bug: Memory leaks in the archive handler.
        Fixed a typo.
      sql/examples/ha_archive.h:
        Test Bug: Memory leaks in the archive handler.
        Added declarations for the new init/cleanup functions.
      sql/handler.cc:
        Test Bug: Memory leaks in the archive handler.
        Added calls of the new init/cleanup functions.
      b6e00331
  13. 11 Jan, 2005 1 commit
    • unknown's avatar
      Fix style nit · 4bd2b5ad
      unknown authored
      sql/examples/ha_archive.cc:
        Fix style
      4bd2b5ad
  14. 10 Jan, 2005 1 commit
  15. 07 Jan, 2005 1 commit
  16. 17 Dec, 2004 1 commit
    • unknown's avatar
      Clean up from code review. · 490ff28a
      unknown authored
      sql/examples/ha_archive.cc:
        Fixed from code review. Cleaned up comment and fixed issue with mean length of row.
      490ff28a
  17. 09 Dec, 2004 1 commit
    • unknown's avatar
      A few simple fixes plus the added support of being able to repair the meta... · b76b2e68
      unknown authored
      A few simple fixes plus the added support of being able to repair the meta data file via REPAIR TABLE. More information is now provided in SHOW TABLE STATUS.
      
      
      mysql-test/r/archive.result:
        Added REPAIR TABLE test
      mysql-test/t/archive.test:
        Added REPAIR TABLE tests.
      sql/examples/ha_archive.cc:
        Added additional code to show more information during a SHOW TABLE STATUS. Curren size of the compressed file is now shown. Also added global "crashed" flag to mark when a table is crashed. Removed autorebuild during open table. Removed a few unneeded actions in OPTIMIZE TABLE. Fixed DBUG_ENTER for end_build_insert().
      sql/examples/ha_archive.h:
        Added repair options
      b76b2e68
  18. 07 Dec, 2004 1 commit
  19. 06 Dec, 2004 1 commit
  20. 30 Nov, 2004 1 commit
    • unknown's avatar
      Changes to support optimized bulk inserts. This will solve the problem of... · 9f726d99
      unknown authored
      Changes to support optimized bulk inserts. This will solve the problem of selects occurring during a bulk insert, and causing the compression factor to drop. 
      
      
      mysql-test/r/archive.result:
        Updated result set for changes amde to support delayed insert and bulk insert optimizations.
      mysql-test/t/archive.test:
        Test cases to test bulk insert statements and delayed insert syntax.
      sql/examples/ha_archive.cc:
        Added methods needed for bulk operations to be optimized. Bulk inserts now do not trigger the file as dirty until they are complete. A normal insert though can still cause them to be synced though since it is not effected by the flag. Removed share variable to determine if row count is right or not (it should not be treated as an upper end estimate).
      sql/examples/ha_archive.h:
        Removed share variable for delayed flag since it is no longer needed. 
        Added flag in table instance to know if a bulk insert is happening.
        
        Added method declarations for bulk insert optimizations.
      9f726d99
  21. 29 Nov, 2004 1 commit
    • unknown's avatar
      Adding support for archive to handle delayed inserts. · dc80fc2d
      unknown authored
      sql/examples/ha_archive.cc:
        Added support for delayed inserts. What delayed inserts mean for archive is that a sync call is not forced with the next select. Instant performance gain, plus if you aren't concerned about having a consistant read you won't be forced to have less then optimized compression.
      sql/examples/ha_archive.h:
        Added flags for dalyed inserts and added table flag so that the server knows that archive can support them.
      dc80fc2d
  22. 06 Nov, 2004 1 commit
    • unknown's avatar
      Remove build errors introduced by 5.0 changes. · 97ab6b91
      unknown authored
      Removed duplicate code where defaults in handler.h will work just as well. 
      
      
      sql/examples/ha_archive.cc:
        Fixed build errors, and removed duplicate code.
      sql/examples/ha_archive.h:
        Removed duplicate code (we will let the default values in handler.h handle these cases).
      97ab6b91
  23. 14 Oct, 2004 1 commit
    • unknown's avatar
      true,false -> TRUE, FALSE · 33073189
      unknown authored
      Simple fixes/optimization of things discovered during review of new pushed code
      
      
      include/my_sys.h:
        Ensure that clear_alloc_root() interacts correctly with alloc_root_inited()
      mysys/hash.c:
        More comments
        Simple optimization (merge identical code)
      mysys/my_bitmap.c:
        Change inline -> static inline
      sql/examples/ha_archive.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        true,false -> TRUE, FALSE
        Change if (false) -> #ifdef NOT_USED
      sql/ha_ndbcluster.h:
        true,false -> TRUE, FALSE
      sql/handler.cc:
        More comments
        Remove not needed initializations.
        #ifdef not used code
      sql/item_cmpfunc.h:
        true,false -> TRUE, FALSE
      sql/item_strfunc.cc:
        Move local variables to function beginning
        Remove wrong comments
      sql/log_event.h:
        true,false -> TRUE, FALSE
      sql/sql_base.cc:
        true,false -> TRUE, FALSE
        More comments
      sql/sql_help.cc:
        true,false -> TRUE, FALSE
      sql/sql_lex.cc:
        Simple optimization of new code
      sql/sql_parse.cc:
        true,false -> TRUE, FALSE
      sql/sql_prepare.cc:
        true,false -> TRUE, FALSE
      sql/sql_table.cc:
        true,false -> TRUE, FALSE
      sql/sql_yacc.yy:
        true,false -> TRUE, FALSE
      33073189
  24. 07 Oct, 2004 1 commit
    • unknown's avatar
      Clean up from Bar and Antony code review. Found an issue with the header file... · 62637c9d
      unknown authored
      Clean up from Bar and Antony code review. Found an issue with the header file were it could end up corrupted.
      
      
      sql/examples/ha_archive.cc:
        Cleanup from Bar's and Antony's code review. Meta file should not be system independent (so you can copy around the files as you like).
      sql/examples/ha_archive.h:
        No longer bother with storing the working version of the data files. Its unimportant while there is only one format.
      62637c9d
  25. 05 Oct, 2004 1 commit
  26. 26 Sep, 2004 1 commit
    • unknown's avatar
      Two cleanups for IRIX build. · 532911af
      unknown authored
      sql/examples/ha_archive.cc:
        Octane host was complaining about unused variable and second declaration of the Field_blob in write row.
      532911af
  27. 21 Sep, 2004 1 commit
    • unknown's avatar
      The major change for this changeset is the addition of code to handle: · 764ea714
      unknown authored
      OPTIMIZE TABLE <archive table>
      
      This recompresses the table, thus removing any additional gzip headers caused by opening/closing or flushing the table.
      
      
      mysql-test/r/archive.result:
        Added optimize test case for archive engine.
      mysql-test/t/archive.test:
        Added test case for OPTIMIZE table <archive table>
      sql/examples/ha_archive.cc:
        The big change was the addition of optimize() call to allow tables to be recompressed (so if you have been reading/writing/reading/writing and ending up with larger files then you should, this will solve it). Though adding this feature is going to make it a real headache to add row level locking. 
        Also fixed bug reported by JD where storage engine code was not functioning (this of course was because I didn't check for the propper return value for hash_init). Removed BROKEN_GZIP ifdef since there was no way to enable it.
      sql/examples/ha_archive.h:
        Added optimize() method.
      764ea714
  28. 23 Aug, 2004 1 commit
    • unknown's avatar
      Changed %lx -> 0x%lx (for easier comparison of debug files) · f7d0dfd9
      unknown authored
      Cosmetic cleanups
      Don't call 'delete_elements' on copy_funcs as this causes elements to be freed twice
      
      
      mysys/hash.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/list.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/mf_iocache.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/mf_keycache.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
        Changed debug messages to be more consistent with other mysys files.
      mysys/mf_keycaches.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_alloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_fopen.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_fstream.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_getwd.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_lib.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_lwrite.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_malloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_pread.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_read.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_realloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/my_write.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/safemalloc.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/thr_alarm.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/thr_lock.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/thr_mutex.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/tree.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      mysys/typelib.c:
        Changed %lx -> 0x%lx (for easier comparison of debug files)
      sql/examples/ha_archive.cc:
        Changed to return error number for some functions (instead of -1)
        Updated function comments & some other minor cleanups
        Ensure that free_share() and gzclose() are always called
        Use 'TRUE' and 'FALSE' instead of 'true' and 'false'
        Removed some compiler warnings
      sql/examples/ha_archive.h:
        Fixed to use new prototypes for records_in_range
      sql/sql_select.cc:
        Don't call 'delete_elements' on copy_funcs
      f7d0dfd9
  29. 20 Jul, 2004 1 commit
  30. 07 Jul, 2004 1 commit
    • unknown's avatar
      ha_archive.cc: · 4e95ea7b
      unknown authored
        Memory was used after it has been alreay freed.
        This led to server crash on FreeBSD.
      
      
      sql/examples/ha_archive.cc:
        Memory was used after it has been alreay freed.
        This led to server crash on FreeBSD.
      4e95ea7b
  31. 23 Jun, 2004 1 commit
    • unknown's avatar
      followup to handler cleanup · ebf9c723
      unknown authored
      mysql-test/r/bdb.result:
        bug#4000
      mysql-test/t/bdb.test:
        bug#4000
      sql/sql_select.cc:
        cleanup
      ebf9c723
  32. 07 Jun, 2004 1 commit
    • unknown's avatar
      Last patch before push into main tree. Updated from code review and final once over. · 89de6359
      unknown authored
      A couple of small changes to ha_example (mainly comments). 
      
      
      sql/examples/ha_archive.cc:
        Changes from Serg.
        A few styles changes, fix for potential hash insert gone wrong, removed bad tables if create fails, gzflush used for flushing by default (had problems with OSX 10.2), and some spelling corrections.
      sql/examples/ha_archive.h:
        Removed fast_key_read() and changed the name of a conflicting variable.
      sql/examples/ha_example.cc:
        Added a few new comments.
      sql/examples/ha_example.h:
        Added pragma interface. Removed fast_key_read() and Serg's request
      89de6359
  33. 25 May, 2004 1 commit
    • unknown's avatar
      Added tests for archive. Cleaned up a merge mistake and added some information... · 9a162f9a
      unknown authored
      Added tests for archive. Cleaned up a merge mistake and added some information on how well archive compresses. 
      
      
      sql/examples/ha_archive.cc:
        Added in example information from testing archive with Slashdot's comments.
      sql/handler.h:
        Fixed broken merge.
      sql/set_var.cc:
        Adding in "have_archive" to variables shown to make tests work.
      9a162f9a
  34. 21 May, 2004 1 commit
    • unknown's avatar
      First commit of archive example. Archive is a simple storage engine that... · 31c1f849
      unknown authored
      First commit of archive example. Archive is a simple storage engine that handles inserts and selects. 
      
      
      acconfig.h:
        Adding undef piece for HAVE_ARCHIVE_DB	
      acinclude.m4:
        Code needed for --with-archive-storage-engine flag for compile.
      configure.in:
        Adding tag for Archive
      sql/Makefile.am:
        Source updates to compile ha_archive
      sql/examples/ha_archive.cc:
        Class file for archive storage engine. First version.
      sql/handler.cc:
        Updates needed for adding archive storage engine.
      sql/handler.h:
        ENUM for archive storage engine.
      sql/mysql_priv.h:
        Archive show options
      sql/mysqld.cc:
        Ifdef foor HAVE_ARCHIVE_DB
      sql/examples/ha_archive.h:
        Include file for archive storage engine addition.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      31c1f849