1. 03 Oct, 2007 3 commits
    • marko's avatar
    • marko's avatar
      branches/zip: Silence most GCC 4.2.1 warnings about const pointers. · 2ddbc912
      marko authored
      For some reason, GCC 4.2.1 ignores casts (for removing constness)
      in calls to inline functions.
      
      page_align(), ut_align_down(): Make the parameter const void*, but still
      return a non-const pointer.  This is ugly, but these functions cannot be
      replaced with a const-preserving macro in a portable way, given that
      the pointer argument is not always pointing to bytes.
      
      buf_block_get_page_zip(): Implement as a const-preserving macro.
      
      buf_frame_get_page_zip(), buf_block_align(): Add const qualifiers.
      
      lock_rec_get_prev(): Silence GCC 4.2.1 warnings.
      
      mlog_write_initial_log_record(), mlog_write_initial_log_record_fast(),
      mtr_memo_contains(): Add const qualifier to the pointer.
      
      page_header_get_ptr(): Rewrite as page_header_get_offs(), and
      implement as a macro that calls this function.
      2ddbc912
    • marko's avatar
      branches/zip: Merge 1918:1937 from trunk. · e9507ea6
      marko authored
      e9507ea6
  2. 01 Oct, 2007 4 commits
  3. 28 Sep, 2007 9 commits
  4. 27 Sep, 2007 13 commits
  5. 26 Sep, 2007 8 commits
    • marko's avatar
      branches/zip: Document the minimum size of row_merge_block_t as UNIV_PAGE_SIZE. · 51436aa1
      marko authored
      row_merge_buf_add(): Add ut_ad(data_size < sizeof(row_merge_block_t))
      and document why it may fail if sizeof row_merge_block_t < UNIV_PAGE_SIZE.
      51436aa1
    • marko's avatar
      branches/zip: row_merge_build_indexes(): Call innobase_rec_reset() only once. · c6d6f1fa
      marko authored
      row_merge_dup_report(): Do not call innobase_rec_reset().
      c6d6f1fa
    • marko's avatar
      branches/zip: Clean up some non-inlined functions. · 2646e38c
      marko authored
      dtuple_create_for_mysql(), dtuple_free_for_mysql(): Remove.
      
      ha_innobase::records_in_range(): Use mem_heap_create(), mem_heap_free(),
      and dtuple_create() instead of the removed functions above.  Since r1587,
      InnoDB C++ functions can invoke inlined C functions.
      2646e38c
    • marko's avatar
      branches/zip: Implement the reporting of duplicate key values to MySQL. · 34ab0c05
      marko authored
      innobase_rec_to_mysql(): New function, for converting an InnoDB clustered
      index record to MySQL table->record[0].  TODO: convert integer fields.
      Currently, integer fields are in big-endian byte order instead of
      host byte order, and signed integer fields are offset by 0x80000000.
      
      innobase_rec_reset(): New function, for resetting table->record[0].
      
      row_merge_build_indexes(): Add the parameter TABLE* table (the MySQL table
      handle) for reporting duplicate key values.
      
      dtuple_from_fields(): New function, to convert an array of dfield_t* to
      dtuple_t.
      
      dtuple_get_n_ext(): New function, to compute the number of externally stored
      fields.
      
      row_merge_dup_t: Structure for counting and reporting duplicate records.
      
      row_merge_dup_report(): Function for counting and reporting duplicate records.
      
      row_merge_tuple_cmp(), row_merge_tuple_sort(): Replace the ulint* n_dup
      parameter with row_merge_dup_t* dup.
      
      row_merge_buf_sort(): Add the parameter row_merge_dup_t* dup, which is
      NULL when sorting a non-unique index.
      
      row_merge_buf_write(), row_merge_heap_create(), row_merge_read_rec(),
      row_merge_cmp(), row_merge_read_clustered_index(), row_merge_blocks(),
      row_merge(), row_merge_sort(): Add const qualifiers.
      
      row_merge_read_clustered_index(): Use a common error handling branch err_exit.
      Invoke row_merge_buf_sort() differently on unique indexes.
      
      row_merge_blocks(): note TODO: We could invoke innobase_rec_to_mysql()
      to report duplicate key values when creating a clustered index.
      34ab0c05
    • marko's avatar
      branches/zip: Minor cleanup. · f44bec19
      marko authored
      dict_find_index_by_max_id(): Rename this static function to its
      only caller, dict_table_get_index_by_max_id().
      
      dict_table_get_index_by_max_id(): Copy the function comment from
      dict_find_index_by_max_id().
      f44bec19
    • marko's avatar
      branches/zip: Add some const qualifiers to input parameters. · 3ad7bd73
      marko authored
      rec_get_converted_size_comp(), rec_convert_dtuple_to_rec_comp(),
      rec_convert_dtuple_to_rec_new(), rec_convert_dtuple_to_rec(): Add a
      const qualifier to dict_index_t*.
      
      row_search_on_row_ref(): Add const qualifiers to the dict_table_t*
      and dtuple_t* parameters.  Note that pcur is an "out" parameter
      and mtr is "in/out".
      3ad7bd73
    • marko's avatar
      branches/zip: Minor cleanup. · 36608705
      marko authored
      row_build_row_ref_fast(): Note that "ref" is an in/out parameter.
      
      row_build_row_ref_from_row(): Add const qualifiers to all "in" parameters.
      36608705
    • marko's avatar
      branches/zip: Minor cleanup. · 9b1d1fff
      marko authored
      dtuple_create(): Simplify a pointer expression.  Flag the fields uninitialized
      after initializing them in the debug version.
      
      dtuple_t: Only declare magic_n if UNIV_DEBUG is defined.  The field is
      not assigned to nor tested unless UNIV_DEBUG is defined.
      9b1d1fff
  6. 25 Sep, 2007 1 commit
  7. 24 Sep, 2007 2 commits
    • marko's avatar
      branches/zip: Add some const qualifiers or in/out comments to the · 1595953a
      marko authored
      dict_index_t* and dict_table_t* parameters of some functions.
      1595953a
    • vasil's avatar
      branches/zip: · 9bbb520f
      vasil authored
      Copy any data (currently table name and table index) that may be
      destroyed after releasing the kernel mutex into internal cache's
      storage.
      
      This is done in efficient manner using ha_storage type and a given
      string is copied only once into the cache's storage. Later additions of
      the same string use the already stored string, thus allocating memory
      only once per unique string.
      
      Approved by:	Marko
      9bbb520f