1. 24 Nov, 2009 1 commit
    • Mattias Jonsson's avatar
      merge of bug#35765 into mysql-next-mr-bugfixing · 9561a29b
      Mattias Jonsson authored
      mysql-test/r/log_tables.result:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        Updated result
      mysql-test/r/partition.result:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        Updated result
      mysql-test/r/partition_innodb.result:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        Updated result
      mysql-test/t/log_tables.test:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        Updated test
      mysql-test/t/partition.test:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        Added test case
      mysql-test/t/partition_innodb.test:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        Updated test
      sql/protocol.cc:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        (fix of bug#48939 to avoid test failures on my test build).
      sql/sql_yacc.yy:
        Bug #35765  	ALTER TABLE produces wrong error when non-existent storage engine used
        
        if no existing engine was given, don't set HA_CREATE_USED_ENGINE
      9561a29b
  2. 20 Nov, 2009 2 commits
    • Martin Hansson's avatar
      merge of Bug#33204 (backport) · 3937a798
      Martin Hansson authored
      3937a798
    • Mattias Jonsson's avatar
      Bug#32115: Bad use of Name_resolution_context from current LEX in partitioning · d8d8efc8
      Mattias Jonsson authored
      port from mysql-next (5.4?) to mysql-next-mr-bugfixes (5.5/5.6?)
      
      3477 Mikael Ronstrom	2009-07-29
      Bug#32115, made use of local lex object to avoid side effects of opening partitioned
      tables
      
      3478 Mikael Ronstrom	2009-07-29
      Bug#32115, added an extra test in debug builds to ensure no dangling pointers to the
      old lex object is still around
      
      3479 Mikael Ronstrom	2009-07-29
      Bug#32115, Removed an assert that was no longer needed
      
      3480 Mikael Ronstrom	2009-08-05
      Bug#32115, fixed review comments
      
      3481 Mikael Ronstrom	2009-08-07
      Bug#32115, remove now obsolete lex_start calls
      d8d8efc8
  3. 19 Nov, 2009 1 commit
    • Mattias Jonsson's avatar
      Bug#32115: Bad use of Name_resolution_context from current LEX in partitioning · 176cabc1
      Mattias Jonsson authored
      port from mysql-next (5.4) to mysql-next-mr-bugfixing (5.5/5.6?)
      
      2755 Konstantin Osipov	2008-11-27
      Bug#32115 will remove the pre-requisite to initialize LEX to open tables.
      This dependency was added in 5.1 and was supposed to be removed in 6.0.
      Remove asserts and initialization of LEX in places where we don't deal
      with partitioned tables.
      
      sql/sp_head.cc:
        Fix a typo.
      176cabc1
  4. 18 Nov, 2009 1 commit
    • Guilhem Bichot's avatar
      Backport of the fix for BUG#40368 "mysqld_safe not honouring underscore same... · 27fca0ab
      Guilhem Bichot authored
      Backport of the fix for BUG#40368 "mysqld_safe not honouring underscore same as dash on server options" from 6.0
      (revision-id:guilhem@mysql.com-20090505113602-l12kxupeatve18dh).
      Such bug led "mysqld_safe --core_file_size=#" to not work because mysqld_safe wouldn't recognize
      that "ulimit -c" is needed; only --core-file-size=# worked. Same for --open_files_limit and other
      options with _ where mysqld_safe needs to do something more than passing to mysqld.
      Original fix by Erik Ljungstrom erik at ibiblio dot org ; slightly modified here.
      Tested on all internally accessible Unix.
      27fca0ab
  5. 17 Nov, 2009 3 commits
  6. 15 Nov, 2009 1 commit
  7. 12 Nov, 2009 10 commits
  8. 11 Nov, 2009 5 commits
  9. 10 Nov, 2009 6 commits
    • Alexey Botchkov's avatar
      Bug #47139 Test "merge" crashes in "embedded" run · c868e89f
      Alexey Botchkov authored
        In fact this crashes in normal (not embedded) run also.
        The problem is in the memory mapping. Handling the ha_myisammrg::extra(MMAP)
        the MERGE engine tries to mmap all the tables it unites.
        Though some can be empty and then in the mi_dynmap_file()
        we call the my_mmap(0). Normally this call returns MAP_FAILED,
        but not on FreeBSD. There it returns like a 'normal' value,
        and after the consequitive munmap systems gets unstable and
        crashes on some system call later.
      
      per-file comments:
        storage/myisam/mi_dynrec.c
      Bug #47139      Test "merge" crashes in "embedded" run
          don't try to mmap zero-length area, just return at once.
      c868e89f
    • Alexey Botchkov's avatar
      Bug#42520 killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8 · 6388a132
      Alexey Botchkov authored
         The additional patch. That 'loadxml.test' failure was actually about our testing system,
         not the code.
         Firstly we need a new mysqltest command, wich i called 'send_eval'. So the expression
         can be evaluated, then started in a parallel thread. We only have separane 'send' and
         'eval' commands at the moment.
         Then we need to add the waiting code after the 'KILL' to our test, so the thread will be killed
         before the test goes further. The present 'reap' command doesn't handle the killed threads
         well.
            
      per-file comments:
        client/mysqltest.cc
      Bug#42520      killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8
          The 'send_eval' command implemented.
      
        mysql-test/r/loadxml.result
      Bug#42520      killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8
         test result updated.
      
        mysql-test/t/loadxml.test
      Bug#42520      killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8
         test case added.
      6388a132
    • Martin Hansson's avatar
      Backport of Bug#33204 from mysql-pe to · 70c7e936
      Martin Hansson authored
      mysql-next-mr-bugfixing.
      
      Bug no 32858 was fixed in two different ways in what was
      then called mysql 5.1 and 6.0. The fix in 6.0 was very
      different since bugfix no 33204 was present.  Furthermore,
      the two fixes were not compatible. Hence in order to
      backport Bug#33204 to the 5.1-based mysql-next-mr-bugfixing,
      it was necessary to remove the 5.1 fix of 32858 and apply
      the 6.0 version of the fix.
      
      
      mysql-test/r/subselect.result:
        Bug#33204-backport: Test result
      mysql-test/r/union.result:
        
        Bug#33204-backport:
        - Reversal of test result: bugfix no 32858 for 5.1
        - Application of test result: bugfix no 32858 for 6.0
      mysql-test/t/subselect.test:
        Bug#33204-backport: 
        - Changed tests
        - Test case
      mysql-test/t/union.test:
        Bug#33204-backport:
        - Reversal of test: bugfix no 32858 for 5.1
        - Application of test: bugfix no 32858 for 6.0
      sql/sql_class.cc:
        Bug#33204-backport: Reversal of bugfix no 32858 for 5.1
      sql/sql_class.h:
        Bug#33204-backport: Reversal of bugfix no 32858 for 5.1
      sql/sql_yacc.yy:
        Bug#33204-backport:
        - Reversal of bugfix no 32858 for 5.1
        - Application of bugfix no 32858 for 6.0
        - Application of bugfix no 33204
      70c7e936
    • Alexander Nozdrin's avatar
      Fix build failure. · ad6883c4
      Alexander Nozdrin authored
      ad6883c4
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-next-mr-alik. · ecd60471
      Alexander Nozdrin authored
      ecd60471
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-next-mr. · b712dce3
      Alexander Nozdrin authored
      b712dce3
  10. 09 Nov, 2009 8 commits
    • Alexander Nozdrin's avatar
      Fix manual-merge (2nd attempt). · 49bb8cba
      Alexander Nozdrin authored
      49bb8cba
    • Alexander Nozdrin's avatar
      Auto-merge from mysql-trunk-merge. · a15de184
      Alexander Nozdrin authored
      a15de184
    • Alexander Nozdrin's avatar
      Fix manual-merge. · 831c8434
      Alexander Nozdrin authored
      831c8434
    • Alexander Nozdrin's avatar
      Fix innodb.test due to Bug#48636. · fae99a38
      Alexander Nozdrin authored
      fae99a38
    • Alexander Barkov's avatar
      725f93fa
    • Alexander Barkov's avatar
      # · f3d89b2a
      Alexander Barkov authored
      # Bug#24690 Stored functions: RETURNing UTF8 strings
      # do not return UTF8_UNICODE_CI collation
      #
      # Bug#17903: cast to char results in binary
      # Regression. The character set was not being properly initialized
      # for CAST() with a type like CHAR(2) BINARY, which resulted in
      # incorrect results or even a server crash.
      #
      
      Backporting from mysql-6.0-codebase.
      
      mysql-test/r/sp-ucs2.result:
      mysql-test/t/sp-ucs2.test:
      
        Adding tests
      
      sql/mysql_priv.h:
        Adding prototype
      
      sql/sp.cc
        Remember COLLATE clause for non-default collations
      
      sql/sql_parse.cc
        Adding a new helper function
      
      sql/sql_yacc.yy
        - Allow "CHARACTER SET cs COLLATE cl" in
          SP parameters, RETURNS, DECLARE
        - Minor reorganization for "ASCII" and "UNICODE"
          related rules, to make the code more readable,
          also to allow these aliases:
          * "VARCHAR(10) ASCII BINARY"   -> CHARACTER SET latin1 COLLATE latin1_bin
          * "VARCHAR(10) BINARY ASCII"   -> CHARACTER SET latin1 COLLATE latin1_bin
          * "VARCHAR(10) UNICODE BINARY" -> CHARACTER SET ucs2 COLLATE ucs2_bin
          * "VARCHAR(10) BINARY UNICODE" -> CHARACTER SET ucs2 COLLATE ucs2_bin
          Previously these four aliases returned the error
          "This version of MySQL does not yet support return value collation".
      
      Note:
      
         This patch allows  "VARCHAR(10) CHARACTER SET cs COLLATE cl"
         and the above four aliases.
      
         "VARCHAR(10) COLLATE cl" is still not allowed
         i.e. when COLLATE is given without CHARACTER SET.
         If we want to support this, we need an architecture decision
         which character set to use by default.
      f3d89b2a
    • Alexander Barkov's avatar
    • Alexander Barkov's avatar
      7e8b208d
  11. 06 Nov, 2009 2 commits