1. 28 Feb, 2008 2 commits
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B34747-5.0-opt · 9a19de7a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B34747-5.1-opt
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/subselect.result:
        merged bug 34747 and 33266 5.0-opt->5.1-opt
      mysql-test/t/subselect.test:
        merged bug 34747 and 33266 5.0-opt->5.1-opt
      9a19de7a
    • unknown's avatar
      Bug #34747: crash in debug assertion check after derived table · f28612ea
      unknown authored
      Was a double-free of the Unique member of Item_func_group_concat.
      This was not causing a crash because the Unique is a descendent of
      Sql_alloc.
      Fixed to free the Unique only if it was allocated for the instance 
      of Item_func_group_concat it was referenced from
      
      
      mysql-test/r/func_gconcat.result:
        Bug #34747: test case
      mysql-test/t/func_gconcat.test:
        Bug #34747: test case
      sql/item_sum.cc:
        Bug #34747: free the Unique only if it was allocated
        for this instance of Item_func_group_concat
      f28612ea
  2. 27 Feb, 2008 8 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33834/my51-bug33834 · 9c0ee58f
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      9c0ee58f
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33834/my50-bug33834 · ed6f54da
      unknown authored
      into  kaamos.(none):/data/src/opt/bug33834/my51-bug33834
      
      
      mysql-test/t/func_time.test:
        Auto merged
      ed6f54da
    • unknown's avatar
      Fixed test suite failures with --ps-protocol introduced in PB by · c8885dfb
      unknown authored
      the patch for bug #33834.
      
      
      c8885dfb
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 68b21ebb
      unknown authored
      into  mysql.com:/home/hf/work/25097/my51-25097
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/log.cc:
        Auto merged
      68b21ebb
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 87007702
      unknown authored
      into  mysql.com:/home/hf/work/25097/my50-25097
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      87007702
    • unknown's avatar
      merging · 4a8c442f
      unknown authored
      4a8c442f
    • unknown's avatar
      Merge mysql.com:/home/hf/work/25097/my50-25097 · 33c43019
      unknown authored
      into  mysql.com:/home/hf/work/25097/my51-25097
      
      
      client/mysql.cc:
        Auto merged
      include/sql_common.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql-common/client.c:
        merging
      sql/log.cc:
        merging
      33c43019
    • unknown's avatar
      Bug #25097 mysql_server_init fails silently if no errmsg.sys is present. · a4b0a2cf
      unknown authored
      There was no way to return an error from the client library
      if no MYSQL connections was established.
      So here i added variables to store that king of errors and
      made functions like mysql_error(NULL) to return these.
      
      
      client/mysql.cc:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        Show the error message on std_error
      include/sql_common.h:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        cant_connect_sqlstate constant declared
      libmysql/libmysql.c:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        mysql_sqlstate(NULL) returns 'unknown_sqlstate'
      libmysqld/lib_sql.cc:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        EMBEDDED_SERVER version of the vprint_msg_to_log() implemented
      sql-common/client.c:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        mysql_server_last_errno and mysql_server_last_error introduced
        to store errors not related to particular connections.
        
        mysql_error(NULL) and mysql_errno(NULL) now returns these
        mysql_server_last_error and errno respectively
      sql/log.cc:
        Bug #25097 mysql_server_init fails silently if no errmsg.sys is present.
        
        EMBEDDED_LIBRARY implementation of the vprint_msg_to_log() moved
        to lib_sql.cc
      a4b0a2cf
  3. 26 Feb, 2008 2 commits
  4. 25 Feb, 2008 3 commits
    • unknown's avatar
      Post-merge fixes for bug #33834. · 561827e2
      unknown authored
      561827e2
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug33834/my50-bug33834 · c6d141a5
      unknown authored
      into  kaamos.(none):/data/src/opt/bug33834/my51-bug33834
      
      
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge.
      c6d141a5
    • unknown's avatar
      Fix for bug #33834: FRAC_SECOND: Applicability not clear in · 4f3eab58
      unknown authored
                          documentation
      
      While the manual mentions FRAC_SECOND only for the TIMESTAMPADD()
      function, it was also possible to use FRAC_SECOND with DATE_ADD(),
      DATE_SUB() and +/- INTERVAL.
      
      Fixed the parser to match the manual, i.e. using FRAC_SECOND for 
      anything other than TIMESTAMPADD()/TIMESTAMPDIFF() now produces a 
      syntax error.
      
      Additionally, the patch allows MICROSECOND to be used in TIMESTAMPADD/
      TIMESTAMPDIFF and marks FRAC_SECOND as deprecated.
      
      
      mysql-test/r/func_time.result:
        Added a test case for bug #33834.
      mysql-test/t/func_time.test:
        Added a test case for bug #33834.
      sql/sql_yacc.yy:
        Reject FRAC_SECOND for anything other than TIMESTAMPADD() or
        TIMESTAMPDIFF().
        Allow MICROSECOND to be used with TIMESTAMPADD()/TIMESTAMPDIFF().
        Warn about FRAC_SECOND being a deprecated unit.
      4f3eab58
  5. 24 Feb, 2008 5 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · f13831f4
      unknown authored
      into  mysql.com:/misc/mysql/99999/51-99999
      
      
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      f13831f4
    • unknown's avatar
      Bug#32757: hang with sql_mode set when setting some global variables · 9bd3b854
      unknown authored
      If setting a system-variable provided by a plug-in failed, no OK or
      error was sent in some cases, hanging the client. We now send an error
      in the case from the ticket (integer-argument out of range in STRICT
      mode). We also provide a semi-generic fallback message for possible
      future cases like this where an error is signalled, but no message is
      sent to the client. The error/warning handling is unified so it's the
      same again for variables provided by plugins and those in the server
      proper.
      
      
      mysql-test/r/plugin.result:
        show that on out-of-range values, plugin interface throws errors
        in STRICT mode and warnings otherwise.
      mysql-test/t/plugin.test:
        show that on out-of-range values, plugin interface throws errors
        in STRICT mode and warnings otherwise.
      sql/set_var.cc:
        - handle signedness of values used in warnings
        - in STRICT mode, throw errors rather than warnings
      sql/sql_parse.cc:
        If sql_set_variables() returns with an error but no message
        was sent to the client, send a semi-generic one so the session
        won't hang and we won't fail silently.
      sql/sql_plugin.cc:
        throw a warning if more than just block-size was corrected
        (or an error in STRICT mode). use functions from set_var
        for uniform behaviour of server- and plug-in variables.
      storage/example/ha_example.cc:
        Add a ULONG system variable to example plugin so
        we can test integers in the plugin-interface without
        having to depend on the presence of innobase.
      9bd3b854
    • unknown's avatar
      Bug#32753: PAD_CHAR_TO_FULL_LENGTH is not documented and interferes with grant tables · a22c3d21
      unknown authored
      SQL-mode PAD_CHAR_TO_FULL_LENGTH affected mysqld's user-table too. If
      enabled, user-name and host were space-padded and no longer matched
      the login-data of incoming connexions.
      
      Patch disregards pad-flag while loading privileges so ability to log
      in does not depend on SQL-mode.
      
      
      mysql-test/r/sql_mode.result:
        show that SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' does not affect
        loading of privileges (and by extension, ability to log in).
      mysql-test/t/sql_mode.test:
        show that SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' does not affect
        loading of privileges (and by extension, ability to log in).
      sql/sql_acl.cc:
        temporarily disable SQL-mode 'PAD_CHAR_TO_FULL_LENGTH' while
        reloading privileges
      a22c3d21
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 177a0a0c
      unknown authored
      into  mysql.com:/misc/mysql/20752/51-20752
      
      
      sql/item_func.cc:
        Auto merged
      177a0a0c
    • unknown's avatar
      Bug#20752: BENCHMARK with many iterations returns too quickly · 7b8717ac
      unknown authored
      In BENCHMARK(count, expr), count could overflow/wrap-around.
      Patch changes to a sufficiently large data-type. Adds a warning
      for negative count values.
      
      
      mysql-test/r/func_str.result:
        show that a negative 'count' for BENCHMARK(count, expr)
        throws a warning and returns NULL.
      mysql-test/t/func_str.test:
        show that a negative 'count' for BENCHMARK(count, expr)
        throws a warning and returns NULL.
      sql/item_func.cc:
        use ulonglong rather than ulong in BENCHMARK(count, expr)
        throw warning on negative 'count'; return SQL-NULL.
      7b8717ac
  6. 22 Feb, 2008 11 commits
  7. 20 Feb, 2008 2 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 463edf37
      unknown authored
      into  moonbone.local:/work/33266-bug-5.0-opt-mysql
      
      
      463edf37
    • unknown's avatar
      Bug#33266: Incorrect test case for the bug#31048 failing on some platforms. · daffceb4
      unknown authored
      The test case for the bug#31048 checks that there is no crash on stack
      overrun. But due to different stack sizes on different platforms it failed
      on some of them.
      
      The new test case check that a query with at least 4 level subquery nesting
      works without the stack overrun nesting and other levels of nesting doesn't
      cause a crash.
      
      
      mysql-test/t/subselect.test:
        Corrected test case for the bug#31048.
      mysql-test/r/subselect.result:
        Corrected test case for the bug#31048.
      daffceb4
  8. 19 Feb, 2008 3 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/bug31236/my51-bug31236 · 173efef4
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      configure.in:
        Auto merged
      mysql-test/r/strict.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/unireg.h:
        Auto merged
      173efef4
    • unknown's avatar
      Fix for bug #31236: Inconsistent division by zero behavior for · 61c31af4
      unknown authored
                          floating point numbers
      
      Some math functions did not check if the result is a valid number
      (i.e. neither of +-inf or nan).
      
      Fixed by validating the result where necessary and returning NULL in
      case of invalid result.
      
      
      BitKeeper/deleted/.del-matherr.c:
        Rename: sql/matherr.c -> BitKeeper/deleted/.del-matherr.c
      configure.in:
        Removed DONT_USE_FINITE, it is not used anywhere.
      include/my_global.h:
        isfinite() is a C99 macro which absoletes finite(). First try to use
        it, then fall back to finite() if the target platform has it,
        otherwise use our own implementation.
      mysql-test/r/func_math.result:
        Added a test case for bug #31236.
      mysql-test/r/strict.result:
        Fixed a test case which relied on old behavior.
      mysql-test/t/func_math.test:
        Added a test case for bug #31236.
      mysql-test/t/strict.test:
        Fixed a test case which relied on old behavior.
      sql/field.cc:
        No need to check if the finite() or its equivalent is available.
      sql/item_func.cc:
        Use fix_result() wherever the result can be one of +-inf or nan, 
        assuming the function arguments are valid numbers.
        Removed fix_result() from functions that are defined for all possible
        input numbers.
      sql/item_func.h:
        Moved fix_result() from Item_dec_func to Item_func which is a common
        ancestor for Item_dec_func and Item_num_op.
      sql/unireg.h:
        Removed POSTFIX_ERROR because no code returns it.
      61c31af4
    • unknown's avatar
      Bug #30604: different flagging of time_zone_used in normal · 1ac31924
      unknown authored
        and ps-protocol
      Finding a routine should be a transparent operation as 
      far as the binary log is concerned.
      But it was influencing the binary log because of the TIMESTAMP
      column in the proc table.
      
      Fixed by preserving and restoring the time_zone usage flag when
      searching for a stored routine in the proc table.
      
      
      mysql-test/r/binlog_innodb.result:
        Bug #30604: test case
      mysql-test/r/ctype_cp932_binlog.result:
        Bug #30604: updated test results (a procedure call before that)
      mysql-test/t/binlog_innodb.test:
        Bug #30604: test case
      sql/sp.cc:
        Bug #30604: finding a routine should be a transparent operation as 
        far as the binary log is concerned.
        Fixed by preserving and restoring the time_zone usage flag.
      1ac31924
  9. 18 Feb, 2008 4 commits