An error occurred fetching the project authors.
  1. 08 Feb, 2008 1 commit
    • unknown's avatar
      Bug#33798 prepared statements improperly handle large unsigned ints · cea021da
      unknown authored
      The unsignedness of large integer user variables was not being
      properly preserved when feeded to prepared statements. This was
      happening because the unsigned flags wasn't being updated when
      converting the user variable is converted to a parameter.
      
      The solution is to copy the unsigned flag when converting the
      user variable to a parameter and take the unsigned flag into
      account when converting the integer to a string.
      
      
      mysql-test/r/binlog.result:
        Add test case result for Bug#33798
      mysql-test/r/ps.result:
        Add test case result for Bug#33798
      mysql-test/t/binlog.test:
        Add test case for Bug#33798
      mysql-test/t/ps.test:
        Add test case for Bug#33798
      sql/item.cc:
        Take the unsigned flag into account when converting the
        user variable.
      cea021da
  2. 04 Feb, 2008 1 commit
  3. 01 Feb, 2008 3 commits
    • unknown's avatar
      Again blanking out some numbers in file names that is dependent · 94c8fd42
      unknown authored
      on the context.
      
      
      mysql-test/r/mysqlbinlog.result:
        Result file change.
      mysql-test/t/mysqlbinlog.test:
        Blanking out yet some numbers in file names.
      94c8fd42
    • unknown's avatar
      Fixes to make tests pass in pushbuild. · 6a1e8b9a
      unknown authored
      mysql-test/r/mysqlbinlog.result:
        Result file change.
      mysql-test/t/mysqlbinlog.test:
        Fixing test to not be dependent on the sequence numbers
        for file names generated by mysqlbinlog.
      6a1e8b9a
    • unknown's avatar
      Various fixes to make tests pass on Windows. · 9b9694b3
      unknown authored
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Result change
      mysql-test/t/binlog_start_comment.test:
        Adding --local-load to mysqlbinlog to prevent it from failing
        on Windows. Also adding --short-form.
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Extending LIKE pattern to use either \n or \r\n in order to work
        on Windows.
      9b9694b3
  4. 31 Jan, 2008 1 commit
    • unknown's avatar
      Changes to fix tests in pushbuild. · 5e0f848b
      unknown authored
      mysql-test/include/have_local_infile.inc:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/include/have_local_infile.inc
      mysql-test/r/have_local_infile.require:
        BitKeeper file /data0/mkindahl/mysql-5.0-rpl-merge/mysql-test/r/have_local_infile.require
      mysql-test/t/binlog_start_comment.test:
        Test requires that local_infile is on, so added require for that.
      mysql-test/t/rpl_sp.test:
        Adding missing sync_slave_with_master causing following tests to fail.
      5e0f848b
  5. 30 Jan, 2008 1 commit
    • unknown's avatar
      Changes to make tests pass in pushbuild. · e7a28528
      unknown authored
      mysql-test/r/bdb_notembedded.result:
        Result change.
      mysql-test/r/rpl_loaddata_map.result:
        Result change.
      mysql-test/t/rpl_loaddata_map.test:
        Blanking out file id as well.
      e7a28528
  6. 29 Jan, 2008 1 commit
  7. 27 Jan, 2008 1 commit
    • unknown's avatar
      Fix test case for Bug #25347 so that it actually tests the code fix, · 2989a539
      unknown authored
      and so that it works correctly on Windows.
      
      
      mysql-test/r/mysqlcheck.result:
        Flush tables before monkeying around with underlying MyISAM data files
      mysql-test/t/mysqlcheck.test:
        Fix the test case for bug #25347 so that it actually does test the behavior.
        Also, this makes it work on Windows by ensuring that mysqld doesn't hold the
        underlying MyISAM files open while we try to corrupt them on disk.
        
        Flush tables before monkeying around with underlying MyISAM data files;
        --use-frm, so that mysqlcheck will succeed.
      2989a539
  8. 25 Jan, 2008 1 commit
    • unknown's avatar
      BUG#33862 completely failed DROP USER statement gets replicated · c78852a5
      unknown authored
      The problem is when create/rename/drop users, the statement was logged regardless of error, even if no data has been changed, the statement was logged.
      
      After this patch, create/rename/drop users don't write the binlog if the statement makes no changes, if the statement does make any changes, log the statement with possible error code.
      
      This patch is based on the patch for BUG#29749, which is not pushed
      
      
      sql/sql_acl.cc:
        when create/rename/drop users, don't write the binlog if the statement make no changes
      mysql-test/r/rpl_user.result:
        New BitKeeper file ``mysql-test/r/rpl_user.result''
      mysql-test/t/rpl_user.test:
        New BitKeeper file ``mysql-test/t/rpl_user.test''
      c78852a5
  9. 23 Jan, 2008 3 commits
    • unknown's avatar
      manual merge · 5ecbc830
      unknown authored
      5ecbc830
    • unknown's avatar
      Bug#33618 (Crash in sp_rcontext) · 96dc5f05
      unknown authored
      Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted)
      
      The server used to crash when REPEAT or another control instruction
      was used in conjunction with labels and a LEAVE instruction.
      
      The crash was caused by a missing "pop" of handlers or cursors in the
      code representing the stored program. When executing the code in a loop,
      this missing "pop" would result in a stack overflow, corrupting memory.
      
      Code generation has been fixed to produce the missing h_pop/c_pop
      instructions.
      
      Also, the logic checking that labels at the beginning and the end of a
      statement are matched was incorrect, causing Bug 33983.
      End labels, when used, must match the label used at the beginning of a block.
      
      
      mysql-test/r/sp-code.result:
        Bug#33618 (Crash in sp_rcontext)
      mysql-test/r/sp-error.result:
        Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted)
      mysql-test/r/sp.result:
        Bug#33618 (Crash in sp_rcontext)
      mysql-test/t/sp-code.test:
        Bug#33618 (Crash in sp_rcontext)
      mysql-test/t/sp-error.test:
        Bug 33983 (Stored Procedures: wrong end <label> syntax is accepted)
      mysql-test/t/sp.test:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_head.cc:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_head.h:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_rcontext.cc:
        Bug#33618 (Crash in sp_rcontext)
      sql/sp_rcontext.h:
        Bug#33618 (Crash in sp_rcontext)
      sql/sql_yacc.yy:
        Bug#33618 (Crash in sp_rcontext)
      96dc5f05
    • unknown's avatar
      Patch contributed by Jocelyn Fournier. CLA received 2007-02-27. · 1589dc39
      unknown authored
      Bug#25347: mysqlcheck -A -r doesn't repair table marked as crashed
      
      mysqlcheck tests nullness of the engine type to know whether the
      "table" is a view or not.  That also falsely catches tables that 
      are severly damaged.
      
      Instead, use SHOW FULL TABLES to test whether a "table" is a view
      or not.
      
      (Don't add new function.  Instead, get original data a smarter way.)
      
      Make it safe for use against databases before when views appeared.
      
      
      client/mysqlcheck.c:
        Use SHOW FULL TABLES to test better whether a name in the table
        list is one of a view.  Checking that the engine is NULL is 
        insufficient.
        
        Implemented suggestion from jimw that involved removing most of 
        original patch and getting data a better way
      mysql-test/r/mysqlcheck.result:
        Verify that tables that have NULL/unreadable engine types are 
        processed and not interpreted as views.
      mysql-test/t/mysqlcheck.test:
        Verify that tables that have NULL/unreadable engine types are 
        processed and not interpreted as views.
      1589dc39
  10. 20 Jan, 2008 1 commit
  11. 18 Jan, 2008 1 commit
    • unknown's avatar
      BUG#33794 "MySQL crashes executing specific query": · c726f011
      unknown authored
      The problem occurred when one had a subquery that had an equality X=Y where 
      Y referred to a named select list expression from the parent select. MySQL 
      crashed when trying to use the X=Y equality for ref-based access. 
      
      Fixed by allowing non-Item_field items in the described case.
      
      
      mysql-test/r/subselect.result:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      mysql-test/t/subselect.test:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      sql/sql_select.cc:
        BUG#33794 "MySQL crashes executing specific query"
        get_store_key() assumed that if it got a reference
          t.key=Item_outer_ref(Item_direct_ref(x)) 
        then x was an Item_field object, which is not the case when one refers to a
        named select list expression out ot subquery.
      c726f011
  12. 14 Jan, 2008 1 commit
    • unknown's avatar
      Bug#33143: Incorrect ORDER BY for ROUND()/TRUNCATE() result · 01557dde
      unknown authored
      The ROUND(X, D) function would change the Item::decimals field during
      execution to achieve the effect of a dynamic number of decimal digits.
      This caused a series of bugs:
      Bug #30617:Round() function not working under some circumstances in InnoDB
      Bug #33402:ROUND with decimal and non-constant cannot round to 0 decimal places
      Bug #30889:filesort and order by with float/numeric crashes server
      Fixed by never changing the number of shown digits for DECIMAL when
      used with a nonconstant number of decimal digits.
      
      
      mysql-test/r/type_decimal.result:
        Bug#33143: Test result
      mysql-test/t/type_decimal.test:
        Bug#33143: Test case
      sql/item_func.cc:
        Bug#33143: 
        - Moved the DECIMAL_MAX_SCALE limitation to fix_length_and_dec.
        - Removed resetting of Item::decimals field.
        - set the frac field of the output value to current scale.
      strings/decimal.c:
        Bug#33143: It is necessary to set all digits in the buffer following the 
        rounded one to zero, as they may now be displayed.
      01557dde
  13. 11 Jan, 2008 3 commits
    • unknown's avatar
      Bug#31797: error while parsing subqueries -- WHERE is parsed as HAVING · 2771cf8b
      unknown authored
      The name resolution for correlated subqueries and HAVING clauses
      failed to distinguish which of two was being performed when there 
      was a reference to an outer aliased field.
      Fixed by adding the condition that HAVING clause name resulotion
      is being performed.
      
      
      mysql-test/r/group_by.result:
        Bug#31797: Test result
      mysql-test/t/group_by.test:
        Bug#31797: Test case
      sql/item.cc:
        Bug#31797: 
        Corrected function comment.
        The fix, raising the error is restricted to HAVING name resolution.
      2771cf8b
    • unknown's avatar
      Bug#29477: Not all fields of the target table were checked to have a default · c328260a
      unknown authored
      value when inserting into a view.
      
      The mysql_prepare_insert function checks all fields of the target table that
      directly or indirectly (through a view) are specified in the INSERT
      statement to have a default value. This check can be skipped if the INSERT
      statement doesn't mention any insert fields. In case of a view this allows
      fields that aren't mentioned in the view to bypass the check.
      
      Now fields of the target table are always checked to have a default value
      when insert goes into a view.
      
      
      mysql-test/t/view.test:
        Added a test case for the bug#29477: Not all fields of the target table were 
        checked to have a default value when inserting into a view.
      mysql-test/r/view.result:
        Added a test case for the bug#29477: Not all fields of the target table were 
        checked to have a default value when inserting into a view.
      sql/sql_insert.cc:
        Bug#29477: Not all fields of the target table were checked to have a default
        value when inserting into a view.
        Now fields of the target table are always checked to have a default value
        when insert goes into a view.
      c328260a
    • unknown's avatar
      Bug#33814 - yassl problems · ce9a829e
      unknown authored
      extra/yassl/src/template_instnt.cpp:
        new template instantiation
      ce9a829e
  14. 09 Jan, 2008 1 commit
    • unknown's avatar
      Bug #33133: Views are not transparent · 5ffb9978
      unknown authored
      When resolving references we need to take into consideration
      the view "fields" and allow qualified access to them.
      Fixed by extending the reference resolution to process view
      fields correctly.
      
      
      mysql-test/r/func_group.result:
        Bug #33133: test case
      mysql-test/t/func_group.test:
        Bug #33133: test case
      sql/sql_base.cc:
        Bug #33133: allow qualified alias refs to view fields
      5ffb9978
  15. 08 Jan, 2008 3 commits
    • unknown's avatar
      Bug#33675: Usage of an uninitialized memory by filesort in a subquery caused · 89cccc7c
      unknown authored
      server crash.
      
      The filesort implementation has an optimization for subquery execution which
      consists of reusing previously allocated buffers. In particular the call to
      the read_buffpek_from_file function might be skipped when a big enough buffer
      for buffer descriptors (buffpeks) is already allocated. Beside allocating
      memory for buffpeks this function fills allocated buffer with data read from
      disk. Skipping it might led to using an arbitrary memory as fields' data and
      finally to a crash.
      
      Now the read_buffpek_from_file function is always called. It allocates
      new buffer only when necessary, but always fill it with correct data.
      
      
      sql/filesort.cc:
        Bug#33675: Usage of an uninitialized memory by filesort in a subquery caused
        server crash.Now the read_buffpek_from_file function is always called. It allocates
        new buffer only when necessary, but always fill it with correct data.
      mysql-test/r/subselect.result:
        Added a test case for the bug#33675: Usage of an uninitialized memory by
        filesort in a subquery caused server crash.
      mysql-test/t/subselect.test:
        Added a test case for the bug#33675: Usage of an uninitialized memory by
        filesort in a subquery caused server crash.
      89cccc7c
    • unknown's avatar
      Post-merge fixes to make tests pass. · c47bf649
      unknown authored
      mysql-test/r/blackhole.result:
        Result change.
      mysql-test/r/mysqlbinlog2.result:
        Result change.
      mysql-test/t/blackhole.test:
        Fixing test to ignore file_id for exec_load_file events.
      c47bf649
    • unknown's avatar
      Bug#29770 Two handlers are allowed to catch an error in an stored procedure. · f18ef31b
      unknown authored
      Add test case.
      
      
      mysql-test/r/sp.result:
        Add test case result for Bug#29770
      mysql-test/t/sp.test:
        Add test case for Bug#29770
      f18ef31b
  16. 06 Jan, 2008 1 commit
    • unknown's avatar
      Fixed some test case after push of BUG#32205 · 2c6ff6dd
      unknown authored
      mysql-test/r/binlog_start_comment.result:
        Drop tables used in the test case when done
      mysql-test/r/blackhole.result:
        Mask out file_id in show binlog events output
      mysql-test/r/case.result:
        Drop table t2 too if it exists at the start of the test
      mysql-test/t/blackhole.test:
        Mask out file_id in show binlog events output
      mysql-test/t/case.test:
        Drop table t2 too if it exists at the start of the test
      2c6ff6dd
  17. 24 Dec, 2007 1 commit
    • unknown's avatar
      Fix for bug #33305: Test case in 'skip_grants' file need dynamic loading · 8d8ef7be
      unknown authored
                          to be compiled in
      
      The problem was that on a statically built server an attempt to create
      a UDF resulted in a different, but reasonable error ("Can't open shared
      library" instead of "UDFs are unavailable with the --skip-grant-tables
      option"), which caused a failure for the test case for bug #32020.
      
      Fixed by moving the test case for bug #32020 from skip_grants.test to a
      separate test to ensure that it is only run when the server is built
      with support for dynamically loaded libraries.
      
      
      mysql-test/r/skip_grants.result:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/t/skip_grants.test:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/r/udf_skip_grants.result:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/t/udf_skip_grants-master.opt:
        Moved the test case for bug #32020 to a separate test.
      mysql-test/t/udf_skip_grants.test:
        Moved the test case for bug #32020 to a separate test.
      8d8ef7be
  18. 23 Dec, 2007 1 commit
    • unknown's avatar
      bug#30435 · fbc6d53d
      unknown authored
      changes due to non-determinism in value of read_buffer_size.
      
      
      mysql-test/r/rpl_loaddata_map.result:
        results changed
      mysql-test/t/rpl_loaddata_map.test:
        showing only the fact that the buffer size is larger than the packet size.
      mysql-test/std_data/bug30435_10k_items.txt:
        data for bug#30435 regression testing
      mysql-test/std_data/bug30435_5k.txt:
        data for bug#30435 regression testing
      fbc6d53d
  19. 22 Dec, 2007 1 commit
    • unknown's avatar
      bug#30435 · 15426424
      unknown authored
      refining the test after it failed on pb.
      
      
      mysql-test/r/rpl_loaddata_map.result:
        results changed
      mysql-test/t/rpl_loaddata_map.test:
        refining the test
      15426424
  20. 21 Dec, 2007 4 commits
    • unknown's avatar
      BUG#30435 loading large LOAD DATA INFILE breaks slave with · 62c67f19
      unknown authored
                read_buffer_size set on master
      BUG#33413 show binlog events fails if binlog has event size of close
                to max_allowed_packet
      
      
      The size of Append_block replication event was determined solely by
      read_buffer_size whereas the rest of replication code deals with
      max_allowed_packet.
      When the former parameter was set to larger than the latter there were
      two artifacts: the master could not read events from binlog;
      show master events did not show.
      
      Fixed with 
      - fragmenting the used io-cached buffer into pieces each size of less
        than max_allowed_packet (bug#30435)
      - incrementing show-binlog-events handling thread's max_allowed_packet
        with the max estimated for the replication header size
      
      
      include/my_sys.h:
        accessor-macros added in order not to mess with the io cache's implementation
        details in code that merely exploits the io-cache.
      sql/sql_repl.cc:
        BUG#33413: incrementing thd->variables.max_allowed_packet with 
        the max estimation for the replication header size (from bug#19402);
        refactoring log_loaded_block() to fragment the io_cache buffer in case
         read_buffer_size > max_allowed_packet.
      mysql-test/r/rpl_loaddata_map.result:
        New BitKeeper file ``mysql-test/r/rpl_loaddata_map.result''
      mysql-test/t/rpl_loaddata_map-master.opt:
        specific options to trigger  BUG#30435,  BUG#33413 situations
      mysql-test/t/rpl_loaddata_map-slave.opt:
        max_allowed_packet to be compatible with the master's version.
      mysql-test/t/rpl_loaddata_map.test:
        regression tests for two bugs.
      62c67f19
    • unknown's avatar
      BUG#26395: if crash during autocommit update to transactional table on master, slave fails · b00fc710
      unknown authored
      Now, every transaction (including autocommit transactions) start with
      a BEGIN and end with a COMMIT/ROLLBACK in the binlog.
      Added a test case, and updated lots of test case result files.
      
      
      mysql-test/t/rpl_transaction-master.opt:
        BitKeeper file /home/sven/bk/b26395-autocommit-xa/5.0-rpl/mysql-test/t/rpl_transaction-master.opt
      mysql-test/t/rpl_transaction-slave.opt:
        BitKeeper file /home/sven/bk/b26395-autocommit-xa/5.0-rpl/mysql-test/t/rpl_transaction-slave.opt
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Updated result file
      mysql-test/r/multi_update.result:
        Updated result file
      mysql-test/r/rpl_transaction.result:
        New result file for new test case.
      mysql-test/r/sp_trans_log.result:
        Updated result file
      mysql-test/r/variables-big.result:
        Updated result file
      mysql-test/t/rpl_transaction.test:
        New test case.
      sql/log.cc:
         - Always write BEGIN and COMMIT around statements, even in autocommit
           mode.
         - Added comments for binlog_commit and binlog_rollback.
      sql/log_event.cc:
        Added debug trigger to avoid writing xid events to the binlog.
      b00fc710
    • unknown's avatar
      Bug #33256: CREATE ... SELECT creates obsolete table · cb3cfe74
      unknown authored
       w/ Field_date instead of Field_newdate
        
      Field_date was still used in temp table creation.
      Fixed by using Field_newdate consistently throughout the server
      except when reading tables defined with older MySQL version.
      No test suite is possible because both Field_date and Field_newdate
      return the same values in all the metadata calls. 
      
      
      mysql-test/r/type_decimal.result:
        Bug #33256: removed redundant warnings
      sql/field.h:
        Bug #33256: Add a constructor similar to Field_date::Field_date()
      sql/item.cc:
        Bug #33256: Use Field_newdate instead of Field_date 
        for all temp tables and CREATE .. SELECT
      sql/item_sum.cc:
        Bug #33256: Use Field_newdate instead of Field_date 
        for all temp tables and CREATE .. SELECT
      sql/item_timefunc.cc:
        Bug #33256: Use Field_newdate instead of Field_date 
        for all temp tables and CREATE .. SELECT
      sql/item_timefunc.h:
        Bug #33256: Use Field_newdate instead of Field_date 
        for all temp tables and CREATE .. SELECT
      cb3cfe74
    • unknown's avatar
      BUG#28908 Replication: set global server_id is not setting the session server_id · 25d238de
      unknown authored
      When set the server-id dynamically, the server_id member of current thread is not updated.
      
      Update the server_id member of current thread after updated the global variable value.
      
      
      sql/set_var.cc:
        Update server_id of current thread
      mysql-test/r/rpl_server_id.result:
        Add test for BUG#28908
      mysql-test/t/rpl_server_id.test:
        Add test for BUG#28908
      25d238de
  21. 20 Dec, 2007 1 commit
    • unknown's avatar
      BUG#12691 (Exec_master_log_pos corrupted with SQL_SLAVE_SKIP_COUNTER): · dad5ba13
      unknown authored
      Complementary patch since LOAD DATA INFILE was not covered in
      the previous patch.
      
      This patch adds a check so that the slave skip counter is not
      decreased to zero if seeing a BEGIN_LOAD_QUERY_EVENT,
      APPEND_BLOCK_EVENT, or CREATE_FILE_EVENT since these cannot
      end a group. The group is terminated by an EXECUTE_LOAD_QUERY_
      EVENT or DELETE_FILE_EVENT.
      
      
      mysql-test/r/rpl_slave_skip.result:
        Result change.
      mysql-test/t/rpl_slave_skip.test:
        Adding tests to test that the first event of a LOAD DATA INFILE
        can be skipped safely for both transactional and non-transactional
        tables. Also include a case that will generate a DELETE_FILE event
        last in the group, and this should be properly skipped as well.
      sql/slave.cc:
        Not decrementing slave skip counter to zero when seeing a
        BEGIN_LOAD_QUERY_EVENT, APPEND_BLOCK_EVENT, or CREATE_FILE_EVENT
        since these cannot end a group.
      dad5ba13
  22. 19 Dec, 2007 1 commit
    • unknown's avatar
      correct invalid values in SET GLOBAL var=DEFAULT · a3ad4f87
      unknown authored
      bug#33382
      
      
      mysql-test/r/variables.result:
        typo in a test case
      mysql-test/t/variables.test:
        typo in a test case
      sql/set_var.cc:
        correct invalid values in SET GLOBAL var=DEFAULT
      a3ad4f87
  23. 18 Dec, 2007 1 commit
    • unknown's avatar
      Fixed some test case for BUG#32205 · 0493f058
      unknown authored
      mysql-test/r/binlog_start_comment.result:
        update result
      mysql-test/r/mysqlbinlog2.result:
        Update result for BUG#32205
      mysql-test/t/binlog_start_comment.test:
        Reset master at the start of test, use a file instead of a pipe, do clean up
      0493f058
  24. 17 Dec, 2007 1 commit
    • unknown's avatar
      Bug #19390: Test 'rpl_trigger' fails, might be random · 38712142
      unknown authored
      The checks in the test for bug #12480 were too wide and
      made the test to depend on the procedures and triggers
      present in the server.
      Corrected the test to check only for the procedure and 
      trigger it creates.
      
      
      mysql-test/r/rpl_trigger.result:
        Bug #19390: corrected the test to check for its procedure only
      mysql-test/t/rpl_trigger.test:
        Bug #19390: corrected the test to check for its procedure only
      38712142
  25. 15 Dec, 2007 1 commit
    • unknown's avatar
      BUG#32205 Replaying statements from mysqlbinlog fails with a syntax error, replicates fine · f53f0455
      unknown authored
      The reason of this bug is that when mysqlbinlog dumps a query, the query is written to
      output with a delimeter appended right after it, if the query string ends with a '--'
      comment, then the delimeter would be considered as part of the comment, if there are any
      statements after this query, then it will cause a syntax error.
      
      Start a newline before appending delimiter after a query string
      
      
      mysql-test/r/ctype_ucs_binlog.result:
        Update test result for BUG#32205
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Update test result for BUG#32205
      mysql-test/r/mysqlbinlog.result:
        Update test result for BUG#32205
      mysql-test/r/rpl_charset.result:
        Update test result for BUG#32205
      mysql-test/r/rpl_timezone.result:
        Update test result for BUG#32205
      mysql-test/r/user_var-binlog.result:
        Update test result for BUG#32205
      mysql-test/t/mix_innodb_myisam_binlog.test:
        Fixed for BUG#32205
      sql/log_event.cc:
        Start a newline before appending delimiter after a query string
      mysql-test/r/binlog_start_comment.result:
        Add test for BUG#32205
      mysql-test/t/binlog_start_comment.test:
        Add test for BUG#32205
      f53f0455
  26. 14 Dec, 2007 2 commits
    • unknown's avatar
      Fixed bug #27848. · e8d00ea7
      unknown authored
      In a union without braces, the order by at the end is applied to the 
      overall union. It therefore should not interfere with the individual
      select parts of the union.
      
      Fixed by changing our parser rules appropriately.
      
      
      mysql-test/r/union.result:
        Added a test case for bug #27848.
      mysql-test/t/union.test:
        Added a test case for bug #27848.
      e8d00ea7
    • unknown's avatar
      Bug#32798: DISTINCT in GROUP_CONCAT clause fails when ordering by a column · 94962b96
      unknown authored
      with null values
      
      For queries containing GROUP_CONCAT(DISTINCT fields ORDER BY fields), there 
      was a limitation that the DISTINCT fields had to be the same as ORDER BY 
      fields, owing to the fact that one single sorted tree was used for keeping 
      track of tuples, ordering and uniqueness. Fixed by introducing a second 
      structure to handle uniqueness so that the original structure has only to 
      order the result.
      
      
      mysql-test/r/func_gconcat.result:
        Bug#32798:
        - Wrong test result turned correct after fix.
        - Correct test result
      mysql-test/t/func_gconcat.test:
        Bug#32798: Test case
      sql/item_sum.cc:
        Bug#32798: Implementation of fix. Dead code removal.
        
        - removed comment describing this bug
        - replaced body of function group_concat_key_cmp_with_distinct
        - removed function group_concat_key_cmp_with_distinct_and_order
        - Added a Unique object to maintain uniqueness of values.
      sql/item_sum.h:
        Bug#32798: Declarations and comments.
      94962b96
  27. 13 Dec, 2007 2 commits
    • unknown's avatar
      after merge fix · 72bdad35
      unknown authored
      72bdad35
    • unknown's avatar
      BUG#32198: Comparison of DATE with DATETIME still not using indexes correctly · 4c56d1af
      unknown authored
      - Make conditions like "date_col $CMP$ 'datetime-const'" range-sargable
      
      
      mysql-test/r/range.result:
        BUG#32198: Comparison of DATE with DATETIME still not using indexes correctly
        - Testcase
      mysql-test/t/range.test:
        BUG#32198: Comparison of DATE with DATETIME still not using indexes correctly
        - Testcase
      sql/field.cc:
        BUG#32198: Comparison of DATE with DATETIME still not using indexes correctly
        - Added comments
      4c56d1af