1. 23 Apr, 2020 4 commits
    • Otto Kekäläinen's avatar
      MDEV-21944: Remove TokuDB from Debian packaging · 9cc1c74c
      Otto Kekäläinen authored
      It was already disabled in 1589cf1c but
      turns out that as long as the packaging is there, is requires maintenance,
      ensuring it still builds, debugging failing tests etc and that takes its
      toll and is not worth all the extra work. Having it "only disabled" does
      not help, since either we have it and keep it tested and working, or we
      don't have it and don't spend time on keeping it working and tested.
      
      In MDEV-19780 there was already a decision to drop TokuDB from MariaDB.
      
      If somebody wants TokuDB, they can use the 10.4 branch.
      9cc1c74c
    • Otto Kekäläinen's avatar
    • Otto Kekäläinen's avatar
      Deb: Add a customized salsa-ci.yml for easy extra testing · 03119c58
      Otto Kekäläinen authored
      As initially most tests fail, they have allow_failures defined so that
      testing anyway proceeds all the way to the final 'upgrade extras' stage.
      
      All of these tests work for downstream Debian packaging of MariaDB 10.4
      and should eventually pass on upstream MariaDB 10.5 as well.
      
      Also upstream the Debian autopkgtests from MariaDB 10.4 in Debian so that
      pipeline includes running mtr.
      03119c58
    • Otto Kekäläinen's avatar
      Temporarily disable tests permanently failing on 10.5 · 6f0b621c
      Otto Kekäläinen authored
      This are filed as issues so I trust these will not be forgotten:
      - MDEV-20372
      - MDEV-21965
      - MDEV-21968
      - MDEV-22119
      
      Having these tests fail the MTR permanently decreases the overall quality
      of the software as:
      - developers start neglecting the results from CI systems and do not spot
        the new regressions their changes introduce
      - reviews take many hours as a diligent reviewer needs to open all build
        logs that are failing, see what is failing, and check if those are new
        failures or not – alternatively reviewers stop looking at CI altogether
      
      It is better to disable these test now and prioritize the MDEVs for the
      test failure bugs than keep the MTR red and allow more test failures to
      creep in.
      6f0b621c
  2. 22 Apr, 2020 4 commits
  3. 21 Apr, 2020 4 commits
  4. 20 Apr, 2020 2 commits
  5. 19 Apr, 2020 20 commits
  6. 18 Apr, 2020 2 commits
  7. 17 Apr, 2020 3 commits
    • Kentoku SHIBA's avatar
      MDEV-20502 Queries against spider tables return wrong values for columns... · 181f17c3
      Kentoku SHIBA authored
      MDEV-20502 Queries against spider tables return wrong values for columns following constant declarations.
      
      When executing a query like "select id, 0 as const, val from ...", there are 3 columns(items) in Query->select at handlerton->create_group_by(). After that, MariaDB makes a temporary table with 2 columns. The skipped items are const item, so fixing Spider to skip const items for items at Query->select.
      181f17c3
    • Kentoku SHIBA's avatar
      b4dd996d
    • Vladislav Vaintroub's avatar
      Post-fixes for MDEV-18851 for Windows · e2a932c9
      Vladislav Vaintroub authored
      - On Windows, do not handle lack of SeLockMemory privilege as fatal error.
      Just like on any other platform, there is a fallback to ordinary pages.
      It is better than server that does not start, silently.
      
      - On Windows, remove incorrect  irritating "fallback to conventional pages failed"
      from the warning, when allocating large pages fails.
      e2a932c9
  8. 14 Apr, 2020 1 commit
    • Marko Mäkelä's avatar
      MDEV-22242 B-trees can become extremely skewed · 2f7d91bb
      Marko Mäkelä authored
      The test innodb.innodb_wl6326 that had been disabled in 10.4 due to
      MDEV-21535 is failing on 10.5 due to a different reason: the removal
      of the MLOG_COMP_END_COPY_CREATED operations in MDEV-12353
      commit 276f996a caused PAGE_LAST_INSERT
      to be set to something nonzero by the function page_copy_rec_list_end().
      
      This in turn would cause btr_page_get_split_rec_to_right() to behave
      differently: we would not attempt to split the page at all, but simply
      insert the new record into the new, empty, right leaf page.
      
      Even though the change reduced the sizes of some tables, it is better
      to aim for balanced trees.
      
      page_copy_rec_list_end(), PageBulk::finishPage():
      Preserve PAGE_LAST_INSERT, PAGE_N_DIRECTION, PAGE_DIRECTION.
      
      PageBulk::finish(): Move some common code from PageBulk::finishPage().
      2f7d91bb