1. 21 Mar, 2019 3 commits
  2. 15 Mar, 2019 1 commit
    • Igor Babaev's avatar
      MDEV-18896 Crash in convert_join_subqueries_to_semijoins · 0dd12b4f
      Igor Babaev authored
      If an IN-subquery is used in a table-less select the current code
      should never consider it as candidate for semi-join optimizations.
      Yet the function check_and_do_in_subquery_rewrites() improperly
      checked the property "to be a table-less select". As a result
      such select in IN subquery was used in INSERT .. SELECT then
      the IN subquery by mistake was registered as a semi-join subquery
      and convert_subq_to_sj() was called for it. However the code of
      this function does not assume that the parent select of the subquery
      could be a table-less select.
      0dd12b4f
  3. 11 Mar, 2019 1 commit
    • Sergey Vojtovich's avatar
      MDEV-17595 - ALTER TABLE ADD FOREIGN KEY crash · 149b7547
      Sergey Vojtovich authored
      ALTER TABLE ... ADD FOREIGN KEY may trigger assertion failure when
      it has LOCK=EXCLUSIVE clause or concurrent FLUSH TABLES is being
      executed.
      
      In both cases being altered table is marked as flushed, which forces
      subsequent attempt to open parent table to re-open. Which in turn is
      not allowed while transaction is running.
      
      Rather than opening parent table, just take appropriate MDL lock.
      
      Also removed table_already_fk_prelocked() check: MDL itself has much
      better methods to handle duplicate locks. E.g. the former won't acquire
      MDL_SHARED_NO_WRITE if it already has MDL_SHARED_READ.
      149b7547
  4. 07 Mar, 2019 2 commits
    • Marko Mäkelä's avatar
      Merge 5.5 into 10.0 · 0a0eed80
      Marko Mäkelä authored
      0a0eed80
    • Marko Mäkelä's avatar
      MDEV-18272 InnoDB fails to rollback after exceeding FOREIGN KEY recursion depth · 8024f8c6
      Marko Mäkelä authored
      row_mysql_handle_errors(): Correct the wrong error handling for
      the code DB_FOREIGN_EXCEED_MAX_CASCADE that was introduced in
      
      https://github.com/mysql/mysql-server/commit/c0923d396aef46799883390e9dcf7bbf173e4a03
      
          commit 35f5429e
          Author: Jimmy Yang <jimmy.yang@oracle.com>
          Date:   Wed Oct 6 06:55:34 2010 -0700
      
              Manual port Bug #Bug #54582 "stack overflow when opening many tables
              linked with foreign keys at once" from mysql-5.1-security to
              mysql-5.5-security again.
      
              rb://391 approved by Heikki
      
      No known test case exists for repeating the bug before MariaDB 10.2.
      The scenario should be that DB_FOREIGN_EXCEED_MAX_CASCADE is returned,
      then InnoDB wrongly skips the rollback to the start of the current
      row operation, and finally the SQL layer commits the transaction.
      Normally the SQL layer would roll back either the entire transaction or
      to the start of the statement. In the faulty scenario, InnoDB would
      leave the transaction in an inconsistent state, and the SQL layer could
      commit the transaction.
      8024f8c6
  5. 28 Feb, 2019 4 commits
  6. 07 Feb, 2019 1 commit
  7. 31 Jan, 2019 1 commit
  8. 30 Jan, 2019 2 commits
  9. 29 Jan, 2019 7 commits
  10. 28 Jan, 2019 9 commits
  11. 27 Jan, 2019 2 commits
    • Sergei Golubchik's avatar
      Crude "auto-load-data-local-infile" mode · 2175bfce
      Sergei Golubchik authored
      Disable LOAD DATA LOCAL INFILE suport by default and
      auto-enable it for the duration of one query, if the query
      string starts with the word "load". In all other cases the application
      should enable LOAD DATA LOCAL INFILE support explicitly.
      2175bfce
    • Vicențiu Ciorbaru's avatar
      MDEV-18360 Prevent set_max_open_files from allocating too many files · 21f90371
      Vicențiu Ciorbaru authored
      If the rlimit.rlim_cur value returned by getrlimit is not the
      RLIM_INFINITY magic constant, but a *very* large number, we can allocate
      too many open files. Restrict set_max_open_files to only return at most
      max_file_limit, as passed via its parameter.
      21f90371
  12. 25 Jan, 2019 3 commits
    • Olivier Bertrand's avatar
      Squashed commit of connect/10.0: · e6fcd723
      Olivier Bertrand authored
      commit 6a6a1f37798
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Fri Jan 4 12:31:52 2019 +0100
      
          - Fix a few bug mainly concerning discovery and call from OEM
            (and prepare new table types)
      
            modified:   storage/connect/tabjson.cpp
            modified:   storage/connect/tabjson.h
            modified:   storage/connect/tabxml.cpp
            modified:   storage/connect/tabxml.h
      
          - Fix wrong line estimate
            modified:   storage/connect/mysql-test/connect/r/part_table.result
            modified:   storage/connect/mysql-test/connect/t/part_table.test
      
      commit bd7d2e912d9
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Tue Dec 4 23:35:09 2018 +0100
      
          Fix wrong version number
      
      commit 4933680e7ab
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Sun Dec 2 00:25:05 2018 +0100
      
          - Make PlugSubAlloc to be exportable
            Suppress unused parameter from PlugSubSet
            modified:   storage/connect/global.h
            modified:   storage/connect/plugutil.cpp
            modified:   storage/connect/jsonudf.cpp
            modified:   storage/connect/tabjson.cpp
            modified:   storage/connect/user_connect.cc
      
          - Fix a bug making column catalog XML tables fail
            modified:   storage/connect/tabxml.cpp
      
          - Comment out wrong message
            modified:   storage/connect/ha_connect.cc
      
          - Update error message when sorting an ODBC table fails
            modified:   storage/connect/tabodbc.cpp
      
          - Add error message when gettting an address
            from an OEM fails.
            modified:   storage/connect/reldef.cpp
      
          - Make some modifications useful for OEM module writting
            Export discovery functions for CSV, JDBC and XML
            Remove unuseful include from tabjson.h
            Move TDBXML::data_charset function from header file to source
            modified:   storage/connect/tabfmt.h
            modified:   storage/connect/tabjson.h
            modified:   storage/connect/tabxml.cpp
            modified:   storage/connect/tabxml.h
      
          - Update test result
            modified:   storage/connect/mysql-test/connect/r/jdbc_oracle.result
      e6fcd723
    • Sergei Golubchik's avatar
      cleanup: fill_alter_inplace_info · 38ad46e0
      Sergei Golubchik authored
      remove attempts to track "candidate keys", use what was already
      decided in create_table_impl().
      38ad46e0
    • Sergei Golubchik's avatar
      compiler warning · 013186eb
      Sergei Golubchik authored
      013186eb
  13. 24 Jan, 2019 4 commits