1. 16 May, 2020 2 commits
  2. 15 May, 2020 14 commits
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 3d0bb2b7
      Marko Mäkelä authored
      3d0bb2b7
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 6a6bcc53
      Marko Mäkelä authored
      6a6bcc53
    • Marko Mäkelä's avatar
      MDEV-22456 Dropping the adaptive hash index may cause DDL to lock up InnoDB · ad6171b9
      Marko Mäkelä authored
      If the InnoDB buffer pool contains many pages for a table or index
      that is being dropped or rebuilt, and if many of such pages are
      pointed to by the adaptive hash index, dropping the adaptive hash index
      may consume a lot of time.
      
      The time-consuming operation of dropping the adaptive hash index entries
      is being executed while the InnoDB data dictionary cache dict_sys is
      exclusively locked.
      
      It is not actually necessary to drop all adaptive hash index entries
      at the time a table or index is being dropped or rebuilt. We can let
      the LRU replacement policy of the buffer pool take care of this gradually.
      For this to work, we must detach the dict_table_t and dict_index_t
      objects from the main dict_sys cache, and once the last
      adaptive hash index entry for the detached table is removed
      (when the garbage page is evicted from the buffer pool) we can free
      the dict_table_t and dict_index_t object.
      
      Related to this, in MDEV-16283, we made ALTER TABLE...DISCARD TABLESPACE
      skip both the buffer pool eviction and the drop of the adaptive hash index.
      We shifted the burden to ALTER TABLE...IMPORT TABLESPACE or DROP TABLE.
      We can remove the eviction from DROP TABLE. We must retain the eviction
      in the ALTER TABLE...IMPORT TABLESPACE code path, so that in case the
      discarded table is being re-imported with the same tablespace identifier,
      the fresh data from the imported tablespace will replace any stale pages
      in the buffer pool.
      
      rpl.rpl_failed_drop_tbl_binlog: Remove the test. DROP TABLE can
      no longer be interrupted inside InnoDB.
      
      fseg_free_page(), fseg_free_step(), fseg_free_step_not_header(),
      fseg_free_page_low(), fseg_free_extent(): Remove the parameter
      that specifies whether the adaptive hash index should be dropped.
      
      btr_search_lazy_free(): Lazily free an index when the last
      reference to it is dropped from the adaptive hash index.
      
      buf_pool_clear_hash_index(): Declare static, and move to the
      same compilation unit with the bulk of the adaptive hash index
      code.
      
      dict_index_t::clone(), dict_index_t::clone_if_needed():
      Clone an index that is being rebuilt while adaptive hash index
      entries exist. The original index will be inserted into
      dict_table_t::freed_indexes and dict_index_t::set_freed()
      will be called.
      
      dict_index_t::set_freed(), dict_index_t::freed(): Note that
      or check whether the index has been freed. We will use the
      impossible page number 1 to denote this condition.
      
      dict_index_t::n_ahi_pages(): Replaces btr_search_info_get_ref_count().
      
      dict_index_t::detach_columns(): Move the assignment n_fields=0
      to ha_innobase_inplace_ctx::clear_added_indexes().
      We must have access to the columns when freeing the
      adaptive hash index. Note: dict_table_t::v_cols[] will remain
      valid. If virtual columns are dropped or added, the table
      definition will be reloaded in ha_innobase::commit_inplace_alter_table().
      
      buf_page_mtr_lock(): Drop a stale adaptive hash index if needed.
      
      We will also reduce the number of btr_get_search_latch() calls
      and enclose some more code inside #ifdef BTR_CUR_HASH_ADAPT
      in order to benefit cmake -DWITH_INNODB_AHI=OFF.
      ad6171b9
    • Marko Mäkelä's avatar
      Amend af784385: Avoid vtable overhead · ff66d65a
      Marko Mäkelä authored
      When neither MSAN nor Valgrind are enabled, declare
      Field::mark_unused_memory_as_defined() as an empty inline function,
      instead of declaring it as a virtual function.
      ff66d65a
    • Eugene Kosov's avatar
      span cleanup · 1cac6d48
      Eugene Kosov authored
      1cac6d48
    • Aleksey Midenkov's avatar
      MDEV-22563 Segfault on duplicate free of Item_func_in::array · a4996f95
      Aleksey Midenkov authored
      Same array instance in two Item_func_in instances. First Item_func_in
      instance is freed on table close. Second one is freed on
      cleanup_after_query().
      
      get_copy() depends on copy ctor for copying an item and hence does
      shallow copy for default copy ctor. Use build_clone() for deep copy of
      Item_func_in.
      a4996f95
    • Monty's avatar
      3eadb135
    • Monty's avatar
      Use history.h include file if readline is used · a7c4e85d
      Monty authored
      This allows us to remove our own declarations of functions and structures
      that are declared in the history.h file.
      a7c4e85d
    • Monty's avatar
      Fixed access to not initalized memory · 72789e4b
      Monty authored
      Most of the volations came from:
      sel_arg_range_seq_next(void*, st_key_multi_range*) (opt_range_mrr.cc:342)
      72789e4b
    • Monty's avatar
      Fix for using uninitialized memory · af784385
      Monty authored
      MDEV-22073 MSAN use-of-uninitialized-value in
      collect_statistics_for_table()
      
      Other things:
      innodb.analyze_table was changed to mainly test statistic
      collection. Was discussed with Marko.
      af784385
    • Varun Gupta's avatar
      MDEV-18100: User defined aggregate functions not working correctly when the schema is changed · d49233ca
      Varun Gupta authored
      The issue here was that when the schema was changed the value for the THD::server_status
      is ored with SERVER_SESSION_STATE_CHANGED.
      For custom aggregate functions, currently we check if the server_status is equal to
      SERVER_STATUS_LAST_ROW_SENT then we should terminate the execution of the custom
      aggregate function as there are no more rows to fetch.
      So the check should be that if the server status has the bit set for
      SERVER_STATUS_LAST_ROW_SENT then we should terminate the execution of the
      custom aggregate function.
      d49233ca
    • Monty's avatar
      Fixed bugs found by valgrind · 277aa85c
      Monty authored
      Other things:
      - Removed innodb_encryption_tables.test from valgrind as it
        takes a REALLY long time
      277aa85c
    • Jan Lindström's avatar
      MDEV-22494 : Galera assertion lock_sys.mutex.is_owned() at lock_trx_handle_wait_low · 523d67a2
      Jan Lindström authored
      Problem was that trx->lock.was_chosen_as_wsrep_victim variable was
      not set back to false after it was set true.
      
      wsrep_thd_bf_abort
      	Add assertions for correct mutex status and take necessary
      	mutexes before calling thd->awake_no_mutex().
      
      innobase_rollback_trx()
      	Reset trx->lock.was_chosen_as_wsrep_victim
      
      wsrep_abort_slave_trx()
      	Removed unused function.
      
      wsrep_innobase_kill_one_trx()
      	Added function comment, removed unnecessary parameters
      	and added debug assertions to enforce correct usage. Added
      	more debug output to help out on error analysis.
      
      wsrep_abort_transaction()
      	Added debug assertions and removed unused variables.
      
      trx0trx.h
      	Removed assert_trx_is_free macro and replaced it with
      	assert_freed() member function.
      
      trx_create()
      	Use above assert_free() and initialize wsrep variables.
      
      trx_free()
      	Use assert_free()
      
      trx_t::commit_in_memory()
      	Reset lock.was_chosen_as_wsrep_victim
      
      trx_rollback_for_mysql()
      	Reset trx->lock.was_chosen_as_wsrep_victim
      
      Add test case galera_bf_kill
      523d67a2
    • Alexander Barkov's avatar
      MDEV-22560 Crash on a table value constructor with an SP variable · 1408e26d
      Alexander Barkov authored
      fix_fields_for_tvc() could call fix_fields() for Items that have
      already been fixed before. Changing fix_fields() to fix_fields_if_needed().
      1408e26d
  3. 14 May, 2020 14 commits
  4. 13 May, 2020 4 commits
  5. 12 May, 2020 4 commits
    • Alexander Barkov's avatar
      MDEV-20261 NULL passed to String::eq, SEGV, server crash, regression in 10.4 · 9f209681
      Alexander Barkov authored
      Type_handler_xxx::Item_const_eq() can handle only non-NULL values.
      The code in Item_basic_value::eq() did not take this into account.
      
      Adding a test to detect three different combinations:
      - Both values are NULLs, return true.
      - Only one value is NULL, return false.
      - Both values are not NULL, call Type_handler::Item_const_eq()
        to check equality.
      9f209681
    • Vlad Lesin's avatar
      MDEV-22398: mariabackup.innodb_xa_rollback fails on repeat · 218d20ff
      Vlad Lesin authored
      Flush LSN to system tablespace on innodb shutdown if XA is rolled back by
      mariabackup.
      218d20ff
    • Marko Mäkelä's avatar
      Cleanup: Remove InnoDB wrappers of thd_charset(), thd_query_safe() · 0e6a5786
      Marko Mäkelä authored
      innobase_get_charset(), innobase_get_stmt_safe(): Remove.
      It is more efficient and readable to invoke thd_charset()
      and thd_query_safe() directly, without a non-inlined wrapper function.
      0e6a5786
    • Marko Mäkelä's avatar
      MDEV-22529 thd_query_safe() isn’t, causing InnoDB to hang · a2560b00
      Marko Mäkelä authored
      The function thd_query_safe() is used in the implementation of the
      following INFORMATION_SCHEMA views:
      
          information_schema.innodb_trx
          information_schema.innodb_locks
          information_schema.innodb_lock_waits
          information_schema.rocksdb_trx
      
      The implementation of the InnoDB views is in trx_i_s_common_fill_table().
      This function invokes trx_i_s_possibly_fetch_data_into_cache(),
      which will acquire lock_sys->mutex and trx_sys->mutex in order to
      protect the set of active transactions and explicit locks.
      While holding those mutexes, it will traverse the collection of
      InnoDB transactions. For each transaction, thd_query_safe() will be
      invoked.
      
      When called via trx_i_s_common_fill_table(), thd_query_safe()
      is acquiring THD::LOCK_thd_data while holding the InnoDB locks.
      This will cause a deadlock with THD::awake() (such as executing
      KILL QUERY), because THD::awake() could invoke lock_trx_handle_wait(),
      which attempts to acquire lock_sys->mutex while already holding
      THD::lock_thd_data.
      
      thd_query_safe(): Invoke mysql_mutex_trylock() instead of
      mysql_mutex_lock(). Return the empty string if the mutex
      cannot be acquired without waiting.
      a2560b00
  6. 11 May, 2020 2 commits