1. 23 Apr, 2020 1 commit
  2. 22 Apr, 2020 4 commits
  3. 21 Apr, 2020 1 commit
    • Vlad Lesin's avatar
      MDEV-19347: Mariabackup does not honor ignore_db_dirs from server · 0efe1971
      Vlad Lesin authored
      config.
      
      The solution is to read the system variable value on startup and to fill
      databases_exclude_hash.
      
      xb_load_list_string() became non-static and was reformatted. The system
      variable value is read and processed in get_mysql_vars(), which was also
      reformatted.
      0efe1971
  4. 18 Apr, 2020 6 commits
  5. 17 Apr, 2020 2 commits
    • Marko Mäkelä's avatar
      Fix GCC 10 -Woverflow · ad4b7056
      Marko Mäkelä authored
      maria_page_crc_check_index(): Do not attempt to convert
      HA_ERR_WRONG_CRC (176) to my_bool (char).
      On platforms where char is signed, the 176 will be converted to -80.
      
      It turns out that the callers only care whether the result is zero.
      Let us return 1 in this case, like we do in all other error cases.
      ad4b7056
    • Marko Mäkelä's avatar
      MDEV-22271 Excessive stack memory usage due to WSREP_LOG · 7198c6ab
      Marko Mäkelä authored
      Several tests that involve stored procedures fail on 10.4 kvm-asan
      (clang 10) due to stack overrun. The main contributor to this stack
      overrun is mysql_execute_command(), which is invoked recursively
      during stored procedure execution.
      
      Rebuilding with cmake -DWITH_WSREP=OFF shrunk the stack frame size
      of mysql_execute_command() by more than 10 kilobytes in a
      WITH_ASAN=ON, CMAKE_BUILD_TYPE=Debug build. The culprit
      turned out to be the macro WSREP_LOG, which is allocating a
      separate 1KiB buffer for every occurrence.
      
      We replace the macro with a function, so that the stack will be
      allocated only when the function is actually invoked. In this way,
      no stack space will be wasted by default (when WSREP and Galera
      are disabled).
      
      This backports commit b6c5657e
      from MariaDB 10.3.1.
      
      Without ASAN, compilers can be smarter and optimize the stack usage.
      The original commit message mentions that 1KiB was saved on GCC 5.4,
      and 4KiB on Mac OS X Lion, which presumably uses a clang-based compiler.
      7198c6ab
  6. 16 Apr, 2020 2 commits
  7. 15 Apr, 2020 3 commits
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 9e43ca8e
      Marko Mäkelä authored
      9e43ca8e
    • Marko Mäkelä's avatar
      MDEV-21549 IMPORT TABLESPACE fails to adjust all tablespace ID in root pages · f8166a05
      Marko Mäkelä authored
      After MDEV-12353, the consistency check that I originally added for
      commit 1b9fe0bb
      (InnoDB Plugin for MySQL 5.1) started randomly failing.
      
      It turns out that the IMPORT TABLESPACE code was always incorrect:
      it did not update the (redundantly stored) tablespace ID
      in index tree root pages. It only does that for page headers
      and BLOB pointers.
      
      PageConverter::update_index_page(): Update the tablespace ID
      in the BTR_SEG_TOP and BTR_SEG_LEAF of index root pages.
      
      This is a backport of commit b8b3edff.
      f8166a05
    • Marko Mäkelä's avatar
      mbstream: Remove duplicate definition of datasink_buffer · a215e213
      Marko Mäkelä authored
      For some reason, when mbstream is compiled with GCC 10,
      ld will fail to link it due to a multiple definition of
      datasink_buffer. The code appears to have been like that
      since the very beginning.
      
      Let us remove the duplicate dummy definition.
      a215e213
  8. 14 Apr, 2020 3 commits
  9. 13 Apr, 2020 4 commits
  10. 12 Apr, 2020 1 commit
  11. 10 Apr, 2020 1 commit
    • Sergey Vojtovich's avatar
      MDEV-21599 - plugins.server_audit fails sporadically in buildbot · 06219c2a
      Sergey Vojtovich authored
      Fixed a couple of race conditions in the test case to ensure stable order
      of events. Also removed all sleeps. Test execution time is down from 18s
      to 0.15s.
      
      On disconnect audit event is triggered after control is returned to
      mysqltest client. Which means mysqltest may issue more commands
      concurrently before disconnect is actually logged.
      
      Similar problem happens with regular query execution: an event is
      triggered after control is returner to the client. Which may end
      up with unstable order of events in different connections.
      
      Delayed insert rows are enqueued separately and can either be combined
      into single event or go as separate events. Reduced number of inserted
      rows to 1 to stabilize result.
      
      Also backported 2b3f6ab4 from 10.5.
      06219c2a
  12. 08 Apr, 2020 3 commits
    • Varun Gupta's avatar
      MDEV-22191: Range access is not picked when index_merge_sort_union is turned off · c1394ab6
      Varun Gupta authored
      When index_merge_sort_union is turned off only ror scans were considered for range
      scans, which is wrong.
      To fix the problem ensure both ror scans and non ror scans are considered for range
      access
      c1394ab6
    • Julius Goryavsky's avatar
      MDEV-20676: systemd script not working · c8e0c524
      Julius Goryavsky authored
      When trying to start mariadb via systemctl, WSREP failed
      to start mysqld for wsrep recovery, because the binary
      "galera-recovery" is neither searching the mysqld in the
      same folder as the binary itself nor in the path variable
      but instead expects the root to be /usr/local/mysql.
      
      This fix changes the current directory to the desired
      directory before starting mysqld.
      c8e0c524
    • Sergei Golubchik's avatar
      fix rocksdb compression detection · d565895b
      Sergei Golubchik authored
      cmake module name is BZip2, not BZIP2.
      variable names are WITH_ROCKSDB_zstd and WITH_ROCKSDB_snappy.
      it's SNAPPY_FOUND in older cmake (and both in newer cmake).
      also, make it verbose.
      d565895b
  13. 07 Apr, 2020 2 commits
    • Vlad Lesin's avatar
      MDEV-21168: Active XA transactions stop slave from working after backup · 5836191c
      Vlad Lesin authored
      was restored.
      
      Optionally rollback prepared XA's on "mariabackup --prepare".
      
      The fix MUST NOT be ported on 10.5+, as MDEV-742 fix solves the issue for
      slaves.
      5836191c
    • Rasmus Johansson's avatar
      MDEV-22176 Add JUnit support to MTR to generate XML test result · 5720db2b
      Rasmus Johansson authored
      A new parameter has been added called xml-report, with which the
      filename of the XML file is given to which the XML result is
      written. There is also xml-package for adding a package value in
      the XML output. Example usage:
      ./mysql-test-run.pl main.events_bugs innodb.count_distinct
      main.explain_json innodb.file_format_defaults json.json_no_table
      --suite=main,innodb,json --force --xml-report=build123456789.xml
      --xml-package=simpletestrun
      5720db2b
  14. 05 Apr, 2020 1 commit
  15. 03 Apr, 2020 2 commits
    • Daniel Black's avatar
      Correct FreeBSD cpuset_t type · cd88a606
      Daniel Black authored
      cd88a606
    • Hannu Hartikainen's avatar
      my.cnf: mention that config files must be *.cnf · 64b70b09
      Hannu Hartikainen authored
      It took me a long time to debug why my configs were not being loaded,
      and judging from online discussions I'm not the only one. Make the
      comment in the default my.cnf a bit more helpful.
      
      The !includedir directive is implemented in mysys/my_default.c.
      
      - f_extensions[] is a list of file extensions. It includes .ini and .cnf
        on Windows, and only .cnf on all other platforms.
      - search_default_file_with_ext() contains the !includedir directive. It
        filters files in the directory to those matching f_extensions[].
      
      This file should only be applicable on Unix-like platforms, so only
      files with the .cnf extension are read.
      
      Closes #1485
      64b70b09
  16. 01 Apr, 2020 4 commits