1. 14 Oct, 2021 1 commit
    • Alexander Barkov's avatar
      MDEV-23408 Wrong result upon query from I_S and further Assertion `!alias_arg... · a2a42f4e
      Alexander Barkov authored
      MDEV-23408 Wrong result upon query from I_S and further Assertion `!alias_arg || strlen(alias_arg->str) == alias_arg->length' failed with certain connection charset
      
      There were two independent problems which lead to the crash
      and to the non-relevant records returned in I_S queries:
      
      - The code in the I_S implementation was not secure
        about values with 0x00 bytes.
        It's fixed by using check_db_name() and check_table_name()
        inside make_table_name_list(), and by adding the test for
        0x00 inside check_table_name().
      
      - The code in Item_string::print() did not convert
        strings without introducers when restoring
        the CREATE VIEW statement from an Item tree.
        This made wrong literals inside the "query" line in the view FRM file
        in cases when the VIEW parse time
        character_set_client!=character_set_connection.
        That's fixed by adding a proper conversion.
      
        This change also fixed a similar problem in SHOW PROCEDURE CODE -
        the literals were displayed in wrong character set in SP instructions
        in cases when the SP parse time
        character_set_client!=character_set_connection.
      a2a42f4e
  2. 13 Oct, 2021 3 commits
  3. 12 Oct, 2021 1 commit
  4. 11 Oct, 2021 7 commits
  5. 08 Oct, 2021 1 commit
  6. 07 Oct, 2021 1 commit
  7. 06 Oct, 2021 1 commit
    • Brandon Nesterenko's avatar
      MDEV-25444: mysql --binary-mode is not able to replay some mysqlbinlog outputs · 1ce35c32
      Brandon Nesterenko authored
      Note: This patch backports commits 10cd2818 and 1755ea4b from 10.3.
      
      10cd2818:
      Problem:- Some binary data is inserted into the table using
      Jconnector. When binlog dump of the data is applied using mysql
      client it gives syntax error.
      
      Reason:-
      After investigating it turns out to be a issue of mysql client not
      able to properly handle  \\0 <0 in binary>. In all binary files
      where mysql client fails to insert
      these 2 bytes are common (0x5c00)
      
      Solution:-
      I have changed mysql.cc to include for the possibility that binary
      string can have \\0 in it
      
      1755ea4b:
      Changes on top of Sachin’s patch. Specifically:
       1) Refined the parsing break condition to only change the parser’s
      behavior for parsing strings in binary mode (behavior of \0 outside
      of strings is unchanged).
       2) Prefixed binary_zero_insert.test with ‘mysql_’ to more clearly
      associate the  purpose of the test.
       3) As the input of the test contains binary zeros (0x5c00),
      different text editors can visualize this sequence differently, and
      Github would not display it at all. Therefore, the input itself was
      consolidated into the test and created out of hex sequences to make
      it easier to understand what is happening.
       4) Extended test to validate that the rows which correspond to the
      INSERTS with 0x5c00 have the correct binary zero data.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      1ce35c32
  8. 03 Oct, 2021 1 commit
  9. 30 Sep, 2021 1 commit
    • sjaakola's avatar
      MDEV-24978 crash with transaction on table with no PK and long fulltext column · d5a15f04
      sjaakola authored
      If a table has no unique indexes, write set key information will be collected on all columns in the table.
      The write set key information has space only for max 3500 bytes for individual column, and if a varchar colummn of such non-primary key table is longer than
       this limit, currently a crash follows.
      The fix in this commit, is to truncate key values extracted from such long varhar columns to max 3500 bytes.
      This may potentially lead to false positive certification failures for transactions, which operate on separate cluster nodes, and update/insert/delete table rows, which differ only in the part of such long columns after 3500 bytes border.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      d5a15f04
  10. 29 Sep, 2021 1 commit
  11. 27 Sep, 2021 2 commits
    • Oleksandr Byelkin's avatar
      MDEV-24454 Crash at change_item_tree · 3690c549
      Oleksandr Byelkin authored
      Use in_sum_func (and so nest_level) only in LEX to which SELECT lex belong to
      
      Reduce usage of current_select (because it does not always point on the correct
       SELECT_LEX, for example with prepare.
      
      Change context for all classes inherited from Item_ident (was only for Item_field) in case of pushing down it to HAVING.
      
      Now name resolution context have to have SELECT_LEX reference if the context is present.
      
      Fixed feedback plugin stack usage.
      3690c549
    • Jan Lindström's avatar
  12. 24 Sep, 2021 7 commits
    • Marko Mäkelä's avatar
      Revert MDEV-25114 · f59f5c4a
      Marko Mäkelä authored
      Revert 88a4be75 and
      9d97f92f, which had been
      prematurely pushed by accident.
      f59f5c4a
    • Marko Mäkelä's avatar
      Update libmariadb · cfe1a258
      Marko Mäkelä authored
      cfe1a258
    • Julius Goryavsky's avatar
      MDEV-26360: Using hostnames breaks certificate validation · 77b11965
      Julius Goryavsky authored
      Fixed flaws with overly strict or, conversely,
      overly soft verification of certificates in some
      scenarios:
      
      1. Removed the check that the 'commonname' (CN) in the
         certificate matches the 'localhost' value on the side
         of the joiner node, which was performed earlier, even
         if the address was received by the script only as an
         argument (out of the exchange via the Galera protocol) -
         since for the joining node this argument always contains
         its own local address, not the address of the remote host,
         so it is always treated as 'localhost', which is not
         necessarily true (outside of mtr testing);
      2. Removed checking the domain name or IP-address of the
         peer node in the encrypt=2 mode;
      3. Fixed checking of compliance of certificates when
         rsync SST is used;
      4. Added the ability to specify CA not only as a file,
         but also as a path to the directory where the certificates
         are stored. To do this, the user just needs to specify the
         path to this directory as the value ssl-ca or tca parameter,
         ending with the '/' character.
      77b11965
    • Alexey Bychko's avatar
      MDEV-26612 Two different ways to start MariaDB service can cause data corruption · 467011bc
      Alexey Bychko authored
      RedHat systems have both files for lsb and init functions.
      Old code was written as if/else, so second file (RedHat-specific) was not processed.
      So, systemd redirect didn't work, because its logic is described in
      RedHat-specific functions file
      467011bc
    • Jan Lindström's avatar
      Revert "MDEV-24978 : SIGABRT in __libc_message" · 47ba5523
      Jan Lindström authored
      This reverts commit 30dea459.
      47ba5523
    • sjaakola's avatar
      MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL) · 88a4be75
      sjaakola authored
      This patch is the plan D variant for fixing potetial mutex locking
      order exercised by BF aborting and KILL command execution.
      
      In this approach, KILL command is replicated as TOI operation.
      This guarantees total isolation for the KILL command execution
      in the first node: there is no concurrent replication applying
      and no concurrent DDL executing. Therefore there is no risk of
      BF aborting to happen in parallel with KILL command execution
      either. Potential mutex deadlocks between the different mutex
      access paths with KILL command execution and BF aborting cannot
      therefore happen.
      
      TOI replication is used, in this approach,  purely as means
      to provide isolated KILL command execution in the first node.
      KILL command should not (and must not) be applied in secondary
      nodes. In this patch, we make this sure by skipping KILL
      execution in secondary nodes, in applying phase, where we
      bail out if applier thread is trying to execute KILL command.
      This is effective, but skipping the applying of KILL command
      could happen much earlier as well.
      
      This patch also fixes mutex locking order and unprotected
      THD member accesses on bf aborting case. We try to hold
      THD::LOCK_thd_data during bf aborting. Only case where it
      is not possible is at wsrep_abort_transaction before
      call wsrep_innobase_kill_one_trx where we take InnoDB
      mutexes first and then THD::LOCK_thd_data.
      
      This will also fix possible race condition during
      close_connection and while wsrep is disconnecting
      connections.
      
      Added wsrep_bf_kill_debug test case
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      88a4be75
    • Jan Lindström's avatar
      Revert "MDEV-23328 Server hang due to Galera lock conflict resolution" and · 9d97f92f
      Jan Lindström authored
      Revert "MDEV-24873 galera.galera_as_slave_ctas MTR failed:..."
      
      This reverts commit 29bbcac0 and
      later commit 5ecaf52d.
      9d97f92f
  13. 22 Sep, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-26450: Corruption due to innodb_undo_log_truncate · 1cb218c3
      Marko Mäkelä authored
      At least since commit 055a3334
      (MDEV-13564) the undo log truncation in InnoDB did not work correctly.
      
      The main issue is that during the execution of
      trx_purge_truncate_history() some pages of the newly truncated
      undo tablespace could be discarded.
      
      fsp_try_extend_data_file(): Apply the peculiar rounding of
      fil_space_t::size_in_header only to the system tablespace,
      whose size can be expressed in megabytes in a configuration parameter.
      Other files may freely grow by a number of pages.
      
      fseg_alloc_free_page_low(): Do allow the extension of undo tablespaces,
      and mention the file name in the error message.
      
      mtr_t::commit_shrink(): Implement crash-safe shrinking of a tablespace
      file. First, durably write the log, then shrink the file, and finally
      release the page latches of the rebuilt tablespace. Refactored from
      trx_purge_truncate_history().
      
      log_write_and_flush_prepare(), log_write_and_flush(): New functions
      to durably write log during mtr_t::commit_shrink().
      1cb218c3
    • Marko Mäkelä's avatar
      21d19ed4
    • Daniel Ye's avatar
      MDEV-26545 Spider does not correctly handle UDF and stored function in where conds · ac1c6738
      Daniel Ye authored
      - Handle stored function conditions correctly, with the same logic as with UDFs.
      - When running queries on Spider SE, by default, we do not push down WHERE conditions containing usage of UDFs/stored functions to remote data nodes, unless the user demands (by setting spider_use_pushdown_udf).
      ac1c6738
  14. 20 Sep, 2021 1 commit
    • Julius Goryavsky's avatar
      MDEV-26441: Linux-dependent construct in SST scripts · f4d6d017
      Julius Goryavsky authored
      SST scripts currently use Linux-specific construction
      to create a temporary directory if the path prefix for
      that directory is specified by the user. This does not
      work with FreeBSD. This commit adds support for FreeBSD.
      
      No separate test required.
      f4d6d017
  15. 18 Sep, 2021 1 commit
    • Marko Mäkelä's avatar
      MDEV-26636: InnoDB defragmentation statistics cause races on TEMPORARY TABLE · 3209bc66
      Marko Mäkelä authored
      btr_defragment_save_defrag_stats_if_needed(): Do not save
      defragmentation statistics for temporary tables.
      They are exempt of defragmentation anyway
      (ha_innobase::optimize() never invokes defragmentation for them),
      and the user-visible names are not available inside InnoDB.
      
      Furthermore, InnoDB assumes that temporary tables are never accessed
      by other threads than the one that handles the session with which
      the temporary table is associated with.
      
      Furthermore, we simplify the test innodb.innodb_defrag_stats
      and include a test case that demonstrates that defragmentation
      statistics are no longer being saved for temporary tables.
      3209bc66
  16. 17 Sep, 2021 1 commit
  17. 16 Sep, 2021 2 commits
  18. 15 Sep, 2021 2 commits
  19. 13 Sep, 2021 1 commit
  20. 11 Sep, 2021 2 commits