1. 21 Sep, 2018 8 commits
  2. 20 Sep, 2018 3 commits
  3. 18 Sep, 2018 1 commit
    • Sergey Vojtovich's avatar
      MDEV-14410 - Assertion `table->pos_in_locked_tables == __null || · 327b2717
      Sergey Vojtovich authored
                   table->pos_in_locked_tables->table == table'
                   failed in mark_used_tables_as_free_for_reuse
      
      Assertion failure can be triggered by some DDL executed under LOCK TABLES
      that holds lock for DDL target table multiple times (either explicitly or
      implcitly).
      
      When closing all table instances for given table (e.g. when preparing for
      table removal during CREATE OR REPLACE), only one instance was removed
      from m_locked_tables list.
      
      Later we attempt to re-insert one of the instances in mysql_create_table()/
      add_back_last_deleted_lock(), which wasn't actually removed. This leads
      to m_locks_tables corruption, specifically loss of all following elements.
      
      Then UNLOCK TABLE won't reset some table instances properly (specifically
      pos_in_locked_tables), since they're not present in m_locked_tables.
      
      Eventually such table instance gets released to table cache and then
      re-used by subsequent statement, which triggers this assertion failure.
      327b2717
  4. 10 Sep, 2018 2 commits
  5. 06 Sep, 2018 2 commits
  6. 05 Sep, 2018 2 commits
  7. 04 Sep, 2018 11 commits
  8. 03 Sep, 2018 3 commits
  9. 31 Aug, 2018 1 commit
  10. 30 Aug, 2018 1 commit
    • Monty's avatar
      MDEV-16682 Assertion `(buff[7] & 7) == HEAD_PAGE' failed · 42f09ada
      Monty authored
      Problem was that SQL level tried to read a record with rnd_pos()
      that was already deleted by the same statement.
      In the case where the page for the record had been deleted, this
      caused an assert.
      Fixed by extending the assert to also handle empty pages and
      return HA_ERR_RECORD_DELETED for reads to deleted pages.
      42f09ada
  11. 29 Aug, 2018 1 commit
  12. 28 Aug, 2018 1 commit
  13. 27 Aug, 2018 2 commits
  14. 25 Aug, 2018 2 commits
    • Vicențiu Ciorbaru's avatar
      Fix clang warning of mismatched new[] and delete[] · 51fb163b
      Vicențiu Ciorbaru authored
      Warning:
      'delete' applied to a pointer that was allocated with 'new[]';
      did you mean 'delete[]'?
      51fb163b
    • Daniel Black's avatar
      connect engine: GetStringUTFChars takes pointer arg · 6b22cc4a
      Daniel Black authored
      Avoids compile errors of the form:
      
      /storage/connect/jdbconn.cpp:1473:41: error: cannot initialize a parameter of type 'jboolean *' (aka 'unsigned char *') with an rvalue of type 'jboolean' (aka 'unsigned char')
         name = env->GetStringUTFChars(label, (jboolean)false);
                                              ^~~~~~~~~~~~~~~
      /usr/lib/jvm/java-8-oracle/include/jni.h:1616:58: note: passing argument to parameter 'isCopy' here
          const char* GetStringUTFChars(jstring str, jboolean *isCopy) {
      6b22cc4a