- 15 Feb, 2016 2 commits
-
-
Sergei Golubchik authored
1. check that unused inline functions are removed 2. only allow compilation if they are or if the check if overridden 3. with CMAKE_GENERATOR=Makefiles, use all flags when testing (e.g. both CMAKE_C_FLAGS and CMAKE_C_FLAGS_DEBUG if CMAKE_BUILD_TYPE=Debug). This is because - on Solaris with the SunPro compiler, default CMAKE_C_FLAGS_xxx values contain -xO2 (for Release and RelWithDebInfo) and -g (for RelWithDebInfo and Debug) - proper inlining only works at -xO4 without -g - so if CMAKE_C_FLAGS has -xO4, inlining would work in configure.cmake (before this fix) and fail during actual compilation also remove the outdated check for inline from myu_global.h
-
Sergei Golubchik authored
1. unused static inline functions are only removed at -xO4, otherwise test binaries will depend on various mysys symbols that they don't use. Link test with libmysys. 2. Sphinx - don't instantiate (explicitly) templates before they're defined. Or, rather, don't instantiate them explicitly at all. 3. GIS - don't use anonymous unions and structs.
-
- 14 Feb, 2016 2 commits
-
-
Vicențiu Ciorbaru authored
In case of missing includedir file, we would attempt to free a NULL pointer. Make sure to guard against that.
-
Vicențiu Ciorbaru authored
In the case of error during my_load_defaults, we would not free the args array.
-
- 12 Feb, 2016 1 commit
-
-
Alexey Botchkov authored
-
- 10 Feb, 2016 2 commits
-
-
Alexander Barkov authored
-
Vicențiu Ciorbaru authored
Fix test failure when using maria small-block size. We need to query the max_key_length and max_key_parts based on the the tmp table engine.
-
- 09 Feb, 2016 10 commits
-
-
Oleksandr Byelkin authored
MDEV-7765: Crash (Assertion `!table || (!table->write_set || bitmap_is_set(table->write_set, field_index) || bitmap_is_set(table->vcol_set, field_index))' fails) on using function over not created table Problem was that created table was not marked as used (not set query_id) and so opening tables for stored function pick it up (as opened place holder for it) and used changing TABLE internals.
-
Vicențiu Ciorbaru authored
The select mentioned in the bug attempted to create a temporary table using the maria storage engine. The table needs to have primary keys such that duplicates can be removed. Unfortunately this use case has a longer than allowed key and the tmp table got created without a temporary key. We must not allow materialization for the subquery if the total key length and key parts is greater than what the storage engine supports.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
5.5.47-37.7
-
Sergei Golubchik authored
test case for ALTER TABLE view CHECK PARTITION
-
Sergei Golubchik authored
test case
-
Sergei Golubchik authored
-
Sergei Golubchik authored
Correct fix. Generate the query in the client charset, not in the system one.
-
Sergei Golubchik authored
reverted about half of commits as either not applicable or outright wrong
-
Alexey Botchkov authored
The http-proxy option to the FEEDBACK plugin backported.
-
- 08 Feb, 2016 3 commits
-
-
Sergei Petrunia authored
When one evaluates row-based comparison like (X, Y) = (A,B), one should first call bring_value() for the Item that returns row value. If you don't do that and just attempt to read values of X and Y, you get stale values. Semi-join/Materialization can take a row-based comparison apart and make ref access from it. In that case, we need to call bring_value() to get the index lookup components.
-
Sergei Golubchik authored
-
Sergei Petrunia authored
Consider a query with subquery in form t.key=(select ...). Suppose, the parent query uses this equality for ref access. It will attempt to evaluate the subquery in get_best_combination(), right before the join->join_tab[...] array is filled. The problem was that subquery optimization will attempt to look at parent's join->join_tab to check how many times subquery will be executed (and crash). Fixed by not doing that when the subquery is constant (non-constant subqueries are only be evaluated during join execution, so they are not affected)
-
- 06 Feb, 2016 8 commits
-
-
Sergei Golubchik authored
cherry-pick f1daf9ce from 10.0 branch ------------------------------------- Fix build failures caused by new C runtime library - isnan, snprintf, struct timespec are now defined, attempt to redefine them leads - P_tmpdir, tzname are no more defined - lfind() and lsearch() in lf_hash.c had to be renamed, declaration conflicts with some C runtime functions with the same name declared in a header included by stdlib.h Also fix couple of annoying warnings : - remove #define NOMINMAX from config.h to avoid "redefined" compiler warnings(NOMINMAX is already in compile flags) - disable incremental linker in Debug as well (feature not used much and compiler crashes often) Also simplify package building with Wix, require Wix 3.9 or later (VS2015 is not compatible with old Wix 3.5/3.6)
-
Sergei Golubchik authored
fix dynstr_append_os_quoted() to escape single quotes correctly for a POSIX shell
-
Sergei Golubchik authored
and a trivial cleanup to avoid manually-specified lengths
-
Oleksandr Byelkin authored
Fixed adding derived tables items to outer one.
-
Sergei Golubchik authored
mysqlcheck tool can be used even if opt_systables_only is true (to upgrade views from mysql - that overrides opt_systables_only)
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-9314 fatal build error: viosslfactories.c:58:5: error: dereferencing pointer to incomplete type ‘DH {aka struct dh_st} fixes for openssl that was built with -DOPENSSL_NO_DEPRECATED
-
Vicențiu-Marian Ciorbaru authored
MDEV-9433: Add va_end to sql/rpl_reporting.cc to make cppcheck happy
-
- 05 Feb, 2016 2 commits
-
-
Oleksandr Byelkin authored
MDEV-7827: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed in Field_long::val_str on EXPLAIN EXTENDED (Solution by Sergei Petrunia) It appeared that semijoin conditions was not iterated when we were updating used tables. So now they do.
-
Oleksandr Byelkin authored
added lost virtual fields update call
-
- 03 Feb, 2016 2 commits
-
-
Jan Lindström authored
-
Jan Lindström authored
MDEV-9471: Server crashes or returns an error while trying to alter partitioning on a table moved from Windows to Linux At alter table when server renames the table to temporal name, old name uses normal partioned table naming rules. However, if tables are created on Windows and then transfered to Linux and lower-case-table-names=1 we should modify the old name on rename to lower case to be able to find it from the InnoDB dictionary.
-
- 02 Feb, 2016 1 commit
-
-
Vladislav Vaintroub authored
if mysqld runs as service The bug is caused by the attempt to write to filedescriptor 2 (STDERR_FILENO), however in case of a service stderr has different fd (debugging shows fileno(stderr) is 4 after freopen, and -1 before it) Fixed definition of STDERR_FILENO for Windows to be fileno(stderr).
-
- 01 Feb, 2016 2 commits
-
-
Kristian Nielsen authored
-
Georg Richter authored
The check for UCONTEXT in cmake was somehow become broken, disabling the fallback to ucontext. This caused the non-blocking client API to not be available for non-x86 platforms, on which no hand-crafted assembler implementation of my_context is available.
-
- 29 Jan, 2016 2 commits
- 19 Jan, 2016 1 commit
-
-
Daniel Black authored
-
- 15 Jan, 2016 2 commits
-
-
Alexey Botchkov authored
fixing Windows crash.
-
Shaohua Wang authored
we can see from the hang stacktrace, srv_monitor_thread is blocked when getting log_sys::mutex, so that sync_arr_wake_threads_if_sema_free cannot get a change to break the mutex deadlock. The fix is simply removing any mutex wait in srv_monitor_thread. Patch is reviewed by Sunny over IM.
-