- 06 Jun, 2007 1 commit
-
-
marko authored
-
- 04 Jun, 2007 2 commits
-
-
marko authored
row_merge_mark_prebuilt_obsolete(): Rename to row_prebuilt_table_obsolete() and move from row0merge.c to row0mysql.c. Remove the parameter trx. row_merge_print_table(): Remove.
-
marko authored
row_remove_indexes_for_mysql(): Rename to row_merge_drop_indexes(), move from row0mysql.c to row0merge.c and make the return type void. row_merge_remove_index(): Rename to row_merge_drop_index() and make the return type void.
-
- 29 May, 2007 1 commit
-
-
marko authored
Make use of UT_BITS_IN_BYTES().
-
- 28 May, 2007 1 commit
-
-
marko authored
of UT_SORT_FUNCTION_BODY is best done by defining SORT_FUN and CMP_FUN as macros when needed. The solution of r1523 allows for only one extra parameter.
-
- 24 May, 2007 1 commit
-
-
marko authored
needed in row0merge.c for merge sorting the small blocks in main memory. Pass CTX also to SORT_FUN. Adjust all users.
-
- 22 May, 2007 4 commits
-
-
marko authored
node_ptr.
-
marko authored
rec_get_converted_size_new(): Rename to rec_get_converted_size_comp(). Add const qualifier to dtuple. Remove the assertion dict_table_is_comp(index->table), because this function will be invoked when populating the temporary files in fast index creation. rec_convert_dtuple_to_rec_new(): Rename to rec_convert_dtuple_to_rec_comp(). Add parameter "extra". rec_init_offsets_comp_ordinary(): New function. Used in rec_init_offsets().
-
marko authored
and change the return type from ibool to int (-1, 0, 1). This comparison function will be needed in fast index creation.
-
marko authored
row_merge_read_clustered_index(): Simplify the loop that scans the clustered index.
-
- 21 May, 2007 1 commit
-
-
marko authored
otherwise like INNODB_ZIP, but resets the cumulated counts. Rename innodb_buddy to innodb_zip in some comments. innobase_stat_zip_fill(): Add parameter "reset". Document the race condition with the compression statistics counters.
-
- 18 May, 2007 4 commits
-
-
marko authored
trx_undo_report_row_operation(), trx_undo_report_dict_operation(): Reduce the scope of some variables. Move the return(DB_SUCCESS) case inside the for loop.
-
marko authored
overflow.
-
marko authored
-
marko authored
Replace row0merge.h with row0mysql.h. Remove redundant test trx->dict_operation_lock_mode == 0. Fix typos in comments. row_undo_ins(): Make the function more similar to the one in trunk.
-
- 16 May, 2007 2 commits
-
-
marko authored
exactly. Rename the local variable "ulint level" to "ibool leaf". Document that if the function returns DB_SUCCESS on a compressed page that is covered by the insert buffer, the mini-transaction must be committed before latching any further pages. Verify that this is the case on all execution paths.
-
marko authored
the insert buffer bitmap. ibuf_set_free_bits_func(): Never disable redo logging. ibuf_update_free_bits_zip(): Remove. btr_page_reorganize_low(), page_zip_reorganize(): Do not update the insert buffer bitmap. Instead, document that callers will have to take care of it, and adapt the callers. btr_compress(): On error, reset the insert buffer free bits. btr_cur_insert_if_possible(): Do not modify the insert buffer bitmap. btr_compress(), btr_cur_optimistic_insert(): On compressed pages, reset the insert buffer bitmap. Document why. btr_cur_update_alloc_zip(): Document why it is necessary and sufficient to reset the insert buffer free bits. btr_cur_update_in_place(), btr_cur_optimistic_update(), btr_cur_pessimistic_update(): Update the free bits in the same mini-transaction. Document that the mini-transaction must be committed before latching any further pages. Verify that this is the case in all execution paths. row_ins_sec_index_entry_by_modify(), row_ins_clust_index_entry_by_modify(), row_undo_mod_clust_low(): Because these functions call btr_cur_update_in_place(), btr_cur_optimistic_update(), or btr_cur_pessimistic_update(), document that the mini-transaction must be committed before latching any further pages. Verify that this is the case in all execution paths.
-
- 15 May, 2007 1 commit
-
-
marko authored
page_cur_tuple_insert(), page_cur_rec_insert(): Improve the documentation. Note that the physical position of page_cursor may change. page_cur_rec_insert(), page_cur_insert_rec_low(), page_cur_insert_rec_zip(): Add a const qualifier to the parameter rec.
-
- 14 May, 2007 1 commit
-
-
marko authored
Remove mysql.patch, because the configuration parameter interface has changed.
-
- 07 May, 2007 1 commit
-
-
marko authored
mtr_commit(): Do not acquire the log mutex if no log records are to be written. ibuf_set_free_bits_func(): Do not clear mtr.modifications, because that would prevent the dirty insert buffer bitmap block from being moved to the flush list. Instead, assume that mtr_commit() will not acquire log_sys->mutex because redo logging is disabled. buf_page_init_for_read(): I/O-fix the block before buf_buddy_alloc(), because the newly allocated block could otherwise be reused by the compressed page.
-
- 06 May, 2007 5 commits
-
-
marko authored
the pages be decompressed. buf_read_page_low(), buf_page_init_for_read(): Add parameter "unzip".
-
marko authored
crash recovery is in progress. This avoids a hang when btr_parse_page_reorganize(), called from an I/O handler thread, attempts to acquire log_sys->mutex while it is being held by the main thread (the one that runs innobase_init()). This change was committed accidentally. It may be unsafe to clear mtr.modifications, because buf_page_release() at mtr_commit() may forget to put modified pages to the flush list. Cleanup: Remove the "type" parameter from many ibuf functions. Let the caller check that !dict_index_is_clust(). This should avoid function calls and register spilling. ibuf_set_free_bits_func(), ibuf_set_free_bits(): Remove the parameter "type". ibuf_reset_free_bits_with_type(): Rename to ibuf_reset_free_bits(). Remove the parameter "type". ibuf_update_free_bits_if_full(), ibuf_update_free_bits_zip(), ibuf_update_free_bits_low(), ibuf_update_free_bits_for_two_pages_low(): Remove the parameter "index".
-
marko authored
-
marko authored
log_write_up_to(): Replace if-else if-else with a switch block. log_archive_do(): Remove an excess mutex_enter(). Replace if-else if-else with a switch block. (This function is not included unless UNIV_LOG_ARCHIVE is defined.)
-
marko authored
-
- 03 May, 2007 1 commit
-
-
marko authored
-
- 02 May, 2007 1 commit
-
-
marko authored
pass the compressed page size) with KEY_BLOCK_SIZE.
-
- 30 Apr, 2007 2 commits
-
-
marko authored
to the switch (row_merge_cmp(...)) to eliminate bogus warning about uninitialized variable tmp.
-
marko authored
was broken in one of the earlier cleanups. row_merge_block_merge(): Remove the variable "selected". Clear the record count of new_block1 and new_block2. Anticipate the right return values from row_merge_cmp().
-
- 17 Apr, 2007 4 commits
-
-
marko authored
Add __attribute__((const)) or __attribute__((pure)) to various mach_read functions. dtype_new_read_for_order_and_null_size(): Remove a statement without effect: mach_read_from_2(buf + 4).
-
marko authored
in r1445. They are needed after all, but apparently the tests do not actually verify that the records are sorted. (Also, a buffer overflow will occur in index_merge_innodb.test if MERGE_BLOCK_SIZE is made smaller.)
-
marko authored
Correct the language of some comments. Eliminate the local variables "num_of_merges" (renamed to "sorted" in one function).
-
marko authored
cmp_rec_rec_with_match(): Initialize ret=0. Remove assignments ret=0. rec_init_offsets(): Remove bogus comment.
-
- 16 Apr, 2007 4 commits
-
-
marko authored
-
marko authored
dict_index_is_unique(): New function. row_merge_rec_fits_to_block(), row_merge_store_rec_to_block(): Add const qualifiers to rec, offsets. row_merge_select(): Rename to row_merge_cmp(), simplify the interface. row_merge_sort_linked_list(): Change the return type to ibool. Replace sec_offs1,sec_offs2 with offsets1,offsets2. Replace offset_heap with heap. Define a func_exit label. row_merge_block_merge(): Reduce the scope of rec_offsets.
-
marko authored
merge_rec_list_t: Define n_records only #ifdef UNIV_DEBUG.
-
marko authored
row_merge_dict_table_get_index(): Add function comment. Use inlined versions of mem_alloc() and mem_free().
-
- 13 Apr, 2007 1 commit
-
-
marko authored
and os_file_write(), and return DB_CORRUPTION when they fail. Minor cleanup. row_mege_insert_index_tuples(): Use a shared heap for dtuple and rec. Use fewer gotos. row_merge_sort_linked_list_in_disk(): Free the merge blocks at error exit.
-
- 12 Apr, 2007 2 commits
-
-
marko authored
row_merge_read(), row_merge_write(): Add UNIV_LIKELY hints. row_merge_sort_linked_list_in_disk(): Reduce the scope of many variables. Eliminate the variable "selected".
-
marko authored
Replace byte offsets of type dulint with block offsets of type ulint. Avoid references to MERGE_BLOCK_SIZE. Improve the language of some comments. row_merge_insert_index_tuples(), row_merge_sort_linked_list_in_disk(): Make the offset a ulint. row_merge_read(), row_merge_write(): Helper functions. Return the status of os_file_read() and os_file_write(). TO DO: check the status in the callers.
-