1. 25 Apr, 2019 2 commits
  2. 24 Apr, 2019 5 commits
    • Marko Mäkelä's avatar
      Merge 5.5 into 10.1 · bfb0726f
      Marko Mäkelä authored
      bfb0726f
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-15772 Potential list overrun during XA recovery · d5da8ae0
      Thirunarayanan Balathandayuthapani authored
      InnoDB could return the same list again and again if the buffer
      passed to trx_recover_for_mysql() is smaller than the number of
      transactions that InnoDB recovered in XA PREPARE state.
      
      We introduce the transaction state TRX_PREPARED_RECOVERED, which
      is like TRX_PREPARED, but will be set during trx_recover_for_mysql()
      so that each transaction will only be returned once.
      
      Because init_server_components() is invoking ha_recover() twice,
      we must reset the state of the transactions back to TRX_PREPARED
      after returning the complete list, so that repeated traversals
      will see the complete list again, instead of seeing an empty list.
      Without this tweak, the test main.tc_heuristic_recover would hang
      in MariaDB 10.1.
      d5da8ae0
    • Varun Gupta's avatar
      MDEV-15837: Assertion `item1->type() == Item::FIELD_ITEM && item2->type() == Item::FIELD_ITEM' · 1f1a61cf
      Varun Gupta authored
                  failed in compare_order_elements function
      
      The issue here is the function compare_order_lists() is called for the order by list of the window functions
      so that those window function that can be computed together are adjacent.
      So in the function compare_order_list we iterate over all the elements in the order list of the two functions and
      compare the items in their order by clause.
      The function compare_order_elements() is called for each item in the
      order by clause. This function assumes that all the items that are in the order by list would be of the type
      Item::FIELD_ITEM.
      
      The case we have is that we have constants in the order by clause. We should ignore the constant and only compare
      items of the type Item::FIELD_ITEM in compare_order_elements()
      1f1a61cf
    • Sujatha Sivakumar's avatar
      MDEV-17260: Memory leaks in mysqlbinlog · cb8d888c
      Sujatha Sivakumar authored
      Problem:
      ========
      The mysqlbinlog tool is leaking memory, causing failures in various tests when
      compiling and testing with AddressSanitizer or LeakSanitizer like this:
      
      cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source
      make -j$(nproc)
      cd mysql-test
      ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto rpl.rpl_row_mysqlbinlog
      
      CURRENT_TEST: rpl.rpl_row_mysqlbinlog
      
      Direct leak of 112 byte(s) in 1 object(s) allocated from:
      #0 0x4eff87 in __interceptor_malloc (/dev/shm/5.5/client/mysqlbinlog+0x4eff87)
      #1 0x60eaab in my_malloc /mariadb/5.5/mysys/my_malloc.c:41:10
      #2 0x5300dd in Log_event::read_log_event(char const*, unsigned int, char const**,
         Format_description_log_event const*, char) /mariadb/5.5/sql/log_event.cc:1568:
      #3 0x564a9c in dump_remote_log_entries(st_print_event_info*, char const*)
      /mariadb/5.5/client/mysqlbinlog.cc:1978:17
      
      Analysis:
      ========
      'mysqlbinlog' tool is being used to read binary log events from a remote server.
      While reading binary log, if a fake rotate event is found following actions are
      taken.
      
      If 'to-last-log' option is specified, then fake rotate event is processed.
      In the absence of 'to-last-log' skip the fake rotate event.
      
      In this skipped case the fake rotate event object is not getting cleaned up
      resulting in memory leak.
      
      Fix:
      ===
      Cleanup the fake rotate event.
      
      This issues is already fixed in MariaDB 10.0.23 and higher versions as part of
      commit c3018b0f
      cb8d888c
    • Igor Babaev's avatar
      MDEV-17796 WHERE filter is ignored by DISTINCT IFNULL(GROUP_CONCAT(X), Y) · 5fc8dd8b
      Igor Babaev authored
                 with GROUP BY + ORDER BY
      
      The method JOIN::create_postjoin_aggr_table() should not call
      call JOIN::add_sorting_to_table() unless the first non-constant join
      table is passed as the first parameter to the method.
      5fc8dd8b
  3. 23 Apr, 2019 5 commits
  4. 22 Apr, 2019 3 commits
  5. 21 Apr, 2019 1 commit
    • Alexander Barkov's avatar
      MDEV-19239 ERROR 1300 (HY000): Invalid utf8 character string in 10.3.13-MariaDB · 765ae6e8
      Alexander Barkov authored
      A sequence of <digits>e<mbhead><mbtail>, e.g.:
      
        SELECT 123eXYzzz FROM t1;
      
      was not scanned correctly (where XY is a multi-byte character).
      
      The multi-byte head byte X was appended to 123e separately from
      the multi-byte tail byte Y, so a pointer to "Yzzz" was passed
      into scan_ident_start(), which failed on a bad multi-byte sequence.
      
      After this change, scan_ident_start() gets a pointer to "XYzzz",
      so it correctly sees the whole multi-byte character.
      765ae6e8
  6. 19 Apr, 2019 4 commits
    • Alexander Barkov's avatar
      Backporting from 10.4 to 10.3: MDEV-17325 NULL-ability problems with LEAST()... · f4019f5b
      Alexander Barkov authored
      Backporting from 10.4 to 10.3: MDEV-17325 NULL-ability problems with LEAST() in combination with NO_ZERO_DATE and NO_ZERO_IN_DATE
      
      This also fixes:
      MDEV-17299 Assertion `maybe_null' failed in make_sortkey
      
      Note, during merge of the 10.1 version of MDEV-17299,
      please use the 10.3 version of the code (i.e. null merge the 10.1 version).
      f4019f5b
    • Alexander Barkov's avatar
    • Andrei Elkin's avatar
      MDEV-18096 The server would crash when has configs... · 42c58b87
      Andrei Elkin authored
      MDEV-18096 The server would crash when has configs rpl_semi_sync_master_enabled = OFF rpl_semi_sync_master_wait_no_slave = OFF
      
      The patch fixes a fired assert in the semisync master module. The assert
      caught attempt to switch semisync off (per rpl_semi_sync_master_wait_no_slave = OFF)
      when it was not even initialized (per rpl_semi_sync_master_enabled = OFF).
      The switching-off execution branch is relocated under one that executes
      enable_master() first.
      
      A minor cleaup is done to remove the int return from two functions that
      did not return anything but an error which could not happen in the functions.
      42c58b87
    • Marko Mäkelä's avatar
      Remove IBUF_COUNT_DEBUG · d315b4ff
      Marko Mäkelä authored
      The compile-time option IBUF_COUNT_DEBUG has not been used for years.
      It would only work with up to 3 created .ibd files, with no buffered
      changes existing while InnoDB is started up.
      d315b4ff
  7. 18 Apr, 2019 2 commits
    • Sergei Petrunia's avatar
      MDEV-17297: stats.records=0 for a table of Archive engine when it has rows,... · 056b6fe1
      Sergei Petrunia authored
      MDEV-17297: stats.records=0 for a table of Archive engine when it has rows, when we run ANALYZE command
      
      Archive storage engine assumed that any query that attempts to read from
      the table will call ha_archive::info() beforehand. ha_archive would flush
      un-written data in that call (this would make it visible for the reads).
      
      Break this assumption. Flush the data when the table is opened for reading.
      
      This way, one can do multiple write statements without causing a flush, but
      as soon as we might need the data, we flush it.
      056b6fe1
    • Alexander Barkov's avatar
      MDEV-18092 Query with the table I_S.PARAMETERS stop working after a package is created · 323e6cd7
      Alexander Barkov authored
      This patch was originally made by Anel Husakovic.
      
      Skip `PACKAGE` and `PACKAGE BODY` records quickly.
      
      These stored objects do not have any parameters or return values
      (only procedures and functions have).
      So no needs to build a `CREATE` statement
      (in `Sp_handler::sp_load_for_information_schema()`) and parse it:
      this won't give us any data useful for `INFORMATION_SCHEMA.PARAMETERS`.
      323e6cd7
  8. 17 Apr, 2019 4 commits
    • Alexander Barkov's avatar
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 250799f9
      Marko Mäkelä authored
      250799f9
    • Marko Mäkelä's avatar
      MDEV-12699 Improve crash recovery of corrupted data pages · 169c0099
      Marko Mäkelä authored
      InnoDB crash recovery used to read every data page for which
      redo log exists. This is unnecessary for those pages that are
      initialized by the redo log. If a newly created page is corrupted,
      recovery could unnecessarily fail. It would suffice to reinitialize
      the page based on the redo log records.
      
      To add insult to injury, InnoDB crash recovery could hang if it
      encountered a corrupted page. We will fix also that problem.
      InnoDB would normally refuse to start up if it encounters a
      corrupted page on recovery, but that can be overridden by
      setting innodb_force_recovery=1.
      
      Data pages are completely initialized by the records
      MLOG_INIT_FILE_PAGE2 and MLOG_ZIP_PAGE_COMPRESS.
      MariaDB 10.4 additionally recognizes MLOG_INIT_FREE_PAGE,
      which notifies that a page has been freed and its contents
      can be discarded (filled with zeroes).
      
      The record MLOG_INDEX_LOAD notifies that redo logging has
      been re-enabled after being disabled. We can avoid loading
      the page if all buffered redo log records predate the
      MLOG_INDEX_LOAD record.
      
      For the internal tables of FULLTEXT INDEX, no MLOG_INDEX_LOAD
      records were written before commit aa3f7a10.
      Hence, we will skip these optimizations for tables whose
      name starts with FTS_.
      
      This is joint work with Thirunarayanan Balathandayuthapani.
      
      fil_space_t::enable_lsn, file_name_t::enable_lsn: The LSN of the
      latest recovered MLOG_INDEX_LOAD record for a tablespace.
      
      mlog_init: Page initialization operations discovered during
      redo log scanning. FIXME: This really belongs in recv_sys->addr_hash,
      and should be removed in MDEV-19176.
      
      recv_addr_state: Add the new state RECV_WILL_NOT_READ to
      indicate that according to mlog_init, the page will be
      initialized based on redo log record contents.
      
      recv_add_to_hash_table(): Set the RECV_WILL_NOT_READ state
      if appropriate. For now, we do not treat MLOG_ZIP_PAGE_COMPRESS
      as page initialization. This works around bugs in the crash
      recovery of ROW_FORMAT=COMPRESSED tables.
      
      recv_mark_log_index_load(): Process a MLOG_INDEX_LOAD record
      by resetting the state to RECV_NOT_PROCESSED and by updating
      the fil_name_t::enable_lsn.
      
      recv_init_crash_recovery_spaces(): Copy fil_name_t::enable_lsn
      to fil_space_t::enable_lsn.
      
      recv_recover_page(): Add the parameter init_lsn, to ignore
      any log records that precede the page initialization.
      Add DBUG output about skipped operations.
      
      buf_page_create(): Initialize FIL_PAGE_LSN, so that
      recv_recover_page() will not wrongly skip applying
      the page-initialization record due to the field containing
      some newer LSN as a leftover from a different page.
      Do not invoke ibuf_merge_or_delete_for_page() during
      crash recovery.
      
      recv_apply_hashed_log_recs(): Remove some unnecessary lookups.
      Note if a corrupted page was found during recovery.
      After invoking buf_page_create(), do invoke
      ibuf_merge_or_delete_for_page() via mlog_init.ibuf_merge()
      in the last recovery batch.
      
      ibuf_merge_or_delete_for_page(): Relax a debug assertion.
      
      innobase_start_or_create_for_mysql(): Abort startup if
      a corrupted page was found during recovery. Corrupted pages
      will not be flagged if innodb_force_recovery is set.
      However, the recv_sys->found_corrupt_fs flag can be set
      regardless of innodb_force_recovery if file names are found
      to be incorrect (for example, multiple files with the same
      tablespace ID).
      169c0099
    • Marko Mäkelä's avatar
      MDEV-19241 InnoDB fails to write MLOG_INDEX_LOAD upon completing ALTER TABLE · 376bf4ed
      Marko Mäkelä authored
      Similar to what was done in commit aa3f7a10
      for FULLTEXT INDEX, we must ensure that MLOG_INDEX_LOAD records will always
      be written if redo logging was disabled.
      
      row_merge_build_indexes(): Invoke row_merge_write_redo() also when
      online operation is not being executed or an error occurs.
      In case of an error, invoke flush_observer->interrupted() so that
      the pages will not be flushed but merely evicted from the buffer pool.
      Before resuming redo logging, it is crucial for the correctness of
      mariabackup and InnoDB crash recovery to flush or evict all affected pages
      and to write MLOG_INDEX_LOAD records.
      376bf4ed
  9. 16 Apr, 2019 1 commit
  10. 15 Apr, 2019 1 commit
  11. 12 Apr, 2019 2 commits
  12. 11 Apr, 2019 1 commit
  13. 10 Apr, 2019 2 commits
  14. 09 Apr, 2019 1 commit
  15. 08 Apr, 2019 6 commits