1. 04 Nov, 2010 3 commits
  2. 03 Nov, 2010 8 commits
  3. 02 Nov, 2010 10 commits
    • unknown's avatar
      Null merge mysql-5.1-innodb to mysql-5.5-innodb" · 9c8758b9
      unknown authored
      9c8758b9
    • unknown's avatar
      In this patch, existing tests innodb_bug54679.test and innodb_bug56632.test are · 64e476e0
      unknown authored
      removed and replaced by the comprehensive innodb-create-options.test.
      It uses the rules listed in the comments at the top of that test.
        
      This patch introduces these differences from previous behavior;
      1)  KEY_BLOCK_SIZE=0 is allowed by Innodb in both strict and non-strict mode
      with no errors or warnings. It was previously used by the server to set 
      KEY_BLOCK_SIZE to undefined.  (Bug#56628)
      2)  An explicit valid non-DEFAULT ROW_FORMAT always takes priority over a
      valid KEY_BLOCK_SIZE. (bug#56632)
      3)  Automatic use of COMPRESSED row format is only done if the ROW_FORMAT
      is DEFAULT or unspecified.
      4)  ROW_FORMAT=FIXED is prevented in strict mode.
      
      This patch also includes various formatting changes for consistency with
      InnoDB coding standards.
      
      Related Bugs
      Bug#54679: ALTER TABLE causes compressed row_format to revert to compact
      Bug#56628: ALTER TABLE .. KEY_BLOCK_SIZE=0 produces untrue warning or unnecessary error
      Bug#56632: ALTER TABLE implicitly changes ROW_FORMAT to COMPRESSED
      64e476e0
    • unknown's avatar
      In this patch, existing tests innodb_bug54679.test and innodb_bug56632.test are · 6794155a
      unknown authored
      removed and replaced by the comprehensive innodb-create-options.test.
      It uses the rules listed in the comments at the top of that test.
        
      This patch introduces these differences from previous behavior;
      1)  KEY_BLOCK_SIZE=0 is allowed by Innodb in both strict and non-strict mode
      with no errors or warnings. It was previously used by the server to set 
      KEY_BLOCK_SIZE to undefined.  (Bug#56628)
      2)  An explicit valid non-DEFAULT ROW_FORMAT always takes priority over a
      valid KEY_BLOCK_SIZE. (bug#56632)
      3)  Automatic use of COMPRESSED row format is only done if the ROW_FORMAT
      is DEFAULT or unspecified.
      4)  ROW_FORMAT=FIXED is prevented in strict mode.
      
      This patch also includes various formatting changes for consistency with
      InnoDB coding standards.
      
      Related Bugs
      Bug#54679: ALTER TABLE causes compressed row_format to revert to compact
      Bug#56628: ALTER TABLE .. KEY_BLOCK_SIZE=0 produces untrue warning or unnecessary error
      Bug#56632: ALTER TABLE implicitly changes ROW_FORMAT to COMPRESSED
      6794155a
    • unknown's avatar
      Merge · f45f5902
      unknown authored
      f45f5902
    • unknown's avatar
      Bug#57904 - Only one INFORMATION_SCHEMA.REFERENTIAL_CONSTRAINTS was displayed · a63c14e9
      unknown authored
      per table from Innodb
      a63c14e9
    • Vasil Dimov's avatar
      Merge mysql-5.1-innodb -> mysql-5.5-innodb · 9b9ac02e
      Vasil Dimov authored
      9b9ac02e
    • Vasil Dimov's avatar
      Increment InnoDB Plugin version to 1.0.14. · addb1475
      Vasil Dimov authored
      InnoDB Plugin 1.0.13 has been released with MySQL 5.1.52.
      addb1475
    • Marko Mäkelä's avatar
      a6bb1a01
    • Marko Mäkelä's avatar
      Bug#57799 READ UNCOMMITTED access failure of off-page DYNAMIC or COMPRESSED · 004bb1b1
      Marko Mäkelä authored
      columns again
      
      This is follow-up to Bug #54358. Not all occurrences of the bug were fixed.
      We need to check all calls to btr_copy_externally_stored_field_prefix_low()
      and do the right thing when the pointer to the off-page column is null
      (full of zero bytes).
      
      It turns out that only the call to btr_copy_externally_stored_field_prefix()
      in row_sel_sec_rec_is_for_blob() needs to be changed.
      
      For fetching complete off-page columns rather than prefixes, the function
      btr_rec_copy_externally_stored_field() already checks if the pointer
      is null (all-zero).  Two of its callers (row_merge_copy_blobs() and
      row_sel_fetch_columns()) are never executed as READ COMMITTED and can
      rightfully assert that the fetch succeeded.  The third caller,
      row_sel_store_mysql_rec(), already does the right thing.
      
      The calls in row_upd_ext_fetch() and trx_undo_page_fetch_ext() must
      expect that the off-page column exists. Update and rollback are
      locking operations, never READ UNCOMMITTED.
      004bb1b1
    • Marko Mäkelä's avatar
      6c802b3c
  4. 01 Nov, 2010 2 commits
  5. 29 Oct, 2010 1 commit
  6. 28 Oct, 2010 5 commits
    • Vasil Dimov's avatar
      Fix a compilation warning: · e3decfa0
      Vasil Dimov authored
      /export/home/pb2/build/sb_0-2459340-1288264809.63/mysql-5.5.8-ga/storage/innobase/os/os0sync.c: In function 'os_cond_wait_timed':
      /export/home/pb2/build/sb_0-2459340-1288264809.63/mysql-5.5.8-ga/storage/innobase/os/os0sync.c:184: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'time_t'
      gmake[2]: *** [storage/innobase/CMakeFiles/innobase.dir/os/os0sync.c.o] Error 1 
      e3decfa0
    • Calvin Sun's avatar
      8fc8e01f
    • Calvin Sun's avatar
      Bug#52062: Compiler warning in os0file.c on windows 64-bit · ec51b479
      Calvin Sun authored
      On Windows, the parameter for number of bytes passed into WriteFile()
      and ReadFile() is DWORD. Casting is needed to silence the warning on
      64-bit Windows.
      
      Also, adding several asserts to ensure the variable for number of bytes
      is no more than 32 bits, even on 64-bit Windows.
      
      rb://415
      Approved by: Inaam
      ec51b479
    • Calvin Sun's avatar
      Bug#52062: Compiler warning in os0file.c on windows 64-bit · 460ad14e
      Calvin Sun authored
      On Windows, the parameter for number of bytes passed into WriteFile()
      and ReadFile() is DWORD. Casting is needed to silence the warning on
      64-bit Windows.
      
      Also, adding several asserts to ensure the variable for number of bytes
      is no more than 32 bits, even on 64-bit Windows.
      
      This is for InnoDB Plugin.
      
      rb://415
      Approved by: Inaam
      460ad14e
    • Calvin Sun's avatar
      Bug#52062: Compiler warning in os0file.c on windows 64-bit · 16feea41
      Calvin Sun authored
      On Windows, the parameter for number of bytes passed into WriteFile()
      and ReadFile() is DWORD. Casting is needed to silence the warning on
      64-bit Windows.
      
      Also, adding several asserts to ensure the variable for number of bytes
      is no more than 32 bits, even on 64-bit Windows.
      
      This is for built-in InnoDB.
      
      rb://415
      Approved by: Inaam
      16feea41
  7. 27 Oct, 2010 9 commits
  8. 26 Oct, 2010 2 commits