1. 15 Aug, 2019 1 commit
  2. 14 Aug, 2019 11 commits
  3. 13 Aug, 2019 5 commits
  4. 12 Aug, 2019 6 commits
    • Alexander Barkov's avatar
    • Alexander Barkov's avatar
      0e0d5714
    • Marko Mäkelä's avatar
      MDEV-20316 InnoDB writes uninitialised tail of XID buffer · ae1d17f5
      Marko Mäkelä authored
      Starting with commit 210855ce
      Valgrind became aware that the unused tail of the buffer that
      is returned by thd_get_xid() is actually uninitialized.
      
      The problem should exist already in MySQL 5.0. I was able to
      repeat it on MariaDB Server 5.5 with some additional instrumentation.
      InnoDB is allocating 128+4+4 bytes for the XID and the lengths of
      its components, even when the XID is shorter than 64+64 bytes.
      In MariaDB Server 10.3, while running the test main.xa_binlog,
      in the xid_t::set() that is called by sql_yacc.yy, the 128-byte data
      buffer was uninitialized according to Valgrind, and only the first bytes
      were initialized. When the xid_t::data was copied to
      thd.transaction.xid_state.xid.data, it happened so that the entire
      target buffer was considered initialized. With MariaDB Server 10.4 since
      the said commit, Valgrind will correctly be detect the tail of the buffer
      as uninitialized.
      
      The impact of this bug is as follows:
      
      (1) InnoDB will write unnecessarily much redo log for XA PREPARE.
      (2) InnoDB will write garbage bytes to the redo log and undo log pages.
      (3) The garbage should be 'harmless', because on recovery, only the
      actual payload of the XID will be used, based on the written length.
      
      trx_rseg_write_wsrep_checkpoint(), trx_undo_write_xid(): Write only
      the actually used length of xid->data to the data page, and
      zero out the rest of the buffer by mlog_memset().
      ae1d17f5
    • Marko Mäkelä's avatar
      Revert part of 05619f69 · 97bbac8e
      Marko Mäkelä authored
      This fixes the following test failures related to index cardinality:
      main.join main.stat_tables main.partition main.stat_tables_innodb
      innodb.innodb_bug57252
      97bbac8e
    • Alexander Barkov's avatar
      e7525bea
    • Monty's avatar
      Fixes based on warnings from gcc/clang and valgrind · 05619f69
      Monty authored
      - Initialize variables that could be used uninitialized
      - Added extra end space to DbugStringItemTypeValue to get rid of warnings
        from c_ptr()
      - Session_sysvars_tracker::update() accessed unitialized memory if called
        with NULL value.
      - get_schema_stat_record() accessed unitialized memory if HA_KEY_LONG_HASH
        was used
      - parse_vcol_defs() accessed random memory for tables without keys.
      05619f69
  5. 11 Aug, 2019 2 commits
  6. 09 Aug, 2019 3 commits
  7. 08 Aug, 2019 5 commits
  8. 07 Aug, 2019 4 commits
  9. 06 Aug, 2019 3 commits